Ki/appeals 17508 v3 - Add Edit Issues Dropdown #18453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HunJerBAH
reviewed
Apr 18, 2023
HunJerBAH
reviewed
Apr 18, 2023
HunJerBAH
approved these changes
Apr 18, 2023
kristeja
pushed a commit
that referenced
this pull request
Apr 19, 2023
* APPEALs-17508 - feature branch update issues fix * APPEALS-17508 - MST/PACT FeatureToggle
HunJerBAH
added a commit
that referenced
this pull request
Apr 19, 2023
* jHoang/APPEALS-17511 (#18444) * migration to add mst and pact status to request_issues * schema update * typo in migration * typo in schema * set default status * Revert "schema update" This reverts commit 0d5df1a. * Revert "typo in schema" This reverts commit 9a74e6e. * +1 --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Justin/appeals 17512 (#18443) * feature toggle mst_pact_identification * toggle added to queue, intake, and hearings erb * replaced bracket that was accidentally removed * hearings feature toggle to camelCase to match * removing merge problems * APPEALS-17506: MST & PACT Components (#18451) * APPEALS-17506: MST & PACT Components * +1 * updated storybook test args for rendering badges --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457) * added mst and pact option to contention generator * added mst and pact option to bgs_contention generator * updated record maker to build epes with mst/pact contentions * refactored to create both mst and pact contention cases for veterans * added duplicate contention error handling in generator * Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453) * APPEALs-17508 - feature branch update issues fix * APPEALS-17508 - MST/PACT FeatureToggle * Info banner for Special Issues Page * re-implement banner to ensure fontsize is consistent * added some spacing under banner --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com> Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: Ki Mau <ki.mau@va.gov>
kristeja
pushed a commit
that referenced
this pull request
Apr 20, 2023
* APPEALs-17508 - feature branch update issues fix * APPEALS-17508 - MST/PACT FeatureToggle
kristeja
pushed a commit
that referenced
this pull request
Apr 20, 2023
* jHoang/APPEALS-17511 (#18444) * migration to add mst and pact status to request_issues * schema update * typo in migration * typo in schema * set default status * Revert "schema update" This reverts commit 0d5df1a. * Revert "typo in schema" This reverts commit 9a74e6e. * +1 --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Justin/appeals 17512 (#18443) * feature toggle mst_pact_identification * toggle added to queue, intake, and hearings erb * replaced bracket that was accidentally removed * hearings feature toggle to camelCase to match * removing merge problems * APPEALS-17506: MST & PACT Components (#18451) * APPEALS-17506: MST & PACT Components * +1 * updated storybook test args for rendering badges --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457) * added mst and pact option to contention generator * added mst and pact option to bgs_contention generator * updated record maker to build epes with mst/pact contentions * refactored to create both mst and pact contention cases for veterans * added duplicate contention error handling in generator * Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453) * APPEALs-17508 - feature branch update issues fix * APPEALS-17508 - MST/PACT FeatureToggle * Info banner for Special Issues Page * re-implement banner to ensure fontsize is consistent * added some spacing under banner --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com> Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: Ki Mau <ki.mau@va.gov>
KiMauVA
added a commit
that referenced
this pull request
Apr 21, 2023
* jHoang/APPEALS-17511 (#18444) * migration to add mst and pact status to request_issues * schema update * typo in migration * typo in schema * set default status * Revert "schema update" This reverts commit 0d5df1a. * Revert "typo in schema" This reverts commit 9a74e6e. * +1 --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Justin/appeals 17512 (#18443) * feature toggle mst_pact_identification * toggle added to queue, intake, and hearings erb * replaced bracket that was accidentally removed * hearings feature toggle to camelCase to match * removing merge problems * APPEALS-17506: MST & PACT Components (#18451) * APPEALS-17506: MST & PACT Components * +1 * updated storybook test args for rendering badges --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457) * added mst and pact option to contention generator * added mst and pact option to bgs_contention generator * updated record maker to build epes with mst/pact contentions * refactored to create both mst and pact contention cases for veterans * added duplicate contention error handling in generator * Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453) * APPEALs-17508 - feature branch update issues fix * APPEALS-17508 - MST/PACT FeatureToggle * Info banner for Special Issues Page * re-implement banner to ensure fontsize is consistent * added some spacing under banner --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com> Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: Ki Mau <ki.mau@va.gov>
jonathanh-va
pushed a commit
that referenced
this pull request
Apr 21, 2023
* APPEALs-17508 - feature branch update issues fix * APPEALS-17508 - MST/PACT FeatureToggle
jonathanh-va
added a commit
that referenced
this pull request
Apr 21, 2023
* jHoang/APPEALS-17511 (#18444) * migration to add mst and pact status to request_issues * schema update * typo in migration * typo in schema * set default status * Revert "schema update" This reverts commit 0d5df1a. * Revert "typo in schema" This reverts commit 9a74e6e. * +1 --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Justin/appeals 17512 (#18443) * feature toggle mst_pact_identification * toggle added to queue, intake, and hearings erb * replaced bracket that was accidentally removed * hearings feature toggle to camelCase to match * removing merge problems * APPEALS-17506: MST & PACT Components (#18451) * APPEALS-17506: MST & PACT Components * +1 * updated storybook test args for rendering badges --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457) * added mst and pact option to contention generator * added mst and pact option to bgs_contention generator * updated record maker to build epes with mst/pact contentions * refactored to create both mst and pact contention cases for veterans * added duplicate contention error handling in generator * Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453) * APPEALs-17508 - feature branch update issues fix * APPEALS-17508 - MST/PACT FeatureToggle * Info banner for Special Issues Page * re-implement banner to ensure fontsize is consistent * added some spacing under banner --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com> Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: Ki Mau <ki.mau@va.gov>
HunJerBAH
added a commit
that referenced
this pull request
Apr 24, 2023
…odal (#18478) * APPEALs-17508 - feature branch update issues fix * APPEALS-17508 - MST/PACT FeatureToggle * APPEALS-17507 - Connection Pieces Working * APPEALS-17507 - Index work for Modal * APPEALS-17507 - Fully working Modal component * APPEALS-17506: MST & PACT Components (#18451) * APPEALS-17506: MST & PACT Components * +1 * updated storybook test args for rendering badges --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * Update warmup_vacols.rb * Update warmup_vacols.rb * Update warmup_vacols.rb * Update warmup_vacols.rb * Update ApiUtil.js * Update ApiUtil.js * ACD: Disable Legacy Docket and Non Priority distribution (#18463) * Update by_docket_date_distribution.rb * Update docket_coordinator.rb * disable Legacy * add feature toggle indicators to stats * Update by_docket_date_distribution.rb * Update push_priority_appeals_to_judges_job.rb * HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457) * added mst and pact option to contention generator * added mst and pact option to bgs_contention generator * updated record maker to build epes with mst/pact contentions * refactored to create both mst and pact contention cases for veterans * added duplicate contention error handling in generator * removed MST (#18455) * jHoang/APPEALS-17511 (#18444) * migration to add mst and pact status to request_issues * schema update * typo in migration * typo in schema * set default status * Revert "schema update" This reverts commit 0d5df1a. * Revert "typo in schema" This reverts commit 9a74e6e. * +1 --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Justin/appeals 17512 (#18443) * feature toggle mst_pact_identification * toggle added to queue, intake, and hearings erb * replaced bracket that was accidentally removed * hearings feature toggle to camelCase to match * removing merge problems * APPEALS-17506: MST & PACT Components (#18451) * APPEALS-17506: MST & PACT Components * +1 * updated storybook test args for rendering badges --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * removed MST --------- Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com> Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com> Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * jHoang/APPEALS-17523 (#18466) * jHoang/APPEALS-17511 (#18444) * migration to add mst and pact status to request_issues * schema update * typo in migration * typo in schema * set default status * Revert "schema update" This reverts commit 0d5df1a. * Revert "typo in schema" This reverts commit 9a74e6e. * +1 --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Justin/appeals 17512 (#18443) * feature toggle mst_pact_identification * toggle added to queue, intake, and hearings erb * replaced bracket that was accidentally removed * hearings feature toggle to camelCase to match * removing merge problems * APPEALS-17506: MST & PACT Components (#18451) * APPEALS-17506: MST & PACT Components * +1 * updated storybook test args for rendering badges --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457) * added mst and pact option to contention generator * added mst and pact option to bgs_contention generator * updated record maker to build epes with mst/pact contentions * refactored to create both mst and pact contention cases for veterans * added duplicate contention error handling in generator * Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453) * APPEALs-17508 - feature branch update issues fix * APPEALS-17508 - MST/PACT FeatureToggle * Info banner for Special Issues Page * re-implement banner to ensure fontsize is consistent * added some spacing under banner --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com> Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: Ki Mau <ki.mau@va.gov> * revert timeouts * HunJerBAH/APPEALS-17522: Create IssuesUpdate Task Model (#18465) * Created Issues Update task model and methods for formatting instructions * jHoang/APPEALS-17511 (#18444) * migration to add mst and pact status to request_issues * schema update * typo in migration * typo in schema * set default status * Revert "schema update" This reverts commit 0d5df1a. * Revert "typo in schema" This reverts commit 9a74e6e. * +1 --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Justin/appeals 17512 (#18443) * feature toggle mst_pact_identification * toggle added to queue, intake, and hearings erb * replaced bracket that was accidentally removed * hearings feature toggle to camelCase to match * removing merge problems * APPEALS-17506: MST & PACT Components (#18451) * APPEALS-17506: MST & PACT Components * +1 * updated storybook test args for rendering badges --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * added issueUpdateTask bool check * refactored format_instructions method to store in nested array * refactored instruction logic and updated rendering/styling of task instructions * updated css styling to match wireframes * refactored special issue format and created tests --------- Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com> Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com> Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com> * removed console log and copy.json value * removed commented code * fixed minor syntax complaints and added proptypes * APPEALS-17507 - Updated storybook --------- Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: Matt Roth <roth_matthew@bah.com> Co-authored-by: Matt Roth <mattcroth@gmail.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: IsaiahBar <107133331+IsaiahBar@users.noreply.github.com> Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com> Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
HunJerBAH
added a commit
that referenced
this pull request
Apr 26, 2023
* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457) * added mst and pact option to contention generator * added mst and pact option to bgs_contention generator * updated record maker to build epes with mst/pact contentions * refactored to create both mst and pact contention cases for veterans * added duplicate contention error handling in generator * Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453) * APPEALs-17508 - feature branch update issues fix * APPEALS-17508 - MST/PACT FeatureToggle * added methods that return mst/pact status * added safety operator to contention * refactored changes onto request issue model * refactored hash check with has_value? * added rspec tests * added generator for mst + pact status contention * added brackets * refactored spec tests * updated contention generation methods for special issues * updated status return methods to conform to test cases * updated serialize attr from snake case to camel case --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: Ki Mau <ki.mau@va.gov>
HunJerBAH
added a commit
that referenced
this pull request
Apr 26, 2023
* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457) * added mst and pact option to contention generator * added mst and pact option to bgs_contention generator * updated record maker to build epes with mst/pact contentions * refactored to create both mst and pact contention cases for veterans * added duplicate contention error handling in generator * Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453) * APPEALs-17508 - feature branch update issues fix * APPEALS-17508 - MST/PACT FeatureToggle * adding feature toggle to intakes controller * Adding checkbox to conditionally render * attempting to add checkbox to state management * pact box and code cleanup * Redux state management * Adding spec test for checkboxes * Matching wireframe * testing with 2 args, as 3 fails * testing spec test idea * re-writing spec method * default state to false and merge fixes * parity for redux variables for mstpact checkboxes * feature toggle fix --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: Ki Mau <ki.mau@va.gov>
youfoundmanesh
pushed a commit
that referenced
this pull request
May 3, 2023
* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457) * added mst and pact option to contention generator * added mst and pact option to bgs_contention generator * updated record maker to build epes with mst/pact contentions * refactored to create both mst and pact contention cases for veterans * added duplicate contention error handling in generator * Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453) * APPEALs-17508 - feature branch update issues fix * APPEALS-17508 - MST/PACT FeatureToggle * adding feature toggle to intakes controller * Adding checkbox to conditionally render * attempting to add checkbox to state management * pact box and code cleanup * Redux state management * Adding spec test for checkboxes * Matching wireframe * testing with 2 args, as 3 fails * testing spec test idea * re-writing spec method * default state to false and merge fixes * parity for redux variables for mstpact checkboxes * feature toggle fix * added mst and pact to intake payload, issues format, and serializer * added spec tests to payload information * created intake controller specs for mst and pact payload --------- Co-authored-by: Ki Mau <ki.mau@va.gov> Co-authored-by: sulak-j <justin.sulak@va.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #{APPEALS-17508}
Description
Added an additional dropdown option for "Edit Issue" in Caseflow Intake on the Edit Issues page for action options.
Acceptance Criteria
Testing Plan
User Facing Changes
BEFORE|AFTER
(In JIRA Ticket)