Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jHoang/APPEALS-17523 #18466

Merged
merged 8 commits into from
Apr 19, 2023
Merged

jHoang/APPEALS-17523 #18466

merged 8 commits into from
Apr 19, 2023

Conversation

jonathanh-va
Copy link
Contributor

@jonathanh-va jonathanh-va commented Apr 18, 2023

Resolves 17523

Description

Added a banner to the special issues view alerting users that the MST Checkbox and PACT Checkbox will be handled at issue level now.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Login as an attorney or judge that has a legacy case assigned. (BVASCASPER1 or BVAAABSHIRE)
  2. Go to a legacy appeal with at least one issue.
  3. Under the Actions dropdown click on "Decision ready for review" (for attorneys)
    OR
    Under the Actions dropdown click on "Ready for dispatch" (for judges)
  4. Observe that a blue banner appears at the top of the page with a description that matches the wireframe

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue

BEFORE
Screenshot 2023-04-18 at 1 26 37 PM

AFTER

Screenshot 2023-04-18 at 1 34 24 PM

jonathanh-va and others added 8 commits April 13, 2023 17:13
* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems
* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator
* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle
@jonathanh-va jonathanh-va marked this pull request as ready for review April 18, 2023 19:18
@HunJerBAH HunJerBAH merged commit ea649c9 into feature/APPEALS-17497 Apr 19, 2023
@HunJerBAH HunJerBAH deleted the JHoang/APPEALS-17523 branch April 19, 2023 20:11
kristeja pushed a commit that referenced this pull request Apr 20, 2023
* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* Info banner for Special Issues Page

* re-implement banner to ensure fontsize is consistent

* added some spacing under banner

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>
KiMauVA added a commit that referenced this pull request Apr 21, 2023
* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* Info banner for Special Issues Page

* re-implement banner to ensure fontsize is consistent

* added some spacing under banner

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>
jonathanh-va added a commit that referenced this pull request Apr 21, 2023
* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* Info banner for Special Issues Page

* re-implement banner to ensure fontsize is consistent

* added some spacing under banner

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>
HunJerBAH added a commit that referenced this pull request Apr 24, 2023
…odal (#18478)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* APPEALS-17507 - Connection Pieces Working

* APPEALS-17507 - Index work for Modal

* APPEALS-17507 - Fully working Modal component

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* Update warmup_vacols.rb

* Update warmup_vacols.rb

* Update warmup_vacols.rb

* Update warmup_vacols.rb

* Update ApiUtil.js

* Update ApiUtil.js

* ACD: Disable Legacy Docket and Non Priority distribution (#18463)

* Update by_docket_date_distribution.rb

* Update docket_coordinator.rb

* disable Legacy

* add feature toggle indicators to stats

* Update by_docket_date_distribution.rb

* Update push_priority_appeals_to_judges_job.rb

* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* removed MST (#18455)

* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* removed MST

---------

Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* jHoang/APPEALS-17523 (#18466)

* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* Info banner for Special Issues Page

* re-implement banner to ensure fontsize is consistent

* added some spacing under banner

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>

* revert timeouts

* HunJerBAH/APPEALS-17522: Create IssuesUpdate Task Model (#18465)

* Created Issues Update task model and methods for formatting instructions

* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* added issueUpdateTask bool check

* refactored format_instructions method to store in nested array

* refactored instruction logic and updated rendering/styling of task instructions

* updated css styling to match wireframes

* refactored special issue format and created tests

---------

Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>

* removed console log and copy.json value

* removed commented code

* fixed minor syntax complaints and added proptypes

* APPEALS-17507 - Updated storybook

---------

Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: Matt Roth <roth_matthew@bah.com>
Co-authored-by: Matt Roth <mattcroth@gmail.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: IsaiahBar <107133331+IsaiahBar@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants