Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msteele96/APPEALS-25001 #19088

Merged
merged 11 commits into from
Aug 7, 2023
Merged

msteele96/APPEALS-25001 #19088

merged 11 commits into from
Aug 7, 2023

Conversation

msteele96
Copy link
Contributor

@msteele96 msteele96 commented Jul 31, 2023 •
edited by ThorntonMatthew
Loading

Resolves APPEALS-25001

Description

Allow for Hearing Postponement Request Mail Tasks to be created on Legacy Appeals.

Acceptance Criteria

  • HearingPostponementMailRequestTasks can be added to legacy appeals, in addition to AMA ones.
  • HPR Task workflows can operate on legacy appeals and hearings as they do for the AMA variants (may be existing, but please confirm).
  • HPR spec file has test cases added to cover task's interactions with legacy appeals and hearings.

Testing Plan

  1. Go to APPEALS-27329 & APPEALS-27396

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

@msteele96 msteele96 self-assigned this Jul 31, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 1, 2023 •
edited
Loading

Code Climate has analyzed commit 69c3fb8 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@msteele96 msteele96 marked this pull request as draft August 2, 2023 20:59
@msteele96 msteele96 changed the base branch from master to feature/APPEALS-21339 August 3, 2023 14:17
@msteele96 msteele96 changed the base branch from feature/APPEALS-21339 to master August 3, 2023 14:17
@jimfoley25 jimfoley25 marked this pull request as ready for review August 4, 2023 15:23
@jimfoley25 jimfoley25 changed the base branch from master to feature/APPEALS-21339 August 4, 2023 19:35
jimfoley25
jimfoley25 reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@jimfoley25 jimfoley25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@msteele96 @ThorntonMatthew
APPEALS-25001 Ignore CC issues
df08aec 
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
ThorntonMatthew
ThorntonMatthew approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@ThorntonMatthew ThorntonMatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ThorntonMatthew ThorntonMatthew merged commit d785c6d into feature/APPEALS-21339 Aug 7, 2023
12 of 14 checks passed
@ThorntonMatthew ThorntonMatthew deleted the msteele/APPEALS-25001 branch August 7, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimfoley25 jimfoley25 jimfoley25 left review comments

@ThorntonMatthew ThorntonMatthew ThorntonMatthew approved these changes

Assignees

@msteele96 msteele96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msteele96 @ThorntonMatthew @jimfoley25