msteele96/APPEALS-25001

app/models/tasks/mail_task.rb

@@ -20,6 +20,12 @@ class MailTask < Task
   def verify_org_task_unique; end
   prepend PrivacyActPending
 
+  # This constant is more efficient than iterating through all mail tasks
+  # and filtering out almost all of them since only HPR and HWR are approved for now
+  LEGACY_MAIL_TASKS = [
+    { label: "Hearing postponement request", value: "HearingPostponementRequestMailTask" }
+  ].freeze
+
   class << self
     def blocking?
       # Some open mail tasks should block distribution of an appeal to judges.

app/models/tasks/root_task.rb

@@ -76,8 +76,9 @@ def hide_from_task_snapshot
     true
   end
 
+  # :reek:UtilityFunction
   def available_actions(user)
-    return [Constants.TASK_ACTIONS.CREATE_MAIL_TASK.to_h] if RootTask.user_can_create_mail_task?(user) && ama?
+    return [Constants.TASK_ACTIONS.CREATE_MAIL_TASK.to_h] if RootTask.user_can_create_mail_task?(user)
 
     []
   end

app/repositories/task_action_repository.rb

@@ -18,8 +18,13 @@ def assign_to_organization_data(task, _user = nil)
     end
 
     def mail_assign_to_organization_data(task, user = nil)
-      options = MailTask.descendant_routing_options(user: user, appeal: task.appeal)
-      valid_options = task.appeal.outcoded? ? options : options.reject { |opt| opt[:value] == "VacateMotionMailTask" }
+      if task.appeal.is_a? Appeal
+        options = MailTask.descendant_routing_options(user: user, appeal: task.appeal)
+        valid_options = task.appeal.outcoded? ? options : options.reject { |opt| opt[:value] == "VacateMotionMailTask" }
+      elsif task.appeal.is_a? LegacyAppeal
+        valid_options = MailTask::LEGACY_MAIL_TASKS
+      end
+
       { options: valid_options }
     end
 

spec/models/tasks/root_task_spec.rb

@@ -28,6 +28,14 @@
         expect(subject).to eq([])
       end
     end
+
+    context "when the appeal is a legacy appeal" do
+      it "mail team members still have the option to add mail tasks" do
+        allow(user).to receive(:organizations).and_return([MailTeam.singleton])
+
+        expect(subject).to eq([root_task.build_action_hash(Constants.TASK_ACTIONS.CREATE_MAIL_TASK.to_h, user)])
+      end
+    end
   end
 
   describe ".update_children_status_after_closed" do

spec/repositories/task_action_repository_spec.rb

@@ -120,6 +120,36 @@
     end
   end
 
+  describe "#mail_assign_to_organization_data" do
+    context "outcoded Appeal" do
+      let(:appeal) { create(:appeal, :outcoded) }
+      subject { TaskActionRepository.mail_assign_to_organization_data(appeal.root_task) }
+
+      it "returns all of the options when outcoded" do
+        expect(subject[:options]).to eq(MailTask.descendant_routing_options)
+      end
+    end
+
+    context "active Appeal" do
+      let(:appeal) { create(:appeal, :active) }
+      subject { TaskActionRepository.mail_assign_to_organization_data(appeal.root_task) }
+
+      it "returns all of the options except VacateMotionMailTask when not outcoded" do
+        expect(subject[:options]).to eq(MailTask.descendant_routing_options.reject do |opt|
+          opt[:value] == "VacateMotionMailTask"
+        end)
+      end
+    end
+
+    context "LegacyAppeal" do
+      let(:appeal) { create(:legacy_appeal, :with_root_task) }
+      subject { TaskActionRepository.mail_assign_to_organization_data(appeal.root_task) }
+      it "returns only the HPR and HWR options" do
+        expect(subject[:options]).to eq(MailTask::LEGACY_MAIL_TASKS)
+      end
+    end
+  end
+
   describe "#vha caregiver support task actions" do
     describe "#vha_caregiver_support_return_to_board_intake" do
       let(:user) { create(:user) }