Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lthompson/APPEALS-26633 #19112

Merged
merged 51 commits into from
Aug 23, 2023
Merged

lthompson/APPEALS-26633 #19112

merged 51 commits into from
Aug 23, 2023

Conversation

lauren-e-thompson
Copy link
Contributor

@lauren-e-thompson lauren-e-thompson commented Aug 2, 2023 •
edited
Loading

Resolves Complete SelectConferenceType Radio Button Functionality

Description

Value Statement:

As a Caseflow Developer I need to assign the selected virtual hearing type to a user so that user can eventually schedule a hearing using Webex

Acceptance Criteria

  • Code compiles correctly
  • Update users_controller to include a method that updates the meeting_type of a user from pexip or webex
  • Update organizations_user.rb to include the methods that would update the meeting_type column in the users table
  • Update the onChange action of the radio buttons to include a method that persists the choice of the end user to the database
  • Selections of Pexip or Webex radio buttons are now persisted after page refresh

Testing Plan

  • New meeting type selected is now equal to the meeting type in the users database table

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

breedbah and others added 30 commits July 20, 2023 13:50
@breedbah
Added feature toggles to index.html.rb
c468255
@breedbah
Added toggle to index.html.erb
7f0bae2
@lauren-e-thompson
Progress on conference types radio field
5fe4690
@lauren-e-thompson
adding conference type selection logic
6780e00
@konhilas-ariana
APPEALS-25141: created migrations to add pexip bool column to users v…
72cc092 
…irtual hearings and conference links
@konhilas-ariana
APPEALS-25141: set default value to true on users
e18314c
@lauren-e-thompson
Work on radio field selection
07be387
@lauren-e-thompson
Fixed errors with conference selection radio field
4d9694c
@lauren-e-thompson
Clean up code after new import file
3264c4b
@lauren-e-thompson
Update copy file and state
fc72e95
@lauren-e-thompson
APPEALS-25112 Added styling for radio field component
6fc2c0f
@breedbah
Merge branch 'lthompson/APPEALS-25112' into b_reed/APPEALS-25130-v3
8db7067
@breedbah
APPEALS-25130 updated user.rb
6957d77
@konhilas-ariana
APPEALS-25141: rolling back changes, creating new migrations, deletin…
ba63cf8 
…g the old, to meeting type varchar default on users only
@konhilas-ariana
APPEALS-25141: removed version 5.2 from migrations
0e48803
@breedbah
Merge branch 'b_reed/APPEALS-25130-v3' of https://github.com/departme…
e22ddda 
…nt-of-veterans-affairs/caseflow into b_reed/APPEALS-25130-v3
@mchbidwell
Merge pull request #19038 from department-of-veterans-affairs/b_reed/…
ab8ce3c 
…APPEALS-25130-v3

b_reed/APPEALS-25130 Create Feature Flag for Pexip/Webex functionality
@lauren-e-thompson
Create jest test
bdc3a52
@lauren-e-thompson
Test passing
3dae8f5
@lauren-e-thompson
Fixed syntax errors from merged code
5bfdc9b
@lauren-e-thompson
Radio buttons fixed to only display on Hearings Admin page
c023af4
@lauren-e-thompson
Wrap li elements in ul elements
08c7910
@lauren-e-thompson
Test that radio button values change when selected
7421103
@lauren-e-thompson
Update to testing logic with radio buttons
daae3bf
@konhilas-ariana
APPEALS-25141: refactoring migrations to include up/down methods, add…
5115f7c 
…ing default for virt hearings and conf links
@lauren-e-thompson
Styling comments updated after review
78af497
@mchbidwell
Merge branch 'master' into akonhilas/APPEALS-25141
ba97e73
@ThorntonMatthew
Revert 'Merge pull request #19038 from department-of-veterans-affairs…
0ab42a3 
…/b_reed/APPEALS-25130-v3'

This reverts commit ab8ce3c, reversing
changes made to 6fc2c0f.
@lauren-e-thompson
Fixed linting issues and updated jest snapshot
97bba81
@ThorntonMatthew
Merge branch 'feature/APPEALS-25109' into lthompson/APPEALS-25112
6e9c1e8
@lauren-e-thompson lauren-e-thompson added the Team: Oumuamua ☄️ Development Team for the Hearings ART label Aug 3, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 4, 2023 •
edited
Loading

Code Climate has analyzed commit 923fb83 and detected 0 issues on this pull request.

View more on Code Climate.

ThorntonMatthew and others added 12 commits August 4, 2023 17:01
@ThorntonMatthew
Merge branch 'feature/APPEALS-25109' into akonhilas/APPEALS-25141
fbdffcf
@mchbidwell
Merge pull request #19055 from department-of-veterans-affairs/akonhil…
4987df1 
…as/APPEALS-25141

akonhilas/APPEALS-25141
@lauren-e-thompson
APPEALS-26633 Progress on linking backend and frontend radio option c…
6a8edf6 
…hanges and added modifyConferenceTypes
@lauren-e-thompson
Merge branch 'feature/APPEALS-25109' into lthompson/APPEALS-26633
1b1353e
@lauren-e-thompson
APPEALS-26633 Framing for logic to link onChange function
55ac16f
@lauren-e-thompson
Adding modifyConferenceType to patch to backend
e670373
@lauren-e-thompson
Add meeting_type to user to capture new meeting type from frontend, d…
c376385 
…ebugging in byebug
@lauren-e-thompson
Fixed bug so frontend hearings change is persisted to backend and upd…
d5df546 
…ates user meeting type
@lauren-e-thompson
Fixed linting issues and added rspec test to check the new meeting type
6b2dad9
@lauren-e-thompson
Add information about patch response test
14d7675
@lauren-e-thompson
Fix code climates issues
7c0f3c6
@lauren-e-thompson
Jest testing fixed to check for changing values by radio button selec…
73aa405 
…tion
mchbidwell
mchbidwell reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@mchbidwell mchbidwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For client/app/queue/OrganizationUsers.jsx it looks like the l273 has the wrong page target of 'Hearing Admin' it should be pointed at 'Hearings Management' instead as that is the correct page

@lauren-e-thompson
Copy link
Contributor Author

@mchbidwell Changes made in OrganizationUsers and users_controller to switch the page from Hearing Admin to Hearings Management

@mchbidwell mchbidwell merged commit 83509ba into master Aug 23, 2023
9 of 14 checks passed
@mchbidwell mchbidwell mentioned this pull request Aug 23, 2023
Merged
@andrecolinone andrecolinone deleted the lthompson/APPEALS-26633 branch November 27, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchbidwell mchbidwell mchbidwell approved these changes

Assignees
No one assigned
Labels
Team: Oumuamua ☄️ Development Team for the Hearings ART
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lauren-e-thompson @mchbidwell @breedbah @konhilas-ariana @ThorntonMatthew