-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kshiflett/appeals 26109 #19171
Closed
Closed
Kshiflett/appeals 26109 #19171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add catch to get document call * Update documentViewer.js * generic error handling and custom error handling * Update ApiUtil.js * send error logs to backend * Update Metrics.js * add uuid to error logging * add metrics table * revert * send metrics to backend * store metrics in table * update info for javascript metrics * cleanup * add source parameter * add ability to mark as performance * add feature toggle * log_controller unit test and fixes * Update schema.rb * Update schema.rb * Update metric.rb * more and fix unit tests * update metrics table for new fields and update ApiUtils error handling * update Metric.js for usage * record metrics from MetricsService * Update documentViewer.js * Update metrics_service.rb * metric_service fixes * fixing issues * can view metrics on demo * Update dashboard_controller.rb * reduce to 7 days, newest first * Update dashboard_controller.rb * 1 day at a time * add indexes
* new frontend metrics setup * improve loading screen metric * record metrics for searching within a document * update feature toggle * add in feature toggles * Update show.html.erb
…fairs/caseflow into feature/APPEALS-22218
* adds feature toggle * adds feature toggle to reader pdfpage which renders readertext document id, type and render time * refactors uuid * fixes file prop --------- Co-authored-by: Matt Roth <mattcroth@gmail.com>
* APPEALS-23475. Record Successhandling in the metrics * Added successhandling on other HTTP methods and some refactor * Added feature toggle- metricsLogRestSuccess * APPEALS-23475. Test case for success handling * reverting changes --------- Co-authored-by: SHarshain <spoosa@razortalent.com>
* Update PdfPage.jsx * Update Metrics.js * Update PdfPage.jsx
* Added PDFJS page and text getting/storing metrics * Add toggle feature for PDFJS page and text metrics * Adjusted metrics and feature toggle naming * Remove unused props pass * Revert "Added PDFJS page and text getting/storing metrics" This reverts commit ac6513e.
* Added browser error feature toggle to all pages * Revert changes I did not make * Revert change made in metric model --------- Co-authored-by: Matt Roth <mattcroth@gmail.com>
…fairs/caseflow into feature/APPEALS-22218
* First draft * ready * Add meterics capture for PDFJS document loading - Remove dev debugging code * Remove test code for v2.0 (not in use) * Revert test code for v2.0 * Restore v2.0 docviewer * Fix variable issue * Fix variable type issue --------- Co-authored-by: Christopher Detlef <christopherdetlef@T2202359.local>
…fairs/caseflow into feature/APPEALS-22218
…fairs/caseflow into feature/APPEALS-22218
* enabled_metric? * update caseflow-commons * update caseflow-commons * fix jslint, issues, add feature toggle to retrieving PDF, wrap error and success metrics with feature toggle
…fairs/caseflow into feature/APPEALS-22218
Co-authored-by: SHarshain <spoosa@razortalent.com>
…fairs/caseflow into feature/APPEALS-22218
…/APPEALS-22218-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://jira.devops.va.gov/browse/APPEALS-26102
Resolves https://jira.devops.va.gov/browse/APPEALS-26109
Description
As a developer I need to create or improve Metric Service Sentry updates for Reader application and ensure they are present after
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling