-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/appeals 22218 master #19129
Merged
mikefinneran
merged 634 commits into
feature/APPEALS-22218
from
feature/APPEALS-22218-master
Aug 3, 2023
Merged
Feature/appeals 22218 master #19129
mikefinneran
merged 634 commits into
feature/APPEALS-22218
from
feature/APPEALS-22218-master
Aug 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…://github.com/department-of-veterans-affairs/caseflow into hearings/pacman-triple-j-branch-of-excellence
…://github.com/department-of-veterans-affairs/caseflow into hearings/pacman-triple-j-branch-of-excellence
… and destination audit tables and functions
…nging distribution id and communicationpackageid from string to int
…f-veterans-affairs/caseflow into MattT/APPEALS-24643
This reverts commit d38eb98.
* Remove obsolete Dispatch_stats specs The dispatch_stats logic is deprecated and is now being fully deleted. We can remove the specs as part of that process. * Remove certification_stats specs The certification_stats logic is deprecated and is now being fully deleted. We can remove the specs as part of that process.
* Removing skip made this test pass * Adding puts to see what value does response body has * testing database result * testing database result * running db cleaner before to make sure hearing day is always contains 1 and 2 * resetting Pk in hearing table before all
…port/skipped-test-updates-2 Remove deprecated stats specs - APPEALS/25431 (#18998)
* update m1 setup instructions * add how to determine procssor type
…-vre-business-line
…u/APPEALS-23894-close-vrr-tasks-for-vre-business-line jcroteau/APPEALS-23894 - Close VeteranRecordRequest tasks for Veterans Readiness and Employment (VRE) business line
* ✨ Introduce method object CancelTasksAndDescendants * ✨ Introduce rake task remediations:cancel_vrr_tasks_open_for_vre * 🚚 Move VeteranRecordRequestsOpenForVREQuery into its own namespace * 💡 Add to comment * ♻️ Reference Constants::BENEFIT_TYPES instead of local constant * ♻️ Extract factory for VRE business line * ✏️ Fix typo * 🔊 Log time elapsed * ♻️ Extract constant * ♻️ Refactor tests * 🔊 Log total tasks for cancellation * 🔊 Log cancelled task ids * 🔊 Log errored cancellations * ♻️ Extract method * 🐛 Task #descendants already includes self * 🐛 Only include open tasks in total * 🐛 Only log cancellable (open) task ids * ♻️ Extract method * ♻️ Replace query with temp * 🔊 Log total cancelled * ♻️ Slide statements into block * ♻️ Combine logging of cancellable tasks before/after into single method * ♻️ Rearrange method definitions * ♻️ Rename method * 💡 Add comments * 🔊 Append logs to stdout * 👔 Ensure PaperTrail versions reflect appropriate whodunnit and request_id for cancelled tasks * 🚨 Lint * ✅ Fix broken spec * fix potentially flaky finds --------- Co-authored-by: Jeremy Croteau <jeremiah.croteau@va.gov> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>
…fairs/caseflow into dev-support/test-updates
…port/test-updates dev-support/test-updates
* modify formatting, add notes and foreword * add missing parenthesis
…tment-of-veterans-affairs/caseflow into JHoang/APPEALS-23520/23521
…/APPEALS-17497 Feature/APPEALS-17497 MST/PACT Act Special Identification
…18472-feature/APPEALS-17497 Revert "Feature/APPEALS-17497 MST/PACT Act Special Identification"
…APPEALS-23520/23521 APPEALS-23521 CAVC Dashboard not showing all issues for Remand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling