Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

akonhilas/APPEALS-35195 #20006

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

konhilas-ariana
Copy link
Contributor

@konhilas-ariana konhilas-ariana commented Nov 21, 2023

Resolves: Subject param, sub, for Daily Docket does not have unique "name"

https://jira.devops.va.gov/browse/APPEALS-35195

Description

Updated the hearing_day.subject_for_conference from "Guest Link for #{scheduled_for.strftime('%b %e, %Y')}" to "#{id}_#{scheduled_for.strftime('%b %e, %Y')}"

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to https://jira.devops.va.gov/browse/APPEALS-35271
  • For feature branches merging into master: Was this deployed to UAT?

Backend

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

  • Are performance metrics (e.g., response time, throughput) being tracked?
  • Are key application components monitored (e.g., database, cache, queues)?
  • Is there a system in place for setting up alerts based on performance thresholds?

Logging

  • Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
  • Are logs structured (e.g., using log tags) for easier querying and analysis?
  • Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
  • Is log retention and rotation configured correctly?
  • Are logs being forwarded to a centralized logging system if needed?

Auditing

  • Are user actions being logged for audit purposes?
  • Are changes to critical data being tracked ?
  • Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

  • Are errors being caught and handled gracefully?
  • Are appropriate error messages being displayed to users?
  • Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
  • Are unhandled exceptions being caught at the application level ?

Exception Handling

  • Are custom exceptions defined and used where appropriate?
  • Is exception handling consistent throughout the codebase?
  • Are exceptions logged with relevant context and stack trace information?
  • Are exceptions being grouped and categorized for easier analysis and resolution?

Copy link
Contributor

@mchbidwell mchbidwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the date format lets go with strftime('%m %e, %Y'), which will change the testing

@mchbidwell mchbidwell marked this pull request as ready for review November 27, 2023 13:40
@mchbidwell mchbidwell merged commit 7996b93 into feature/APPEALS-26734 Nov 27, 2023
13 of 14 checks passed
@ThorntonMatthew ThorntonMatthew deleted the akonhilas/APPEALS-35195 branch September 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants