Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

akonhilas/APPEALS-35195 #20006

Merged
merged 3 commits into from
Nov 27, 2023
Merged

akonhilas/APPEALS-35195 #20006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4387c75
APPEALS-35195: update sub to use unique hearing day id
konhilas-ariana Nov 21, 2023
ca377b1
APPEALS-35195: update hearing day spec to have specific id for hearin…
konhilas-ariana Nov 21, 2023
7311a8e
APPEALS-35195: change date format
konhilas-ariana Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/hearing_day.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ def conference_links
end

def subject_for_conference
"Guest Link for #{scheduled_for.strftime('%b %e, %Y')}"
"#{id}_#{scheduled_for.strftime('%m %e, %Y')}"
end

def nbf
Expand Down
11 changes: 7 additions & 4 deletions spec/models/hearing_day_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,19 +595,22 @@ def format_begins_at_from_db(time_string, scheduled_for)
context "#subject_for_conference" do
include_context "Enable both conference services"

let(:expected_date) { "Sep 21, 2023" }
let(:expected_date_parsed) { Date.parse(expected_date) }
let(:assigned_date) { "Sep 21, 2023" }
let(:id) { 2_000_006_656 }
let(:expected_date_parsed) { Date.parse(assigned_date) }
let(:hearing_day) do
build(
:hearing_day,
scheduled_for: expected_date_parsed
scheduled_for: expected_date_parsed,
id: id
)
end

subject { hearing_day.subject_for_conference }

it "returns the expected meeting conference details" do
is_expected.to eq("Guest Link for #{expected_date}")
expected_date = "09 21, 2023"
is_expected.to eq("#{hearing_day.id}_#{expected_date}")
end

context "nbf and exp" do
Expand Down
Loading