-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TYLERB/APPEALS-30892: Report Generation through ‘Generate task report’ button #20024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the form submission.
…instead of get because of param passing issues.
…rams. Changed the filename of the csv to include hour and minute.
…ng. Also renamed the days waiting filter value from range: to operator: since it makes more sense. Cleaned up some testing code.
Code Climate has analyzed commit cc807cb and detected 0 issues on this pull request. View more on Code Climate. |
…erver side mapping. Fixed a bug where the date object was not being preserved when converting the object keys to snake case in the ApiUtils convertToSnakeCase recursive method. Updated the decision reviews controller spec to match the new change history filter strong params definitions. Started a spec file for the change history reporter class and added a few tests to it.
… Page for change history.
…VHA. Added in a css class to make adding feature tests for it easier.
…ry to fill out some conditions on the form and submit the page. Also added some code to check the generated CSV.
…clude last event for each task_id if the status filter for 'last_action_taken' is one of the included filters.
…number for claims without intakes. It now joins to both of the claim tables and coalesces the veteran file number field from the 3 tables.
… using the BGS_FACILITY_CODES json file. Also added this helper to the as_csv instead of the user_facility getter.
… the event generation to be incorrect since the first version state change is handled differently from the rest.
…ere being modified by the QueryBuilder. Altered the way that the filter params are being formatted by the change history csv reporter. Fixed a bug where the specific event filter parser was containing event filters that were not checked anymore. Added the report type to the parsed filters so it can be displayed in the change history csv reporter.
…history event spec to use the new readable facility name helper for the csv_method test. Updated the change history reporter test to use the new filter formatting. Fixed the claim history service spec to work with the updated task factory and added a new test for the 'last_action_taken' status_report_type filter.
it's instance variable instead of passing around params.
…dded_issue events instead of added_issue_without_decision_date events.
…on date and no decision date added at.
…ded an edge case fall back that could happen if the request issue that was being parsed was not added during intake and the request issue update that is being parsed in the same database row is the correct request issues updates row. Added a test to support this and updated tests to work with this fallback.
… since it is already storing the results in the events attribute. Removed the filters= and replaced it with an attr writer. Moved some of the event array checks into constants instead of method declarations. Added an additional checkto the request issue updates database fetch fallback to avoid a database hit if there is no request issues update or intake for a claim.
…row that is being parsed is the request issue that is being processed for the request issue update.
…fetching. Removed some todo statements. Fixed other code climate issues.
…o test the format of every type of event when it is converted into a csv row.
…es a github action test failure.
…ities filter in the business line class.
…ckbox will work properly.
…eing passed down to the server as 'last_x_days' when the backend was expecting 'last x days'.
… in the database that do not have a disposition. Added the 'Blank' filter into the claim history service class as well. Added rspec tests for the business line and claim history service to cover this new filter.
…nd as a fallback in the event generation so those issues would not be completely blank. Adjusted how the filter gets displayed in the csv and changed the test to match.
craigrva
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ART: VHA
Change History: Claims Report History
javascript
Pull requests that update Javascript code
Product: Decision Review Queues
ruby
Pull requests that update Ruby code
Stakeholder: VHA
Functionality associated with Veterans Health Administration workflows/feature requests
Team: Saturn 🪐
A development team for the VHA business line
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-30892
Epic link: https://jira.devops.va.gov/browse/APPEALS-26499
Description
The primary purpose of this PR is to link the Report Page form submission, the change history event generation, and the csv creation together. This PR also creates all of the mappings between the form values and the backend values in the ReportPage.jsx ui component and the DecisionReviewsController in order to prepare the values for use in event generation. In addition to the primary focus, there were additional changes made to the change history query to accommodate AttorneyClaimants and Unrecognized claimants. The query was also changed to work with the completed_by_id field on a task in addition to the already working task version whodunnit value for determining which user completed a task/disposition.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling