Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYLERB/APPEALS-30892: Report Generation through ‘Generate task report’ button #20024

Merged
merged 70 commits into from
Dec 20, 2023

Commits on Nov 20, 2023

  1. Configuration menu
    Copy the full SHA
    932b24a View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Configuration menu
    Copy the full SHA
    106f4a1 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Testing some changes for form submission and csv generation via post …

    …instead of get because of param passing issues.
    TylerBroyles committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    bbe42ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e94c664 View commit details
    Browse the repository at this point in the history
  3. Added some filter helpers to the controller for the change history pa…

    …rams. Changed the filename of the csv to include hour and minute.
    TylerBroyles committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    7aca562 View commit details
    Browse the repository at this point in the history
  4. Added mappings for events filtering and days waiting operator filteri…

    …ng. Also renamed the days waiting filter value from range: to operator: since it makes more sense. Cleaned up some testing code.
    TylerBroyles committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    64af681 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ea9f570 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0f08f8c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    604835f View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Added the status component filters into the client side parsing and s…

    …erver side mapping. Fixed a bug where the date object was not being preserved when converting the object keys to snake case in the ApiUtils convertToSnakeCase recursive method. Updated the decision reviews controller spec to match the new change history filter strong params definitions. Started a spec file for the change history reporter class and added a few tests to it.
    TylerBroyles committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    4706a20 View commit details
    Browse the repository at this point in the history
  2. Merged feature branch.

    TylerBroyles committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    4e77888 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7ae13b7 View commit details
    Browse the repository at this point in the history
  4. Started adding a large feature test for form submission on the Report…

    … Page for change history.
    TylerBroyles committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    1a8e70d View commit details
    Browse the repository at this point in the history
  5. Small changes to the personnel condition to make it more agnostic to …

    …VHA. Added in a css class to make adding feature tests for it easier.
    TylerBroyles committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    90f4c1a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    24f7832 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Added a test and some helpers to the ReportPage spec for change histo…

    …ry to fill out some conditions on the form and submit the page. Also added some code to check the generated CSV.
    TylerBroyles committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    b0f1d34 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3215188 View commit details
    Browse the repository at this point in the history
  3. More tests.

    TylerBroyles committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    3a1fe22 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e93c83b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e52b834 View commit details
    Browse the repository at this point in the history
  6. Added a method to the service class to truncate the events to only in…

    …clude last event for each task_id if the status filter for 'last_action_taken' is one of the included filters.
    TylerBroyles committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    06ee4b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Added a fallback to the change history query to get the veteran file …

    …number for claims without intakes. It now joins to both of the claim tables and coalesces the veteran file number field from the 3 tables.
    TylerBroyles committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    9adcf1a View commit details
    Browse the repository at this point in the history
  2. Added a helper to create a readable_facility_name from the station_id…

    … using the BGS_FACILITY_CODES json file. Also added this helper to the as_csv instead of the user_facility getter.
    TylerBroyles committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    bb1ccd1 View commit details
    Browse the repository at this point in the history
  3. Fixed a bug where the task status ordering would be incorrect causing…

    … the event generation to be incorrect since the first version state change is handled differently from the rest.
    TylerBroyles committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    77308c7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    de1b453 View commit details
    Browse the repository at this point in the history
  5. Fixed a bug where the filter params being passed into business line w…

    …ere being modified by the QueryBuilder. Altered the way that the filter params are being formatted by the change history csv reporter. Fixed a bug where the specific event filter parser was containing event filters that were not checked anymore. Added the report type to the parsed filters so it can be displayed in the change history csv reporter.
    TylerBroyles committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    adda016 View commit details
    Browse the repository at this point in the history
  6. Removed some unused code from claim history event. Updated the Claim …

    …history event spec to use the new readable facility name helper for the csv_method test. Updated the change history reporter test to use the new filter formatting. Fixed the claim history service spec to work with the updated task factory and added a new test for the 'last_action_taken' status_report_type filter.
    TylerBroyles committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    b464927 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    8cbae1f View commit details
    Browse the repository at this point in the history
  2. Added the bgs attorney table and the unrecognized appellant and unrec…

    …ognized_party_details tables into the change history query in order to properly retrieve the claimant information for unrecognized appellants and attorney appellants.
    TylerBroyles committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    82f21c5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    81240ed View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2d62485 View commit details
    Browse the repository at this point in the history
  5. Added file number back into the query after it was accidently removed…

    …. Updated the business line spec tests to work with the new claimant name alias.
    TylerBroyles committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    79bf0d1 View commit details
    Browse the repository at this point in the history
  6. Updated the higher level review and supplemental claim factories when…

    … using the :with_decision trait to use the 'Granted' disposition value instead of 'allowed' since allowed was not one of the regular values that can be used to complete a disposition. Updated the tests to reflect using Granted instead of allowed. Also added 'issue-dispositions' class name to the IssueDisposition filter for testing and styling.
    TylerBroyles committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    f548e8b View commit details
    Browse the repository at this point in the history
  7. Changed how the form reset button was working since it was buggy. Fin…

    …ished up a much more detailed feature test for the report page that submits the page multiple times including a form reset and multiple csv generations.
    TylerBroyles committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    bfe1fd4 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Added a fallback for the decision user fields to the change history q…

    …uery that also uses the completed_by_id field to join to users instead of only the task versions whodunnit field.
    TylerBroyles committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    a49a1d3 View commit details
    Browse the repository at this point in the history
  2. Removed a constant from the report page validation errors that was du…

    …plicated. Changed the references to use the remaining error that matched the text description.
    TylerBroyles committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    1bacc44 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    22d7698 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f49ec4b View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Configuration menu
    Copy the full SHA
    faf23c0 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Configuration menu
    Copy the full SHA
    9bbc03c View commit details
    Browse the repository at this point in the history
  2. Fixed some jest test errors and added some react hook form validation…

    … testing into the jest tests for the various components.
    TylerBroyles committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    1e1bec2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2001aea View commit details
    Browse the repository at this point in the history
  4. Moved the change history filter parsing into a different file and pla…

    …ced it with the service class. Cleaned up a couple of code climate errors.
    TylerBroyles committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    0b7f494 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2954cda View commit details
    Browse the repository at this point in the history
  6. Removed some of the statistics code from The claim history service si…

    …nce it will be using the Metrics class in the controller for this.
    TylerBroyles committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    31ef79c View commit details
    Browse the repository at this point in the history
  7. Updated the references in the ChangeHistoryFilterParser to use

     it's instance variable instead of passing around params.
    TylerBroyles committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    fd26c0d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c487513 View commit details
    Browse the repository at this point in the history
  9. Fixed a bug where issues without decision dates would be showing as a…

    …dded_issue events instead of added_issue_without_decision_date events.
    TylerBroyles committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    e8e82bd View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Added a test for the create_add_issue_event to cover having no decisi…

    …on date and no decision date added at.
    TylerBroyles committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    f63ee61 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b7c672 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Configuration menu
    Copy the full SHA
    0852cee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d5fdc08 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Removed an alias that wasn't needed from the change history query. Ad…

    …ded an edge case fall back that could happen if the request issue that was being parsed was not added during intake and the request issue update that is being parsed in the same database row is the correct request issues updates row. Added a test to support this and updated tests to work with this fallback.
    TylerBroyles committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    dc71c74 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Changed the Change history service entries loop from a map to an each…

    … since it is already storing the results in the events attribute. Removed the filters= and replaced it with an attr writer. Moved some of the event array checks into constants instead of method declarations. Added an additional checkto the request issue updates database fetch fallback to avoid a database hit if there is no request issues update or intake for a claim.
    TylerBroyles committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    a88317e View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Added a small optimization to avoid a DB fetch if the change history …

    …row that is being parsed is the request issue that is being processed for the request issue update.
    TylerBroyles committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    3837531 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd219fc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1e1c0f8 View commit details
    Browse the repository at this point in the history
  4. Updated some tests for a small optimization to request issue uipdate …

    …fetching. Removed some todo statements. Fixed other code climate issues.
    TylerBroyles committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    36ce2cd View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Code climate fix. Added a large test in the change history reporter t…

    …o test the format of every type of event when it is converted into a csv row.
    TylerBroyles committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    d639445 View commit details
    Browse the repository at this point in the history
  2. Removed a puts statement and increased the wait time to see if it fix…

    …es a github action test failure.
    TylerBroyles committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    cc807cb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    13d9753 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    859b8dc View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Configuration menu
    Copy the full SHA
    bd56a0e View commit details
    Browse the repository at this point in the history
  2. Added the decision_users_completed by join to the personnel and facil…

    …ities filter in the business line class.
    TylerBroyles committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    8a07df8 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Updated the specific status filter parsing so unchecking a status che…

    …ckbox will work properly.
    TylerBroyles committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    57814af View commit details
    Browse the repository at this point in the history
  2. Fixed a bug where the timing filters for 'last_x_days' filters were b…

    …eing passed down to the server as 'last_x_days' when the backend was expecting 'last x days'.
    TylerBroyles committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    b639ef3 View commit details
    Browse the repository at this point in the history
  3. Added 'Blank' into the dispositions filters. It should match any rows…

    … in the database that do not have a disposition. Added the 'Blank' filter into the claim history service class as well. Added rspec tests for the business line and claim history service to cover this new filter.
    TylerBroyles committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    ae8e3db View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Added in the description field for unidentified issues to the query a…

    …nd as a fallback in the event generation so those issues would not be completely blank. Adjusted how the filter gets displayed in the csv and changed the test to match.
    TylerBroyles committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    d8e5e4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    86feda7 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Configuration menu
    Copy the full SHA
    8e38f02 View commit details
    Browse the repository at this point in the history