Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SeanC/APPEALS-5034 Decided non-comp issues are not getting closed as decided #20126

Merged
merged 39 commits into from
Dec 21, 2023
Merged

SeanC/APPEALS-5034 Decided non-comp issues are not getting closed as decided #20126

merged 39 commits into from
Dec 21, 2023

Commits on Dec 6, 2023

  1. added basic code to meet ac

    @seancva
    seancva committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    a6330c7 View commit details
    Browse the repository at this point in the history

  2. updated code in decsion reveiw task

    @seancva
    seancva committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    a700536 View commit details
    Browse the repository at this point in the history

  3. updated code to set the completed_by as well

    @seancva
    seancva committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    33810a6 View commit details
    Browse the repository at this point in the history

  4. started refactoring handle_issues_with_no_decision_date!

    @seancva
    seancva committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    60de9d0 View commit details
    Browse the repository at this point in the history

  5. refactored function to reduce cyclomatic complexity

    @seancva
    seancva committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    4e4bcde View commit details
    Browse the repository at this point in the history

  6. fixed a code climate issue

    @seancva
    seancva committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    b88023e View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. attempting to fix a code climate issue

    @seancva
    seancva committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    4501498 View commit details
    Browse the repository at this point in the history

  2. moved handle_issues_with_no_decision_date! to decision_review to fix … 

    …code climate issue
    @seancva
    seancva committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    fc68ef4 View commit details
    Browse the repository at this point in the history

  3. Empty-Commit

    @seancva
    seancva committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    0cd37b8 View commit details
    Browse the repository at this point in the history

  4. put function back

    @seancva
    seancva committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    d8fc619 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. fixed the failing tests in decision_review_task_spec

    @seancva
    seancva committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b330918 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Added _current_user to complete_with_payload in business_line_task

    @seancva
    seancva committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    c6fb189 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. fixed a test in board_grant_effectuation_task_spec

    @seancva
    seancva committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    1fe3d7e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/department-of-veterans-af… 

    …fairs/caseflow into SeanC/APPEALS-5034
    @seancva
    seancva committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    7cafdfc View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. created a new def in request_issues for active or decided

    @seancva
    seancva committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    38fbd19 View commit details
    Browse the repository at this point in the history

  2. added the new def to the serializer

    @seancva
    seancva committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8c1717d View commit details
    Browse the repository at this point in the history

  3. changed the name of activeRequestIssues to activeOrDecidedRequestIssues

    @seancva
    seancva committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    7c754a1 View commit details
    Browse the repository at this point in the history

  4. updated business_line_task to set completed_by for board grants

    @seancva
    seancva committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    6535e37 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. added basic code to meet ac

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    41f5dd5 View commit details
    Browse the repository at this point in the history

  2. updated code in decsion reveiw task

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    cb31410 View commit details
    Browse the repository at this point in the history

  3. updated code to set the completed_by as well

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    065b3cb View commit details
    Browse the repository at this point in the history

  4. started refactoring handle_issues_with_no_decision_date!

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    d064dea View commit details
    Browse the repository at this point in the history

  5. refactored function to reduce cyclomatic complexity

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    3d44c19 View commit details
    Browse the repository at this point in the history

  6. fixed a code climate issue

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    dd9e24d View commit details
    Browse the repository at this point in the history

  7. attempting to fix a code climate issue

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    27e0aed View commit details
    Browse the repository at this point in the history

  8. moved handle_issues_with_no_decision_date! to decision_review to fix … 

    …code climate issue
    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    71e1f85 View commit details
    Browse the repository at this point in the history

  9. Empty-Commit

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    c3f4e4d View commit details
    Browse the repository at this point in the history

  10. put function back

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    a0dc68e View commit details
    Browse the repository at this point in the history

  11. fixed the failing tests in decision_review_task_spec

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    ead6ec6 View commit details
    Browse the repository at this point in the history

  12. Added _current_user to complete_with_payload in business_line_task

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    4c45580 View commit details
    Browse the repository at this point in the history

  13. fixed a test in board_grant_effectuation_task_spec

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    28e57ae View commit details
    Browse the repository at this point in the history

  14. created a new def in request_issues for active or decided

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    052c8e1 View commit details
    Browse the repository at this point in the history

  15. added the new def to the serializer

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    3ef552b View commit details
    Browse the repository at this point in the history

  16. changed the name of activeRequestIssues to activeOrDecidedRequestIssues

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    80d1745 View commit details
    Browse the repository at this point in the history

  17. updated business_line_task to set completed_by for board grants

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    2b97018 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'SeanC/APPEALS-5034' of https://github.com/department-of… 

    …-veterans-affairs/caseflow into SeanC/APPEALS-5034
    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    48f7121 View commit details
    Browse the repository at this point in the history

  19. addressing first comment from review

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    a1e034d View commit details
    Browse the repository at this point in the history

  20. addressed the second comment of review

    @seancva
    seancva committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    d791947 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Merge branch 'feature/APPEALS-26499' of https://github.com/department… 

    …-of-veterans-affairs/caseflow into SeanC/APPEALS-5034
    @seancva
    seancva committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9477a1d View commit details
    Browse the repository at this point in the history