Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ki/APPEALS-41707 - Intake: Update and remove fields #21473

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

KiMauVA
Copy link
Contributor

@KiMauVA KiMauVA commented Apr 26, 2024

Resolves APPEALS-41707 - Intake: Update and remove field

Description

  • Updated Correspondence Intake Step 1 to remove Source Type Column
  • Updated Correspondence Intake Step 3 to remove:
    • Portal Entry Date, Source Type, CM Packet Number, CMP Queue Name
  • Validated Back-end not returning additional updated information on Submit
  • Updated RSpec Tests for this functionality
  • Code Clean-up
    • Removed 86 unrelated _correspondence.scss Lint issues (21 still remain that require more testing beyond this ticket to update/remove)
    • Updated other linting issues
    • Cleared out other failing RSPecs in branch/same files

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Log in as any correspondence user (ie. INTAKE_OPS_TEAM_MAIL_INTAKE_USER)
  2. Navigate to Correspondence Cases/Your Correspondence
  3. Click on any case in the queue that takes you to a Review Package
  4. Click Create Record
  5. Select "Yes" for Associate with Prior Mail on Step 1 of Intake
  6. Validate that Source Type is no longer in Prior Mail Table
  7. Continue through to Step 3 of Intake Process
  8. Validate that "About the Correspondence" section matches criteria:
    1. Removed: Portal Entry Date, Source Type, CM Packet Number, CMP Queue Name
    2. CSS: Matches 30px requirement, 25% for the 4 non-Note columns

Frontend

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue

Step 1

Screenshot 2024-04-30 at 10 24 57 AM

Step 3

Screenshot 2024-04-30 at 10 22 04 AM

CSS for Step 3 Example/Wireframes

Screenshot 2024-04-25 at 3 54 29 PM
Screenshot 2024-04-26 at 4 07 13 PM

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Other(Linting)

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

@KiMauVA KiMauVA changed the base branch from feature/APPEALS-41477 to master April 26, 2024 20:24
@KiMauVA KiMauVA changed the base branch from master to feature/APPEALS-41477 April 26, 2024 20:29
@KiMauVA KiMauVA self-assigned this Apr 26, 2024
@KiMauVA KiMauVA requested a review from cacevesva April 30, 2024 14:28
@KiMauVA KiMauVA marked this pull request as ready for review April 30, 2024 14:29
@cacevesva cacevesva merged commit 864c7fb into feature/APPEALS-41477 Apr 30, 2024
13 of 17 checks passed
@cacevesva cacevesva deleted the Ki/APPEALS-41707 branch April 30, 2024 18:38
cacevesva added a commit that referenced this pull request May 31, 2024
* Ki/APPEALS-41707 - Intake: Update and remove fields (#21473)

* APPEALS-41707 - Functionality and some CSS

* APPEALS-41707 - Updates

* APPEALS-41707 - Unrelated Specs and Correspondence CSS Lint fixes

* APPEALS-41707 - Additional Linting

* APPEALS-41707 - More Clean up

* APPEALS-42281 - displaying NOD of correspondence in review package page (#21528)

* APPEALS-42281 - displaying NOD of correspondence in review package page

* fixing package document type alignment

* Khalin/appeals 41705 (#21450)

* WIP

* VA DOR update

* VA DOR date text area working as intended

* Functionality working as intended

* Styling

* CPM info removed

* Fixed some failing tests

* WIP

* VA DOR Read Only Styling

* Edit CMP Test Passing

* Fix Jest Job Test

* Jest test fix WIP

* Jest test fix WIP #2

* ReviewForm.test.js Provider Store Update

* Styling

* style

* styling

* remove unused

---------

Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com>
Co-authored-by: KiMauVA <Ki.Mau@va.gov>

* Package document type styling (#21546)

* bug fix for NOD update (#21544)

* bug fix for NOPD update

* APPEALS-42281-bug-fix  - fix to update the nod on selection of correspondence document

* Add data for VA 10182 (#21553)

* Review Package General Info Section Spacing Change (#21559)

* Review Package text spacing (#21560)

* Ki/APPEALS-45367 - Intake - Confirm 3 - Package Document Type (#21571)

* APPEALS-45367 - Fixed Linting. Fixed unnecessary delete

* Rspec fixes

* update package document type NOD/NON-NOD (#21584)

* update NOD

* fix rubocop issues

* Khalin/appeals 45567 Request Package Action Modals Updated (#21590)

* Functionally complete

* Jest test fix

* Khalin/appeals 41706 Intake: Remove Mail Tasks (#21572)

* 'Returned or undeliverable mail' and 'Sent to ROJ' to be removed

* Fix faling tests wip

* Fixed test

* Update correspondence_intake_processor.rb

* Update tasks.js

---------

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* Mail Task Position Correction (#21597)

* added changes to display intake appeal button based on NOD NON-NOD (#21618)

* added changes to display intake appeal button based on NOD NON-NOD

* updated to display intake appeal button after editing the document type

* fixing lint issues

* Update correspondence_review_package_controller.rb

Updated syntax instead of each to find_each

---------

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* Khalin/Appeals 45367 - NOD/Non-NOD Bug Fix (#21619)

* Bug Fixed NOD/Non-NOD Functioning Correctly

* Triggering test

---------

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* Khalin/appeals 45367 NON/Non-NOD Status Fix v2 (#21664)

* NOD/Non-NOD status Fix

* Kicking off tests

* Kicing off tests

* Caceves/appeals 46003 (#21661)

* Add inbound ops super user & adjust inbound ops normal user, disable  VA DOR logic for super user

* Add automatic seeding of inbound ops team super user

* fix for continue button on select of yes no (#21721)

* Sivakesh/appeals 44110 - Correspondence CSS Issues (#21763)

* #44110 - moved all ReceiptDatePicker styles to correspondence scss file

* #44110 - moved all TaskCompletedDatePicker styles to correspondence scss file

* #44110 - moved all AddLetter styles to correspondence scss file

* #44110 - moved all NewLetter styles to correspondence scss file

* #44110 - moved all CorrespondencePdfUI.jsx styles to correspondence scss file

* Khalin/appeals 45867 (#21703)

* WIP

* Reverting changes

* Save Changes Bug Fixed

* Return To Queue button working as intended

* Prevents save action in case of errorMessage

* WIP

* WIP

* Working as intended

* Removing comments

* fixing tests

* fixing lint error

---------

Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com>

* Sivakesh/appeals 44110 (#21775)

* #44110 - moved all ReceiptDatePicker styles to correspondence scss file

* #44110 - moved all TaskCompletedDatePicker styles to correspondence scss file

* #44110 - moved all AddLetter styles to correspondence scss file

* #44110 - moved all NewLetter styles to correspondence scss file

* #44110 - moved all CorrespondencePdfUI.jsx styles to correspondence scss file

* #44110 - lint errors

* Remove old seed data (#21780)

---------

Co-authored-by: Ki Mau <ki.mau@va.gov>
Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com>
Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com>
Co-authored-by: psivakeshva <168677299+psivakeshva@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants