Khalin/appeals 45867 #21703
Merged
Khalin/appeals 45867 #21703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 7c8d226 and detected 23 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
cacevesva
reviewed
May 31, 2024
| @@ -308,6 +372,7 @@ ReviewForm.propTypes = { | |||
| userIsCorrespondenceSuperuser: PropTypes.bool, | |||
| userIsCorrespondenceSupervisor: PropTypes.bool, | |||
| correspondence: PropTypes.object, | |||
| setCorrTypeSelected: PropTypes.bool | |||
There was a problem hiding this comment.
Duplicate key name lint error
cacevesva
approved these changes
May 31, 2024
cacevesva
approved these changes
May 31, 2024
cacevesva
added a commit
that referenced
this pull request
May 31, 2024
* Ki/APPEALS-41707 - Intake: Update and remove fields (#21473) * APPEALS-41707 - Functionality and some CSS * APPEALS-41707 - Updates * APPEALS-41707 - Unrelated Specs and Correspondence CSS Lint fixes * APPEALS-41707 - Additional Linting * APPEALS-41707 - More Clean up * APPEALS-42281 - displaying NOD of correspondence in review package page (#21528) * APPEALS-42281 - displaying NOD of correspondence in review package page * fixing package document type alignment * Khalin/appeals 41705 (#21450) * WIP * VA DOR update * VA DOR date text area working as intended * Functionality working as intended * Styling * CPM info removed * Fixed some failing tests * WIP * VA DOR Read Only Styling * Edit CMP Test Passing * Fix Jest Job Test * Jest test fix WIP * Jest test fix WIP #2 * ReviewForm.test.js Provider Store Update * Styling * style * styling * remove unused --------- Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com> Co-authored-by: KiMauVA <Ki.Mau@va.gov> * Package document type styling (#21546) * bug fix for NOD update (#21544) * bug fix for NOPD update * APPEALS-42281-bug-fix - fix to update the nod on selection of correspondence document * Add data for VA 10182 (#21553) * Review Package General Info Section Spacing Change (#21559) * Review Package text spacing (#21560) * Ki/APPEALS-45367 - Intake - Confirm 3 - Package Document Type (#21571) * APPEALS-45367 - Fixed Linting. Fixed unnecessary delete * Rspec fixes * update package document type NOD/NON-NOD (#21584) * update NOD * fix rubocop issues * Khalin/appeals 45567 Request Package Action Modals Updated (#21590) * Functionally complete * Jest test fix * Khalin/appeals 41706 Intake: Remove Mail Tasks (#21572) * 'Returned or undeliverable mail' and 'Sent to ROJ' to be removed * Fix faling tests wip * Fixed test * Update correspondence_intake_processor.rb * Update tasks.js --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Mail Task Position Correction (#21597) * added changes to display intake appeal button based on NOD NON-NOD (#21618) * added changes to display intake appeal button based on NOD NON-NOD * updated to display intake appeal button after editing the document type * fixing lint issues * Update correspondence_review_package_controller.rb Updated syntax instead of each to find_each --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Khalin/Appeals 45367 - NOD/Non-NOD Bug Fix (#21619) * Bug Fixed NOD/Non-NOD Functioning Correctly * Triggering test --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Khalin/appeals 45367 NON/Non-NOD Status Fix v2 (#21664) * NOD/Non-NOD status Fix * Kicking off tests * Kicing off tests * Caceves/appeals 46003 (#21661) * Add inbound ops super user & adjust inbound ops normal user, disable VA DOR logic for super user * Add automatic seeding of inbound ops team super user * fix for continue button on select of yes no (#21721) * Sivakesh/appeals 44110 - Correspondence CSS Issues (#21763) * #44110 - moved all ReceiptDatePicker styles to correspondence scss file * #44110 - moved all TaskCompletedDatePicker styles to correspondence scss file * #44110 - moved all AddLetter styles to correspondence scss file * #44110 - moved all NewLetter styles to correspondence scss file * #44110 - moved all CorrespondencePdfUI.jsx styles to correspondence scss file * Khalin/appeals 45867 (#21703) * WIP * Reverting changes * Save Changes Bug Fixed * Return To Queue button working as intended * Prevents save action in case of errorMessage * WIP * WIP * Working as intended * Removing comments * fixing tests * fixing lint error --------- Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com> * Sivakesh/appeals 44110 (#21775) * #44110 - moved all ReceiptDatePicker styles to correspondence scss file * #44110 - moved all TaskCompletedDatePicker styles to correspondence scss file * #44110 - moved all AddLetter styles to correspondence scss file * #44110 - moved all NewLetter styles to correspondence scss file * #44110 - moved all CorrespondencePdfUI.jsx styles to correspondence scss file * #44110 - lint errors * Remove old seed data (#21780) --------- Co-authored-by: Ki Mau <ki.mau@va.gov> Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com> Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com> Co-authored-by: psivakeshva <168677299+psivakeshva@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
"Create Record" button is now disabled until "Correspondence Type" is chosen.
Acceptance Criteria
Testing Plan