hotfix/APPEALS-45399-45401 #21555
Merged
hotfix/APPEALS-45399-45401 #21555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefftmarks
changed the title
…-of-veterans-affairs/caseflow into hotfix/APPEALS-45399-45401
…iler failed delivery
…issue mailer failed delivery" This reverts commit d9ce585.
msteele96
approved these changes
May 6, 2024
jefftmarks
changed the title
mchbidwell
pushed a commit
that referenced
this pull request
May 20, 2024
* added saftey opperator and removed outdated date check * removed leftover method that was breaking and unused. * removed legacy appeal date check for MST on special issue list * updated mst and pact badges to check decisions in flight (if any) then appeal model. * removed bypass for special issue list for pact toggle for AMA. * updated rake and seed comments * allowed special issues page tracking for AMA MST issues when pact is enabled * remove code changes causing cancel to progress forward * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * moved method definition validate_claim_code into ClaimLabelChange class * fixed spacing issue * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * fixed linting error * fixed linting issue * draft pr * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Wmedders21/appeals 44873 (#21469) * add rubyzip gem * Test: Hearings::ZipAndUploadTranscriptionFilesJob * Feature: Hearings::ZipAndUploadTranscriptionFilesJob * Add zip subfolder to tmp/transcription_files * Move new gem to proper alphabetical position in list * revert gem file changes * update gem file with feature branch * refactor #perform method parameters * update parameter name * Piedram/appeals 44897 (#21519) * Create new Workflow transcription_packages: Step One * add some changes * Modified the parameters for ZipAndUploadTranscriptionFilesJob * Modified spec test * Update transcription_packages.rb * remove extra blank line --------- Co-authored-by: piedram <maite.piedrayera@va.gov> * Wmedders21/appeals 44874 (#21512) * add rubyzip gem * Test: Hearings::ZipAndUploadTranscriptionFilesJob * Feature: Hearings::ZipAndUploadTranscriptionFilesJob * Add zip subfolder to tmp/transcription_files * Move new gem to proper alphabetical position in list * revert gem file changes * update gem file with feature branch * refactor #perform method parameters * update parameter name * add zip extension to valid file types * Test: transcription file creation and upload to s3 * Hearings::ZipAndUploadTranscriptionFilesJob updates db and uploads to s3 * resolve merge conflict * APPEALS-44876 Work order job file (#21504) * APPEALS-44876 Work order job file * Updated filename with work order name * Refactored create table method and updated spec --------- Co-authored-by: Jim Foley <james.foley4@va.gov> * Completing AC for ticketing for styling and error portion of page. Now doing feature test * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * added ability for user to search by css id * added feature tests for using search bar * reverted changes in package.json * removed added file * removed linting error * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * searchable by 2 characters instead of 1 * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * ccc * gggg * gggg * Create new Workflow transcription_packages: Step Two (#21570) * Add call function to the new job, and modified spec files * call the jobs * feature/APPEALS-44188-44282 - Deprecation fixes for Rails 6.1 (release) (#21614) * 🔀 Squash merge jcroteau/APPEALS-44188-fix-deprecation-warning-class-level-methods-will-no-longer-inherit-scoping * 🔀 Squash merge jcroteau/APPEALS-44282-fix-deprecation-not-conditions-will-no-longer-behave-as-nor * Work order file upload to AWS s3 (#21582) * Work order file upload to AWS s3 * refactor code for upload to AWS * refactor code for instance variables * Revert "refactor code for instance variables" This reverts commit b61c72a. * code refactor for work order file * APPEALS-44877 refactor for work order * APPEALS-44310: add notification for unexpected task trees and update tests (#21474) * add notification for unexpected task trees and update tests * add slack notification to distribution errors, set default slack url in SlackService * add tests for distributions to validate handling of errors in the ama_statistics method * fix bad check for allowable tasks * fix tests which were expecting a url as arg to new slack service * fix codeclimate warning * APPEALS-45199: Update Quality Review selection probabilities #21518 * APPEALS-44423: Remove therubyracer and jshint gems (#21443) * APPEALS-42941 copied over Matt's work (#21624) * APPEALS-43190 (#21448) * APPEALS-43190 initial migration file * APPEALS-43190 add seed data * APPEALS-43190 add magic comment * APPEALS-43190 move seed command * APPEALS-43190 add bang! * APPEALS-43190 update migration file * APPEALS-43190 attribute name fix and updates * APPEALS-43190 fix seed attribute * APPEALS-43190 stubbed more seed data * APPEALS-43190 remove seed comment * APPEALS-43190 remove comment * APPEALS-43190 add magic comment * APPEALS-43190 update comments * Wmedders21/appeals 44875 (#21605) * Add retry logic for upload failure * fix indentation rubocop warning * Refactor zip job * remove blank line --------- Co-authored-by: Jim Foley <james.foley4@va.gov> * akonhilas/APPEALS-43193 (#21581) * APPEALS-43193: Add new columns and indexes to transcriptions table * APPEALS-43193: Add new columns and indexes to transcriptions table * APPEALS-43193: move index to own file * APPEALS-43193: Update transcription contractor id to bigint * APPEALS-43193: bigint * APPEALS-43193: add fk after trancription_contractors table added * lint error resolution (#21631) * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * APPEALS-44878 refactor for retry and upon success kickoff zip file job (#21652) * APPEALS-44878 refactor for retry and upon success kickoff zip file job * APPEALS-44878 refactor code * APPEALS-44878 refactor xls path * lint error fix * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * Piedram/appeals 45696 (#21655) * Create new Workflow Error handling transcription_packages: Step Three related to appeals-31793 * MOdified spec file * fix lint error * APPEALS-45696 refactor for work_order_params --------- Co-authored-by: Kamala Madamanchi <kamala.madamanchi@va.gov> Co-authored-by: Jim Foley <james.foley4@va.gov> * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * Fix lint warnings --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Andrew Hadley <hadley_andrew@bah.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: IsaiahBar <isaiah.barnett@va.gov> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com> Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: piedram <maite.piedrayera@va.gov> Co-authored-by: Kamala Madamanchi <110078646+kamala-07@users.noreply.github.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: piedram <110848569+piedram@users.noreply.github.com> Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> Co-authored-by: Kamala Madamanchi <kamala.madamanchi@va.gov>
minhazur9
added a commit
that referenced
this pull request
May 23, 2024
…-affairs/caseflow into min/APPEALS-43140 * 'min/APPEALS-43140' of github.com:department-of-veterans-affairs/caseflow: (57 commits) APPEALS-45503 created table for transcription_packages (#21685) Wmedders21/appeals 43231 (#21670) Remove unused styles after merge hotfix/APPEALS-45828 (#21625) Piedram/appeals 45696 (#21655) msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) APPEALS-44878 refactor for retry and upon success kickoff zip file job (#21652) Hotfix/APPEALS-45818 (#21632) hotfix/APPEALS-45472 (#21562) lint error resolution (#21631) APPEALS-42941 copied over Matt's work (#21624) APPEALS-44423: Remove therubyracer and jshint gems (#21443) APPEALS-45199: Update Quality Review selection probabilities #21518 APPEALS-44310: add notification for unexpected task trees and update tests (#21474) feature/APPEALS-44188-44282 - Deprecation fixes for Rails 6.1 (release) (#21614) Added a customizable per page task limitation attribute to QueueTab that is used by task_pager to allow an adjustable maximum number of tasks per tab. (#21594) gggg gggg ccc hotfix/APPEALS-45399-45401-45472 (#21555) ...
mchbidwell
added a commit
that referenced
this pull request
Jul 16, 2024
* APPEALS-43190 (#21448) * APPEALS-43190 initial migration file * APPEALS-43190 add seed data * APPEALS-43190 add magic comment * APPEALS-43190 move seed command * APPEALS-43190 add bang! * APPEALS-43190 update migration file * APPEALS-43190 attribute name fix and updates * APPEALS-43190 fix seed attribute * APPEALS-43190 stubbed more seed data * APPEALS-43190 remove seed comment * APPEALS-43190 remove comment * APPEALS-43190 add magic comment * APPEALS-43190 update comments * APPEALS-43137 (#21511) * APPEALS-43190 initial migration file * APPEALS-43190 add seed data * APPEALS-43190 add magic comment * APPEALS-43190 move seed command * APPEALS-43190 add bang! * APPEALS-43190 update migration file * APPEALS-43190 attribute name fix and updates * APPEALS-43190 fix seed attribute * APPEALS-43190 stubbed more seed data * APPEALS-43190 remove seed comment * APPEALS-43190 remove comment * APPEALS-43137 - Basic controller and route * APPEALS-43137 - Test the new transcription settings controller * APPEALS-43137 - Add basic route and tests for index * APPEALS-43137 - Remove changes * APPEALS-43137 - Fix JSON responses and error * APPEALS-43137 - Change record to contractor --------- Co-authored-by: breedbah <brandon.reed3@va.gov> * APPEALS-43125 (#21550) * APPEALS-43190 initial migration file * APPEALS-43190 add seed data * APPEALS-43190 add magic comment * APPEALS-43190 move seed command * APPEALS-43190 add bang! * APPEALS-43190 update migration file * APPEALS-43190 attribute name fix and updates * APPEALS-43190 fix seed attribute * APPEALS-43137 - Basic controller and route * initial component folder creation and db update * APPEALS-43190 stubbed more seed data * APPEALS-43190 remove seed comment * APPEALS-43190 remove comment * APPEALS-43137 - Basic controller and route * APPEALS-43137 - Test the new transcription settings controller * APPEALS-43137 - Add basic route and tests for index * Initial heading creation * add container for transcription settings * Remove errors * Pushing with error - change to component style * Updated component style - working * Updated styling with all components present * Add text to copy and update settings page * Add test to check that page displays contractor content * Clean up CSS * Update Gemfile.lock Added libv8 linux version back into file --------- Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> * APPEALS-43138 (#21554) * APPEALS_43138 init commit * APPEALS-43138 update jsx * APPEALS-43138 upudate transcription_c tests * APPEALS-43138 add unit tests * APPEALS - 43138 handle error * APPEALS-43138 update snaphot * APPEALS-43138 update snapshot details.test.js * APPEALS-43138 lint TranscriptionSettingsContainer.jsx * APPEALS-43138 lint TranscriptionSettings.jsx * APPEALS-43138 update feature_helper.rb * APPEALS-43138 update test * APPEALS-43138 change feature_helper back * APPEALS-43138 feature_helper * APPEALS-43138 add delay * APPEALS-43138 update feature helper * APPEALS-43138 remove sleep(1) * APPEALS-43138 add wait on dropdown * APPEALS-43138 change back to original * APPEALS-43138 add "wait" * APPEALS-43138 - Testing a theory * APPEALS-43138 add seed data to test * APPELA-43138 update the wait in spec_helper * APPELA-43138 - Remove test changes --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-43195 - Create MVC for Contractors (#21628) * APPEALS-43195 - Updated transcription setttings controller, models, tests # Conflicts: # app/models/hearings/transcription_contractor.rb # spec/models/hearings/transcription_contractors_model_spec.rb * APPEALS-43195 - Rename controller * APPEALS-43195 - Sort contractors in dropdown * Merging lastest changes from outside APPEALS-31792 (#21680) * added saftey opperator and removed outdated date check * removed leftover method that was breaking and unused. * removed legacy appeal date check for MST on special issue list * updated mst and pact badges to check decisions in flight (if any) then appeal model. * removed bypass for special issue list for pact toggle for AMA. * updated rake and seed comments * allowed special issues page tracking for AMA MST issues when pact is enabled * remove code changes causing cancel to progress forward * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * moved method definition validate_claim_code into ClaimLabelChange class * fixed spacing issue * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * fixed linting error * fixed linting issue * draft pr * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Wmedders21/appeals 44873 (#21469) * add rubyzip gem * Test: Hearings::ZipAndUploadTranscriptionFilesJob * Feature: Hearings::ZipAndUploadTranscriptionFilesJob * Add zip subfolder to tmp/transcription_files * Move new gem to proper alphabetical position in list * revert gem file changes * update gem file with feature branch * refactor #perform method parameters * update parameter name * Piedram/appeals 44897 (#21519) * Create new Workflow transcription_packages: Step One * add some changes * Modified the parameters for ZipAndUploadTranscriptionFilesJob * Modified spec test * Update transcription_packages.rb * remove extra blank line --------- Co-authored-by: piedram <maite.piedrayera@va.gov> * Wmedders21/appeals 44874 (#21512) * add rubyzip gem * Test: Hearings::ZipAndUploadTranscriptionFilesJob * Feature: Hearings::ZipAndUploadTranscriptionFilesJob * Add zip subfolder to tmp/transcription_files * Move new gem to proper alphabetical position in list * revert gem file changes * update gem file with feature branch * refactor #perform method parameters * update parameter name * add zip extension to valid file types * Test: transcription file creation and upload to s3 * Hearings::ZipAndUploadTranscriptionFilesJob updates db and uploads to s3 * resolve merge conflict * APPEALS-44876 Work order job file (#21504) * APPEALS-44876 Work order job file * Updated filename with work order name * Refactored create table method and updated spec --------- Co-authored-by: Jim Foley <james.foley4@va.gov> * Completing AC for ticketing for styling and error portion of page. Now doing feature test * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * added ability for user to search by css id * added feature tests for using search bar * reverted changes in package.json * removed added file * removed linting error * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * searchable by 2 characters instead of 1 * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585c59444f9793e681e58060d71872057e4c. * ccc * gggg * gggg * Create new Workflow transcription_packages: Step Two (#21570) * Add call function to the new job, and modified spec files * call the jobs * feature/APPEALS-44188-44282 - Deprecation fixes for Rails 6.1 (release) (#21614) * 🔀 Squash merge jcroteau/APPEALS-44188-fix-deprecation-warning-class-level-methods-will-no-longer-inherit-scoping * 🔀 Squash merge jcroteau/APPEALS-44282-fix-deprecation-not-conditions-will-no-longer-behave-as-nor * Work order file upload to AWS s3 (#21582) * Work order file upload to AWS s3 * refactor code for upload to AWS * refactor code for instance variables * Revert "refactor code for instance variables" This reverts commit b61c72a3f2e30e4003e9d4a4dc57a01dbb105443. * code refactor for work order file * APPEALS-44877 refactor for work order * APPEALS-44310: add notification for unexpected task trees and update tests (#21474) * add notification for unexpected task trees and update tests * add slack notification to distribution errors, set default slack url in SlackService * add tests for distributions to validate handling of errors in the ama_statistics method * fix bad check for allowable tasks * fix tests which were expecting a url as arg to new slack service * fix codeclimate warning * APPEALS-45199: Update Quality Review selection probabilities #21518 * APPEALS-44423: Remove therubyracer and jshint gems (#21443) * APPEALS-42941 copied over Matt's work (#21624) * APPEALS-43190 (#21448) * APPEALS-43190 initial migration file * APPEALS-43190 add seed data * APPEALS-43190 add magic comment * APPEALS-43190 move seed command * APPEALS-43190 add bang! * APPEALS-43190 update migration file * APPEALS-43190 attribute name fix and updates * APPEALS-43190 fix seed attribute * APPEALS-43190 stubbed more seed data * APPEALS-43190 remove seed comment * APPEALS-43190 remove comment * APPEALS-43190 add magic comment * APPEALS-43190 update comments * Wmedders21/appeals 44875 (#21605) * Add retry logic for upload failure * fix indentation rubocop warning * Refactor zip job * remove blank line --------- Co-authored-by: Jim Foley <james.foley4@va.gov> * akonhilas/APPEALS-43193 (#21581) * APPEALS-43193: Add new columns and indexes to transcriptions table * APPEALS-43193: Add new columns and indexes to transcriptions table * APPEALS-43193: move index to own file * APPEALS-43193: Update transcription contractor id to bigint * APPEALS-43193: bigint * APPEALS-43193: add fk after trancription_contractors table added * lint error resolution (#21631) * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * APPEALS-44878 refactor for retry and upon success kickoff zip file job (#21652) * APPEALS-44878 refactor for retry and upon success kickoff zip file job * APPEALS-44878 refactor code * APPEALS-44878 refactor xls path * lint error fix * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * Piedram/appeals 45696 (#21655) * Create new Workflow Error handling transcription_packages: Step Three related to appeals-31793 * MOdified spec file * fix lint error * APPEALS-45696 refactor for work_order_params --------- Co-authored-by: Kamala Madamanchi <kamala.madamanchi@va.gov> Co-authored-by: Jim Foley <james.foley4@va.gov> * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * Fix lint warnings --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Andrew Hadley <hadley_andrew@bah.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: IsaiahBar <isaiah.barnett@va.gov> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com> Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: piedram <maite.piedrayera@va.gov> Co-authored-by: Kamala Madamanchi <110078646+kamala-07@users.noreply.github.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: piedram <110848569+piedram@users.noreply.github.com> Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> Co-authored-by: Kamala Madamanchi <kamala.madamanchi@va.gov> * APPEALS-43127 (#21702) * APPEALS-43127 initial setup * APPEALS-43127 modal is popping up and getting data * APPEALS-43127 update tghe state * APPEALS-43127 updated lint * APPEALS-43127 remove unused function * APPEALS-43127 change to searchableDropdown * APPEALS-43127 update COPY.json * APPEALS-43127 remove commented data * APPEALS-43127 lint in modal * APPEALS-43127 update COPY.json * APPEALS-43127 update COPY.json * APPEALS-43127 update COPY.json * APPEALS-43172 removeContractorModal tests complete * APPEALS-43127 update test and snapshot * APPEALS-43127 update cancel button * APPEALS-43127 lint * APPEALS-43128 - Create a New Modal named "Add Contractor" (#21720) * APPEALS-43128 - First pass at modal with form and basic validation # Conflicts: # client/COPY.json # client/app/hearings/components/transcriptionProcessing/TranscriptionSettings.jsx * APPEALS-43128 - Saving a contractor and displaying success # Conflicts: # client/app/hearings/components/transcriptionProcessing/TranscriptionSettings.jsx * APPEALS-43128 - Remove bad migration * APPEALS-43128 - Update modal validation and handle error from server side * APPEALS-43128 - Some cleanup and test writing # Conflicts: # client/app/hearings/components/transcriptionProcessing/TranscriptionSettings.jsx * APPEALS-43128 - Some minor updates to make the edit work easier when it starts * APPEALS-43128 - Text changes for edit view to match designs * APPEALS-43128 - Un-change a line # Conflicts: # client/app/hearings/components/transcriptionProcessing/TranscriptionSettings.jsx * APPEALS-43128 - Updates after new code was merged in * APPEALS-43128 - Fixing jest problems * APPEALS-43128 - Text adjustments from BA review * APPEALS-45881 (#21787) * Showing iterating contractors on transcription settings page * Add changes to iteration and seed data * Styling progress * CSS fixes for a couple of alignment issues and some lint warnings * Use state contractors instead of props so the list refreshes * Updates for button area * Forgot to update the snapshot * Link frontend toggle switch to contractor table --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-43129 Create a New Modal named "Edit Contractor" (#21877) * added saftey opperator and removed outdated date check * removed leftover method that was breaking and unused. * removed legacy appeal date check for MST on special issue list * updated mst and pact badges to check decisions in flight (if any) then appeal model. * removed bypass for special issue list for pact toggle for AMA. * updated rake and seed comments * allowed special issues page tracking for AMA MST issues when pact is enabled * remove code changes causing cancel to progress forward * moved method definition validate_claim_code into ClaimLabelChange class * fixed spacing issue * fixed linting error * fixed linting issue * draft pr * Completing AC for ticketing for styling and error portion of page. Now doing feature test * added ability for user to search by css id * added feature tests for using search bar * reverted changes in package.json * removed added file * removed linting error * searchable by 2 characters instead of 1 * ccc * gggg * gggg * feature/APPEALS-44188-44282 - Deprecation fixes for Rails 6.1 (release) (#21614) * 🔀 Squash merge jcroteau/APPEALS-44188-fix-deprecation-warning-class-level-methods-will-no-longer-inherit-scoping * 🔀 Squash merge jcroteau/APPEALS-44282-fix-deprecation-not-conditions-will-no-longer-behave-as-nor * APPEALS-44310: add notification for unexpected task trees and update tests (#21474) * add notification for unexpected task trees and update tests * add slack notification to distribution errors, set default slack url in SlackService * add tests for distributions to validate handling of errors in the ama_statistics method * fix bad check for allowable tasks * fix tests which were expecting a url as arg to new slack service * fix codeclimate warning * APPEALS-45199: Update Quality Review selection probabilities #21518 * APPEALS-44423: Remove therubyracer and jshint gems (#21443) * APPEALS-42941 copied over Matt's work (#21624) * lint error resolution (#21631) * Feature/appeals 46208.rc (#21746) * Added Assignment Queue link to Switch Users test page * Updated controller to validate role and redirect * Updated error information * Updated rspec tests * Ricky/appeals-43523 (#21345) * Added Assignment Queue link to Switch Users test page * Updated controller to validate role and redirect * Updated error information * Updated rspec tests * Added Download Ineligible Judge List * APPEALS-43116 add sentry error capture to push priority job and updated specs (#21369) * Updated query to include css_id and updated id fetch * Updates button styling, fixed csv to have all values but judge name * Updated id to sattyid values, and added name data to column * fixed linting error * Updated logic to account for inactive users in both caseflow and vacols * Updated button component and cleaned up code * Updated handling of ids in situation where sattyid is unavailable in record * Updated to have individual columns for caseflow id and satty id * APPEALS-43117 Add QA Users for testing (#21580) * APPEALS-43117 Add QA Users for testing * Fix rspecs --------- Co-authored-by: Christopher Detlef <> * APPEALS-42266 Remove CaseDistributionLevers seed config in Rails helper and update required spec files * APPEALS-42266 fixing a couple of linting issues * APPEALS-43523 reverted the legacy tasks controller (#21713) * APPEALS-43523 reverted the legacy tasks controller * APPEALS-43523 reverted the erorrs concern too * Update legacy_tasks_controller_spec.rb * reverted raven call * APPEALS-46208 fixed code climate warning about a bad naming convention. * APPEALS-46208 fixed indentation --------- Co-authored-by: 631068 <rickybmanus@gmail.com> Co-authored-by: Blake Manus <33578594+Blake-Manus@users.noreply.github.com> Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com> Co-authored-by: cdetlefva <133903625+cdetlefva@users.noreply.github.com> Co-authored-by: kristeja <krishnateja.golla@va.gov> * APPEALS-44148: Add ruby CE API Gem (#21520) * hotfix/APPEALS-46182 (#21709) * Added tests and added logic to account for sct distribution * Added more tests and changed logic * Adding comments * Fixing logic for SCT * Update test and logic * Fixing tests * Update docket switch mail task to match corrected logic * Fixing logic * Cleaning up refactor * Worked with the amazing ALex and we figured it out! * Fixing linting issue * Fix linting issues * Skipping flaky tests * Skipping another flaky test --------- Co-authored-by: Alexandra Ferencz <ferencz_alexandra@bah.com> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * MattT/APPEALS-46383: Upgrade aws-sdk gem to v3.2 (#21748) * Upgrade aws-sdk gem to v3.2 * Update caseflow-commons hash * Apply new hash update * Skip flaky test --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Update gemfile and gemfile.lock to point to new bgs version (#21749) * Update gemfile and gemfile.lock to point to new bgs version * Skipping flake specs in review_spec.rb file * Revert "APPEALS-44148: Add ruby CE API Gem (#21520)" (#21762) This reverts commit 3a393d1f3f40b35b5063c2b7d0f1508ef5a61bb7. * Update ruby-bgs gemfile and gemfile.lock to new version (#21761) * Update MAC_INTEL.md Update Oracle client link * Resolved merge conflicts * Call patch with updateContractor * Progress with linking EditModal to Edit Contractor link * Updated Edit contractor link details * Edit Modal working with link and persisting changes * Add rendering test to check for Edit contractor modal * Fix styling and update copy * Fix linting issues * Update snapshot and fix linting issue --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: Andrew Hadley <hadley_andrew@bah.com> Co-authored-by: IsaiahBar <isaiah.barnett@va.gov> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com> Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> Co-authored-by: 631068 <rickybmanus@gmail.com> Co-authored-by: Blake Manus <33578594+Blake-Manus@users.noreply.github.com> Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com> Co-authored-by: cdetlefva <133903625+cdetlefva@users.noreply.github.com> Co-authored-by: kristeja <krishnateja.golla@va.gov> Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com> Co-authored-by: Alex Ferencz VA <156860944+aferencz1987VA@users.noreply.github.com> Co-authored-by: Alexandra Ferencz <ferencz_alexandra@bah.com> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Alec Spottswood <ajspottswood@gmail.com> * APPEALS-43134 Create a New Modal named "Edit Goals" (#22022) * added saftey opperator and removed outdated date check * removed leftover method that was breaking and unused. * removed legacy appeal date check for MST on special issue list * updated mst and pact badges to check decisions in flight (if any) then appeal model. * removed bypass for special issue list for pact toggle for AMA. * updated rake and seed comments * allowed special issues page tracking for AMA MST issues when pact is enabled * remove code changes causing cancel to progress forward * moved method definition validate_claim_code into ClaimLabelChange class * fixed spacing issue * fixed linting error * fixed linting issue * draft pr * Completing AC for ticketing for styling and error portion of page. Now doing feature test * added ability for user to search by css id * added feature tests for using search bar * reverted changes in package.json * removed added file * removed linting error * searchable by 2 characters instead of 1 * ccc * gggg * gggg * feature/APPEALS-44188-44282 - Deprecation fixes for Rails 6.1 (release) (#21614) * 🔀 Squash merge jcroteau/APPEALS-44188-fix-deprecation-warning-class-level-methods-will-no-longer-inherit-scoping * 🔀 Squash merge jcroteau/APPEALS-44282-fix-deprecation-not-conditions-will-no-longer-behave-as-nor * APPEALS-44310: add notification for unexpected task trees and update tests (#21474) * add notification for unexpected task trees and update tests * add slack notification to distribution errors, set default slack url in SlackService * add tests for distributions to validate handling of errors in the ama_statistics method * fix bad check for allowable tasks * fix tests which were expecting a url as arg to new slack service * fix codeclimate warning * APPEALS-45199: Update Quality Review selection probabilities #21518 * APPEALS-44423: Remove therubyracer and jshint gems (#21443) * APPEALS-42941 copied over Matt's work (#21624) * lint error resolution (#21631) * Feature/appeals 46208.rc (#21746) * Added Assignment Queue link to Switch Users test page * Updated controller to validate role and redirect * Updated error information * Updated rspec tests * Ricky/appeals-43523 (#21345) * Added Assignment Queue link to Switch Users test page * Updated controller to validate role and redirect * Updated error information * Updated rspec tests * Added Download Ineligible Judge List * APPEALS-43116 add sentry error capture to push priority job and updated specs (#21369) * Updated query to include css_id and updated id fetch * Updates button styling, fixed csv to have all values but judge name * Updated id to sattyid values, and added name data to column * fixed linting error * Updated logic to account for inactive users in both caseflow and vacols * Updated button component and cleaned up code * Updated handling of ids in situation where sattyid is unavailable in record * Updated to have individual columns for caseflow id and satty id * APPEALS-43117 Add QA Users for testing (#21580) * APPEALS-43117 Add QA Users for testing * Fix rspecs --------- Co-authored-by: Christopher Detlef <> * APPEALS-42266 Remove CaseDistributionLevers seed config in Rails helper and update required spec files * APPEALS-42266 fixing a couple of linting issues * APPEALS-43523 reverted the legacy tasks controller (#21713) * APPEALS-43523 reverted the legacy tasks controller * APPEALS-43523 reverted the erorrs concern too * Update legacy_tasks_controller_spec.rb * reverted raven call * APPEALS-46208 fixed code climate warning about a bad naming convention. * APPEALS-46208 fixed indentation --------- Co-authored-by: 631068 <rickybmanus@gmail.com> Co-authored-by: Blake Manus <33578594+Blake-Manus@users.noreply.github.com> Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com> Co-authored-by: cdetlefva <133903625+cdetlefva@users.noreply.github.com> Co-authored-by: kristeja <krishnateja.golla@va.gov> * APPEALS-44148: Add ruby CE API Gem (#21520) * hotfix/APPEALS-46182 (#21709) * Added tests and added logic to account for sct distribution * Added more tests and changed logic * Adding comments * Fixing logic for SCT * Update test and logic * Fixing tests * Update docket switch mail task to match corrected logic * Fixing logic * Cleaning up refactor * Worked with the amazing ALex and we figured it out! * Fixing linting issue * Fix linting issues * Skipping flaky tests * Skipping another flaky test --------- Co-authored-by: Alexandra Ferencz <ferencz_alexandra@bah.com> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * MattT/APPEALS-46383: Upgrade aws-sdk gem to v3.2 (#21748) * Upgrade aws-sdk gem to v3.2 * Update caseflow-commons hash * Apply new hash update * Skip flaky test --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Update gemfile and gemfile.lock to point to new bgs version (#21749) * Update gemfile and gemfile.lock to point to new bgs version * Skipping flake specs in review_spec.rb file * Revert "APPEALS-44148: Add ruby CE API Gem (#21520)" (#21762) This reverts commit 3a393d1f3f40b35b5063c2b7d0f1508ef5a61bb7. * Update ruby-bgs gemfile and gemfile.lock to new version (#21761) * Update MAC_INTEL.md Update Oracle client link * Resolved merge conflicts * APPEALS-44496 Fix Factory (#21770) * APPEALS-44496 Fix Factory * updated falky test --------- Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * fix(va facilities): update per page param (#21754) * Hotfix/appeals 44033:Fix Judge and Attorney tasks in the QualityReview workflow are being erroneously cancelled (#21786) * Adjusts the send_to_hearings_branch method to exclude JudgeQualityReviews when cancelling all Judge tasks and subtasks rebase * adjusts spacing and adds back deleted test * Remove unnecessary schema changes and adds an exclamation mark to account for method that changes data * add exclamation to handle_judge_tasks --------- Co-authored-by: Zackary Borges-Rowe <borges-rowe_zackary@bah.com> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * Hotfix/appeals 45150 (#21627) * Added distribution task with children status change on split appeal test * Added tests and commented out pry session in appeal * Changed split appeal test to test for both defects * Added conditional logic to status_is_valid_on_create in task model * looking for defect * Reverted changes to finalize split appeal method added condtional logic to schedule hearing tasks model * Removed debugger and commented out lines * Added erroneously removed lines of code and added spacing * Fix linting errors * Added conditional logic for appeal split process --------- Co-authored-by: Alexandra Ferencz <ferencz_alexandra@bah.com> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * hotfix/APPEALS-36313-V2 (#21782) * avoid IHP task creation with an open pre-docket task * Fix linting errors on RSpec * Skip flaky BGS Share Error test * comment failed test case --------- Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> * APPEALS-47106 Caseflow Swagger (#21847) * Add Rswag and convert existing API documentation (#21778) * add rswag * Update Gemfile.lock * Setup yaml UI * remove and reroute old swagger files * update format and servers values * Update route_docs_controller.rb * Update cmp_controller.rb * cmp endpoint yaml * cmp endpoint to return 501 * CMP endpoint swagger flies * update swagger files * adjust server order, add auth token * cmp parameter name change * add comments * Update users_controller.rb * unit tests and linting * lint fixes * Update swagger_helper.rb * skip flakey tests * Update appeal_notifications_page_spec.rb * Hotfix/appeals 36313 v2 (#21858) * avoid IHP task creation with an open pre-docket task * Fix linting errors on RSpec * Skip flaky BGS Share Error test * comment failed test case * Add predocket coverage for IHP task creation when POA is updated * adjust predocketed from active status to open to include on_hold status * Remove commented out data staging for bgs POA rspec test --------- Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> * feature/appeals-43220 (#21862) * Adding 403 and 404 functionality to Reader. * Adding icon to button. * Fixing linting issues. * Using the Link component and moving href into constant * fix linter issues --------- Co-authored-by: Brian Bommarito <brian@bommarito.me> * feature/appeals-39842 (#21864) * anusha/appeals-45976 (#21738) * Change address format * added rspec tests to cover hotfix * testing for inclusion of expected values (addressLine1, etc.) * rspec test -- wip * still WIP * Fix address tests. * updated fakes * Update internationalPostalCode * appeals controller spec update * http request changed and test --------- Co-authored-by: Noelle Adkin <98478937+NoelleAd@users.noreply.github.com> Co-authored-by: Anusha Palliyil <palliyil_anusha@bah.com> Co-authored-by: Lauren Berry <berry_lauren@bah.com> * lauren/APPEALS-39842 (#21739) * Add scroll metrics start time fix and update metric message * Add metrics attributes json in PdfPage constructor and add isPageVisible metric attribute * Fix scroll message spacing --------- Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> * noelle/appeals-39842 (#21740) * Remove UUID from attrs sent_to metrics. * Remove UUID from spec * remove uuid from update_appellant job --------- Co-authored-by: Noelle Adkin <98478937+NoelleAd@users.noreply.github.com> * fix failing tests --------- Co-authored-by: Noelle Adkin <98478937+NoelleAd@users.noreply.github.com> Co-authored-by: Anusha Palliyil <palliyil_anusha@bah.com> Co-authored-by: Lauren Berry <berry_lauren@bah.com> Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> * APPEALS-44916: Case Distribution Affinity Calculations (#21666) * APPEALS-44956: Add AppealAffinity model and database table (#21526) * add migration for appeal_affinities * add AppealAffinity model and associations, update migration for new column * update index to be unique * add factory, add tests * add factory traits to appeal and case for appeal affinities * add combination trait to appeal factory * add appeal_affinity to skipped associations in ETL reporting * add a validation, test * Craig/appeals 44958 (#21564) * add new job, update affinity model validation and after save hook * add update from push job * fix job extending distribution scopes * add with appeal affinities to distribution scopes * typo * add error handling, add test file * add distributed case factory, refactor naming in job * fix factories, added tests * fix migration for null affinity start date column * fixes, added tests * more test updates * add return in job if no query results, tests for no query results * add test for after_save hook adding dist task instructions * set start dist job to queue affinity job after running * fix update job and start dist job spec * queue affinity update job from push job * code clarity * fix judge in seed file * remove comment, fix hearing factory, disable some seeds for testing * add more tests * test refactor * update appeals for dist query to add affinity start, add seed file, fix hearing factory, add stat to dist factory * disable new seed on reset * update seed file with vet names, add another seed category * fix distirbuted case factory? * actually fix GHA runs * lint, test fixes * change constants in new job * APPEALS-44959: Modify affinity date checks to use appeal_affinity (#21611) * swap distribution queries from distribution_task to appeal_affinities * update seed files to use appeal affinities instead of distribution task * clean up seed file method names * add missing Timecop.return in ama affinity case seed * fix name of a method in a seed file * remove references to distribution task in distribution scopes * fix push priority job tests * fix naming of args in one of the seed files * fix user seed, fix date format in distribution task instructions * fix tests for date format update * Calvin/APPEALS-44957-rake-affinity (#21577) * grabbed receipt dates from distributed cases * refactored for functionality + added method to grab appeals that match * using receipt date, get all related appeals * added update/creation plus cleaned prior imple. * gets most recent distributed case receipt_date * skips if receipt_date is nil for performance * if appeal affinity is nil, it will now be updated * created spec file * fixed non ready appeals * updated query to match new AC * removing comment * testing for each docket * updated spec file * added new tests to rspec * updated start date to receipt date instead of Time.now * fixed date/time rspec errors * added rails logger to know when rake task has finished * added tag for rails log * removed nonpriority dockets for direct_review and evidence_submission * fixed lint issue * fixed flaky spec test * limits distributed cases query to within the last week * APPEALS-46016: Add Affinity Start Date to the Explain Page (#21660) * add affinity start date to explain page * add feature test to verify dates display * update rake task and spec (#21731) * APPEALS-46325: Add Seeds for AOD Appeals and Update Dates to Match CAVC (#21730) * add aod hearing cases to ama affinity cases seed * fix lever spec * APPEALS-45148: Hook to clear saved affinity date (#21623) * initial imp. idea * AC1: check for affinity_start_date on assignment * AC2/3: update affinity start date w/ instr. * updates to naming, instructions, and hook logic * updates after review * rspec coverage and addtional condition * removed unused identifier * removed reduntant 'self's * added update on actual AA record * updated to save aa record and addtional rspec * added change to assignment on no record test * check for assignment * addd update to 'on_hold' status * public method to handle legacy affinity appeals * added .reload to :with_affinity_appeal * added .reload to :ready_for_distribution * updates to pass explain_spec * switched boolean values * typo * readujsted order on :create for affinity appeal * removed after(:create) * testing rspec by readding after :create * reloading in assertation * addressing lint errors * fix seeds/users_spec * add case dist lever to new tests (#21776) * remove unnecessarily included module from job (#21827) * APPEALS-47211: Improve Performance of Distribution Queries (#21840) * rework ready_for_distribution scope * fix non-hearing docket distribution bug * restart tests --------- Co-authored-by: calvincostaBAH <108481161+calvincostaBAH@users.noreply.github.com> Co-authored-by: Isaiah Saucedo <irsaucedo5@gmail.com> * APPEALS-46540: Reduce time to deploy demo environments (#21791) * APPEALS-42710: Modify local/demo seed data so that not all seed files need to be run when resetting/deploying (#21743) * refactor users to use factories and create singletons * code quality, reduce counts * refactor substitutions * refactor veterans health administration seed * refactor MTV * move education orgs to users seed * move intake users to users seed, comment non-required seed files * add veterans seed file from Sean's branch * fix errors * add hearing prep role to judges * add optional seed file * add optional seed file and button to run it in demo * lint, specs * remove priority dist from optional, test fix * fix tests * Disable repeated conditional in Test::UsersController * feature/APPEALS-43597 RC (#21860) * APPEALS-36759 Add sms_response_content and sms_response_time notifications table * APPEALS-37003 First pass at job refactor * APPEALS-37003 Add comments and update kwargs for va notify service * APPEALS-37003 Update spec files * APPEALS-37003 Update spec * APPEALS-37003 Ensure user in job and create email_enabled method * APPEALS-37003 Remove question mark * Limit max retry attempts to 5 * Add ? to boolen return methods * jcohen/APPEALS-43706 (#21444) * APPEALS-43706 macros added to each model file for the polymorphic relationship to be setup. * APPEALS-43706 migration made and yet to be run. * APPEALS-43706 migrations ran and expected columns and indexes are in table. * Fix some spec failures unrelated to this branch * Limit schema diff * Add a missing tab * Fix more unrelated failures. Also prevent ACD lever seeds from overwriting spec output * Fix last unrelated failure. * APPEALS-43706 linting issues in va_notify_service fixed. --------- Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * [APPEALS-43598] Quarterly Notification Job refactoring (#21505) * Quarterly Notification Job refactoring * APPEALS-43598 Fix lint issues for QuarterlyNotificationsJob refactor * APPEALS-43598 Fix db schema.rb file * APPEALS-43598 Fix schema.rb file * APPEALS-43598 Refactoring QuarterlyNotificationsJob for readability * APPEALS-43598 Refactoring QuarterlyNotificationsJob and removing extra methods * [APPEALS-43598] Update method name --------- Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> * APPEALS-44007: Eliminate Transmission of Notifications to Deceased Veterans (#21481) * APPEALS-44007: Writing tests to ensure adding the 'failure due to deceased' information is properly set and added to the db * updates to pr * pushing changes for tonight * updating spec file to handle enabling and disabling feature flags * Update format_message_status * Lint roll * fixing conflicts * Updates to send notification spec * Fix one of the legacy test cases * Remove accidental push * Fix remaining test --------- Co-authored-by: Noah Hansen <nhansen@Noahs-MacBook-Pro.local> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> * MattT/APPEALS-45235: Remove Temporary PDF Files From tmp Directory After All eFolder Upload Attempts (#21557) * Cleanup files after uploading to VBMS * Only delete file if it exists * Resolve linter issue * Update specs * Trigger CodeClimate --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Add appeal alias for notifiable * APPEALS-45346: Populate Polymorphic Association Columns When Creating New Notifications (#21575) * APPEALS-45346: Populate Polymorphic Association Columns When Creating New Notifications * fixing some errors * updating factory * updating tests * updating tests and factory * rubocop --------- Co-authored-by: Noah Hansen <nhansen@Noahs-MacBook-Pro.local> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> * APPEALS-43596 Adding JobMessageDeletionMiddleware to delete SQS messages for certain jobs * APPEALS-43596 Adding tests * APPEALS-43596 Fix codeclimate * APPEALS-43714: Refactor VANotify Modules to Not Rely on Class Variables (#21596) * APPEALS-43714: Refactor VANotify Modules to Not Rely on Class Variables * pushing changes * updating tests * rubocop * rubocop'n * deleting repeat constants * removing file in favor of EVENT_TYPE_FILTERS.json * removing instances of using VA_NOTIFY_TEMPLATE_NAMES and using EVENT_TYPE_FILTERS instead * replacing all instances of strings with constants * fixing bug * rubocop'n * rubocop'n * rubocop --------- Co-authored-by: Noah Hansen <nhansen@Noahs-MacBook-Pro.local> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> * Clean notification_events after notification report specs finish (#21662) Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * MattT/APPEALS-43725: Extract `notify_appellant` Call from `QuaterlyNotificationsJob` to Decrease Runtime (#21643) * Group notification types as scopes * Add new job * Fix typo * Add back batching * Batch send messages * Multithread job queueing * Reconfigure bulk enqueueing to utilize send_notifications.fifo queue * Update the comment on QuaterlyNotificationsJob#perform to adhere to the RDoc standard * Use constants for template name * Provide a more descriptive var name * Remove unused env var * Fix linting issues * Prevent error from being thrown early in init job * Add RDoc comments to appeal_state * Add rdoc comment to init job * Add another rdoc comment to the init job * Use a more specific error class whenever an appeal cannot be located within the init job * Add a more specific error to CaseflowJob#enqueue_batch_of_jobs * Add test for SendNotificationJob.queue_name_suffix * Update QuarterlyNotificationsJob tests * Update appeal_state_spec.rb to cover new scopes * Add spec file for NotificationInitializationJob * Add CaseflowJob specs * Add CaseflowJob specs * Address rubocop issue (by ignoring it) * Kicking off CodeClimate * Fix some lint issues * Freeze constant --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move spec file to proper location * APPEALS-43599 (#21696) * APPEALS-43599 Refactoring SendNotificationJob * APPEALS-43599 Remove comments * APPEALS-43599 Suppress code smells from reek * APPEALS-43599 Suppress code smells from reek * jcohen/APPEALS-43727 (#21589) * APPEALS-43727 Branch created. Extracted all the 'when' conditions in the case statement within appellant_notification.rb update_appeal_state method. * APPEALS-43727 appellant_notification_service is created, logic from crowded method in appellant_notificaion.rb placed in newly created file, allowing redability. * APPEALS-43727 added logic to appeal_state.rb, appellant_notification.rb updated with less logic, readable code through well named methods. * APPEALS-43727 commit before merge from teammates work * APPEALS-43727 removed freeze method on default status hash in appeal_state.rb. removed some rubocop disabling in appellant_notificaion.rb * APPEALS-43727 extracted more logic from the appellant_notification module and placed it into the appeal_state class. Also got rid of rubocop declarations in app_notif and app_state as well. finally removed feature_toggle calls in appell_notif. * APPEALS-43727 tests passing, code works * APPEALS-43727 adding tests to appeal_state_spec to test functionality * APPEALS-43727 rspec tests in appeal_state. * APPEALS-43727 tests pass. * Fixing code climate duplicate code issue * fixing case statement * code climate things * rubocop * APPEALS-43727 work completed. * APPEALS-43727 PR comments applied. tests not in a working state. * APPEALS-43727 PR comments applied. appeal_state_spec in working state. * APPEALS-43727 PR comments applied. appellant_notification_spec.rb all green. * Adjust spacing of comments in appeal_state.rb * Utilize #external_id method over ternary * Swap or conditional for blank? * Fix another whitespace gap * APPEALS-43727 PR comments applied. again after reset. * APPEALS-43727 PR comments applied. flipped conditionals in appeal_state.rb * Update app/models/concerns/appeal_concern.rb * APPEALS-43727 code/test edits * APPEALS-43727 bulk_task_reasssignment_spec reverted to orginal state, with the exception of an expectation that was on line 98 * APPEALS-43727 lint fix --------- Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com> Co-authored-by: Noah Hansen <nhansen@Noahs-MacBook-Pro.local> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> * APPEALS-46179 (#21712) * APPEALS-46179 Create JobExecutionTimes table * APPEALS-46179 Add comment * APPEALS-46179 Update schema * APPEALS-46193 (#21753) * APPEALS-46193 Add record to JobExecutionTime table when job is performed * APPEALS-46193 Updating JobExecutionTimes table with an upsert query * APPEALS-46193 Ignore JobExecutionTimes for certain jobs * APPEALS-46193 Update ignore_job_execution_time? method * APPEALS-46193 Adding tests * Fix lint issues * Update AWS dependencies * Rollback gem reduction due to UAT issue * Alter queue priority * Forward error in SendNotificationJob * Allow for notification audit records to remain in ProdTest * Fix spec * Fix typo in test fixture's name * Fix lint infraction related to re-raising exceptions * Address duplication CC error * Reenable-privacy-mail-notifications (#21859) * Add conditional for FOIA and Privacy Act mail task to receives 'Privacy Act Pending' notifications * Update spec * Adjust some specs * Add missing param --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Remove byebug from spec * Revert queue adjustment * Remove unused method --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jonathan Cohen <121630615+JCohDev@users.noreply.github.com> Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com> Co-authored-by: prernadevbah <132498915+prernadevbah@users.noreply.github.com> Co-authored-by: noahhansen-gov <166541737+noahhansen-gov@users.noreply.github.com> Co-authored-by: Noah Hansen <nhansen@Noahs-MacBook-Pro.local> Co-authored-by: Prerna Devulapalli <prerna.devulapalli@va.gov> * feature/appeals-39842.1 (#21871) * Fix PdfFile test * Delete client/app/readerprototype/components/ReaderDocument.jsx (#21870) Delete empty ReaderDocument file * Fix lint issue in PdfFile (#21873) --------- Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> * Revert "APPEALS-44916: Case Distribution Affinity Calculations (#21666)" (#21888) * Revert "APPEALS-44916: Case Distribution Affinity Calculations (#21666)" This reverts commit 7aa04e6713759c3212820a78aa6500863dd7f91a. * fix users seed spec * Revert "feature/APPEALS-43597 RC (#21860)" (#21895) This reverts commit df60ddb567c3e02556e85ba37d555768d3a0de7e. * Revert "APPEALS-47106 Caseflow Swagger (#21847)" (#21901) This reverts commit c3bc5012618d614c3d017ae0f260a91c6d4aebec. * sbashamoni/APPEALS-43724 Node 16 version upgrade changes (#21966) (#21975) * Update node verstion to 16 in git workflow * Update node verstion to 16 in nvm and dockerfile for demo * Update node version in yarn.lock and package.json and .nvmrc file * Update node's version path to node16 in docker-bin/env.sh * Update and upgrade to node16 in client * More updates to yarn.lock and package.json * Fix tests by Adam Shaw * Upadate snapshot for ScheduleVeteran.test.js.snap * Doing some code clean up * Doiing some more clean up * Add and remove spaces to match master * One more space to take care of * One more space to take care of again * One more space to take care of again --------- Co-authored-by: ramon-chavez <Ramon.Chavez@va.gov> * APPEALS-47277 remove Vegas office (#21876) * APPEALS-47277 remove Vagas office * Removed Texas ID from other files and updated tests * Snapshot update --------- Co-authored-by: Ron Wabukenda <130374706+ronwabVa@users.noreply.github.com> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * hotfix/APPEALS-22403 (#21942) * add identifier for filenumber or ssn in filenumber search * linting * codeclimate linting * update match call to return boolean --------- Co-authored-by: Ron Wabukenda <130374706+ronwabVa@users.noreply.github.com> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * APPEALS-46907: Update to Determination of Gen Pop Legacy Cases (#21986) * Isaiah/merge 46910 (#21983) * removed BFHINES checks and modified tests * removed lingering bfhines test * modified test * most recent updates on tests for passing status * removed refs to cavc updates * Skip flaky test ro_viewhearsched_spec --------- Co-authored-by: Isaiah Saucedo <irsaucedo5@gmail.com> * APPEALS-44916: Case Distribution Affinity Calculations (#21899) * APPEALS-44956: Add AppealAffinity model and database table (#21526) * add migration for appeal_affinities * add AppealAffinity model and associations, update migration for new column * update index to be unique * add factory, add tests * add factory traits to appeal and case for appeal affinities * add combination trait to appeal factory * add appeal_affinity to skipped associations in ETL reporting * add a validation, test * Craig/appeals 44958 (#21564) * add new job, update affinity model validation and after save hook * add update from push job * fix job extending distribution scopes * add with appeal affinities to distribution scopes * typo * add error handling, add test file * add distributed case factory, refactor naming in job * fix factories, added tests * fix migration for null affinity start date column * fixes, added tests * more test updates * add return in job if no query results, tests for no query results * add test for after_save hook adding dist task instructions * set start dist job to queue affinity job after running * fix update job and start dist job spec * queue affinity update job from push job * code clarity * fix judge in seed file * remove comment, fix hearing factory, disable some seeds for testing * add more tests * test refactor * update appeals for dist query to add affinity start, add seed file, fix hearing factory, add stat to dist factory * disable new seed on reset * update seed file with vet names, add another seed category * fix distirbuted case factory? * actually fix GHA runs * lint, test fixes * change constants in new job * APPEALS-44959: Modify affinity date checks to use appeal_affinity (#21611) * swap distribution queries from distribution_task to appeal_affinities * update seed files to use appeal affinities instead of distribution task * clean up seed file method names * add missing Timecop.return in ama affinity case seed * fix name of a method in a seed file * remove references to distribution task in distribution scopes * fix push priority job tests * fix naming of args in one of the seed files * fix user seed, fix date format in distribution task instructions * fix tests for date format update * Calvin/APPEALS-44957-rake-affinity (#21577) * grabbed receipt dates from distributed cases * refactored for functionality + added method to grab appeals that match * using receipt date, get all related appeals * added update/creation plus cleaned prior imple. * gets most recent distributed case receipt_date * skips if receipt_date is nil for performance * if appeal affinity is nil, it will now be updated * created spec file * fixed non ready appeals * updated query to match new AC * removing comment * testing for each docket * updated spec file * added new tests to rspec * updated start date to receipt date instead of Time.now * fixed date/time rspec errors * added rails logger to know when rake task has finished * added tag for rails log * removed nonpriority dockets for direct_review and evidence_submission * fixed lint issue * fixed flaky spec test * limits distributed cases query to within the last week * APPEALS-46016: Add Affinity Start Date to the Explain Page (#21660) * add affinity start date to explain page * add feature test to verify dates display * update rake task and spec (#21731) * APPEALS-46325: Add Seeds for AOD Appeals and Update Dates to Match CAVC (#21730) * add aod hearing cases to ama affinity cases seed * fix lever spec * APPEALS-45148: Hook to clear saved affinity date (#21623) * initial imp. idea * AC1: check for affinity_start_date on assignment * AC2/3: update affinity start date w/ instr. * updates to naming, instructions, and hook logic * updates after review * rspec coverage and addtional condition * removed unused identifier * removed reduntant 'self's * added update on actual AA record * updated to save aa record and addtional rspec * added change to assignment on no record test * check for assignment * addd update to 'on_hold' status * public method to handle legacy affinity appeals * added .reload to :with_affinity_appeal * added .reload to :ready_for_distribution * updates to pass explain_spec * switched boolean values * typo * readujsted order on :create for affinity appeal * removed after(:create) * testing rspec by readding after :create * reloading in assertation * addressing lint errors * fix seeds/users_spec * add case dist lever to new tests (#21776) * remove unnecessarily included module from job (#21827) * APPEALS-47211: Improve Performance of Distribution Queries (#21840) * rework ready_for_distribution scope * fix non-hearing docket distribution bug * restart tests * added null checks for appeal affinity in distribution queries, update tests (#21893) * add check for appeal being active to distribution and associated slack message (#21902) * Update users_spec.rb --------- Co-authored-by: calvincostaBAH <108481161+calvincostaBAH@users.noreply.github.com> Co-authored-by: Isaiah Saucedo <irsaucedo5@gmail.com> * hotfix/APPEALS-45177: TaskTable Default Sorting Fix (#21772) * Updated the TaskTable component to use the defaultSort property instead of the defaultSortIdx property for queue table since that property is not used anywhere. Added a default sorting hash to the UnassignedCasesPage component and now pass that down to TaskTable. Removed references to defaultSortIdx. * Added the type column default sort to the AssignedCasesPage widget as well. * Added a parenthesis for clarity around a boolean. Moved the defaultSortingHash out into a constants file. --------- Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com> * APPEALS-47106 Caseflow Swagger (#21993) * Add Rswag and convert existing API documentation (#21778) * add rswag * Update Gemfile.lock * Setup yaml UI * remove and reroute old swagger files * update format and servers values * Update route_docs_controller.rb * Update cmp_controller.rb * cmp endpoint yaml * cmp endpoint to return 501 * CMP endpoint swagger flies * update swagger files * adjust server order, add auth token * cmp parameter name change * add comments * Update users_controller.rb * unit tests and linting * lint fixes * Update swagger_helper.rb * APPEALS-48048 Swagger Updates (#21909) * update servers to not include a host * remove host for server * remove generated swaggers from definitions * remove internal API endpoints from having generated swagger * IDT servers fixes * disable CMP swagger in prod and prodtest * set authorization correctly * fix what is required for CMP upload * fix linting issues, update lint rake task to autocorrect for rubocop, add rubocop make command * Update decision_reviews.yaml * Update ama_issues.yaml * Update vacols_issues.yaml * Update swagger.yaml * fix check failures * Update docs_controller_spec.rb * fix unit tests * Update fetch_all_active_legacy_appeals_job_spec.rb * Update rswag_ui.rb * Update lint.rake * Update decision_reviews_spec.rb * Update fetch_all_active_legacy_appeals_job_spec.rb * Update veterans_controller_spec.rb * feature/APPEALS-43597 RC1.5.1 (#21996) * APPEALS-36759 Add sms_response_content and sms_response_time notifications table * APPEALS-37003 First pass at job refactor * APPEALS-37003 Add comments and update kwargs for va notify service * APPEALS-37003 Update spec files * APPEALS-37003 Update spec * APPEALS-37003 Ensure user in job and create email_enabled method * APPEALS-37003 Remove question mark * Limit max retry attempts to 5 * Add ? to boolen return methods * jcohen/APPEALS-43706 (#21444) * APPEALS-43706 macros added to each model file for the polymorphic relationship to be setup. * APPEALS-43706 migration made and yet to be run. * APPEALS-43706 migrations ran and expected columns and indexes are in table. * Fix some spec failures unrelated to this branch * Limit schema diff * Add a missing tab * Fix more unrelated failures. Also prevent ACD lever seeds from overwriting spec output * Fix last unrelated failure. * APPEALS-43706 linting issues in va_notify_service fixed. --------- Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * [APPEALS-43598] Quarterly Notification Job refactoring (#21505) * Quarterly Notification Job refactoring * APPEALS-43598 Fix lint issues for QuarterlyNotificationsJob refactor * APPEALS-43598 Fix db schema.rb file * APPEALS-43598 Fix schema.rb file * APPEALS-43598 Refactoring QuarterlyNotificationsJob for readability * APPEALS-43598 Refactoring QuarterlyNotificationsJob and removing extra methods * [APPEALS-43598] Update method name --------- Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> * APPEALS-44007: Eliminate Transmission of Notifications to Deceased Veterans (#21481) * APPEALS-44007: Writing tests to ensure adding the 'failure due to deceased' information is properly set and added to the db * updates to pr * pushing changes for tonight * updating spec file to handle enabling and disabling feature flags * Update format_message_status * Lint roll * fixing conflicts * Updates to send notification spec * Fix one of the legacy test cases * Remove accidental push * Fix remaining test --------- Co-authored-by: Noah Hansen <nhansen@Noahs-MacBook-Pro.local> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> * MattT/APPEALS-45235: Remove Temporary PDF Files From tmp Directory After All eFolder Upload Attempts (#21557) * Cleanup files after uploading to VBMS * Only delete file if it exists *…
ThorntonMatthew
added a commit
that referenced
this pull request
Sep 20, 2024
* Add shared context file * Trigger CI * Trigger CI * Fix test * APPEALS-25117: delete conferences job spec passing * APPEALS-25117: pexip service spec passing * APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) # Description Please explain the changes you made here. ## Acceptance Criteria - [ ] Code compiles correctly ## Testing Plan <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? # Frontend ## User Facing Changes - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- ## Storybook Story *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component # Backend ## Database Changes *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) ## Integrations: Adding endpoints for external APIs * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT # Best practices ## Code Documentation Updates - [ ] Add or update code comments at the top of the class, module, and/or component. ## Tests ### Test Coverage Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other ### Code Climate Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added ## Monitoring, Logging, Auditing, Error, and Exception Handling Checklist ### Monitoring - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? ### Logging - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? ### Auditing - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? ### Error Handling - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? ### Exception Handling - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
ThorntonMatthew
added a commit
that referenced
this pull request
Sep 20, 2024
* Fix test * APPEALS-25117: delete conferences job spec passing * APPEALS-25117: pexip service spec passing * APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) # Description Please explain the changes you made here. ## Acceptance Criteria - [ ] Code compiles correctly ## Testing Plan <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? # Frontend ## User Facing Changes - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- ## Storybook Story *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component # Backend ## Database Changes *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) ## Integrations: Adding endpoints for external APIs * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT # Best practices ## Code Documentation Updates - [ ] Add or update code comments at the top of the class, module, and/or component. ## Tests ### Test Coverage Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other ### Code Climate Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added ## Monitoring, Logging, Auditing, Error, and Exception Handling Checklist ### Monitoring - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? ### Logging - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? ### Auditing - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? ### Error Handling - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? ### Exception Handling - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
msteele96
added a commit
that referenced
this pull request
Sep 26, 2024
* APPEALS-25117: delete conferences job spec passing * APPEALS-25117: pexip service spec passing * APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) # Description Please explain the changes you made here. ## Acceptance Criteria - [ ] Code compiles correctly ## Testing Plan <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? # Frontend ## User Facing Changes - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- ## Storybook Story *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component # Backend ## Database Changes *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) ## Integrations: Adding endpoints for external APIs * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT # Best practices ## Code Documentation Updates - [ ] Add or update code comments at the top of the class, module, and/or component. ## Tests ### Test Coverage Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other ### Code Climate Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added ## Monitoring, Logging, Auditing, Error, and Exception Handling Checklist ### Monitoring - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? ### Logging - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? ### Auditing - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? ### Error Handling - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? ### Exception Handling - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests --------- Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
msteele96
added a commit
that referenced
this pull request
Oct 9, 2024
commit 82aec7f7dc43334d16075523738568a3a52096fb
Merge: 3014d65ff9 8acb7f81a3
Author: msteele <Marc.Steele@va.gov>
Date: Wed Oct 9 08:48:27 2024 -0400
Merge branch 'main' into feature/APPEALS-25121
commit 3014d65ff9d4dfecfb10f08b15fbadd92d71944b
Author: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Date: Tue Oct 8 15:43:04 2024 -0400
Hotfix/APPEALS-59907 (#23100)
* APPEALS-59907 fix for rtf being reconverted and uploaded
* APPEALS-59907 fixed check for converting rtf
* APPEALS-59907 adjusting location of checks
* APPEALS-59907 added a guard for downloading files
* APPEALS-59907 added rspec tests
* APPEALS-59907 method name changes
* APPEALS-59907 method name changes
* APPEALS-59907 method name changes
* APPEALS-59907 Remove redundant if statement
---------
Co-authored-by: msteele <Marc.Steele@va.gov>
commit efca1eb0cb98b07a532c73676b6159815362509a
Merge: 23a99f324f 46ab40b610
Author: msteele <Marc.Steele@va.gov>
Date: Thu Sep 26 21:32:24 2024 -0400
Merge branch 'release/FY24Q4.6.0' into feature/APPEALS-25121
commit 23a99f324f0553a79fd54dc094fef3bc60f1ec1a
Merge: b87d60d27a 07e2c5047d
Author: msteele <Marc.Steele@va.gov>
Date: Wed Sep 25 19:48:54 2024 -0400
Merge branch 'main' into feature/APPEALS-25121
commit b87d60d27a56822549d618052393ad19694c115f
Author: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Date: Wed Sep 25 19:44:33 2024 -0400
akonhilas/APPEALS-59152 (#22973)
* APPEALS-59152: removed unnecessary logic, color.primary
* APPEALS-59152: update snapshot tests
commit 4fc00d3114aa31e8ec3a33f047fc868c731e0c97
Author: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Date: Fri Sep 20 10:32:28 2024 -0400
Remove bad metrics line
commit 0a4894c6f4241c06097fe85558b13a1553d6beef
Merge: e6054b6054 ba1fd59cfd
Author: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Date: Fri Sep 20 09:54:23 2024 -0400
Merge remote-tracking branch 'origin/master' into feature/APPEALS-25121
commit e6054b6054e9acbfa3a2ea2f2956d5cea86351e4
Author: msteele <Marc.Steele@va.gov>
Date: Thu Sep 19 13:28:34 2024 -0400
Remove x86_64 platforms, add ruby platform
commit 3ee0a933665d833848941fb56f9024b0f5311226
Merge: 9f46a84877 e34da001d7
Author: msteele <Marc.Steele@va.gov>
Date: Mon Sep 16 12:45:01 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit 9f46a8487792e6173137b680728afdb5f00c9170
Merge: d739cf9ae8 f62b14fa0f
Author: Marc Steele <71673522+msteele96@users.noreply.github.com>
Date: Thu Sep 12 08:21:18 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit d739cf9ae86d9b3ee3f51a11297fb5827bf0a85d
Author: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Date: Tue Sep 10 15:24:55 2024 -0400
Fix bad merge conflict resolution
commit 22578c33cfedf534c82e9c1285b5ccf0a1a39388
Author: msteele <Marc.Steele@va.gov>
Date: Tue Sep 10 11:09:34 2024 -0400
Remove duplicate method
commit f8c25db91ea9ca20c6c6aa17ccc23c02044a4a78
Merge: 53953de939 5ae099e0ff
Author: Marc Steele <71673522+msteele96@users.noreply.github.com>
Date: Tue Sep 10 10:25:29 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit 53953de93929380ab2ef5706b34f2563e5b5de6b
Merge: fd491f9f6a 8eb1ccee5e
Author: msteele <Marc.Steele@va.gov>
Date: Mon Sep 9 13:12:04 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit fd491f9f6af7b27e806b88fe2e715f39934095fc
Merge: 41ab669167 6dd9870c8f
Author: Marc Steele <71673522+msteele96@users.noreply.github.com>
Date: Fri Aug 23 11:56:06 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit 41ab66916772efde4e3cd37f9f21262925df935c
Merge: e3d7531197 e5563b2d8f
Author: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Date: Mon Aug 12 18:21:18 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit e3d75311971e5023cf3905fe4111d6cb7ff0c842
Merge: e9d2469494 3367fbe79e
Author: Marc Steele <71673522+msteele96@users.noreply.github.com>
Date: Wed Jul 31 12:43:50 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit e9d2469494c7c886376aab3d1d765cee6c205b5f
Author: msteele <Marc.Steele@va.gov>
Date: Wed Jul 31 11:12:14 2024 -0400
Update bundler version
commit 52348aa5c78025e1cce0832ae251ea2b6440299e
Merge: dec62ecd45 4d1bfd38d3
Author: Marc Steele <71673522+msteele96@users.noreply.github.com>
Date: Tue Jul 30 09:39:22 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit dec62ecd4527b7fc6b04d35c559fdc84ca2968f9
Merge: 8068d22043 95fec6f6af
Author: msteele <Marc.Steele@va.gov>
Date: Mon Jul 15 15:51:24 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit 8068d220433939972ecf46fe1db1957524fc0df7
Merge: 64b26be7c4 5fbafad5e5
Author: msteele <Marc.Steele@va.gov>
Date: Mon Jul 15 08:51:25 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit 64b26be7c4f3cce192d278a571b75ec7b250522c
Author: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Date: Tue Jul 9 13:56:12 2024 -0400
Min/APPEALS-50859 (#22081)
* remediated code climate issues
* remediated code climate issues
* remediated code climate issues
* fixed duplicate code issues
* fixed duplicate code issues
* fixed duplicate code issues
* APPEALS-50859 added new concern to abstract duplicate code
* APPEALS-50859 fixed new concern climate issues
* APPEALS-50859 added new config method for rooms endpoints to concern
* APPEALS-50859 added new config method for rooms endpoints to concern
* APPEALS-50859 added new config method for instant connect to concern
* APPEALS-50859 added new config method for instant connect to concern
commit 952afc9d9ae46b415aae7a8f51d8d9b256e24f91
Author: msteele <Marc.Steele@va.gov>
Date: Tue Jul 2 17:19:05 2024 -0400
Reintroduce code after bad merge conflict resolution
commit 2a0f144da48c2e1ecf5a01a966e51648f750cb00
Author: msteele <Marc.Steele@va.gov>
Date: Tue Jul 2 15:40:56 2024 -0400
Recover lost code to compress multiple lines by same speaker into one large block
commit 6dd5511012be0b2da942a3296d78d30408463f0b
Author: msteele <Marc.Steele@va.gov>
Date: Mon Jul 1 15:44:54 2024 -0400
Remove extra newline after merge conflict
commit 641cb23d5d67e2e21175ba8bd4868e8a7b7bf8f0
Author: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Date: Mon Jul 1 15:43:37 2024 -0400
Hotfix/Appeals-49560-v2 (#22052)
* APPEALS-49560 moved non-virtual conference link creation to hearing concern
* APPEALS-49560 moved non_virtual conference creation inside of reschedule method
* APPEALS-49560 added a new spec test to test link creation
* APPEALS-49560 refactored rspec
* APPEALS-49560 removed additional method in after_create to prevent risk of duplication
* APPEALS-49560 removed additional method in after_create to prevent risk of duplication
* APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask
* Update app/models/concerns/hearing_concern.rb
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
---------
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
commit df3e75d6ccc013c82ce2dcecc9c7c622d5d4cf06
Author: msteele <Marc.Steele@va.gov>
Date: Mon Jul 1 14:24:37 2024 -0400
Remove extra newline for Rubocop
commit 147b6115afb458ba2565bdb01b63a010016a7811
Merge: dfd4ec7f00 02eb20387b
Author: msteele <Marc.Steele@va.gov>
Date: Mon Jul 1 14:05:53 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit dfd4ec7f00107c78a1bbe5de6dda8ff21ae180b5
Author: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Date: Wed Jun 26 20:09:30 2024 -0400
Hotfix/APPEALS-49624 (#22016)
* APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks
* APPEALS-49624: add rooms and room details to mailer preview, correct api url
* APPEALS-49624: cleaning up rspecs
* APPEALS-49624: update query format, add mailer tests
* APPEALS-49624: update mailer keys
* APPEALS-49624: fix lint errors
* APPEALS-49624 Remove rubocop ignores and fix query format
---------
Co-authored-by: msteele <Marc.Steele@va.gov>
commit 9b418f17d6b72e3ba50ae984b7c8a0f369016f23
Author: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Date: Wed Jun 26 16:56:09 2024 -0400
Hotfix/APPEALS-49560 (#22015)
* APPEALS-49560 moved non-virtual conference link creation to hearing concern
* APPEALS-49560 moved non_virtual conference creation inside of reschedule method
* APPEALS-49560 added a new spec test to test link creation
* APPEALS-49560 refactored rspec
* APPEALS-49560 removed additional method in after_create to prevent risk of duplication
* APPEALS-49560 removed additional method in after_create to prevent risk of duplication
commit e4c0bb6fc7e72fa20725984fdc6b8a4312c0a951
Merge: b8f034fd22 b75d2f09ae
Author: Marc Steele <71673522+msteele96@users.noreply.github.com>
Date: Mon Jun 24 09:09:24 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit b8f034fd224b56a69f05e41917a9a0b593069b51
Author: msteele <Marc.Steele@va.gov>
Date: Fri Jun 21 12:15:43 2024 -0400
Adjust spacing in gemfile
commit b53c8f1db97fa1d9f2f17e1360bdfedf493ab10f
Author: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Date: Mon Jun 17 14:21:59 2024 -0400
APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941)
commit 6247d95e1462d418005b85c65f1ad7adb0829867
Author: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Date: Fri Jun 14 14:05:55 2024 -0400
Hotfix/APPEALS-48161 (#21917)
* APPEALS-48161: remove, refactor, fake update, specs, filename update
* APPEALS-48161: kickoff gha on right branch merge
* APPEALS-48161: filter title call only once
commit 496d74d45acdee4f598d4ff2565effb8831321a3
Author: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Date: Mon Jun 10 16:48:59 2024 -0400
akonhilas/APPEALS-46130 (#21804)
* APPEALS-43160: Fix linting errors in OrgUsers
* APPEALS-43160: fix margins and move divider
* APPEALS-43160: remove margin top on search bar styling
* APPEALS-43160: fix webex lint errors
* APPEALS-43160: move radio button style div inside visibility check
* APPEALS-46130: move css inline style to scss
* APPEALS-46130: fix lint errors, remove gray line
commit c879e7766107ed9c4a07d1c1dba0ebd81551e9ea
Author: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Date: Fri Jun 7 14:12:30 2024 -0400
Hotfix/APPEALS-46083 (#21832)
* Min/APPEALS-46009 (#21690)
* APPEALS-46005: job, job logic, env placeholder, schedule update
* APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service
* APPEALS-46011 Update fakes
* APPEALS-46005: merge 46011 logic updates
* APPEALS-46009 added the new webex room details job
* APPEALS-46011 Update specs
* commenting out code
* commenting code back in
* APPEALS-46009 adjusted rspec tests
* APPEALS-46009 adjusted rspec tests
* APPEALS-46005: add rspec, comment out rooms details call, final filter
* APPEALS-46009 adjusted rspec tests
* APPEALS-46005: rough filter test added to rooms list spec commented out
* APPEALS-46009 adjusted rspec tests
* APPEALS-46009: filter rspec, filter in rooms list job, add fake data
* APPEALS-46009: resolved comments
---------
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
* APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed
* APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings
---------
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
commit 54e9bf4fcdced880764d9ea4501b0768d41bfd2f
Author: Marc Steele <71673522+msteele96@users.noreply.github.com>
Date: Tue Jun 4 14:41:47 2024 -0400
feature/APPEALS-45998 Webex Rooms API Workaround (#21810)
* Min/APPEALS-46009 (#21690)
* APPEALS-46005: job, job logic, env placeholder, schedule update
* APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service
* APPEALS-46011 Update fakes
* APPEALS-46005: merge 46011 logic updates
* APPEALS-46009 added the new webex room details job
* APPEALS-46011 Update specs
* commenting out code
* commenting code back in
* APPEALS-46009 adjusted rspec tests
* APPEALS-46009 adjusted rspec tests
* APPEALS-46005: add rspec, comment out rooms details call, final filter
* APPEALS-46009 adjusted rspec tests
* APPEALS-46005: rough filter test added to rooms list spec commented out
* APPEALS-46009 adjusted rspec tests
* APPEALS-46009: filter rspec, filter in rooms list job, add fake data
* APPEALS-46009: resolved comments
---------
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
* akonhilas/APPEALS-46006 (#21734)
* APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job
* APPEALS-46006: webex service spec update, fake update, recordings list response update
* APPEALS-46006: recordings details job and spec updates, lint fix recordings list job
* APPEALS-46006: recordings list spec and job updates
* APPEALS-46006: room meeting details spec updates
* APPEALS-46006: final updates to fake data
* APPEALS-46006: changing topic to actual webex response
* APPEALS-46006 create and use self.acceses_token method in WebexService classes
* APPEALS-46006 Update failing rspec for Details and List Jobs
* APPEALS-46006: update mailer, preview, specs, lint error
---------
Co-authored-by: msteele <Marc.Steele@va.gov>
---------
Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
commit b54514c896a23aadba5681e563f5e14008296718
Merge: e6f4bf8e80 2e6dd412c3
Author: msteele <Marc.Steele@va.gov>
Date: Fri May 31 12:45:35 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit e6f4bf8e80625383d4252fb3d901e5e9ae77364b
Author: Marc Steele <71673522+msteele96@users.noreply.github.com>
Date: Thu May 30 12:19:41 2024 -0400
APPEALS-45285 added conditional to handled nil conference ids (#21766)
Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
commit 8e20751792f766ec36f44ce4ce838522b3dc3459
Author: msteele <Marc.Steele@va.gov>
Date: Fri May 17 16:03:48 2024 -0400
Remove unused styles after merge
commit 359a9f7f3f11d022adf82cbe0b82ae0c88234624
Merge: 8711b430de ee2d6d293a
Author: msteele <Marc.Steele@va.gov>
Date: Fri May 17 16:01:59 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit 8711b430de2361864638bc691eb93b9eb76e77c9
Author: Jeff Marks <106996298+jefftmarks@users.noreply.github.com>
Date: Fri May 17 10:49:09 2024 -0600
hotfix/APPEALS-45828 (#21625)
* APPEALS-45828 Include call to create webex conference links in base hearing update form
* APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual
* Fix needing to reload to display co host link on details page
* Fix incorrect method name
* Remove temporary rendering of default pexip link for webex hearings after conversion
* APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT
* APPEALS-45828 Remove file name argument from fetch details job spec
* APPEALS-45828 Fail on bad hearing link if link nil or legacy link
* APPEALS-45828 Sanitize url string
* APPEALS-45828 Undo url sanitize
commit 8168a8e123e9313e8391d0ff581a9a11a9f7c20a
Author: Marc Steele <71673522+msteele96@users.noreply.github.com>
Date: Thu May 16 15:25:47 2024 -0400
msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634)
* APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument
* APPEALS-45285 Update spec to use virtual_hearing
* APPEALS-45285 Linting fixes
commit 4d0ea50836c0362d0067c2f8eec821bb668ec1c4
Author: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Date: Thu May 16 14:17:28 2024 -0400
Hotfix/APPEALS-45818 (#21632)
* APPEALS-45818: parsing fix, remove topic param, fix response
* APPEALS-45818: revert list and details job back to original state, update tests
---------
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
commit 269bfafaa4b02f1e9a0996f39e1af84705d79473
Author: Jeff Marks <106996298+jefftmarks@users.noreply.github.com>
Date: Thu May 16 08:15:01 2024 -0600
hotfix/APPEALS-45472 (#21562)
* APPEALS-45472 Refactor error handling for transcription
* APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer
commit 05ec53cdadf1eceace53ccc6682b2087b46d6b02
Author: Jeff Marks <106996298+jefftmarks@users.noreply.github.com>
Date: Mon May 6 11:45:25 2024 -0600
hotfix/APPEALS-45399-45401-45472 (#21555)
* APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash
* APPEALS-45399-45401 Remove CGI escape from fetch webex list job
* APPEALS-445399-45401 Update spec files for webex list and details job
* APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery
* Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery"
This reverts commit d9ce585c59444f9793e681e58060d71872057e4c.
commit 8367adaea7563d14047645dd5d65b53593b7b42a
Merge: ce8e077e41 e2777cf417
Author: Marc Steele <71673522+msteele96@users.noreply.github.com>
Date: Mon May 6 11:33:48 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit ce8e077e4174062b83869de43272898f27038950
Author: Marc Steele <71673522+msteele96@users.noreply.github.com>
Date: Fri May 3 08:02:51 2024 -0400
msteele/APPEALS-45349 (#21539)
* APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error
* APPEALS-45349 Flip conditionals
* APPEALS-45349 Fix linting errors
commit 99bab7aefdb62a487b52ea76a184362d3ee9264e
Author: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Date: Thu May 2 13:38:26 2024 -0400
Hotfix/APPEALS-45218-v2 (#21522)
* APPEALS-45218 reverted webex config arguments
* APPEALS-45218 reverted webex config arguments
* APPEALS-45218 added query argument to webex conference link
* APPEALS-45218: webex recordings endpoint correction
* APPEALS-45218 adjusted arguments during inititalizing of refresh tokens
* APPEALS-45218 fixed rspec
* APPEALS-45218: added error catching on webex service response
* APPEALS-45218: remove tested code
* APPEALS-45218 Go back to leveraging HTTPI response inherited methods
---------
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: msteele <Marc.Steele@va.gov>
commit b5adae6a3e67d3a2ce7f2853922f4ce3d17f19b3
Author: breedbah <123968373+breedbah@users.noreply.github.com>
Date: Thu May 2 12:32:05 2024 -0400
B_reed/hotfix_APPEALS-45285 (#21531)
* APPEALS-45285 Bug Fix
* APPEALS-45285 update pexip_service_spec
* APPEALS-45285 remove white space
commit 92fb787c453f39c8451300d9df486507b266ff41
Author: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Date: Tue Apr 30 14:14:18 2024 -0400
Hotfix/APPEALS-45218 (#21503)
* APPEALS-45218 reverted webex config arguments
* APPEALS-45218 reverted webex config arguments
* APPEALS-25218 Update WebexService to remove config in favor of individual arguments
* APPEALS-45218 Format comment
---------
Co-authored-by: msteele <Marc.Steele@va.gov>
commit 66e261b7b103b6ae006583994b08ee624c59ca4e
Author: Marc Steele <71673522+msteele96@users.noreply.github.com>
Date: Mon Apr 29 13:27:54 2024 -0400
msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492)
* APPEALS-45182 Reinforce has_many relationships
* APPEALS-45182 Add missing comma
* Resolve lint issue
---------
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
commit d9d1cbaf85b3505e8ee6bc3a6191b4eea323c428
Author: msteele <Marc.Steele@va.gov>
Date: Mon Apr 29 10:02:11 2024 -0400
Update job to set user manually and pass in updated_by
commit 79be3df2a32b85f7a2abcdc5ec3f8a0cc327ffda
Author: msteele <Marc.Steele@va.gov>
Date: Wed Apr 24 13:19:13 2024 -0400
Update scheduled jobs key and move job to different folder
commit ec5ab73b3a566a2b20c716d2c280f30ac01fda8a
Author: msteele <Marc.Steele@va.gov>
Date: Mon Apr 22 16:57:48 2024 -0400
Update gemfile.lock
commit 8c16ed7fd67cfc255cf4da3270f07f3cd165fb8e
Author: msteele <Marc.Steele@va.gov>
Date: Mon Apr 22 16:55:10 2024 -0400
Update ref for caseflow-commons
commit afc9b0992ce71c9e4e067b55d958c73f27e01f18
Author: msteele <Marc.Steele@va.gov>
Date: Mon Apr 22 15:12:17 2024 -0400
Match yarn.lock to master
commit 4331dba4145979fc60240cc5a3a7675df7141bf1
Merge: a16f611a93 25f654361c
Author: msteele <Marc.Steele@va.gov>
Date: Mon Apr 22 15:05:42 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit a16f611a9352f53eec7af98233a575a39828123f
Author: msteele <Marc.Steele@va.gov>
Date: Mon Apr 22 11:57:19 2024 -0400
Move methods from hearing.rb to hearing concern and add default aws region to resolve error
commit 1e196487504e5a31342aa4f3b900b53540c0fd22
Author: breedbah <123968373+breedbah@users.noreply.github.com>
Date: Fri Apr 19 15:38:12 2024 -0400
b_reed/APPEALS-34071-v2 (#21422)
* Add rcredstash and dynamodb
* Update ports
* Fix m1 docker compose
* Add kms
* Add initializers
* Upgrade aws-sdk
* Lint roll
* Update table name
* Add back VirtualHearings::RefreshWebexAccessTokenJob
* Add refresh_access_token method to ExternalApi::WebexService
* Add back AccessTokenRefreshResponse
* Add back in error handling in Webex Response class
* Add new job to SCHEDULED_JOBS
* Add WebexInvalidTokenError error class
* Add refresh_access_token to fake WebexService
* Add back in specs
* APPEALS-34071 bundle install additions gemfile.lock
* APPEALS-34071 slim out test
* Fix the 'levers exists' message overwritting test output
---------
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
commit 9cdba4be6eaf3d0e695aa367ecd098d56023f378
Author: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Date: Wed Apr 17 10:57:28 2024 -0400
Min/APPEALS-43214 (#21344)
* APPEALS-43214 added new error handling for file upload and new param to custom exception
* APPEALS-43214 wrote rspec tests and made some adjustment to error handlers
* rerun checks
* rerun checks
* APPEALS-43214 adjusted failing rspec
* APPEALS-43214 Linting fix
* APPEALS-43214 Indentation fixes
* APPEALS-43214 Update mailer to handle different transcription file jobs
* APPEALS-43214 Added beginning of hour to webex list calls
* APPEALS-43214 Update mailer to show download link and fix failing test
* APPEALS-43214 Refactor transcription file issues mailer
* APPEALS-43214 Remove old spec file
* APPEALS-43214 Refactor content section of mailer
* APPEALS-43214 Add missing comma
* APPEALS-43212 Refactor mailer to render nested lists
* APPEALS-43214 Update prodtest email and demo vs dev distinction
* APPEALS-43214 Linting and fixes to create conference job
* APPEALS-43214 Call job#extra
* APPEALS-43214 job#log_error
* APPEALS-43214 Remove extra method
* APPEALS-43214 Fix log error issue
* APPEALS-43214 Fix typo
* APPEALS-43214 Incorporate action direction into job action hash
* APPEALS-43214 Remove byebug
---------
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
Co-authored-by: msteele <Marc.Steele@va.gov>
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
commit a2ffa6bea4a959aa3a638452c74c11dad14fde5a
Author: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Date: Thu Apr 11 12:34:22 2024 -0400
akonhilas/APPEALS-40906 (#21165)
* APPEALS-40906: remove sub nbf exp from hearing_day
* APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual
* APPEALS-40906: Update so many jest tests and test data
* APPEALS-40906: merge latest from feature
* APPEALS-40906: Update snapshots after merge
* APPEALS-40906: updates to feature test
* APPEALS-40906 change serializer debug attempt
* APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx
* APPEALS-40906 Return references of conference_links to conference_link
* APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer
* APPEALS-40906 Update failing spec and serializer
* APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx
* APPEALS-40906 Ensure correct classname and button text for hearing coordinator link
* Fix hearing_day_spec to user singular conference link
* Update hearing details snap shots
* APPEALS-40906 Update Details.test.js snapshot
* APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx
* APPEALS-40906 Remove hearing links from central and video details page
* Uncomment hearing details feature spec
* APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past
* APPEALS-40906 Add bang operator
* APPEALS-40906 Update Hearing Links jest to not use redux store
* APPEALS-40906 Remove console.log
* APPEALS-40906 Remove console.log
* APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video
* APPEALS-40906 Update snapshots
* APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links
* APPEALS-40908 Update HearingLinks UI to show copy link button at all times
* APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types
* APPEALS-40906 Fix jest test props for HearingLinks test
* APPEALS-40906 Uncomment out jest config
* APPEALS-40906: remove unused code from hearing links test
* APPEALS-40906: move non virtual conference link to hearing concern
---------
Co-authored-by: msteele <Marc.Steele@va.gov>
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
commit 52f7a89d13144e8bc196cf8ff65ea43050f8c8ae
Merge: 8ce1262c89 d97385fbc4
Author: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Date: Tue Apr 9 10:11:48 2024 -0400
Merge remote-tracking branch 'origin/master' into feature/APPEALS-25121
commit 8ce1262c89f08b3577a2bff6aab1bb547d11f088
Author: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Date: Tue Apr 2 13:03:10 2024 -0400
Min/APPPEALS-42711 (#21285)
* APPEALS-42711 adjusted query for webex recordings list
* APPEALS-42711 added rspec tests for webex_conference_link
* APPEALS-42711 some code climate refactors
* APPEALS-42711 fixed code climate issues and webex service argument refactor
* APPEALS-42711 fixed som broken rspec tests
* APPEALS-42711 fixed a few code climate issues with mailer
* APPEALS-42711 refactored more code climate issues with mailer and webex implementation
* APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues
* APPEALS-42711 fixed some broken rspec tests and more code climate issues
* APPEALS-42711 changed names of classes and methods to fix code climate issue
* APPEALS-42711 changed names of classes and methods to fix code climate issue
* APPEALS-42711 changed names of classes and methods to fix code climate issue
* APPEALS-42711 added max value back in to webex recordings
* APPEALS-42711 added max value back in to webex recordings
* min/APPEALS-42711 adjusted query
* APPEALS-42711 refactored some code
commit 8dc7e13a353b55cd2ff42c34937ef2e2c9c29a75
Author: Jeff Marks <106996298+jefftmarks@users.noreply.github.com>
Date: Fri Mar 29 11:35:24 2024 -0400
jefftmarks/APPEALS-40907 (#21249)
* APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models
* APPEALS-40907 Remove unnecessary polymorphic concerns
* APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links
* APPEALS-40907 Update models
* APPEALS-40907 Update models
* APPEALS-40907 Update and remove jest tests
commit b5d78aa5fb26e8077926c96d04bacd419f348f69
Author: msteele <Marc.Steele@va.gov>
Date: Mon Mar 25 13:44:20 2024 -0400
BelongsToPolymorphicHearingConcern updates from Rails 6.0
commit 38d24e8550fd2b06d87761aa0d5bb86b6a1895cb
Merge: 924868053f 8b01651bcf
Author: msteele <Marc.Steele@va.gov>
Date: Mon Mar 25 09:53:57 2024 -0400
Merge branch 'master' into feature/APPEALS-25121
commit 924868053fdb396f91283396f176ef94f801e811
Author: Jeff Marks <106996298+jefftmarks@users.noreply.github.com>
Date: Mon Mar 25 09:51:09 2024 -0400
jefftmarks/APPEALS-37292-37293 (#21140)
* APPEALS-37292 Create transcription files table
* APPEALS-37292 Adjust table styling
* APPEALS-37292 Update legacy conditional to show transcription details
* APPEALS-37292 Conditionally render different sections of transcription details
* APPEALS-37292 Implement useState and useEffect to reduce renders on table
* APPEALS-37293 Populate table with updated transcription file serializer
* APPEALS-37292-37293
* APPEALS-37293 Comment code
* APPEALS-37293 Update snapshot
* APPEALS-37292-37293 Update snapshot
* APPEALS-37293 Revert transcription files controller
* APPEALS-37293 Update Details jest test
* APPEALS-37293 Add date attribute to hearings data for jest test
* APPEALS-37293 Update imports on Details.jsx jest test
* APPEALS-37293 Update hearing concern with transcription file by recording method
* APPEALS-37292 Update LegacyHearing model and serializer
* APPEALS-37293 Update feature test for details page
* APPEALS-37293 Fix typo in table id
* APPEALS-37293 Add aws link to factory
* APPEALS-37293 Fix hearing links snapshot to pass jest test
* APPEALS-37293 Fix hearing factory
* APPEALS-37293-37293
* APPEALS-37293 Fix transcription files controller spec
* APPEALS-37293 Update to group files on table by docket number
* APPEALS-37293 Refactor route/controller without responds_to and move css
* APPEALS-37293 Fix feature test to reflect route update
* APPEALS-37293 Fix linting on css
* APPEALS-37293 scss lint
commit 620aefccacdf0d1eb7ebb1015266e683eccbb8f5
Author: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Date: Wed Mar 20 15:50:21 2024 -0400
Min/APPEALS-37605 (#21151)
* APPEALS-37605 added route and test json response
* APPEALS-37605 file now gets downloaded onto local computer
* APPEALS-37605 added user verification
* min/APPEALS-37605 added rspec and factory for transcription_file
* APPEALS-37605 finished writing rspec tests
* APPEALS-37605 finished writing rspec tests
* APPEALS-37605 added more error handling
* APPEALS-37605 Move controller back to hearings folder
* APPEALS-37605 Remove unused methods from controller
* APPEALS-37605 Move transcription_file_spec to hearings folder
---------
Co-authored-by: msteele <Marc.Steele@va.gov>
commit 693a0ae89e3a3e37831bb8b7eae030724cf69e44
Author: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Date: Thu Mar 14 09:52:40 2024 -0400
akonhilas/APPEALS-40921 (#21116)
* APPEALS-40921: added method to concern and reference to both hearing serializers
* APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors
* APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors
commit f46c6cd4f1f93581623e323bc27b2bc9d4637aa4
Author: msteele <Marc.Steele@va.gov>
Date: Fri Mar 8 15:02:30 2024 -0500
Missed rubocop merge conflict
commit 5618b52e8e13dc649b1df7344aac27faea582bd2
Merge: 7f49157e84 277d05e79f
Author: msteele <Marc.Steele@va.gov>
Date: Fri Mar 8 15:02:07 2024 -0500
Merge branch 'master' into feature/APPEALS-25121
commit 7f49157e84dd6eecff979c3e84d96aacf1549d65
Author: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Date: Fri Mar 8 11:27:15 2024 -0500
akonhilas/APPEALS-40915 (#20948)
* APPEALS-40915: initial commit
* APPEALS-40909 Create migration and write spec tests
* APPEALS-40909 Update conference_link model to associate with polymorphic hearing
* APPEALS-40909 Write spec for add index to conference links
* APPEALS-40909 Add spec to test conference link factory after null constraint removed
* APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA
* APPEALS-40915: updated comments to job
* APPEALS-40909 Implement database cleaner fix and write down test for index migration
* APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation
* APPEALS-40915: updated existing rspec tests to include/exclude new functionality
* APPEALS-40909 Test conference links can belong to hearings and hearing days
* APPEALS-40915: prepping branch for merge
* APPEALS-40915: job creates a hearing conference link
* APPEALS-40915: updating rspecs
* APPEALS-40915: finished rspecs
* APPEALS-40915: nullifying link values to resolve frontend errors
* APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs
* APPEALS-40915: final rspec addition
* APPEALS-40915: remove migration specs
* APPEALS-40915: add code review updates
---------
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
Co-authored-by: Adam Ducker <adam.ducker@va.gov>
commit 3a909382c7554f4c21554838b55e4869906aa83d
Author: breedbah <123968373+breedbah@users.noreply.github.com>
Date: Thu Mar 7 11:32:58 2024 -0500
APPEALS-39907 (#20952)
* APPEALS-39907 Initial commit
* APPEALS-39907 update convention
* APPEALS-39907 update render call
* APPEALS-39907 update to/from within .erb
* APPEALS-39907 added to and from attributes
* APPEALS-39907 to/from update
* APPEALS-39907 direction update
* APPEALS-39907 conditional added
* APPEALS-39907 update conditional
* b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob
* APPEALS-39907 added more mailing code for error handling
* APPEALS-39907 adjusted rspec tests
* APPEALS-39907 Unit tests complete
* APPEALS-39907 adjusted lint
* APPEALS-39907 update class ActionMailer
* APPEALS-39907 added comments
* APPEALS-39907 removed redundant unit test
* APPEALS-39907 update demo url
* APPEALS-39907 seperated env instances
* APPEALS-39907 update id fetch method ln: 209
* APPEALS-39907 remove filename parameter ln: 32
* APPEALS-39907 added filename argument back
* APPEALS-39907 added the lint disabler back
* APPEALS-39907 updated demo env test
* b_reed/APPEALS-39907 fixed minor issue with argument names
* APPEALS-39907 updated how appeal ids are found
* APPEALS-39907 more minor fixes
* APPEALS-39907
* APPEALS-39907 email address to send mail and cc now changes depending on rails env
* APPEALS-39907 fixed rspec tests
* APPEALS-39907 Update html doc layout
* APPEALS-39907 adjusted email addresses and some refactors
* APPEALS-39907 adjusted rspec tests
* APPEALS-39907 update case statements
* APPEALS-39907 email preview template
* APPEALS-39907 update values
* APPEALS-39907 added appeal id
* APPEALS-39907 previewer lint
* APPEALS-39907 remove blank space
* APEALS-39907 disable actionMailer lint
* APPEALS-39907 fixed rspecs
* APPEALS-39907 config file update
---------
Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
commit 1f9bfa0c9d95308a66813624d89426a74bad4b6b
Author: Jeff Marks <106996298+jefftmarks@users.noreply.github.com>
Date: Wed Mar 6 15:45:06 2024 -0500
jefftmarks/APPEALS-40909 (#20951)
* APPEALS-40909 Create migration and write spec tests
* APPEALS-40909 Update conference_link model to associate with polymorphic hearing
* APPEALS-40909 Write spec for add index to conference links
* APPEALS-40909 Add spec to test conference link factory after null constraint removed
* APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA
* APPEALS-40909 Implement database cleaner fix and write down test for index migration
* APPEALS-40909 Test conference links can belong to hearings and hearing days
* APPEALS-40909 Remove migration tests
* APPEALS-40909 Refactor delete conference link job spec to avoid static record count
* APPEALS-40909 Fix duplicate examples in download transcription file spec
---------
Co-authored-by: Adam Ducker <adam.ducker@va.gov>
commit bf7bc66779b32ad2fedf87449f0a3506341a1755
Merge: ee3bc890eb 48e8270ec5
Author: msteele <Marc.Steele@va.gov>
Date: Fri Feb 23 16:15:03 2024 -0500
Merge branch 'feature/APPEALS-35296' into feature/APPEALS-25121
commit 48e8270ec505d9646ca6017aed4821d0df67d479
Author: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Date: Fri Feb 23 13:19:11 2024 -0500
akonhilas/APPEALS-31620 (#20788)
* APPEALS-31620: initial commit
* APPEALS-31620: finished all webex service/response/fakes/spec updates
* APPEALS-31620: adding recording details job
* APPEALS-31620: cannot get past rspecs here
* APPEALS-31620: update rspecs
* APPEALS-31620: add file
* APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild
* APPEALS-31620: resolve webex service rspec
* APPEALS-31630: code cleanup
* APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex
* APPEALS-31620: rspec
commit d69e165e4ba9d1ddff56fa3e2a0108cb72fa2b90
Author: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Date: Thu Feb 22 17:45:05 2024 -0500
Min/APPEALS-39905 (#20853)
* APPEALS-39905 audible text will now be displayed as [INAUDIBLE]
* APPEALS-39905 csv getting made and uploaded when inaudibles are found
* APPEALS-39905 turned tmp clean up back on
* APPEALS-39905 adjusted rspec tests
* APPEALS-39905 adjusted transformer rspec tests
* APPEALS-39905 added more rspec tests to transformer workflow
* APPEALS-39905 added guards for nil values in hearing info
* added byebug
* removed byebug
* APPEALS-39905 Resolve merge conflicts in download transcription job spec
* APPEALS-39905 changed inaudible display
* APPEALS-39905 changed test url back
* APPEALS-39905 converts input vtt to readable format if invalud utf is found
* APPEALS-39905 adjusted rspec tests
---------
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
commit ca051beedce2299c1f85aa24071557db2446101e
Author: Jeff Marks <106996298+jefftmarks@users.noreply.github.com>
Date: Tue Feb 20 13:50:58 2024 -0500
jefftmarks/APPEALS-40657 (#20851)
* APPEALS-40657 Refactor DownloadTranscriptionFileJob
* APPEALS-40657 Refactor TranscriptionFile
* APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow
* APPEALS-40657 Refactor DownloadTranscriptionFileJob spec
* APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal
* APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes
* APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal
* APPEALS-40657 Schema
* APPEALS-40657 Fix failing spec in virtual hearing spec
* APPEALS-40657 Update comment in migration
* APPEALS-40657 Update schema
commit ee3bc890eb5189168f36a4aaa1ac8ea944db218d
Merge: 5d83e5fd1e 10a39234d4
Author: mchbidwell <122634362+mchbidwell@users.noreply.github.com>
Date: Fri Feb 9 13:59:35 2024 -0600
Merge pull request #20648 from department-of-veterans-affairs/lthompson/APPEALS-36652
APPEALS-36652
commit 10a39234d40496c3ed454f666bf2cbbe6064c8d1
Author: 631862 <lauren.thompson@va.gov>
Date: Fri Feb 9 14:25:34 2024 -0500
Update snapshots for jest testing
commit a1bd90f0d166c144348efa3a8fe4ab5311688164
Author: 631862 <lauren.thompson@va.gov>
Date: Fri Feb 9 13:39:17 2024 -0500
Fix linting error
commit b5ca1231add9657ed3ee5c047bab5322c2534ea0
Author: 631862 <lauren.thompson@va.gov>
Date: Fri Feb 9 13:21:50 2024 -0500
Update linting issues
commit 1439791551900582f0f03fe0834629896758cff2
Author: 631862 <lauren.thompson@va.gov>
Date: Fri Feb 9 12:12:44 2024 -0500
Remove unnecessary commented out code
commit 1ef926bc7611da0c97ce5356b45ddbc337740b08
Author: 631862 <lauren.thompson@va.gov>
Date: Fri Feb 9 10:46:49 2024 -0500
Update snapshots
commit 681ab39e52b44979a45e1d9eaa9bcd6503ca7414
Author: 631862 <lauren.thompson@va.gov>
Date: Fri Feb 9 10:45:58 2024 -0500
Refactor double returns to a single return
commit a5422654f9ddf8c8313edab0c4d560eb7dfd1175
Author: Jeff Marks <106996298+jefftmarks@users.noreply.github.com>
Date: Thu Feb 8 16:37:04 2024 -0500
jefftmarks/APPEALS-38907 (#20659)
* APPEALS-31821 created job file and template
* APPEALS-38907 Create download transcription file job
* min/APPEALS-31821 made new helper method templates for use on perform
* APPEALS-38907 Continue prototype
* APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers
* APPEALS-38907 Complete basic structure for job
* APPEALS-38907 Update error handling
* APPEALS-31821 gathering info for the front page
* APPEALS-38907 Add error handling for invalid file name
* APPEALS-38907 Add error handling for invalid file type
* APPEALS-38907 Fix linting
* APPEALS-38907 Open URI CodeQL fix
* APPEALS-31821 generating a table for the front page info
* APPEALS-31821 generating header info for first page cell
* APPEALS-38907 Update initializer to create subdirectory for each file type
* APPEALS-38907 Update code comments
* APPEALS-31821 most info appearing on first page now
* APPEALS-31821 stashing regexes for future use
* APPEALS-31821 vtt fully converted to rtf
* APPEALS-38907 Implement S3 upload
* APPEALS-38907 Update comments
* APPEALS-31821 page numbers and footers now displaying
* APPEALS-31821 texts from the same speaker is now consolidated
* APPEALS-31821 refactored footer creation on document
* APPEALS-38907 Complete implementation of job minus va ops email
* APPEALS-38907 Update S3 bucket and folder names
* APPEALS-31821 S3 download and upload implemented and tmp file clean up
* APPEALS-31821 S3 download and upload implemented and tmp file clean up
* APPEALS-38907 Polish error handling before moving on to tests
* APPEALS-31821 added error handling and logging
* APPEALS-31821 repurposed class into a workflow
* APPEALS-31821 removed mailer
* APPEALS-38907 Connect job with TranscriptionTransformer workflow
* APPEALS-38907 Small fixes after writing xray tests
* APPEALS-31821 added rspec tests and refactored workflow
* APPEALS-38907 Finish spec files
* APPEALS-31821 removed the new datadog metrics that was made
* APPEALS-31821 removed the new datadog metrics that was made
* APPEALS-31821 added back old datadog metrics
* APPEALS-31821 removed ext_claim schema
* APPEALS-31821 moved transcription_transformer to workflow folder
* APPEALS-38907 Complete spec
* APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers
* APPEALS-31821 fixed minor formatting issues
* APPEALS-31821 edited spacing
* APPEALS-31821 added error class back
* APPEALS-38907 Fix argument being passed to TranscriptionTransformer
* APPEALS-38907 Fix footer on rtf layout
* APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly
* APPEALS-38907 Change URI.open call to be more safe
---------
Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
Co-authored-by: msteele <Marc.Steele@va.gov>
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
commit c2f8a7b187d7f2f6618a6f83b0efa5a85d2a00f6
Author: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Date: Thu Feb 8 16:05:38 2024 -0500
akonhilas/APPEALS-38906 (#20664)
* APPEALS-38906: updates to service, created new file for job
* APPEALS-38906: response, updates to query, finalizing job, fakes
* APPEALS-38906: add query to call
* APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates
* APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job
* APPEALS-38906: pushing failing tests for visibility
* APPEALS-38906: pushing tests for visibility
* APPEALS-38906: final test updates
* APPEALS-38906: remove comments, time updates, va ops email comment
* APPEALS-38906: fixed rspec and removed unnecessary error raise from job
commit 787fdb63ab24f6819aa55dbe221fe1b0b26e23bc
Author: 631862 <lauren.thompson@va.gov>
Date: Thu Feb 8 13:59:53 2024 -0500
Capitalize webex hearing styling
commit 1ffc5219adf02ae0f29bd19107d6e9140fed3495
Author: 631862 <lauren.thompson@va.gov>
Date: Thu Feb 8 13:19:26 2024 -0500
Update jest snapshots
commit 857b2d567207f262ad8ce23923a5e5add059cab6
Author: 631862 <lauren.thompson@va.gov>
Date: Thu Feb 8 12:52:54 2024 -0500
Show hearing links titles and clickable link
commit 584787be3379429c884d5db09066a769bcd24ed9
Author: 631862 <lauren.thompson@va.gov>
Date: Wed Feb 7 14:02:56 2024 -0500
Remove unnecessary test and resolve testing errors with webex hearinglinks tests
commit 837c6f9834bb5defd1fdacff40e62ea99332da9e
Author: 631862 <lauren.thompson@va.gov>
Date: Wed Feb 7 13:46:16 2024 -0500
Add test with default props back into test file
commit 14e672c6ca1a956b36a6de57539f9557e9c07ae9
Author: 631862 <lauren.thompson@va.gov>
Date: Wed Feb 7 13:42:16 2024 -0500
Add nonvirtual webex test - in Progress
commit 5416f3dccbb73e0a7459d355f5bc8b9f8e73f9b3
Author: 631862 <lauren.thompson@va.gov>
Date: Wed Feb 7 13:04:11 2024 -0500
Updated jest testing in progress
commit f05cdba08911d4238dd7b715179fd9d269b70e5f
Author: breedbah <brandon.reed3@va.gov>
Date: Wed Feb 7 08:40:36 2024 -0500
APPEALS-36652 heearing_spec update
commit 1267c042023f4c3d661079417eb9f2d20fdb983c
Author: 631862 <lauren.thompson@va.gov>
Date: Tue Feb 6 16:14:30 2024 -0500
Update feature tests to remove old conditions
commit 5d83e5fd1ece152834700ed01c126e913f184a3f
Merge: 9e8d6f144e 76d60c2ac7
Author: mchbidwell <122634362+mchbidwell@users.noreply.github.com>
Date: Tue Feb 6 07:25:25 2024 -0600
Merge pull request #20703 from department-of-veterans-affairs/a_ducker/APPEALS-35176
APPEALS-35176 - Make margins more consistent across browsers
commit 76d60c2ac7499405fd68d0978fb23b6183a43237
Author: Adam Ducker <adam.ducker@va.gov>
Date: Mon Feb 5 07:25:18 2024 -0600
APPEALS-35176 - Make margins more consistent across browsers
commit b61f99b0b6ecf4f39de28f1983fe4cb1e72fc747
Author: 631862 <lauren.thompson@va.gov>
Date: Fri Feb 2 10:28:03 2024 -0500
Show non virtual webex HC link
commit 971d1b045f5bbf0c730352510e3fcc8bb130bbd5
Author: 631862 <lauren.thompson@va.gov>
Date: Fri Feb 2 09:27:01 2024 -0500
Add daily docket conference link to the nonvirtual webex hearing links
commit 2725ea1db8d385da438b76816e85bc5e9fd4a013
Author: 631862 <lauren.thompson@va.gov>
Date: Fri Feb 2 09:25:54 2024 -0500
Add daily docket conference links to legacy appeals
commit 9e8d6f144e3856de0ae27d254fdb2eac1fcd8b81
Merge: 36d2b8f0c6 0600f70213
Author: mchbidwell <122634362+mchbidwell@users.noreply.github.com>
Date: Fri Feb 2 07:00:31 2024 -0600
Merge pull request #20649 from department-of-veterans-affairs/a_ducker/APPEALS-35176
APPEALS-35176 - Pull radio buttons closer and tidy up the CSS
commit 0600f70213b01ed1670a72d75f1ced078575c1e1
Author: Adam Ducker <adam.ducker@va.gov>
Date: Thu Feb 1 13:06:09 2024 -0600
APPEALS-35176 - Update radio button to align better with label
commit 1ab7e30a44f1c29b84d34164c610730058ef120c
Author: 631862 <lauren.thompson@va.gov>
Date: Thu Feb 1 13:04:35 2024 -0500
Refine conference provider search so that correct links show up for pexip conferences
commit c0a5860917844bb8dfeabcb03b1df4fd741bd64f
Author: Adam Ducker <adam.ducker@va.gov>
Date: Thu Feb 1 08:11:41 2024 -0600
APPEALS-35176 - Update html and css to better match the figma design
commit cca3a8c7ba41e40f25348af4c7fce14b7aedd881
Author: breedbah <brandon.reed3@va.gov>
Date: Wed Jan 31 16:01:29 2024 -0500
APPEALS-36652
commit 1f808b25de17bfa062d5967cf9732e7aecc02691
Author: 631862 <lauren.thompson@va.gov>
Date: Wed Jan 31 13:41:57 2024 -0500
Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings
commit aa3f0d6fb99903a1a1729a4c6d7ddf915ffde8c6
Author: breedbah <brandon.reed3@va.gov>
Date: Wed Jan 31 11:27:16 2024 -0500
APPEALS-36652 Backend changes
commit 00f222968b276d82d589f6573d1fa94eb3aa65d7
Author: 631862 <lauren.thompson@va.gov>
Date: Mon Jan 29 14:10:05 2024 -0500
Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page
commit 5bbb20bc604b52adfcd935fd23bcadbf787c126a
Author: Jeff Marks <106996298+jefftmarks@users.noreply.github.com>
Date: Fri Jan 26 17:18:08 2024 -0500
jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620)
* APPEALS-31619 Created migration
* APPEALS-31619 Add xls column to migration
* APPEALS-31619 Update index name
* APPEALS-31619 Change null options on migration
* APPEALS-31619 Refactor transcription files table
* APPEALS-31619 Remove old migration
* APPEALS-31619 Remove unique contraints on indexes
* APPEALS-31619 Change index order
* APPEALS-31619 Move docket number in index
commit d2b5ee369db870b99b5b67d7cac4bbd80abd10dd
Author: Adam Ducker <adam.ducker@va.gov>
Date: Fri Jan 26 11:15:33 2024 -0600
APPEALS-35176 - Pull radio buttons closer and tidy up the CSS
commit 36d2b8f0c6a5183db7c564afc2ae0242194847b5
Merge: 8823abb0f1 04b06a2f2e
Author: mchbidwell <122634362+mchbidwell@users.noreply.github.com>
Date: Thu Jan 25 15:28:48 2024 -0600
Merge pull request #20615 from department-of-veterans-affairs/b_reed/APPEALS-35177
b_reed/APPEALS-35177
commit 04b06a2f2e8cca282c5df18e37e593a2322bf60b
Author: breedbah <brandon.reed3@va.gov>
Date: Thu Jan 25 09:38:40 2024 -0500
APPEALS-35177 made final positioning adjustments
commit 0b5e6ea31f7f421d5ab5b6fd1237e3ca71f48f46
Author: breedbah <brandon.reed3@va.gov>
Date: Thu Jan 25 08:47:41 2024 -0500
APPEALS-35177 fix lint
commit cb6565607ddb4398116ef64ea50d634edb3161e1
Author: breedbah <brandon.reed3@va.gov>
Date: Thu Jan 25 08:41:50 2024 -0500
APPEALS-35177 adjust spacing
commit c529c5de1229a6340b6cc31b1e89c5686a9abab9
Author: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Date: Mon Jan 22 17:10:00 2024 -0500
akonhilas/APPEALS-31820 (#20510)
* APPEALS-31820: create transcription transactions serializer with outline until model complete
* APPEALS-31820: update aws link attributes
* APPEALS-31820: removed methods and has many relationship, change file name
* APPEALS-31820: updated file tree
* Revert "APPEALS-31820: updated file tree"
This reverts commit 4b58d5a93c3922582b97447e6b40c5cb1b087083.
* APPEALS-31820: updated serializer to match new db columns and updated AC
commit e124cadaba89395beea7b2c43268c1893f59ea09
Author: Jeff Marks <106996298+jefftmarks@users.noreply.github.com>
Date: Fri Jan 19 16:21:00 2024 -0500
hotfix/APPEALS-35296-flaky-conference-job-test (#20555)
commit d75ec57f4b36d205e09e15ea5cf4dd993a6bf61b
Author: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Date: Fri Jan 19 12:39:15 2024 -0500
Min/APPEALS-31621 (#20523)
* APPEALS-31621 added the table
* APPEALS-31621 moved model under hearings folder
* APPEALS-31621 reverted schema back from testing table
* APPEALS-31621 added transcriptions association
* APPEALS-31621 fixed typo
* APPEALS-31621 removed migration file
* APPEALS-31621 added additional template methods in model and comments
* APPEALS-31621 fixed transcription typo
* APPEALS-31621 added additional template methods
* APPEALS-31621 changed name of model and controller
* APPEALS-31621 removed transcript association
commit 8823abb0f110c98d1ae4e0083e76fb3ffcbef139
Merge: b3457dd990 1bf0e64084
Author: mchbidwell <122634362+mchbidwell@users.noreply.github.com>
Date: Fri Jan 19 11:15:23 2024 -0600
Merge pull request #20514 from department-of-veterans-affairs/b_reed/APPEALS-31618
APPEALS-31618
commit 1bf0e64084f674a585788394a7e204e6d60a1b20
Author: breedbah <brandon.reed3@va.gov>
Date: Fri Jan 19 11:37:55 2024 -0500
APPEALS-31618 updated migration inheritance
commit e054f326472077f941f86463dfb5556ce538ee1c
Author: Jeff Marks <106996298+jefftmarks@users.noreply.github.com>
Date: Thu Jan 18 16:30:50 2024 -0500
jefftmarks/APPEALS-31619 (#20515)
* APPEALS-31619 Created migration
* APPEALS-31619 Add xls column to migration
* APPEALS-31619 Update index name
* APPEALS-31619 Change null options on migration
* APPEALS-31619 Refactor transcription files table
* APPEALS-31619 Remove old migration
commit 549ef2506c74ed4e552a06049a724ff00c52a4a1
Author: breedbah <brandon.reed3@va.gov>
Date: Thu Jan 18 15:03:12 2024 -0500
APPEALS-31618 updated Marcs sugestions rnd 1
commit f81a4fceaa0c9146be669f7f22e44a0b560459a6
Author: breedbah <brandon.reed3@va.gov>
Date: Wed Jan 17 15:17:36 2024 -0500
APPEALS-31618 update create_conference_job_spec
commit d70ee41d49c88e07eda0df21966827ccf1001b0e
Author: breedbah <brandon.reed3@va.gov>
Date: Wed Jan 17 14:01:15 2024 -0500
APPEALS-31618 update details.test.js snapshot
commit 77677bff20d85e26c25227c1a87554f99aa45d2f
Author: breedbah <brandon.reed3@va.gov>
Date: Wed Jan 17 13:12:57 2024 -0500
APPEALS-31618 update VirtualHearingsFields snapshot
commit d2738e46b2528a99e3ac170cf65d8bb2e2cf8b2c
Author: breedbah <brandon.reed3@va.gov>
Date: Wed Jan 17 12:49:53 2024 -0500
APPEALS-31618 update lint
commit 43ab31e9af11c56ce769784824b5f4eb2693d314
Author: breedbah <brandon.reed3@va.gov>
Date: Wed Jan 17 12:30:22 2024 -0500
APPEALS-31618 update tests
commit 597b8d53541109407ba5364002429b69434f9270
Author: breedbah <brandon.reed3@va.gov>
Date: Wed Jan 17 12:09:17 2024 -0500
APPEALS-31618 remove attribute conferencelinks
commit 2d74322ac804fb4a3874e11dad42a3e80c12f836
Author: breedbah <brandon.reed3@va.gov>
Date: Wed Jan 17 10:12:03 2024 -0500
APPEALS-31618 added code for co-host
commit 2dcbb63a0701eb799a5b6355742fe801c889c4c1
Author: breedbah <brandon.reed3@va.gov>
Date: Tue Jan 16 22:06:50 2024 -0500
APPEALS-31618 Add co_host_link to conference_links
commit 593472671f27517a62ca6cc480c2a59b3bb40792
Author: breedbah <brandon.reed3@va.gov>
Date: Tue Jan 16 22:04:37 2024 -0500
APPEALS-31618 0fficial add co_host_hearing_link
commit f795c673bf4cde826af13d4bc2a3f47e6dafcc13
Author: breedbah <brandon.reed3@va.gov>
Date: Tue Jan 16 22:00:10 2024 -0500
APPEALS-31618 rmove migration
commit 8ae765ccdc4466b69014e6d77ff54b0729cac5d3
Author: breedbah <brandon.reed3@va.gov>
Date: Tue Jan 16 20:19:13 2024 -0500
APPEALS-31618 add migration files
commit 4a4b4132ecd56868f9a87fbb985147ea57f1dde6
Author: breedbah <brandon.reed3@va.gov>
Date: Tue Jan 16 12:39:27 2024 -0500
Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295
<!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with -->
Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345)
Please explain the changes you made here.
- [ ] Code compiles correctly
<!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR -->
1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below
- [ ] For feature branches merging into master: Was this deployed to UAT?
- [ ] Screenshots of UI changes added to PR & Original Issue
BEFORE|AFTER
---|---
*For Frontend (Presentation) Components*
* [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`)
* [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy
* [ ] Write a separate story (within the same file) for each discrete variation of the component
*Only for Schema Changes*
* [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables
* [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii)
* [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations))
* [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method))
* [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output)
* [ ] For queries using raw sql was an explain plan run by System Team
* [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
* [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys))
* [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated
* [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary)
* [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
* [ ] Request: Service name, method name, input field names
* [ ] Response: Check expected data structure
* [ ] Check that calls are wrapped in MetricService record block
* [ ] Check that all configuration is coming from ENV variables
* [ ] Listed all new ENV variables in description
* [ ] Worked with or notified System Team that new ENV variables need to be set
* [ ] Update Fakes
* [ ] For feature branches: Was this tested in Caseflow UAT
- [ ] Add or update code comments at the top of the class, module, and/or component.
Did you include any test coverage for your code? Check below:
- [ ] RSpec
- [ ] Jest
- [ ] Other
Your code does not add any new code climate offenses? If so why?
- [ ] No new code climate issues added
- [ ] Are performance metrics (e.g., response time, throughput) being tracked?
- [ ] Are key application components monitored (e.g., database, cache, queues)?
- [ ] Is there a system in place for setting up alerts based on performance thresholds?
- [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
- [ ] Are logs structured (e.g., using log tags) for easier querying and analysis?
- [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
- [ ] Is log retention and rotation configured correctly?
- [ ] Are logs being forwarded to a centralized logging system if needed?
- [ ] Are user actions being logged for audit purposes?
- [ ] Are changes to critical data being tracked ?
- [ ] Are logs being securely stored and protected from tampering or exposing protected data?
- [ ] Are errors being caught and handled gracefully?
- [ ] Are appropriate error messages being displayed to users?
- [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
- [ ] Are unhandled exceptions being caught at the application level ?
- [ ] Are custom exceptions defined and used where appropriate?
- [ ] Is exception handling consistent throughout the codebase?
- [ ] Are exceptions logged with relevant context and stack trace information?
- [ ] Are exceptions being grouped and categorized for easier analysis and resolution?
commit b3457dd9901886bb44c458d7bc5d926ed933dc7e
Merge: b2e653be8a 280cced496
Author: breedbah <brandon.reed3@va.gov>
Date: Tue Jan 16 10:53:48 2024 -0500
Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295
commit 76d1ee37b7b743d215f6f01fc722f9faea0b84d1
Merge: aab076bdb5 b2e653be8a
Author: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Date: Fri Jan 12 12:31:57 2024 -0500
Merge in master
commit aab076bdb5754e1a025d8869894d4184cfa6cdd0
Merge: d02d48bc6b b654eac63a
Author: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Date: Fri Jan 5 09:56:31 2024 -0500
Merge branch 'master' into feature/APPEALS-26734
commit d02d48bc6b09c474545690a9fce806128bf54746
Merge: 280cced496 084cd9819c
Author: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Date: Fri Dec 29 09:41:03 2023 -0500
Merge remote-tracking branch 'origin/master' into feature/APPEALS-26734
commit 280cced4966cf7d0787608bf3767e027290390d7
Merge: 3915850abf 6b222c0758
Author: mchbidwell <122634362+mchbidwell@users.noreply.github.com>
Date: Mon Dec 11 10:15:30 2023 -0600
Merge pull request #20095 from department-of-veterans-affairs/akonhilas/APPEALS-35728
akonhilas/APPEALS-35728
commit 3915850abf7b692ad22cb126e042b982fe8870ed
Merge: 64e5abee79 a3050a3eb2
Author: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Date: Fri Dec 8 16:39:53 2023 -0500
Merge branch 'master' into feature/APPEALS-26734
commit 64e5abee793df2deb9f70cf50e1ff65088afb55b
Author: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Date: Wed Dec 6 12:11:09 2023 -0500
Test: Change hearing links label (#20082)
* Change hearing links label
* Update snapshot
* Fix tests
* More snapshots
---------
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
commit 6b222c075820d1d35d5cfc7300ae3423f10f10fd
Author: Ariana Konhilas <konhilas_ariana@bah.com>
Date: Tue Dec 5 15:27:35 2023 -0500
APPEALS-35728: updates to test, props, store, snapshot
commit 4e34c22c7197cc9d6aa4db541f1857bb67a6fa07
Author: Ariana Konhilas <konhilas_ariana@bah.com>
Date: Fri Dec 1 11:46:57 2023 -0500
APPEALS-35728: update logic for type vs conferenceProvider
commit d5be7e4859ea5599d…
msteele96
added a commit
that referenced
this pull request
Oct 13, 2024
* APPEALS-34501 added port env var
* APPEALS-34501 updated the feature toggle
* APPEALS-34501 update spec
* Add helper methods to ExternalApi::WebexService::CreateRespons
* Add create_webex_conference
* Conference ID to string
* Set conference_id back
* Rename LinkService to PexipLinkService
* Remove conference_id setting since we dont use it
* Add env vars to controller spec
* Fix failing tests in pexip_conference_link_spec
* Remove nil check
* Fix pexip_link_service_spec failures
* Clean up test file a bit
* APPEALS-34517 render correct data guestlinks
* Fix test link
* Add fixes and fiel changes to create_conference_job_spec
* Whittle down create_conference_job
* Remove env vars that can come back out
* Add FTs to conf job
* APPEALS-34517 updated tests and guestLink DailyDocket
* Lint
* Remove unused mocks
* Fix conf link tests
* Maybe fix some tests
* Controller spec fixes
* Add fix to virtual hearing spec and update factory and model
* Remove defunct check for host link
* Update link_generation_initialized trait across app
* Resolve daily docket spec with new trait name
* Adjust StuckVirtualHearingsChecker
* Adjust daily docket
* Fix async pending tests
* APPEALS-34673: added conditional based on hearing conference provider to display links
* Add update for links
* Update to guestLink rendering
* APPEALS-34673: update snapshot tests, add hearing links to test runs
* APPEALS-34673: revert caseworkerindex snapshot and remove comment
* APPEALS-34673: update snapshot - passes locally
* APPEALS-34673: updates to snapshot
* APPEALS-34673: updates to snapshot
* APPEALS-34673: updates to snapshot
* APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing
* APPEALS-34880: added nbf exp rspec to virtual hearing spec
* APPEALS-34880: added hearing day spec test for nbf and exp and removed comments
* APPEALS-34880: removed comments
* APPEALS-34880: removed comments
* APPEALS-34880: removed spacing in rspec
* APPEALS-34908: added one liners
* APPEALS-34908 update resp
* APPEALS-34908 update json parse
* APPEALS-34908 update send_webex method nil
* APPEALS-34908 update webex_conference_link to string
* APPEALS-34908 update create_response.rb sym to string
* DRY up generate_conference_information
* APPEALS-34908: service and fakes updates
* APPEALS-34908: update request body
* Change param passing
* APPEALS-34908 rspec test fix
* APPEALS-34908: updated webex service spec
* APPEALS-34908 converted hash to json in fake
* Change some names
* APPEALS-35033: change casing for Nbf Exp to nbf exp
* Correct spec file name
* Remove .gitignore diff
* Use .to_json
* APPEALS-35195: update sub to use unique hearing day id
* APPEALS-35195: update hearing day spec to have specific id for hearing day
* APPEALS-35195: change date format
* APPEALS-35728: initial updates to daily docket row
* APPEALS-35728: update logic for type vs conferenceProvider
* APPEALS-35728: updates to test, props, store, snapshot
* Test: Change hearing links label (#20082)
* Change hearing links label
* Update snapshot
* Fix tests
* More snapshots
---------
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295
<!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with -->
Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345)
# Description
Please explain the changes you made here.
## Acceptance Criteria
- [ ] Code compiles correctly
## Testing Plan
<!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR -->
1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below
- [ ] For feature branches merging into master: Was this deployed to UAT?
# Frontend
## User Facing Changes
- [ ] Screenshots of UI changes added to PR & Original Issue
BEFORE|AFTER
---|---
## Storybook Story
*For Frontend (Presentation) Components*
* [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`)
* [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy
* [ ] Write a separate story (within the same file) for each discrete variation of the component
# Backend
## Database Changes
*Only for Schema Changes*
* [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables
* [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii)
* [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations))
* [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method))
* [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output)
* [ ] For queries using raw sql was an explain plan run by System Team
* [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
* [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys))
* [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated
* [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary)
## Integrations: Adding endpoints for external APIs
* [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
* [ ] Request: Service name, method name, input field names
* [ ] Response: Check expected data structure
* [ ] Check that calls are wrapped in MetricService record block
* [ ] Check that all configuration is coming from ENV variables
* [ ] Listed all new ENV variables in description
* [ ] Worked with or notified System Team that new ENV variables need to be set
* [ ] Update Fakes
* [ ] For feature branches: Was this tested in Caseflow UAT
# Best practices
## Code Documentation Updates
- [ ] Add or update code comments at the top of the class, module, and/or component.
## Tests
### Test Coverage
Did you include any test coverage for your code? Check below:
- [ ] RSpec
- [ ] Jest
- [ ] Other
### Code Climate
Your code does not add any new code climate offenses? If so why?
- [ ] No new code climate issues added
## Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
### Monitoring
- [ ] Are performance metrics (e.g., response time, throughput) being tracked?
- [ ] Are key application components monitored (e.g., database, cache, queues)?
- [ ] Is there a system in place for setting up alerts based on performance thresholds?
### Logging
- [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
- [ ] Are logs structured (e.g., using log tags) for easier querying and analysis?
- [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
- [ ] Is log retention and rotation configured correctly?
- [ ] Are logs being forwarded to a centralized logging system if needed?
### Auditing
- [ ] Are user actions being logged for audit purposes?
- [ ] Are changes to critical data being tracked ?
- [ ] Are logs being securely stored and protected from tampering or exposing protected data?
### Error Handling
- [ ] Are errors being caught and handled gracefully?
- [ ] Are appropriate error messages being displayed to users?
- [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
- [ ] Are unhandled exceptions being caught at the application level ?
### Exception Handling
- [ ] Are custom exceptions defined and used where appropriate?
- [ ] Is exception handling consistent throughout the codebase?
- [ ] Are exceptions logged with relevant context and stack trace information?
- [ ] Are exceptions being grouped and categorized for easier analysis and resolution?
* APPEALS-31618 add migration files
* APPEALS-31618 rmove migration
* APPEALS-31618 0fficial add co_host_hearing_link
* APPEALS-31618 Add co_host_link to conference_links
* APPEALS-31618 added code for co-host
* APPEALS-31618 remove attribute conferencelinks
* APPEALS-31618 update tests
* APPEALS-31618 update lint
* APPEALS-31618 update VirtualHearingsFields snapshot
* APPEALS-31618 update details.test.js snapshot
* APPEALS-31618 update create_conference_job_spec
* APPEALS-31618 updated Marcs sugestions rnd 1
* jefftmarks/APPEALS-31619 (#20515)
* APPEALS-31619 Created migration
* APPEALS-31619 Add xls column to migration
* APPEALS-31619 Update index name
* APPEALS-31619 Change null options on migration
* APPEALS-31619 Refactor transcription files table
* APPEALS-31619 Remove old migration
* APPEALS-31618 updated migration inheritance
* Min/APPEALS-31621 (#20523)
* APPEALS-31621 added the table
* APPEALS-31621 moved model under hearings folder
* APPEALS-31621 reverted schema back from testing table
* APPEALS-31621 added transcriptions association
* APPEALS-31621 fixed typo
* APPEALS-31621 removed migration file
* APPEALS-31621 added additional template methods in model and comments
* APPEALS-31621 fixed transcription typo
* APPEALS-31621 added additional template methods
* APPEALS-31621 changed name of model and controller
* APPEALS-31621 removed transcript association
* hotfix/APPEALS-35296-flaky-conference-job-test (#20555)
* akonhilas/APPEALS-31820 (#20510)
* APPEALS-31820: create transcription transactions serializer with outline until model complete
* APPEALS-31820: update aws link attributes
* APPEALS-31820: removed methods and has many relationship, change file name
* APPEALS-31820: updated file tree
* Revert "APPEALS-31820: updated file tree"
This reverts commit 4b58d5a93c3922582b97447e6b40c5cb1b087083.
* APPEALS-31820: updated serializer to match new db columns and updated AC
* APPEALS-35177 adjust spacing
* APPEALS-35177 fix lint
* APPEALS-35177 made final positioning adjustments
* APPEALS-35176 - Pull radio buttons closer and tidy up the CSS
* jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620)
* APPEALS-31619 Created migration
* APPEALS-31619 Add xls column to migration
* APPEALS-31619 Update index name
* APPEALS-31619 Change null options on migration
* APPEALS-31619 Refactor transcription files table
* APPEALS-31619 Remove old migration
* APPEALS-31619 Remove unique contraints on indexes
* APPEALS-31619 Change index order
* APPEALS-31619 Move docket number in index
* Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page
* APPEALS-36652 Backend changes
* Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings
* APPEALS-36652
* APPEALS-35176 - Update html and css to better match the figma design
* Refine conference provider search so that correct links show up for pexip conferences
* APPEALS-35176 - Update radio button to align better with label
* Add daily docket conference links to legacy appeals
* Add daily docket conference link to the nonvirtual webex hearing links
* Show non virtual webex HC link
* APPEALS-35176 - Make margins more consistent across browsers
* Update feature tests to remove old conditions
* APPEALS-36652 heearing_spec update
* Updated jest testing in progress
* Add nonvirtual webex test - in Progress
* Add test with default props back into test file
* Remove unnecessary test and resolve testing errors with webex hearinglinks tests
* Show hearing links titles and clickable link
* Update jest snapshots
* Capitalize webex hearing styling
* akonhilas/APPEALS-38906 (#20664)
* APPEALS-38906: updates to service, created new file for job
* APPEALS-38906: response, updates to query, finalizing job, fakes
* APPEALS-38906: add query to call
* APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates
* APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job
* APPEALS-38906: pushing failing tests for visibility
* APPEALS-38906: pushing tests for visibility
* APPEALS-38906: final test updates
* APPEALS-38906: remove comments, time updates, va ops email comment
* APPEALS-38906: fixed rspec and removed unnecessary error raise from job
* jefftmarks/APPEALS-38907 (#20659)
* APPEALS-31821 created job file and template
* APPEALS-38907 Create download transcription file job
* min/APPEALS-31821 made new helper method templates for use on perform
* APPEALS-38907 Continue prototype
* APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers
* APPEALS-38907 Complete basic structure for job
* APPEALS-38907 Update error handling
* APPEALS-31821 gathering info for the front page
* APPEALS-38907 Add error handling for invalid file name
* APPEALS-38907 Add error handling for invalid file type
* APPEALS-38907 Fix linting
* APPEALS-38907 Open URI CodeQL fix
* APPEALS-31821 generating a table for the front page info
* APPEALS-31821 generating header info for first page cell
* APPEALS-38907 Update initializer to create subdirectory for each file type
* APPEALS-38907 Update code comments
* APPEALS-31821 most info appearing on first page now
* APPEALS-31821 stashing regexes for future use
* APPEALS-31821 vtt fully converted to rtf
* APPEALS-38907 Implement S3 upload
* APPEALS-38907 Update comments
* APPEALS-31821 page numbers and footers now displaying
* APPEALS-31821 texts from the same speaker is now consolidated
* APPEALS-31821 refactored footer creation on document
* APPEALS-38907 Complete implementation of job minus va ops email
* APPEALS-38907 Update S3 bucket and folder names
* APPEALS-31821 S3 download and upload implemented and tmp file clean up
* APPEALS-31821 S3 download and upload implemented and tmp file clean up
* APPEALS-38907 Polish error handling before moving on to tests
* APPEALS-31821 added error handling and logging
* APPEALS-31821 repurposed class into a workflow
* APPEALS-31821 removed mailer
* APPEALS-38907 Connect job with TranscriptionTransformer workflow
* APPEALS-38907 Small fixes after writing xray tests
* APPEALS-31821 added rspec tests and refactored workflow
* APPEALS-38907 Finish spec files
* APPEALS-31821 removed the new datadog metrics that was made
* APPEALS-31821 removed the new datadog metrics that was made
* APPEALS-31821 added back old datadog metrics
* APPEALS-31821 removed ext_claim schema
* APPEALS-31821 moved transcription_transformer to workflow folder
* APPEALS-38907 Complete spec
* APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers
* APPEALS-31821 fixed minor formatting issues
* APPEALS-31821 edited spacing
* APPEALS-31821 added error class back
* APPEALS-38907 Fix argument being passed to TranscriptionTransformer
* APPEALS-38907 Fix footer on rtf layout
* APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly
* APPEALS-38907 Change URI.open call to be more safe
---------
Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
Co-authored-by: msteele <Marc.Steele@va.gov>
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
* Refactor double returns to a single return
* Update snapshots
* Remove unnecessary commented out code
* Update linting issues
* Fix linting error
* Update snapshots for jest testing
* jefftmarks/APPEALS-40657 (#20851)
* APPEALS-40657 Refactor DownloadTranscriptionFileJob
* APPEALS-40657 Refactor TranscriptionFile
* APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow
* APPEALS-40657 Refactor DownloadTranscriptionFileJob spec
* APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal
* APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes
* APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal
* APPEALS-40657 Schema
* APPEALS-40657 Fix failing spec in virtual hearing spec
* APPEALS-40657 Update comment in migration
* APPEALS-40657 Update schema
* Min/APPEALS-39905 (#20853)
* APPEALS-39905 audible text will now be displayed as [INAUDIBLE]
* APPEALS-39905 csv getting made and uploaded when inaudibles are found
* APPEALS-39905 turned tmp clean up back on
* APPEALS-39905 adjusted rspec tests
* APPEALS-39905 adjusted transformer rspec tests
* APPEALS-39905 added more rspec tests to transformer workflow
* APPEALS-39905 added guards for nil values in hearing info
* added byebug
* removed byebug
* APPEALS-39905 Resolve merge conflicts in download transcription job spec
* APPEALS-39905 changed inaudible display
* APPEALS-39905 changed test url back
* APPEALS-39905 converts input vtt to readable format if invalud utf is found
* APPEALS-39905 adjusted rspec tests
---------
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
* akonhilas/APPEALS-31620 (#20788)
* APPEALS-31620: initial commit
* APPEALS-31620: finished all webex service/response/fakes/spec updates
* APPEALS-31620: adding recording details job
* APPEALS-31620: cannot get past rspecs here
* APPEALS-31620: update rspecs
* APPEALS-31620: add file
* APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild
* APPEALS-31620: resolve webex service rspec
* APPEALS-31630: code cleanup
* APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex
* APPEALS-31620: rspec
* jefftmarks/APPEALS-40909 (#20951)
* APPEALS-40909 Create migration and write spec tests
* APPEALS-40909 Update conference_link model to associate with polymorphic hearing
* APPEALS-40909 Write spec for add index to conference links
* APPEALS-40909 Add spec to test conference link factory after null constraint removed
* APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA
* APPEALS-40909 Implement database cleaner fix and write down test for index migration
* APPEALS-40909 Test conference links can belong to hearings and hearing days
* APPEALS-40909 Remove migration tests
* APPEALS-40909 Refactor delete conference link job spec to avoid static record count
* APPEALS-40909 Fix duplicate examples in download transcription file spec
---------
Co-authored-by: Adam Ducker <adam.ducker@va.gov>
* APPEALS-39907 (#20952)
* APPEALS-39907 Initial commit
* APPEALS-39907 update convention
* APPEALS-39907 update render call
* APPEALS-39907 update to/from within .erb
* APPEALS-39907 added to and from attributes
* APPEALS-39907 to/from update
* APPEALS-39907 direction update
* APPEALS-39907 conditional added
* APPEALS-39907 update conditional
* b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob
* APPEALS-39907 added more mailing code for error handling
* APPEALS-39907 adjusted rspec tests
* APPEALS-39907 Unit tests complete
* APPEALS-39907 adjusted lint
* APPEALS-39907 update class ActionMailer
* APPEALS-39907 added comments
* APPEALS-39907 removed redundant unit test
* APPEALS-39907 update demo url
* APPEALS-39907 seperated env instances
* APPEALS-39907 update id fetch method ln: 209
* APPEALS-39907 remove filename parameter ln: 32
* APPEALS-39907 added filename argument back
* APPEALS-39907 added the lint disabler back
* APPEALS-39907 updated demo env test
* b_reed/APPEALS-39907 fixed minor issue with argument names
* APPEALS-39907 updated how appeal ids are found
* APPEALS-39907 more minor fixes
* APPEALS-39907
* APPEALS-39907 email address to send mail and cc now changes depending on rails env
* APPEALS-39907 fixed rspec tests
* APPEALS-39907 Update html doc layout
* APPEALS-39907 adjusted email addresses and some refactors
* APPEALS-39907 adjusted rspec tests
* APPEALS-39907 update case statements
* APPEALS-39907 email preview template
* APPEALS-39907 update values
* APPEALS-39907 added appeal id
* APPEALS-39907 previewer lint
* APPEALS-39907 remove blank space
* APEALS-39907 disable actionMailer lint
* APPEALS-39907 fixed rspecs
* APPEALS-39907 config file update
---------
Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
* akonhilas/APPEALS-40915 (#20948)
* APPEALS-40915: initial commit
* APPEALS-40909 Create migration and write spec tests
* APPEALS-40909 Update conference_link model to associate with polymorphic hearing
* APPEALS-40909 Write spec for add index to conference links
* APPEALS-40909 Add spec to test conference link factory after null constraint removed
* APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA
* APPEALS-40915: updated comments to job
* APPEALS-40909 Implement database cleaner fix and write down test for index migration
* APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation
* APPEALS-40915: updated existing rspec tests to include/exclude new functionality
* APPEALS-40909 Test conference links can belong to hearings and hearing days
* APPEALS-40915: prepping branch for merge
* APPEALS-40915: job creates a hearing conference link
* APPEALS-40915: updating rspecs
* APPEALS-40915: finished rspecs
* APPEALS-40915: nullifying link values to resolve frontend errors
* APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs
* APPEALS-40915: final rspec addition
* APPEALS-40915: remove migration specs
* APPEALS-40915: add code review updates
---------
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
Co-authored-by: Adam Ducker <adam.ducker@va.gov>
* Missed rubocop merge conflict
* akonhilas/APPEALS-40921 (#21116)
* APPEALS-40921: added method to concern and reference to both hearing serializers
* APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors
* APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors
* Min/APPEALS-37605 (#21151)
* APPEALS-37605 added route and test json response
* APPEALS-37605 file now gets downloaded onto local computer
* APPEALS-37605 added user verification
* min/APPEALS-37605 added rspec and factory for transcription_file
* APPEALS-37605 finished writing rspec tests
* APPEALS-37605 finished writing rspec tests
* APPEALS-37605 added more error handling
* APPEALS-37605 Move controller back to hearings folder
* APPEALS-37605 Remove unused methods from controller
* APPEALS-37605 Move transcription_file_spec to hearings folder
---------
Co-authored-by: msteele <Marc.Steele@va.gov>
* jefftmarks/APPEALS-37292-37293 (#21140)
* APPEALS-37292 Create transcription files table
* APPEALS-37292 Adjust table styling
* APPEALS-37292 Update legacy conditional to show transcription details
* APPEALS-37292 Conditionally render different sections of transcription details
* APPEALS-37292 Implement useState and useEffect to reduce renders on table
* APPEALS-37293 Populate table with updated transcription file serializer
* APPEALS-37292-37293
* APPEALS-37293 Comment code
* APPEALS-37293 Update snapshot
* APPEALS-37292-37293 Update snapshot
* APPEALS-37293 Revert transcription files controller
* APPEALS-37293 Update Details jest test
* APPEALS-37293 Add date attribute to hearings data for jest test
* APPEALS-37293 Update imports on Details.jsx jest test
* APPEALS-37293 Update hearing concern with transcription file by recording method
* APPEALS-37292 Update LegacyHearing model and serializer
* APPEALS-37293 Update feature test for details page
* APPEALS-37293 Fix typo in table id
* APPEALS-37293 Add aws link to factory
* APPEALS-37293 Fix hearing links snapshot to pass jest test
* APPEALS-37293 Fix hearing factory
* APPEALS-37293-37293
* APPEALS-37293 Fix transcription files controller spec
* APPEALS-37293 Update to group files on table by docket number
* APPEALS-37293 Refactor route/controller without responds_to and move css
* APPEALS-37293 Fix feature test to reflect route update
* APPEALS-37293 Fix linting on css
* APPEALS-37293 scss lint
* BelongsToPolymorphicHearingConcern updates from Rails 6.0
* jefftmarks/APPEALS-40907 (#21249)
* APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models
* APPEALS-40907 Remove unnecessary polymorphic concerns
* APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links
* APPEALS-40907 Update models
* APPEALS-40907 Update models
* APPEALS-40907 Update and remove jest tests
* Min/APPPEALS-42711 (#21285)
* APPEALS-42711 adjusted query for webex recordings list
* APPEALS-42711 added rspec tests for webex_conference_link
* APPEALS-42711 some code climate refactors
* APPEALS-42711 fixed code climate issues and webex service argument refactor
* APPEALS-42711 fixed som broken rspec tests
* APPEALS-42711 fixed a few code climate issues with mailer
* APPEALS-42711 refactored more code climate issues with mailer and webex implementation
* APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues
* APPEALS-42711 fixed some broken rspec tests and more code climate issues
* APPEALS-42711 changed names of classes and methods to fix code climate issue
* APPEALS-42711 changed names of classes and methods to fix code climate issue
* APPEALS-42711 changed names of classes and methods to fix code climate issue
* APPEALS-42711 added max value back in to webex recordings
* APPEALS-42711 added max value back in to webex recordings
* min/APPEALS-42711 adjusted query
* APPEALS-42711 refactored some code
* akonhilas/APPEALS-40906 (#21165)
* APPEALS-40906: remove sub nbf exp from hearing_day
* APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual
* APPEALS-40906: Update so many jest tests and test data
* APPEALS-40906: merge latest from feature
* APPEALS-40906: Update snapshots after merge
* APPEALS-40906: updates to feature test
* APPEALS-40906 change serializer debug attempt
* APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx
* APPEALS-40906 Return references of conference_links to conference_link
* APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer
* APPEALS-40906 Update failing spec and serializer
* APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx
* APPEALS-40906 Ensure correct classname and button text for hearing coordinator link
* Fix hearing_day_spec to user singular conference link
* Update hearing details snap shots
* APPEALS-40906 Update Details.test.js snapshot
* APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx
* APPEALS-40906 Remove hearing links from central and video details page
* Uncomment hearing details feature spec
* APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past
* APPEALS-40906 Add bang operator
* APPEALS-40906 Update Hearing Links jest to not use redux store
* APPEALS-40906 Remove console.log
* APPEALS-40906 Remove console.log
* APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video
* APPEALS-40906 Update snapshots
* APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links
* APPEALS-40908 Update HearingLinks UI to show copy link button at all times
* APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types
* APPEALS-40906 Fix jest test props for HearingLinks test
* APPEALS-40906 Uncomment out jest config
* APPEALS-40906: remove unused code from hearing links test
* APPEALS-40906: move non virtual conference link to hearing concern
---------
Co-authored-by: msteele <Marc.Steele@va.gov>
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
* Min/APPEALS-43214 (#21344)
* APPEALS-43214 added new error handling for file upload and new param to custom exception
* APPEALS-43214 wrote rspec tests and made some adjustment to error handlers
* rerun checks
* rerun checks
* APPEALS-43214 adjusted failing rspec
* APPEALS-43214 Linting fix
* APPEALS-43214 Indentation fixes
* APPEALS-43214 Update mailer to handle different transcription file jobs
* APPEALS-43214 Added beginning of hour to webex list calls
* APPEALS-43214 Update mailer to show download link and fix failing test
* APPEALS-43214 Refactor transcription file issues mailer
* APPEALS-43214 Remove old spec file
* APPEALS-43214 Refactor content section of mailer
* APPEALS-43214 Add missing comma
* APPEALS-43212 Refactor mailer to render nested lists
* APPEALS-43214 Update prodtest email and demo vs dev distinction
* APPEALS-43214 Linting and fixes to create conference job
* APPEALS-43214 Call job#extra
* APPEALS-43214 job#log_error
* APPEALS-43214 Remove extra method
* APPEALS-43214 Fix log error issue
* APPEALS-43214 Fix typo
* APPEALS-43214 Incorporate action direction into job action hash
* APPEALS-43214 Remove byebug
---------
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
Co-authored-by: msteele <Marc.Steele@va.gov>
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
* b_reed/APPEALS-34071-v2 (#21422)
* Add rcredstash and dynamodb
* Update ports
* Fix m1 docker compose
* Add kms
* Add initializers
* Upgrade aws-sdk
* Lint roll
* Update table name
* Add back VirtualHearings::RefreshWebexAccessTokenJob
* Add refresh_access_token method to ExternalApi::WebexService
* Add back AccessTokenRefreshResponse
* Add back in error handling in Webex Response class
* Add new job to SCHEDULED_JOBS
* Add WebexInvalidTokenError error class
* Add refresh_access_token to fake WebexService
* Add back in specs
* APPEALS-34071 bundle install additions gemfile.lock
* APPEALS-34071 slim out test
* Fix the 'levers exists' message overwritting test output
---------
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* Move methods from hearing.rb to hearing concern and add default aws region to resolve error
* Match yarn.lock to master
* Update ref for caseflow-commons
* Update gemfile.lock
* Update scheduled jobs key and move job to different folder
* Update job to set user manually and pass in updated_by
* msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492)
* APPEALS-45182 Reinforce has_many relationships
* APPEALS-45182 Add missing comma
* Resolve lint issue
---------
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* Hotfix/APPEALS-45218 (#21503)
* APPEALS-45218 reverted webex config arguments
* APPEALS-45218 reverted webex config arguments
* APPEALS-25218 Update WebexService to remove config in favor of individual arguments
* APPEALS-45218 Format comment
---------
Co-authored-by: msteele <Marc.Steele@va.gov>
* B_reed/hotfix_APPEALS-45285 (#21531)
* APPEALS-45285 Bug Fix
* APPEALS-45285 update pexip_service_spec
* APPEALS-45285 remove white space
* Hotfix/APPEALS-45218-v2 (#21522)
* APPEALS-45218 reverted webex config arguments
* APPEALS-45218 reverted webex config arguments
* APPEALS-45218 added query argument to webex conference link
* APPEALS-45218: webex recordings endpoint correction
* APPEALS-45218 adjusted arguments during inititalizing of refresh tokens
* APPEALS-45218 fixed rspec
* APPEALS-45218: added error catching on webex service response
* APPEALS-45218: remove tested code
* APPEALS-45218 Go back to leveraging HTTPI response inherited methods
---------
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: msteele <Marc.Steele@va.gov>
* msteele/APPEALS-45349 (#21539)
* APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error
* APPEALS-45349 Flip conditionals
* APPEALS-45349 Fix linting errors
* hotfix/APPEALS-45399-45401-45472 (#21555)
* APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash
* APPEALS-45399-45401 Remove CGI escape from fetch webex list job
* APPEALS-445399-45401 Update spec files for webex list and details job
* APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery
* Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery"
This reverts commit d9ce585c59444f9793e681e58060d71872057e4c.
* hotfix/APPEALS-45472 (#21562)
* APPEALS-45472 Refactor error handling for transcription
* APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer
* Hotfix/APPEALS-45818 (#21632)
* APPEALS-45818: parsing fix, remove topic param, fix response
* APPEALS-45818: revert list and details job back to original state, update tests
---------
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
* msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634)
* APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument
* APPEALS-45285 Update spec to use virtual_hearing
* APPEALS-45285 Linting fixes
* hotfix/APPEALS-45828 (#21625)
* APPEALS-45828 Include call to create webex conference links in base hearing update form
* APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual
* Fix needing to reload to display co host link on details page
* Fix incorrect method name
* Remove temporary rendering of default pexip link for webex hearings after conversion
* APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT
* APPEALS-45828 Remove file name argument from fetch details job spec
* APPEALS-45828 Fail on bad hearing link if link nil or legacy link
* APPEALS-45828 Sanitize url string
* APPEALS-45828 Undo url sanitize
* Remove unused styles after merge
* APPEALS-45285 added conditional to handled nil conference ids (#21766)
Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
* feature/APPEALS-45998 Webex Rooms API Workaround (#21810)
* Min/APPEALS-46009 (#21690)
* APPEALS-46005: job, job logic, env placeholder, schedule update
* APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service
* APPEALS-46011 Update fakes
* APPEALS-46005: merge 46011 logic updates
* APPEALS-46009 added the new webex room details job
* APPEALS-46011 Update specs
* commenting out code
* commenting code back in
* APPEALS-46009 adjusted rspec tests
* APPEALS-46009 adjusted rspec tests
* APPEALS-46005: add rspec, comment out rooms details call, final filter
* APPEALS-46009 adjusted rspec tests
* APPEALS-46005: rough filter test added to rooms list spec commented out
* APPEALS-46009 adjusted rspec tests
* APPEALS-46009: filter rspec, filter in rooms list job, add fake data
* APPEALS-46009: resolved comments
---------
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
* akonhilas/APPEALS-46006 (#21734)
* APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job
* APPEALS-46006: webex service spec update, fake update, recordings list response update
* APPEALS-46006: recordings details job and spec updates, lint fix recordings list job
* APPEALS-46006: recordings list spec and job updates
* APPEALS-46006: room meeting details spec updates
* APPEALS-46006: final updates to fake data
* APPEALS-46006: changing topic to actual webex response
* APPEALS-46006 create and use self.acceses_token method in WebexService classes
* APPEALS-46006 Update failing rspec for Details and List Jobs
* APPEALS-46006: update mailer, preview, specs, lint error
---------
Co-authored-by: msteele <Marc.Steele@va.gov>
---------
Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
* Hotfix/APPEALS-46083 (#21832)
* Min/APPEALS-46009 (#21690)
* APPEALS-46005: job, job logic, env placeholder, schedule update
* APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service
* APPEALS-46011 Update fakes
* APPEALS-46005: merge 46011 logic updates
* APPEALS-46009 added the new webex room details job
* APPEALS-46011 Update specs
* commenting out code
* commenting code back in
* APPEALS-46009 adjusted rspec tests
* APPEALS-46009 adjusted rspec tests
* APPEALS-46005: add rspec, comment out rooms details call, final filter
* APPEALS-46009 adjusted rspec tests
* APPEALS-46005: rough filter test added to rooms list spec commented out
* APPEALS-46009 adjusted rspec tests
* APPEALS-46009: filter rspec, filter in rooms list job, add fake data
* APPEALS-46009: resolved comments
---------
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
* APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed
* APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings
---------
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
* akonhilas/APPEALS-46130 (#21804)
* APPEALS-43160: Fix linting errors in OrgUsers
* APPEALS-43160: fix margins and move divider
* APPEALS-43160: remove margin top on search bar styling
* APPEALS-43160: fix webex lint errors
* APPEALS-43160: move radio button style div inside visibility check
* APPEALS-46130: move css inline style to scss
* APPEALS-46130: fix lint errors, remove gray line
* Hotfix/APPEALS-48161 (#21917)
* APPEALS-48161: remove, refactor, fake update, specs, filename update
* APPEALS-48161: kickoff gha on right branch merge
* APPEALS-48161: filter title call only once
* APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941)
* Adjust spacing in gemfile
* Hotfix/APPEALS-49560 (#22015)
* APPEALS-49560 moved non-virtual conference link creation to hearing concern
* APPEALS-49560 moved non_virtual conference creation inside of reschedule method
* APPEALS-49560 added a new spec test to test link creation
* APPEALS-49560 refactored rspec
* APPEALS-49560 removed additional method in after_create to prevent risk of duplication
* APPEALS-49560 removed additional method in after_create to prevent risk of duplication
* Hotfix/APPEALS-49624 (#22016)
* APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks
* APPEALS-49624: add rooms and room details to mailer preview, correct api url
* APPEALS-49624: cleaning up rspecs
* APPEALS-49624: update query format, add mailer tests
* APPEALS-49624: update mailer keys
* APPEALS-49624: fix lint errors
* APPEALS-49624 Remove rubocop ignores and fix query format
---------
Co-authored-by: msteele <Marc.Steele@va.gov>
* Remove extra newline for Rubocop
* Hotfix/Appeals-49560-v2 (#22052)
* APPEALS-49560 moved non-virtual conference link creation to hearing concern
* APPEALS-49560 moved non_virtual conference creation inside of reschedule method
* APPEALS-49560 added a new spec test to test link creation
* APPEALS-49560 refactored rspec
* APPEALS-49560 removed additional method in after_create to prevent risk of duplication
* APPEALS-49560 removed additional method in after_create to prevent risk of duplication
* APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask
* Update app/models/concerns/hearing_concern.rb
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
---------
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
* Remove extra newline after merge conflict
* Recover lost code to compress multiple lines by same speaker into one large block
* Reintroduce code after bad merge conflict resolution
* Min/APPEALS-50859 (#22081)
* remediated code climate issues
* remediated code climate issues
* remediated code climate issues
* fixed duplicate code issues
* fixed duplicate code issues
* fixed duplicate code issues
* APPEALS-50859 added new concern to abstract duplicate code
* APPEALS-50859 fixed new concern climate issues
* APPEALS-50859 added new config method for rooms endpoints to concern
* APPEALS-50859 added new config method for rooms endpoints to concern
* APPEALS-50859 added new config method for instant connect to concern
* APPEALS-50859 added new config method for instant connect to concern
* Update bundler version
* Remove duplicate method
* Fix bad merge conflict resolution
* Remove x86_64 platforms, add ruby platform
* Remove bad metrics line
* Update documentation replacing master with main (#22960)
* Update WINDOWS_11.md replacing master with main
* References to master are changed to main where applicable
* akonhilas/APPEALS-59152 (#22973)
* APPEALS-59152: removed unnecessary logic, color.primary
* APPEALS-59152: update snapshot tests
* APPEALS-54874: Update PG and Ruby-oci8 gems (#22506)
* update minimum version in gemfile and ran bundle install (#22503)
* require ruby-oci8 in config/boot.rb to fix SIGV fault
* APPEALS-36292: Conditionally render banner alerts based on which environment it is deployed on (#21367)
* Conditionally render alerts based on which environment is deployed
* setting Env alert banner sitewide
* separate colors for different envs using the same alert type
* lighter reds for prodtest alert so the text is more readable
* give demo banner more contrast
* adjust specific language for demo env
* adjust logic to accept proper env var. Add style for preprod (yellow)
* isolate env alert styles
* remove duplicate 'demo' Alert
* remove development env banner to fix tests
* making conditional logic a little more bulletproof against 'production'
* update CaseWorkerIndex snapshot
* fix env var
* update snapshot from hard 'uat' setting
* conditionally render env alert on only the home page
* sticky env header statuses
* getting development alert banners to work
* target correct frontend dependency for NavigationBar changes
* connecting new frontend package with better prod exclusion logic
* make the prodtest env badge a more readable color
* cleaning up testing code
* fix linting issues
* Remove unnecessary space
* new NavigationBar update
* yarn install of new FE dependency
* remove extra package.json
* remove development env logic due to NODE_ENV bug
* fixing broken logo link padding and colors
* hardening logic to exclude other inputs
* correcting operator logic
* remove testing var
* point caseflow-frontend to master
* point at most recent caseflow-frontend master
* linting issues fix
* update Route and CaseWorker snapshot
* update snapshot for process.env.DEPLOY_ENV
---------
Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com>
* Merge feature/APPEALS-41559 into release/FY24Q4.6.0 (#22979)
* Start feature work tracking PR with a TODO comment
* Remove TODO comment for CodeClimate
* SeanC/APPEALS-42315 | Create separate Remand table, model and seed data (#22220)
* added migration file for adding type column to supplemental claims table
* created stub for remand model
* added type to supplemental claim factory and new remand trait
* added remand sc's to vha seeds
* updated migration name and fixed typo
* Changed migration to inherit from Caseflow::Mirgration
* schema changes
* reverting schema
* changed the setting of the type column
* fixed schema and renamed migration file
* fixed migration and schema
* updated the remands factory and seeds
* fixed comment in schema
---------
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* TYLERB/APPEALS-42455: Display new and migrated Remands in Decision Review Queue tabs (#22206)
* Added support for remands to the business_line.rb model and the index.js util file that parses the decision review type filters for the decision review queue.
* Updated the business line spec file, the decision reviews controller spec tests, and the reviews spec feature test to support remands.
* Added a decision review polymorphic helper to DRY up some of the polymorphic appeal concerns.
* Overrode the remand model association to request issues so active record joins will work correctly.
* Added another helper for sti polymorphic relationships. Fixed filtering for STI decision review types for remands. Updated tests and added factories for testing.
* Code climate fixes and test fixes.
* Fixed more test failures. Removed the remand request issues relationship since it was incorrectly implemented. Added a scope to supplemental claims for remands. Fixed an issue where board grant effectuation tasks without request issues were missing from the new task type count method.
* Changed the UNION ALL to a UNION in the new task_type_count method to prevent duplicate row counts. Updated tests and fixed an issue where the board grant effectuation tasks were being counted for pending task queries.
* JHoang/APPEALS-42318 (#22270)
* some preliminary remand & sc model updates
* typo
* some preliminary hlr checks?
* undo seed change
* decision issue and sc updates
* attempt code climate fixes
* another code climate fix
* testing changes
* useless variable..
* fix conditional in decision issue
* fix undefined find_by method
* attempt rspec fix
* rspec fix attempt #2
* supplemental_claim_spec fix?
* remove comma
* code climate fix
* added comment for transparency on remand creation, attempt fix for remands route
* updated specs for decision_issue, hlr_spec, appeal_spec to account for remand creation type
* fix lint error
* fix lint error #2
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* APPEALS-42458 (#22365)
* disable edit issues link for remands
* add banners explaining that remands are not editable
also makes sure that remands are not editable on the edit issues page
* TYLERB/APPEALS-44922: Update Generate task report page UI to include Remand in conditions (#22356)
* Initial commit. Changed the DecisionReviewType condition filter to a searchable dropdown and added the remands option to it as well. Updated the report page filter parsing to work with the searchable dropdown instead of checkboxes for the decision review type condition filter.
* Updated the ReportPage jest test and the report page feature test to work with the decision review type filter as a searchable dropdown instead of checkboxes.
* SeanC/APPEALS-42317 | Migrate existing Supplemental Claim Remands to Remand records via script (#22359)
* initial verison of update script
* remanded migration file
* updated sc spec with type
* schema
* fixed a few issues in the migration
* small fix to migration file
* moved the type column check into a seperate it block
* fixed wrong column in migration file
* created a new migration for creating the view
* updated the backfill migration file
---------
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
* J hoang/appeals 44940 (#22428)
* initial
* some factory and spec updates
* change history query update and spec fixes
* code climate/lint fix
* change @claim_type identifier
* fix claim_history_event_spec.rb
* test coverage for change history with Remand claim type
* spec lint fixes
* refactor claim_type filtering to account for remand subtype
* business_line_spec fix
* decision_reviews_controller_spec update for remand claim type
* lint fixes for decision_reviews_controller_spec.rb
* comment updates in business_line.rb
* renamed mock data in change_history_reporter_spec
* trigger GA
* refactor claim type filter for less conditional handling
* business line spec fix
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* Initial commit for the brakeman sql injection warning fixes. (#22598)
* Updated the business line reporter class to properly display Remands as a seperate type than SupplementalClaims. Also added additional testing logic for the business line reporter for hlr and scs since it was only covering appeals. (#22664)
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* Fixed a bug where the frontend would error due to calling .toLowerCase() on a null or undefined value which could happen sometimes if the api filter options are in an incorrect state. (#22796)
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* Updated the remand migration files to work with the rails 6 upgrade and the changes to Caseflow::Migration. (#22825)
* added fix for failing test in decision_reviews_controller_spec (#22829)
---------
Co-authored-by: Robert Travis Pierce <Pierce_Robert@ne.bah.com>
Co-authored-by: Sean Craig <110493538+seancva@users.noreply.github.com>
Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
Co-authored-by: Clay Sheppard <csheepy@gmail.com>
* APPEALS-50679 | Reassign Cases to Camo Change History (#22982)
* Al/APPEALS-45335 (#22228)
* added additional option to check box list
* fixed some tests and code clean up
* fixed more tests
* fixed jest tests
* changes per Pr feedback
* added custom error display
* fixed style for error message
---------
Co-authored-by: Sean Craig <sean.craig2@va.gov>
* adding logic to bring in issue-modification request and updating the … (#22238)
* adding logic to bring in issue-modification request and updating the csv logic
* refactor logic to get pending status and null to request addition
* pending status filter work fixing
* adding withdrawal date and adding logic to display request issue components
* getting edit of request rows and fixing cancelled data
* fixing linter and fixing the query to make test happy
* fixing specs failures
* removing byebug
* removing frontend changes, adding test, fixing the query to replace higherlevel review,adding new field in serializer
* making code climate happy by doing some minor refactor
* fixing the serializer spec failure
* After merging APPEALS-45335, filter for Requested issues were broken, so refactored it and removed the unnecessary methood that i created
* fixing code climate and spec was failing because of hard coded date
* refactor the edit of request logic to take from version, refactored business line query to remove coalesce and fix test
* fixing codeclimate, remove unnecessary field
* refactor to make first comment appear first in edit of request
* fixing linter issue, spec and refactor to fix the bug
* fixing pending status filter issue and adding test for business line
* fixing broken spec failure
* adding user facilty
* fixing the lead and lag function to prevent entry of pending status multiple times
* fixing an issue in which in progress event was not being made
* adding decision reason that was missed and fixing the event logic one more time
* fixing the multiple issue modification request after decision has been made
* refactor inprogress logic for approved data
* fixing spec failure
* fixing the first version logic to be more simpler and fixing name and adding spec
* fixing more inprogess event
* removing the disabled complexity and taking out the boolean condition to a separate method
* Al/APPEALS-45334 Individual change history table which includes Reassign Cases to CAMO events (#22483)
* added logic for claim history events table
* fixed linting errors
* fixing test failures
* added change Pr feedback
* PR feedback round 2
* changes from round 2 of PR feedback
* Added logic event data versions and tests to cover more edgecases
* changed RequestedIssueFragment
* Updated the individual claim history spec file for test failures. Updated an attribute in the IndividualClaimHistory page that was using the wrong getter. Fixed a code climate linting error.
* Removing unnecessary clear filter
* Combined some of the individual claim history tests into one test so it will run more quickly.
* fixing the withdrawal date versioning issue for different level changes
* fixing the spec failure and linter
---------
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
Co-authored-by: = <tyler.broyles@va.gov>
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
* TYLERB/APPEALS-57367: change-history-updates (#22479)
* Initial commit with new tests cases for issue modification requests for change history.
* Added two cte queries to the business line change history query to properly work with a lead for the issue modification requests. Added new methods into the claim history event to work with this new lead and modified the existing issue modification in progress and pending event generation methods to better reflect the state of a claim that is going through the issue modficiation process.
* Cleaned up unused code and todos.
* Updated the claim history event create_imr_in_progress_status_event? with even more logic and edge cases.
* Fixed a possible error when with a greater than operator could be used on a null value.
* Fixed a few rspec tests.
* Renamed a method and fixed a few code climate issues.
* Fixed a bug in event status generation if there is a task with versions but no versions that change status.
* Updated tests to work with new logic and remove a todo statement.
* Fixed code complexity warnings.
* Updated serializer spec to work with the bug fix.
* Adjusted the pending method to prevent possible race conditions.
* Fixed a bug where the incorrect decision event user would be shown for an issue modification request creation if the request has been decided when it should be the requestor as the event user.
* Added the correct css ids to a few IMR change history events so that the filtering would work correctly. Also added some additional sql to properly filter based on css id and station id for requestor and decider joins.
* Updated the IMR business line logic so that the decided at fields would always account for cancelled status since it uses updated at instead of decided at to determine when the IMR was closed. Fixed a bit of logic in the claim history event IMR in progress event generation to work another edge case.
* Added in previous IMR edit versions for displaying it to the user.
* Added a test for the change history service class to verify that request edit events have the correct attributes from the previous edits.
* Fixed a typo for one of the table aliases in the business line query.
* Fixed another typo where the facilities filter was using css id instead of station id from a copy/paste error.
* adding changes for previous state array and some test modification
* adding test for previous data
* Fixed some outstanding test failures.
* Fixed a linting error. Removed some duplicated code that happened when merging in the feature branch. Updated a factorybot method that was causing tests to fail.
* Fixed a few code climate warnings.
* Removed some puts statements in the individual claim history feature test.
---------
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
* TYLERB/APPEALS-58656: Change History CSV and Version Parsing fix (#22874)
* Fixed a modification request claim history in progress event generation bug that could occur when 3-4 pending requests were all created at the same time and then later cancelled at the same time. Also fixed an issue count bug used when building the issue type filter due to additional duplicate rows being inserted into issue type count query due to the left join to the issue modification requests table.
* Altered the version parsing for change history to work with commas in the version strings since that was causing parsing errors. Altered the business line query to use '|||' as a delimeter instead of comma and also changed the array_agg functions to string agg to avoid the '{}' array type casting that was happening between postgres and rails. Updated tests to work with this new parsing.
* Updated vha seed data to have associations to intake data so those seeded claims can correctly generate change history.
* TYLERB/CHANGE-HISTORY-YAML-QUOTE-FIX (#22910)
* Made an update to the claim history parse versions method to work with double quotations after the array_agg to string_agg change.
* Updated the tests to work with the new string agg and version parsing method.
* Skip flakey tests
These are possibly flakey now due to the rails upgrade. We can come
back and fix these once the work has been confirmed in UAT.
* Add rubocop disables for line length
These should be removed when the skips are removed.
* Updated the report_page feature test to reduce flakyness in github actions. Also updated the DownloadHelpers module.
---------
Co-authored-by: Brandon Dorner <brandonleedorner@gmail.com>
* Fix testing error from merge conflict
---------
Co-authored-by: almorbah <149511814+almorbah@users.noreply.github.com>
Co-authored-by: Sean Craig <sean.craig2@va.gov>
Co-authored-by: Prajwal Amatya <122557351+pamatyatake2@users.noreply.github.com>
Co-authored-by: = <tyler.broyles@va.gov>
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com>
* Hotfix/appeals 37269 #2 (#22886)
* adds script and tests for the script
* adjust the way scheduled_for is created since the previous method was removed
* refactor some of the script
* rename test file to include _spec
* push empty commit to rerun tests
---------
Co-authored-by: Zackary Borges-Rowe <borges-rowe_zackary@bah.com>
Co-authored-by: Ron Wabukenda <130374706+ronwabVa@users.noreply.github.com>
* Hotfix/APPEALS-59907 (#23100)
* APPEALS-59907 fix for rtf being reconverted and uploaded
* APPEALS-59907 fixed check for converting rtf
* APPEALS-59907 adjusting location of checks
* APPEALS-59907 added a guard for downloading files
* APPEALS-59907 added rspec tests
* APPEALS-59907 method name changes
* APPEALS-59907 method name changes
* APPEALS-59907 method name changes
* APPEALS-59907 Remove redundant if statement
---------
Co-authored-by: msteele <Marc.Steele@va.gov>
* Update fifo and non-fifo contexts in sqs_service_spec for flaky tests
* Undo changes to sqs_service_spec
* Redo changes to sqs_service_spec
---------
Co-authored-by: breedbah <brandon.reed3@va.gov>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com>
Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Co-authored-by: Adam Ducker <adam.ducker@va.gov>
Co-authored-by: 631862 <lauren.thompson@va.gov>
Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com>
Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>
Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com>
Co-authored-by: seanrpa <155660052+seanrpa@users.noreply.github.com>
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
Co-authored-by: Robert Travis Pierce <Pierce_Robert@ne.bah.com>
Co-authored-by: Sean Craig <110493538+seancva@users.noreply.github.com>
Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
Co-authored-by: Clay Sheppard <csheepy@gmail.com>
Co-authored-by: almorbah <149511814+almorbah@users.noreply.github.com>
Co-authored-by: Sean Craig <sean.craig2@va.gov>
Co-authored-by: Prajwal Amatya <122557351+pamatyatake2@users.noreply.github.com>
Co-authored-by: = <tyler.broyles@va.gov>
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
Co-authored-by: zborgesva <145717155+zborgesva@users.noreply.github.com>
Co-authored-by: Zackary Borges-Rowe <borges-rowe_zackary@bah.com>
Co-authored-by: Ron Wabukenda <130374706+ronwabVa@users.noreply.github.com>
msteele96
added a commit
that referenced
this pull request
Oct 16, 2024
* APPEALS-25117: delete conferences job spec passing * APPEALS-25117: pexip service spec passing * APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) # Description Please explain the changes you made here. ## Acceptance Criteria - [ ] Code compiles correctly ## Testing Plan <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? # Frontend ## User Facing Changes - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- ## Storybook Story *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component # Backend ## Database Changes *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) ## Integrations: Adding endpoints for external APIs * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT # Best practices ## Code Documentation Updates - [ ] Add or update code comments at the top of the class, module, and/or component. ## Tests ### Test Coverage Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other ### Code Climate Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added ## Monitoring, Logging, Auditing, Error, and Exception Handling Checklist ### Monitoring - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? ### Logging - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? ### Auditing - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? ### Error Handling - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? ### Exception Handling - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
msteele96
added a commit
that referenced
this pull request
Oct 17, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) # Description Please explain the changes you made here. ## Acceptance Criteria - [ ] Code compiles correctly ## Testing Plan <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? # Frontend ## User Facing Changes - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- ## Storybook Story *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component # Backend ## Database Changes *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) ## Integrations: Adding endpoints for external APIs * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT # Best practices ## Code Documentation Updates - [ ] Add or update code comments at the top of the class, module, and/or component. ## Tests ### Test Coverage Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other ### Code Climate Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added ## Monitoring, Logging, Auditing, Error, and Exception Handling Checklist ### Monitoring - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? ### Logging - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? ### Auditing - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? ### Error Handling - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? ### Exception Handling - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
AdamShawBAH
pushed a commit
that referenced
this pull request
Oct 19, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
sbashamoni
pushed a commit
that referenced
this pull request
Oct 20, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
AdamShawBAH
pushed a commit
that referenced
this pull request
Oct 20, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
AdamShawBAH
pushed a commit
that referenced
this pull request
Oct 20, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
hawkespoulterva
pushed a commit
that referenced
this pull request
Oct 21, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
hawkespoulterva
pushed a commit
that referenced
this pull request
Oct 21, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
hawkespoulterva
pushed a commit
that referenced
this pull request
Oct 21, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
sbashamoni
pushed a commit
that referenced
this pull request
Oct 21, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
sbashamoni
pushed a commit
that referenced
this pull request
Oct 21, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
sbashamoni
pushed a commit
that referenced
this pull request
Oct 21, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
sbashamoni
pushed a commit
that referenced
this pull request
Oct 21, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
sbashamoni
pushed a commit
that referenced
this pull request
Oct 21, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
sbashamoni
pushed a commit
that referenced
this pull request
Oct 21, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
sbashamoni
pushed a commit
that referenced
this pull request
Oct 21, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
sbashamoni
pushed a commit
that referenced
this pull request
Oct 21, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
sbashamoni
pushed a commit
that referenced
this pull request
Oct 21, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
sbashamoni
pushed a commit
that referenced
this pull request
Oct 21, 2024
* APPEALS-25117: rspec fix + add docket and id as conference id * APPEALS-25117: final service updates * APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review * APPEALS-25117 spec update * APPEALS-25117 update test * APPEALS-25117 finish spec update * APPEALS-25117 correct schema * APPEALS-34501 update arguments * APPEALS-34501 added port env var * APPEALS-34501 updated the feature toggle * APPEALS-34501 update spec * Add helper methods to ExternalApi::WebexService::CreateRespons * Add create_webex_conference * Conference ID to string * Set conference_id back * Rename LinkService to PexipLinkService * Remove conference_id setting since we dont use it * Add env vars to controller spec * Fix failing tests in pexip_conference_link_spec * Remove nil check * Fix pexip_link_service_spec failures * Clean up test file a bit * APPEALS-34517 render correct data guestlinks * Fix test link * Add fixes and fiel changes to create_conference_job_spec * Whittle down create_conference_job * Remove env vars that can come back out * Add FTs to conf job * APPEALS-34517 updated tests and guestLink DailyDocket * Lint * Remove unused mocks * Fix conf link tests * Maybe fix some tests * Controller spec fixes * Add fix to virtual hearing spec and update factory and model * Remove defunct check for host link * Update link_generation_initialized trait across app * Resolve daily docket spec with new trait name * Adjust StuckVirtualHearingsChecker * Adjust daily docket * Fix async pending tests * APPEALS-34673: added conditional based on hearing conference provider to display links * Add update for links * Update to guestLink rendering * APPEALS-34673: update snapshot tests, add hearing links to test runs * APPEALS-34673: revert caseworkerindex snapshot and remove comment * APPEALS-34673: update snapshot - passes locally * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34673: updates to snapshot * APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing * APPEALS-34880: added nbf exp rspec to virtual hearing spec * APPEALS-34880: added hearing day spec test for nbf and exp and removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed comments * APPEALS-34880: removed spacing in rspec * APPEALS-34908: added one liners * APPEALS-34908 update resp * APPEALS-34908 update json parse * APPEALS-34908 update send_webex method nil * APPEALS-34908 update webex_conference_link to string * APPEALS-34908 update create_response.rb sym to string * DRY up generate_conference_information * APPEALS-34908: service and fakes updates * APPEALS-34908: update request body * Change param passing * APPEALS-34908 rspec test fix * APPEALS-34908: updated webex service spec * APPEALS-34908 converted hash to json in fake * Change some names * APPEALS-35033: change casing for Nbf Exp to nbf exp * Correct spec file name * Remove .gitignore diff * Use .to_json * APPEALS-35195: update sub to use unique hearing day id * APPEALS-35195: update hearing day spec to have specific id for hearing day * APPEALS-35195: change date format * APPEALS-35728: initial updates to daily docket row * APPEALS-35728: update logic for type vs conferenceProvider * APPEALS-35728: updates to test, props, store, snapshot * Test: Change hearing links label (#20082) * Change hearing links label * Update snapshot * Fix tests * More snapshots --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295 <!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with --> Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) Please explain the changes you made here. - [ ] Code compiles correctly <!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR --> 1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT - [ ] Add or update code comments at the top of the class, module, and/or component. Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * APPEALS-31618 add migration files * APPEALS-31618 rmove migration * APPEALS-31618 0fficial add co_host_hearing_link * APPEALS-31618 Add co_host_link to conference_links * APPEALS-31618 added code for co-host * APPEALS-31618 remove attribute conferencelinks * APPEALS-31618 update tests * APPEALS-31618 update lint * APPEALS-31618 update VirtualHearingsFields snapshot * APPEALS-31618 update details.test.js snapshot * APPEALS-31618 update create_conference_job_spec * APPEALS-31618 updated Marcs sugestions rnd 1 * jefftmarks/APPEALS-31619 (#20515) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31618 updated migration inheritance * Min/APPEALS-31621 (#20523) * APPEALS-31621 added the table * APPEALS-31621 moved model under hearings folder * APPEALS-31621 reverted schema back from testing table * APPEALS-31621 added transcriptions association * APPEALS-31621 fixed typo * APPEALS-31621 removed migration file * APPEALS-31621 added additional template methods in model and comments * APPEALS-31621 fixed transcription typo * APPEALS-31621 added additional template methods * APPEALS-31621 changed name of model and controller * APPEALS-31621 removed transcript association * hotfix/APPEALS-35296-flaky-conference-job-test (#20555) * akonhilas/APPEALS-31820 (#20510) * APPEALS-31820: create transcription transactions serializer with outline until model complete * APPEALS-31820: update aws link attributes * APPEALS-31820: removed methods and has many relationship, change file name * APPEALS-31820: updated file tree * Revert "APPEALS-31820: updated file tree" This reverts commit 4b58d5a. * APPEALS-31820: updated serializer to match new db columns and updated AC * APPEALS-35177 adjust spacing * APPEALS-35177 fix lint * APPEALS-35177 made final positioning adjustments * APPEALS-35176 - Pull radio buttons closer and tidy up the CSS * jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620) * APPEALS-31619 Created migration * APPEALS-31619 Add xls column to migration * APPEALS-31619 Update index name * APPEALS-31619 Change null options on migration * APPEALS-31619 Refactor transcription files table * APPEALS-31619 Remove old migration * APPEALS-31619 Remove unique contraints on indexes * APPEALS-31619 Change index order * APPEALS-31619 Move docket number in index * Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page * APPEALS-36652 Backend changes * Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings * APPEALS-36652 * APPEALS-35176 - Update html and css to better match the figma design * Refine conference provider search so that correct links show up for pexip conferences * APPEALS-35176 - Update radio button to align better with label * Add daily docket conference links to legacy appeals * Add daily docket conference link to the nonvirtual webex hearing links * Show non virtual webex HC link * APPEALS-35176 - Make margins more consistent across browsers * Update feature tests to remove old conditions * APPEALS-36652 heearing_spec update * Updated jest testing in progress * Add nonvirtual webex test - in Progress * Add test with default props back into test file * Remove unnecessary test and resolve testing errors with webex hearinglinks tests * Show hearing links titles and clickable link * Update jest snapshots * Capitalize webex hearing styling * akonhilas/APPEALS-38906 (#20664) * APPEALS-38906: updates to service, created new file for job * APPEALS-38906: response, updates to query, finalizing job, fakes * APPEALS-38906: add query to call * APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates * APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job * APPEALS-38906: pushing failing tests for visibility * APPEALS-38906: pushing tests for visibility * APPEALS-38906: final test updates * APPEALS-38906: remove comments, time updates, va ops email comment * APPEALS-38906: fixed rspec and removed unnecessary error raise from job * jefftmarks/APPEALS-38907 (#20659) * APPEALS-31821 created job file and template * APPEALS-38907 Create download transcription file job * min/APPEALS-31821 made new helper method templates for use on perform * APPEALS-38907 Continue prototype * APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers * APPEALS-38907 Complete basic structure for job * APPEALS-38907 Update error handling * APPEALS-31821 gathering info for the front page * APPEALS-38907 Add error handling for invalid file name * APPEALS-38907 Add error handling for invalid file type * APPEALS-38907 Fix linting * APPEALS-38907 Open URI CodeQL fix * APPEALS-31821 generating a table for the front page info * APPEALS-31821 generating header info for first page cell * APPEALS-38907 Update initializer to create subdirectory for each file type * APPEALS-38907 Update code comments * APPEALS-31821 most info appearing on first page now * APPEALS-31821 stashing regexes for future use * APPEALS-31821 vtt fully converted to rtf * APPEALS-38907 Implement S3 upload * APPEALS-38907 Update comments * APPEALS-31821 page numbers and footers now displaying * APPEALS-31821 texts from the same speaker is now consolidated * APPEALS-31821 refactored footer creation on document * APPEALS-38907 Complete implementation of job minus va ops email * APPEALS-38907 Update S3 bucket and folder names * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-31821 S3 download and upload implemented and tmp file clean up * APPEALS-38907 Polish error handling before moving on to tests * APPEALS-31821 added error handling and logging * APPEALS-31821 repurposed class into a workflow * APPEALS-31821 removed mailer * APPEALS-38907 Connect job with TranscriptionTransformer workflow * APPEALS-38907 Small fixes after writing xray tests * APPEALS-31821 added rspec tests and refactored workflow * APPEALS-38907 Finish spec files * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 removed the new datadog metrics that was made * APPEALS-31821 added back old datadog metrics * APPEALS-31821 removed ext_claim schema * APPEALS-31821 moved transcription_transformer to workflow folder * APPEALS-38907 Complete spec * APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers * APPEALS-31821 fixed minor formatting issues * APPEALS-31821 edited spacing * APPEALS-31821 added error class back * APPEALS-38907 Fix argument being passed to TranscriptionTransformer * APPEALS-38907 Fix footer on rtf layout * APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly * APPEALS-38907 Change URI.open call to be more safe --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Refactor double returns to a single return * Update snapshots * Remove unnecessary commented out code * Update linting issues * Fix linting error * Update snapshots for jest testing * jefftmarks/APPEALS-40657 (#20851) * APPEALS-40657 Refactor DownloadTranscriptionFileJob * APPEALS-40657 Refactor TranscriptionFile * APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow * APPEALS-40657 Refactor DownloadTranscriptionFileJob spec * APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal * APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes * APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal * APPEALS-40657 Schema * APPEALS-40657 Fix failing spec in virtual hearing spec * APPEALS-40657 Update comment in migration * APPEALS-40657 Update schema * Min/APPEALS-39905 (#20853) * APPEALS-39905 audible text will now be displayed as [INAUDIBLE] * APPEALS-39905 csv getting made and uploaded when inaudibles are found * APPEALS-39905 turned tmp clean up back on * APPEALS-39905 adjusted rspec tests * APPEALS-39905 adjusted transformer rspec tests * APPEALS-39905 added more rspec tests to transformer workflow * APPEALS-39905 added guards for nil values in hearing info * added byebug * removed byebug * APPEALS-39905 Resolve merge conflicts in download transcription job spec * APPEALS-39905 changed inaudible display * APPEALS-39905 changed test url back * APPEALS-39905 converts input vtt to readable format if invalud utf is found * APPEALS-39905 adjusted rspec tests --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * akonhilas/APPEALS-31620 (#20788) * APPEALS-31620: initial commit * APPEALS-31620: finished all webex service/response/fakes/spec updates * APPEALS-31620: adding recording details job * APPEALS-31620: cannot get past rspecs here * APPEALS-31620: update rspecs * APPEALS-31620: add file * APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild * APPEALS-31620: resolve webex service rspec * APPEALS-31630: code cleanup * APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex * APPEALS-31620: rspec * jefftmarks/APPEALS-40909 (#20951) * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40909 Remove migration tests * APPEALS-40909 Refactor delete conference link job spec to avoid static record count * APPEALS-40909 Fix duplicate examples in download transcription file spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov> * APPEALS-39907 (#20952) * APPEALS-39907 Initial commit * APPEALS-39907 update convention * APPEALS-39907 update render call * APPEALS-39907 update to/from within .erb * APPEALS-39907 added to and from attributes * APPEALS-39907 to/from update * APPEALS-39907 direction update * APPEALS-39907 conditional added * APPEALS-39907 update conditional * b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob * APPEALS-39907 added more mailing code for error handling * APPEALS-39907 adjusted rspec tests * APPEALS-39907 Unit tests complete * APPEALS-39907 adjusted lint * APPEALS-39907 update class ActionMailer * APPEALS-39907 added comments * APPEALS-39907 removed redundant unit test * APPEALS-39907 update demo url * APPEALS-39907 seperated env instances * APPEALS-39907 update id fetch method ln: 209 * APPEALS-39907 remove filename parameter ln: 32 * APPEALS-39907 added filename argument back * APPEALS-39907 added the lint disabler back * APPEALS-39907 updated demo env test * b_reed/APPEALS-39907 fixed minor issue with argument names * APPEALS-39907 updated how appeal ids are found * APPEALS-39907 more minor fixes * APPEALS-39907 * APPEALS-39907 email address to send mail and cc now changes depending on rails env * APPEALS-39907 fixed rspec tests * APPEALS-39907 Update html doc layout * APPEALS-39907 adjusted email addresses and some refactors * APPEALS-39907 adjusted rspec tests * APPEALS-39907 update case statements * APPEALS-39907 email preview template * APPEALS-39907 update values * APPEALS-39907 added appeal id * APPEALS-39907 previewer lint * APPEALS-39907 remove blank space * APEALS-39907 disable actionMailer lint * APPEALS-39907 fixed rspecs * APPEALS-39907 config file update --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * akonhilas/APPEALS-40915 (#20948) * APPEALS-40915: initial commit * APPEALS-40909 Create migration and write spec tests * APPEALS-40909 Update conference_link model to associate with polymorphic hearing * APPEALS-40909 Write spec for add index to conference links * APPEALS-40909 Add spec to test conference link factory after null constraint removed * APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA * APPEALS-40915: updated comments to job * APPEALS-40909 Implement database cleaner fix and write down test for index migration * APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation * APPEALS-40915: updated existing rspec tests to include/exclude new functionality * APPEALS-40909 Test conference links can belong to hearings and hearing days * APPEALS-40915: prepping branch for merge * APPEALS-40915: job creates a hearing conference link * APPEALS-40915: updating rspecs * APPEALS-40915: finished rspecs * APPEALS-40915: nullifying link values to resolve frontend errors * APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs * APPEALS-40915: final rspec addition * APPEALS-40915: remove migration specs * APPEALS-40915: add code review updates --------- Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> * Missed rubocop merge conflict * akonhilas/APPEALS-40921 (#21116) * APPEALS-40921: added method to concern and reference to both hearing serializers * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors * Min/APPEALS-37605 (#21151) * APPEALS-37605 added route and test json response * APPEALS-37605 file now gets downloaded onto local computer * APPEALS-37605 added user verification * min/APPEALS-37605 added rspec and factory for transcription_file * APPEALS-37605 finished writing rspec tests * APPEALS-37605 finished writing rspec tests * APPEALS-37605 added more error handling * APPEALS-37605 Move controller back to hearings folder * APPEALS-37605 Remove unused methods from controller * APPEALS-37605 Move transcription_file_spec to hearings folder --------- Co-authored-by: msteele <Marc.Steele@va.gov> * jefftmarks/APPEALS-37292-37293 (#21140) * APPEALS-37292 Create transcription files table * APPEALS-37292 Adjust table styling * APPEALS-37292 Update legacy conditional to show transcription details * APPEALS-37292 Conditionally render different sections of transcription details * APPEALS-37292 Implement useState and useEffect to reduce renders on table * APPEALS-37293 Populate table with updated transcription file serializer * APPEALS-37292-37293 * APPEALS-37293 Comment code * APPEALS-37293 Update snapshot * APPEALS-37292-37293 Update snapshot * APPEALS-37293 Revert transcription files controller * APPEALS-37293 Update Details jest test * APPEALS-37293 Add date attribute to hearings data for jest test * APPEALS-37293 Update imports on Details.jsx jest test * APPEALS-37293 Update hearing concern with transcription file by recording method * APPEALS-37292 Update LegacyHearing model and serializer * APPEALS-37293 Update feature test for details page * APPEALS-37293 Fix typo in table id * APPEALS-37293 Add aws link to factory * APPEALS-37293 Fix hearing links snapshot to pass jest test * APPEALS-37293 Fix hearing factory * APPEALS-37293-37293 * APPEALS-37293 Fix transcription files controller spec * APPEALS-37293 Update to group files on table by docket number * APPEALS-37293 Refactor route/controller without responds_to and move css * APPEALS-37293 Fix feature test to reflect route update * APPEALS-37293 Fix linting on css * APPEALS-37293 scss lint * BelongsToPolymorphicHearingConcern updates from Rails 6.0 * jefftmarks/APPEALS-40907 (#21249) * APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models * APPEALS-40907 Remove unnecessary polymorphic concerns * APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links * APPEALS-40907 Update models * APPEALS-40907 Update models * APPEALS-40907 Update and remove jest tests * Min/APPPEALS-42711 (#21285) * APPEALS-42711 adjusted query for webex recordings list * APPEALS-42711 added rspec tests for webex_conference_link * APPEALS-42711 some code climate refactors * APPEALS-42711 fixed code climate issues and webex service argument refactor * APPEALS-42711 fixed som broken rspec tests * APPEALS-42711 fixed a few code climate issues with mailer * APPEALS-42711 refactored more code climate issues with mailer and webex implementation * APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues * APPEALS-42711 fixed some broken rspec tests and more code climate issues * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 changed names of classes and methods to fix code climate issue * APPEALS-42711 added max value back in to webex recordings * APPEALS-42711 added max value back in to webex recordings * min/APPEALS-42711 adjusted query * APPEALS-42711 refactored some code * akonhilas/APPEALS-40906 (#21165) * APPEALS-40906: remove sub nbf exp from hearing_day * APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual * APPEALS-40906: Update so many jest tests and test data * APPEALS-40906: merge latest from feature * APPEALS-40906: Update snapshots after merge * APPEALS-40906: updates to feature test * APPEALS-40906 change serializer debug attempt * APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx * APPEALS-40906 Return references of conference_links to conference_link * APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer * APPEALS-40906 Update failing spec and serializer * APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx * APPEALS-40906 Ensure correct classname and button text for hearing coordinator link * Fix hearing_day_spec to user singular conference link * Update hearing details snap shots * APPEALS-40906 Update Details.test.js snapshot * APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx * APPEALS-40906 Remove hearing links from central and video details page * Uncomment hearing details feature spec * APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past * APPEALS-40906 Add bang operator * APPEALS-40906 Update Hearing Links jest to not use redux store * APPEALS-40906 Remove console.log * APPEALS-40906 Remove console.log * APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video * APPEALS-40906 Update snapshots * APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links * APPEALS-40908 Update HearingLinks UI to show copy link button at all times * APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types * APPEALS-40906 Fix jest test props for HearingLinks test * APPEALS-40906 Uncomment out jest config * APPEALS-40906: remove unused code from hearing links test * APPEALS-40906: move non virtual conference link to hearing concern --------- Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Min/APPEALS-43214 (#21344) * APPEALS-43214 added new error handling for file upload and new param to custom exception * APPEALS-43214 wrote rspec tests and made some adjustment to error handlers * rerun checks * rerun checks * APPEALS-43214 adjusted failing rspec * APPEALS-43214 Linting fix * APPEALS-43214 Indentation fixes * APPEALS-43214 Update mailer to handle different transcription file jobs * APPEALS-43214 Added beginning of hour to webex list calls * APPEALS-43214 Update mailer to show download link and fix failing test * APPEALS-43214 Refactor transcription file issues mailer * APPEALS-43214 Remove old spec file * APPEALS-43214 Refactor content section of mailer * APPEALS-43214 Add missing comma * APPEALS-43212 Refactor mailer to render nested lists * APPEALS-43214 Update prodtest email and demo vs dev distinction * APPEALS-43214 Linting and fixes to create conference job * APPEALS-43214 Call job#extra * APPEALS-43214 job#log_error * APPEALS-43214 Remove extra method * APPEALS-43214 Fix log error issue * APPEALS-43214 Fix typo * APPEALS-43214 Incorporate action direction into job action hash * APPEALS-43214 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> * b_reed/APPEALS-34071-v2 (#21422) * Add rcredstash and dynamodb * Update ports * Fix m1 docker compose * Add kms * Add initializers * Upgrade aws-sdk * Lint roll * Update table name * Add back VirtualHearings::RefreshWebexAccessTokenJob * Add refresh_access_token method to ExternalApi::WebexService * Add back AccessTokenRefreshResponse * Add back in error handling in Webex Response class * Add new job to SCHEDULED_JOBS * Add WebexInvalidTokenError error class * Add refresh_access_token to fake WebexService * Add back in specs * APPEALS-34071 bundle install additions gemfile.lock * APPEALS-34071 slim out test * Fix the 'levers exists' message overwritting test output --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Move methods from hearing.rb to hearing concern and add default aws region to resolve error * Match yarn.lock to master * Update ref for caseflow-commons * Update gemfile.lock * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * APPEALS-45285 added conditional to handled nil conference ids (#21766) Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> * feature/APPEALS-45998 Webex Rooms API Workaround (#21810) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46006 (#21734) * APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job * APPEALS-46006: webex service spec update, fake update, recordings list response update * APPEALS-46006: recordings details job and spec updates, lint fix recordings list job * APPEALS-46006: recordings list spec and job updates * APPEALS-46006: room meeting details spec updates * APPEALS-46006: final updates to fake data * APPEALS-46006: changing topic to actual webex response * APPEALS-46006 create and use self.acceses_token method in WebexService classes * APPEALS-46006 Update failing rspec for Details and List Jobs * APPEALS-46006: update mailer, preview, specs, lint error --------- Co-authored-by: msteele <Marc.Steele@va.gov> --------- Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> * Hotfix/APPEALS-46083 (#21832) * Min/APPEALS-46009 (#21690) * APPEALS-46005: job, job logic, env placeholder, schedule update * APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service * APPEALS-46011 Update fakes * APPEALS-46005: merge 46011 logic updates * APPEALS-46009 added the new webex room details job * APPEALS-46011 Update specs * commenting out code * commenting code back in * APPEALS-46009 adjusted rspec tests * APPEALS-46009 adjusted rspec tests * APPEALS-46005: add rspec, comment out rooms details call, final filter * APPEALS-46009 adjusted rspec tests * APPEALS-46005: rough filter test added to rooms list spec commented out * APPEALS-46009 adjusted rspec tests * APPEALS-46009: filter rspec, filter in rooms list job, add fake data * APPEALS-46009: resolved comments --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed * APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov> * akonhilas/APPEALS-46130 (#21804) * APPEALS-43160: Fix linting errors in OrgUsers * APPEALS-43160: fix margins and move divider * APPEALS-43160: remove margin top on search bar styling * APPEALS-43160: fix webex lint errors * APPEALS-43160: move radio button style div inside visibility check * APPEALS-46130: move css inline style to scss * APPEALS-46130: fix lint errors, remove gray line * Hotfix/APPEALS-48161 (#21917) * APPEALS-48161: remove, refactor, fake update, specs, filename update * APPEALS-48161: kickoff gha on right branch merge * APPEALS-48161: filter title call only once * APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941) * Adjust spacing in gemfile * Hotfix/APPEALS-49560 (#22015) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * Hotfix/APPEALS-49624 (#22016) * APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Remove extra newline for Rubocop * Hotfix/Appeals-49560-v2 (#22052) * APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Remove extra newline after merge conflict * Recover lost code to compress multiple lines by same speaker into one large block * Reintroduce code after bad merge conflict resolution * Min/APPEALS-50859 (#22081) * remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern * Update bundler version * Remove duplicate method * Fix bad merge conflict resolution * Remove x86_64 platforms, add ruby platform * Remove bad metrics line * akonhilas/APPEALS-59152 (#22973) * APPEALS-59152: removed unnecessary logic, color.primary * APPEALS-59152: update snapshot tests * Merge hotfix/APPEALS-59907 into feature/APPEALS-25121 * Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121 * Edit bad down migration to use SQL --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: Adam Ducker <adam.ducker@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-45399
Resolves APPEALS-45401
Description
APPEALS-45399 Defect Summary: There are two instances where WebexServices are being instantiated within Caseflow in order to call on endpoints to their "thick client", which uses Oauth2 tokens for authentication, however bot tokens (from their Instanct Connect offering) are being provided instead.
APPEALS-45401 Defect Summary: The "to" and "from" query params being passed into Webex's /v1/recordings (list recordings) route are being passed into CGI.escape before being provided for transmission. However, the HTTPI library being employed for request handling encodes query params by default. Since the parameters are being encoded twice they are being corrupted, and it's making it so that the Webex API cannot handle our requests.
Acceptance Criteria
Testing Plan
UAT Testing Plan