Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kev ma/appeals 55015 #22764

Merged
merged 12 commits into from
Sep 11, 2024
Merged

Kev ma/appeals 55015 #22764

merged 12 commits into from
Sep 11, 2024

Conversation

Kevma50287
Copy link
Contributor

@Kevma50287 Kevma50287 commented Sep 9, 2024 •
edited
Loading

Resolves https://jira.devops.va.gov/browse/APPEALS-55015

Description

Updated how organizationPermissions and organizationUserPermissions are loaded into the frontend from server side props in ruby views to React component fetch on page mount for OrganizationUsers.jsx

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Sign in as a Team Admin user
  2. Click on team management in the User dropdown
  3. Click the Org Admin button for InboundOpsTeam
  4. Note that the error page no longer appears and you are successfully directed to organization users page
  5. Inspect the page through Chrome Dev Tools and React Dev Tools, and note that the data for permissions is passed to OrganizationUsers.jsx and OrganizationPermissions.jsx

Frontend

User Facing Changes

BEFORE|AFTER
image

|

Screen.Recording.2024-09-09.at.2.52.44.PM.mov

Backend

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

@Kevma50287 Kevma50287 self-assigned this Sep 9, 2024
@Kevma50287 Kevma50287 marked this pull request as ready for review September 9, 2024 19:47
cacevesva
cacevesva previously approved these changes Sep 10, 2024
View reviewed changes
@cacevesva cacevesva merged commit 9508787 into feature/APPEALS-34965 Sep 11, 2024
17 checks passed
Rnmarshall93 pushed a commit that referenced this pull request Sep 13, 2024
@Kevma50287 @Rnmarshall93
Kev ma/appeals 55015 (#22764)
e5f8f5a 
* Typo fix

* Added safe navigation operator

* Remove permissions from ruby view props

* Update component to save value to state instead of from props

* rename hash key

* updated var ref to state

* Update for code spacing

* Bugfix for sticky checkbox logic
vinner57 pushed a commit that referenced this pull request Sep 15, 2024
@Kevma50287
Kev ma/appeals 55015 (#22764)
142da01 
* Typo fix

* Added safe navigation operator

* Remove permissions from ruby view props

* Update component to save value to state instead of from props

* rename hash key

* updated var ref to state

* Update for code spacing

* Bugfix for sticky checkbox logic
cacevesva added a commit that referenced this pull request Oct 1, 2024
@Rnmarshall93 @Kevma50287
@divyadasari-va @cacevesva @HunJerBAH
Task Added to Appeal no longer being displayed after merge. (#22771)
b0cc879 
* mostly fixed

* fixed css issues on grey timeline.

* fixed missing key issue

* fixed labels and data shape.

* Fixed staged data to use real data.

* removed redundant prop

* Fixed task action dropdown

* fixed linting issue

* Kev ma/appeals 55015 (#22764)

* Typo fix

* Added safe navigation operator

* Remove permissions from ruby view props

* Update component to save value to state instead of from props

* rename hash key

* updated var ref to state

* Update for code spacing

* Bugfix for sticky checkbox logic

* Div/appeals 57463 (#22779)

* Added missing columns in the serializer prepareAppealForSearchStore function

* Removed console log

* Removed unused imports

---------

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* added polymorphic association to correspondence task Correspondence relation

* fixed null task issue

* updated serialized info and passed appeal into CorrespondenceTasksAdded instead of correspondence.

* setup way to load appeals into the Queue redux store to display task actions

* created logic to load serialized tasks into store (but they overwrite each other)

* created logic to add appeal tasks to the redux store.

* added TaskSnapshot to display appeal task actions

* pushed up fix that resolved routing crashes from correspondence

* removed wrapping class for task rows to meet UI/UX requirements. Also disabled the task action dropdown per requirements.

* Refactored component to use different name.

* fixed 6 failing tests

* fixed several failing tests.

* changed shape of mocked data in details test

* adding more data to staged props in test

* fixed task display for tasks added when empty

* reverted jest test files from their extreme size.

* added back in correspondenceAppeal map

* removed console log

* fixed dead import.

* fixed failing tests from div wrappers hiding task actions

* updated tests to be less flaky

---------

Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com>
Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Rnmarshall93 added a commit that referenced this pull request Oct 2, 2024
@Rnmarshall93 @Kevma50287
@divyadasari-va @cacevesva @HunJerBAH
Task Added to Appeal no longer being displayed after merge. (#22771)
2eba601 
* mostly fixed

* fixed css issues on grey timeline.

* fixed missing key issue

* fixed labels and data shape.

* Fixed staged data to use real data.

* removed redundant prop

* Fixed task action dropdown

* fixed linting issue

* Kev ma/appeals 55015 (#22764)

* Typo fix

* Added safe navigation operator

* Remove permissions from ruby view props

* Update component to save value to state instead of from props

* rename hash key

* updated var ref to state

* Update for code spacing

* Bugfix for sticky checkbox logic

* Div/appeals 57463 (#22779)

* Added missing columns in the serializer prepareAppealForSearchStore function

* Removed console log

* Removed unused imports

---------

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* added polymorphic association to correspondence task Correspondence relation

* fixed null task issue

* updated serialized info and passed appeal into CorrespondenceTasksAdded instead of correspondence.

* setup way to load appeals into the Queue redux store to display task actions

* created logic to load serialized tasks into store (but they overwrite each other)

* created logic to add appeal tasks to the redux store.

* added TaskSnapshot to display appeal task actions

* pushed up fix that resolved routing crashes from correspondence

* removed wrapping class for task rows to meet UI/UX requirements. Also disabled the task action dropdown per requirements.

* Refactored component to use different name.

* fixed 6 failing tests

* fixed several failing tests.

* changed shape of mocked data in details test

* adding more data to staged props in test

* fixed task display for tasks added when empty

* reverted jest test files from their extreme size.

* added back in correspondenceAppeal map

* removed console log

* fixed dead import.

* fixed failing tests from div wrappers hiding task actions

* updated tests to be less flaky

---------

Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com>
Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
HunJerBAH added a commit that referenced this pull request Oct 8, 2024
@Rnmarshall93 @Dev-KRedd
@cacevesva @Kevma50287 @divyadasari-va @HunJerBAH
Correspondence and Appeal Tasks: Inbound Ops Team Superuser/visor: Re…
33a6b32 
…move Evidence Submission Window Action Dropdown (#23083)

* is_waivable? method added

* serializer fallback change

* Khalin/appeals 52975 (#22994)

* WIP all styles have been moved

* Fixing linting warnings

* Aria-label added

* Kicking off tests

---------

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* Task Added to Appeal no longer being displayed after merge. (#22771)

* mostly fixed

* fixed css issues on grey timeline.

* fixed missing key issue

* fixed labels and data shape.

* Fixed staged data to use real data.

* removed redundant prop

* Fixed task action dropdown

* fixed linting issue

* Kev ma/appeals 55015 (#22764)

* Typo fix

* Added safe navigation operator

* Remove permissions from ruby view props

* Update component to save value to state instead of from props

* rename hash key

* updated var ref to state

* Update for code spacing

* Bugfix for sticky checkbox logic

* Div/appeals 57463 (#22779)

* Added missing columns in the serializer prepareAppealForSearchStore function

* Removed console log

* Removed unused imports

---------

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* added polymorphic association to correspondence task Correspondence relation

* fixed null task issue

* updated serialized info and passed appeal into CorrespondenceTasksAdded instead of correspondence.

* setup way to load appeals into the Queue redux store to display task actions

* created logic to load serialized tasks into store (but they overwrite each other)

* created logic to add appeal tasks to the redux store.

* added TaskSnapshot to display appeal task actions

* pushed up fix that resolved routing crashes from correspondence

* removed wrapping class for task rows to meet UI/UX requirements. Also disabled the task action dropdown per requirements.

* Refactored component to use different name.

* fixed 6 failing tests

* fixed several failing tests.

* changed shape of mocked data in details test

* adding more data to staged props in test

* fixed task display for tasks added when empty

* reverted jest test files from their extreme size.

* added back in correspondenceAppeal map

* removed console log

* fixed dead import.

* fixed failing tests from div wrappers hiding task actions

* updated tests to be less flaky

---------

Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com>
Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* Fixed Correspondence Intake: Tab name doesn't match page (#23005)

* populating task with dropdown working

* change to get task rendering

* frontend fixes

* added waivable to appeal and task work queue serializers

* added logic to only show evidence window task that is waivable.

* set up task drodown to only show evidence tasks that are waivable.

* fixed failing tests

* refactored waivable? check to fix linting issue.

* removed unused code

---------

Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com>
Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HunJerBAH HunJerBAH HunJerBAH left review comments

@cacevesva cacevesva cacevesva approved these changes

Assignees

@Kevma50287 Kevma50287

Labels
Correspondence
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kevma50287 @HunJerBAH @cacevesva