-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correspondence and Appeal Tasks: Inbound Ops Team Superuser/visor: Remove Evidence Submission Window Action Dropdown #23083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP all styles have been moved * Fixing linting warnings * Aria-label added * Kicking off tests --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* mostly fixed * fixed css issues on grey timeline. * fixed missing key issue * fixed labels and data shape. * Fixed staged data to use real data. * removed redundant prop * Fixed task action dropdown * fixed linting issue * Kev ma/appeals 55015 (#22764) * Typo fix * Added safe navigation operator * Remove permissions from ruby view props * Update component to save value to state instead of from props * rename hash key * updated var ref to state * Update for code spacing * Bugfix for sticky checkbox logic * Div/appeals 57463 (#22779) * Added missing columns in the serializer prepareAppealForSearchStore function * Removed console log * Removed unused imports --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * added polymorphic association to correspondence task Correspondence relation * fixed null task issue * updated serialized info and passed appeal into CorrespondenceTasksAdded instead of correspondence. * setup way to load appeals into the Queue redux store to display task actions * created logic to load serialized tasks into store (but they overwrite each other) * created logic to add appeal tasks to the redux store. * added TaskSnapshot to display appeal task actions * pushed up fix that resolved routing crashes from correspondence * removed wrapping class for task rows to meet UI/UX requirements. Also disabled the task action dropdown per requirements. * Refactored component to use different name. * fixed 6 failing tests * fixed several failing tests. * changed shape of mocked data in details test * adding more data to staged props in test * fixed task display for tasks added when empty * reverted jest test files from their extreme size. * added back in correspondenceAppeal map * removed console log * fixed dead import. * fixed failing tests from div wrappers hiding task actions * updated tests to be less flaky --------- Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
HunJerBAH
reviewed
Oct 8, 2024
app/models/serializers/work_queue/correspondence_appeals_serializer.rb
Outdated
Show resolved
Hide resolved
HunJerBAH
reviewed
Oct 8, 2024
app/models/serializers/work_queue/correspondence_appeals_serializer.rb
Outdated
Show resolved
Hide resolved
Rnmarshall93
changed the title
58227 draft PR
Correspondence and Appeal Tasks: Inbound Ops Team Superuser/visor: Remove Evidence Submission Window Action Dropdown
Oct 8, 2024
HunJerBAH
reviewed
Oct 8, 2024
HunJerBAH
reviewed
Oct 8, 2024
HunJerBAH
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Correspondence and Appeal Tasks: Inbound Ops Team Superuser/visor: Remove Evidence Submission Window Action Dropdown
Description
This PR introduces the ability to view completed evidence submission tasks within the correspondence details component. The page also introduces a dropdown that allows the user to remove the waive evidence window period. This dropdown is only visible if the window period is currently less than 90 days, the user is a superuser or supervisor of the inbound ops team, and the task is completed.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
BEFORE|AFTER
|