Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correspondence and Appeal Tasks: Inbound Ops Team Superuser/visor: Remove Evidence Submission Window Action Dropdown #23083

Merged
merged 16 commits into from
Oct 8, 2024

Conversation

Rnmarshall93
Copy link
Contributor

@Rnmarshall93 Rnmarshall93 commented Oct 4, 2024

Resolves Correspondence and Appeal Tasks: Inbound Ops Team Superuser/visor: Remove Evidence Submission Window Action Dropdown

Description

This PR introduces the ability to view completed evidence submission tasks within the correspondence details component. The page also introduces a dropdown that allows the user to remove the waive evidence window period. This dropdown is only visible if the window period is currently less than 90 days, the user is a superuser or supervisor of the inbound ops team, and the task is completed.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Take a correspondence through intake and make sure to add at least one task related to an appeal to it.
  2. Visit the correspondence details for the correspondence and find the evidence submission window task listed. Note that it does not have the dropdown in its current status.
  3. Set the evidence submission task into a completed state.
  4. Swap users to a supervisor or superuser for inbound ops team.
  5. Note that the dropdown now displays.

Frontend

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue

BEFORE|AFTER

image | image

Rnmarshall93 and others added 12 commits September 30, 2024 12:38
* WIP all styles have been moved

* Fixing linting warnings

* Aria-label added

* Kicking off tests

---------

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* mostly fixed

* fixed css issues on grey timeline.

* fixed missing key issue

* fixed labels and data shape.

* Fixed staged data to use real data.

* removed redundant prop

* Fixed task action dropdown

* fixed linting issue

* Kev ma/appeals 55015 (#22764)

* Typo fix

* Added safe navigation operator

* Remove permissions from ruby view props

* Update component to save value to state instead of from props

* rename hash key

* updated var ref to state

* Update for code spacing

* Bugfix for sticky checkbox logic

* Div/appeals 57463 (#22779)

* Added missing columns in the serializer prepareAppealForSearchStore function

* Removed console log

* Removed unused imports

---------

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* added polymorphic association to correspondence task Correspondence relation

* fixed null task issue

* updated serialized info and passed appeal into CorrespondenceTasksAdded instead of correspondence.

* setup way to load appeals into the Queue redux store to display task actions

* created logic to load serialized tasks into store (but they overwrite each other)

* created logic to add appeal tasks to the redux store.

* added TaskSnapshot to display appeal task actions

* pushed up fix that resolved routing crashes from correspondence

* removed wrapping class for task rows to meet UI/UX requirements. Also disabled the task action dropdown per requirements.

* Refactored component to use different name.

* fixed 6 failing tests

* fixed several failing tests.

* changed shape of mocked data in details test

* adding more data to staged props in test

* fixed task display for tasks added when empty

* reverted jest test files from their extreme size.

* added back in correspondenceAppeal map

* removed console log

* fixed dead import.

* fixed failing tests from div wrappers hiding task actions

* updated tests to be less flaky

---------

Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com>
Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
@Rnmarshall93 Rnmarshall93 changed the title 58227 draft PR Correspondence and Appeal Tasks: Inbound Ops Team Superuser/visor: Remove Evidence Submission Window Action Dropdown Oct 8, 2024
@HunJerBAH HunJerBAH merged commit 33a6b32 into feature/APPEALS-34965 Oct 8, 2024
12 of 17 checks passed
@HunJerBAH HunJerBAH deleted the ryan/APPEALS-58227 branch October 8, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants