-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current user mgmt #23137
Open
youfoundmanesh
wants to merge
29
commits into
main
Choose a base branch
from
current-user-mgmt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Current user mgmt #23137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit 65ba2ae and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
* Add New CE REST API REST Functionality for Vet Docs - Add feature toggle to enable/disable new functionality. - Call REST endpoint for veteran docs when the use_ce_api feature toggle is enabled. - Add supporting services and specs. * Fix Misc. Issues - Update JsonApiResponseAdapter with latest changes to respnse parsing found in caseflow-efolder testing. - Update ruby_claim_evidence_api to bugfix version. * Update received_at Date Parsing Logic - Use slashes instead of hyphens to help JS correctly parse the date. * Fix Double Quote Issue * Improve JsonApiResponseAdapter Blank Response Handling * Pass Rails Logger to VeteranFileFetcher
* Add New CE REST API REST Functionality for Vet Docs - Add feature toggle to enable/disable new functionality. - Call REST endpoint for veteran docs when the use_ce_api feature toggle is enabled. - Add supporting services and specs. * Fix Misc. Issues - Update JsonApiResponseAdapter with latest changes to respnse parsing found in caseflow-efolder testing. - Update ruby_claim_evidence_api to bugfix version. * Update received_at Date Parsing Logic - Use slashes instead of hyphens to help JS correctly parse the date. * Fix Double Quote Issue * add CE-API endpoint to fetch document * Improve JsonApiResponseAdapter Blank Response Handling * Pass Rails Logger to VeteranFileFetcher * small fix --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>
* Add New CE REST API REST Functionality for Vet Docs - Add feature toggle to enable/disable new functionality. - Call REST endpoint for veteran docs when the use_ce_api feature toggle is enabled. - Add supporting services and specs. * Fix Misc. Issues - Update JsonApiResponseAdapter with latest changes to respnse parsing found in caseflow-efolder testing. - Update ruby_claim_evidence_api to bugfix version. * Update received_at Date Parsing Logic - Use slashes instead of hyphens to help JS correctly parse the date. * Fix Double Quote Issue * add CE-API endpoint to fetch document * Improve JsonApiResponseAdapter Blank Response Handling * Pass Rails Logger to VeteranFileFetcher * Updated Vbms Service for RestAPI --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: Deepak <santhi.parakal@va.gov>
* Add series_id assignment to initial fetch from VBMS * Wrap attribute assignment in feature toggle and added test case
* Allow Vet File Update via Claim Evidence API * Update Gem Version and Get Specs Passing
- Remove curly brackets around file series IDs and update call to use series ID. - Correctly format date_va_received_document string. - Update specs.
* Move update_document Feature Flag Logic Move to wrap call to the legacy SOAP request. Previously, the legacy request could still be used if users called update_document directly, but this PR closes that loophole. * Add Subject to Doc Update
* Move update_document Feature Flag Logic Move to wrap call to the legacy SOAP request. Previously, the legacy request could still be used if users called update_document directly, but this PR closes that loophole. * Add Subject to Doc Update * allow VeteranFileUpload to connect with CEAPI * update response * update specs * fix * add json adapter * small fix * Fix lint issues * lint fix * rubocop fix * Updated ruby ce api gem --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* Update How Caseflow Adapts CE API Responses * Remove Unneeded Gemfile Changes * Reset Gemfile to Match Feature Branch --------- Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Address issues with AWS requests failing by falling back to older versions of some gems.
* Add Base Sensitivity Methods and Services - Add user/veteran sensitivity methods to BGSService, borrowed from work done for correspondence auto assignment. - Create new service for checking the compatibility of user/veteran sensitivity. * Add Sensitivity Method to VBMS Service
* Add Sensitivity Checks - Verify user/veteran sensitivity levels are compatible when calling ExternalApi::VBMSService.fetch_document_series_for and when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch. * Add Class Comment * Add Sensitivity Check Failure Handling Logic to Frontend * Improve Comment Wording * Add Missing Space Before Access Email
* Add Sensitivity Checks - Verify user/veteran sensitivity levels are compatible when calling ExternalApi::VBMSService.fetch_document_series_for and when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch. * Add Class Comment * Add Sensitivity Check Failure Handling Logic to Frontend * Improve Comment Wording * Add Missing Space Before Access Email * Add checks for Sensitivity level * small fix * update specs --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>
* Added method to fetch and verify access by vet file number * Added spec tests and guard clause for unassosciated documents
* Update Feature Toggle Logic - Remove references to the send_current_user_cred_to_ce_api flag as it is not yet implemented. - Update sensitivity checks in vbms_service to be controlled by the use_ce_api feature toggle. - Remove sensitivity checks from VbmsRequestWithFileNumber and child classes. * Revert Unintended DB Schema Changes
* Add New CE REST API REST Functionality for Vet Docs (#21812) * Add New CE REST API REST Functionality for Vet Docs - Add feature toggle to enable/disable new functionality. - Call REST endpoint for veteran docs when the use_ce_api feature toggle is enabled. - Add supporting services and specs. * Fix Misc. Issues - Update JsonApiResponseAdapter with latest changes to respnse parsing found in caseflow-efolder testing. - Update ruby_claim_evidence_api to bugfix version. * Update received_at Date Parsing Logic - Use slashes instead of hyphens to help JS correctly parse the date. * Fix Double Quote Issue * Improve JsonApiResponseAdapter Blank Response Handling * Pass Rails Logger to VeteranFileFetcher * Deepak/appeals 46955 (#21865) * Add New CE REST API REST Functionality for Vet Docs - Add feature toggle to enable/disable new functionality. - Call REST endpoint for veteran docs when the use_ce_api feature toggle is enabled. - Add supporting services and specs. * Fix Misc. Issues - Update JsonApiResponseAdapter with latest changes to respnse parsing found in caseflow-efolder testing. - Update ruby_claim_evidence_api to bugfix version. * Update received_at Date Parsing Logic - Use slashes instead of hyphens to help JS correctly parse the date. * Fix Double Quote Issue * add CE-API endpoint to fetch document * Improve JsonApiResponseAdapter Blank Response Handling * Pass Rails Logger to VeteranFileFetcher * small fix --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> * Kev ma/appeals 46956 v1 (#21920) * Add New CE REST API REST Functionality for Vet Docs - Add feature toggle to enable/disable new functionality. - Call REST endpoint for veteran docs when the use_ce_api feature toggle is enabled. - Add supporting services and specs. * Fix Misc. Issues - Update JsonApiResponseAdapter with latest changes to respnse parsing found in caseflow-efolder testing. - Update ruby_claim_evidence_api to bugfix version. * Update received_at Date Parsing Logic - Use slashes instead of hyphens to help JS correctly parse the date. * Fix Double Quote Issue * add CE-API endpoint to fetch document * Improve JsonApiResponseAdapter Blank Response Handling * Pass Rails Logger to VeteranFileFetcher * Updated Vbms Service for RestAPI --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: Deepak <santhi.parakal@va.gov> * Updated ruby_claim_evidence_api gem * Added ClaimEvidenceApiError to rescue block (#21987) * update result_hash (#22011) * Fix nil Series_id for GetDocumentContent (#22038) * Add series_id assignment to initial fetch from VBMS * Wrap attribute assignment in feature toggle and added test case * Allow Vet File Update via Claim Evidence API (#22194) * Allow Vet File Update via Claim Evidence API * Update Gem Version and Get Specs Passing * Update Caseflow to Use Updated CE API Gem (#22272) * Fix Misc. Issues with Caseflow Vet Doc Updates (#22301) - Remove curly brackets around file series IDs and update call to use series ID. - Correctly format date_va_received_document string. - Update specs. * Move update_document Feature Flag Logic (#22345) * Move update_document Feature Flag Logic Move to wrap call to the legacy SOAP request. Previously, the legacy request could still be used if users called update_document directly, but this PR closes that loophole. * Add Subject to Doc Update * Deepak/appeals 51312 (#22364) * Move update_document Feature Flag Logic Move to wrap call to the legacy SOAP request. Previously, the legacy request could still be used if users called update_document directly, but this PR closes that loophole. * Add Subject to Doc Update * allow VeteranFileUpload to connect with CEAPI * update response * update specs * fix * add json adapter * small fix * Fix lint issues * lint fix * rubocop fix * Updated ruby ce api gem --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Updated ruby_claim_evidence_ap gem * Update How Caseflow Adapts CE API Responses (#22395) * Update How Caseflow Adapts CE API Responses * Remove Unneeded Gemfile Changes * Reset Gemfile to Match Feature Branch --------- Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Reset Gem Versions (#22458) Address issues with AWS requests failing by falling back to older versions of some gems. * Updated ruby_claim_evidence_api gem * Create Example Sensitivity Banner (#22562) * Add Base Sensitivity Methods and Services (#22589) * Add Base Sensitivity Methods and Services - Add user/veteran sensitivity methods to BGSService, borrowed from work done for correspondence auto assignment. - Create new service for checking the compatibility of user/veteran sensitivity. * Add Sensitivity Method to VBMS Service * Add FindDocumentSeriesReference Sensitivity Checks (#22616) * Add Sensitivity Checks - Verify user/veteran sensitivity levels are compatible when calling ExternalApi::VBMSService.fetch_document_series_for and when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch. * Add Class Comment * Add Sensitivity Check Failure Handling Logic to Frontend * Improve Comment Wording * Add Missing Space Before Access Email * Deepak/appeals 53851 (#22628) * Add Sensitivity Checks - Verify user/veteran sensitivity levels are compatible when calling ExternalApi::VBMSService.fetch_document_series_for and when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch. * Add Class Comment * Add Sensitivity Check Failure Handling Logic to Frontend * Improve Comment Wording * Add Missing Space Before Access Email * Add checks for Sensitivity level * small fix * update specs --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> * Kev ma/appeals 53862 (#22636) * Added method to fetch and verify access by vet file number * Added spec tests and guard clause for unassosciated documents * Updated ruby_claim_evidence_api gem with ref * Updated ruby_claim_evidence_api gem * Update feature toogle to send_current_user_cred * Update feature toogle to send_current_user_cred_to_ce_api * Update Feature Toggle Logic (#23001) * Update Feature Toggle Logic - Remove references to the send_current_user_cred_to_ce_api flag as it is not yet implemented. - Update sensitivity checks in vbms_service to be controlled by the use_ce_api feature toggle. - Remove sensitivity checks from VbmsRequestWithFileNumber and child classes. * Revert Unintended DB Schema Changes * Update VBMSService to Pass ClaimEvidenceRequest to CE API Gem - This change will allow the CE API gem to call the CE API using the css_id and station_id in the passed ClaimEvidenceRequest object. - The send_current_user_cred_to_ce_api in Caseflow will control whether user credentials or system credentials flow the CE API gem. * Update ruby_claim_evidence_api Gem - Update gem to use changes that allow for sending user creds to the CE API. * Fix Misc. Issues - Refactor some duplicate code. - Use branch for CE API gem in Gemfile. --------- Co-authored-by: SanthiParakal133 <132940479+SanthiParakal133@users.noreply.github.com> Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com> Co-authored-by: Deepak <santhi.parakal@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* update unused parameter * rubocop fix
* Updated to error object * Fix rspec failures * Update VBMSService to Pass ClaimEvidenceRequest to CE API Gem (#23101) * Add New CE REST API REST Functionality for Vet Docs (#21812) * Add New CE REST API REST Functionality for Vet Docs - Add feature toggle to enable/disable new functionality. - Call REST endpoint for veteran docs when the use_ce_api feature toggle is enabled. - Add supporting services and specs. * Fix Misc. Issues - Update JsonApiResponseAdapter with latest changes to respnse parsing found in caseflow-efolder testing. - Update ruby_claim_evidence_api to bugfix version. * Update received_at Date Parsing Logic - Use slashes instead of hyphens to help JS correctly parse the date. * Fix Double Quote Issue * Improve JsonApiResponseAdapter Blank Response Handling * Pass Rails Logger to VeteranFileFetcher * Deepak/appeals 46955 (#21865) * Add New CE REST API REST Functionality for Vet Docs - Add feature toggle to enable/disable new functionality. - Call REST endpoint for veteran docs when the use_ce_api feature toggle is enabled. - Add supporting services and specs. * Fix Misc. Issues - Update JsonApiResponseAdapter with latest changes to respnse parsing found in caseflow-efolder testing. - Update ruby_claim_evidence_api to bugfix version. * Update received_at Date Parsing Logic - Use slashes instead of hyphens to help JS correctly parse the date. * Fix Double Quote Issue * add CE-API endpoint to fetch document * Improve JsonApiResponseAdapter Blank Response Handling * Pass Rails Logger to VeteranFileFetcher * small fix --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> * Kev ma/appeals 46956 v1 (#21920) * Add New CE REST API REST Functionality for Vet Docs - Add feature toggle to enable/disable new functionality. - Call REST endpoint for veteran docs when the use_ce_api feature toggle is enabled. - Add supporting services and specs. * Fix Misc. Issues - Update JsonApiResponseAdapter with latest changes to respnse parsing found in caseflow-efolder testing. - Update ruby_claim_evidence_api to bugfix version. * Update received_at Date Parsing Logic - Use slashes instead of hyphens to help JS correctly parse the date. * Fix Double Quote Issue * add CE-API endpoint to fetch document * Improve JsonApiResponseAdapter Blank Response Handling * Pass Rails Logger to VeteranFileFetcher * Updated Vbms Service for RestAPI --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: Deepak <santhi.parakal@va.gov> * Updated ruby_claim_evidence_api gem * Added ClaimEvidenceApiError to rescue block (#21987) * update result_hash (#22011) * Fix nil Series_id for GetDocumentContent (#22038) * Add series_id assignment to initial fetch from VBMS * Wrap attribute assignment in feature toggle and added test case * Allow Vet File Update via Claim Evidence API (#22194) * Allow Vet File Update via Claim Evidence API * Update Gem Version and Get Specs Passing * Update Caseflow to Use Updated CE API Gem (#22272) * Fix Misc. Issues with Caseflow Vet Doc Updates (#22301) - Remove curly brackets around file series IDs and update call to use series ID. - Correctly format date_va_received_document string. - Update specs. * Move update_document Feature Flag Logic (#22345) * Move update_document Feature Flag Logic Move to wrap call to the legacy SOAP request. Previously, the legacy request could still be used if users called update_document directly, but this PR closes that loophole. * Add Subject to Doc Update * Deepak/appeals 51312 (#22364) * Move update_document Feature Flag Logic Move to wrap call to the legacy SOAP request. Previously, the legacy request could still be used if users called update_document directly, but this PR closes that loophole. * Add Subject to Doc Update * allow VeteranFileUpload to connect with CEAPI * update response * update specs * fix * add json adapter * small fix * Fix lint issues * lint fix * rubocop fix * Updated ruby ce api gem --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Updated ruby_claim_evidence_ap gem * Update How Caseflow Adapts CE API Responses (#22395) * Update How Caseflow Adapts CE API Responses * Remove Unneeded Gemfile Changes * Reset Gemfile to Match Feature Branch --------- Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Reset Gem Versions (#22458) Address issues with AWS requests failing by falling back to older versions of some gems. * Updated ruby_claim_evidence_api gem * Create Example Sensitivity Banner (#22562) * Add Base Sensitivity Methods and Services (#22589) * Add Base Sensitivity Methods and Services - Add user/veteran sensitivity methods to BGSService, borrowed from work done for correspondence auto assignment. - Create new service for checking the compatibility of user/veteran sensitivity. * Add Sensitivity Method to VBMS Service * Add FindDocumentSeriesReference Sensitivity Checks (#22616) * Add Sensitivity Checks - Verify user/veteran sensitivity levels are compatible when calling ExternalApi::VBMSService.fetch_document_series_for and when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch. * Add Class Comment * Add Sensitivity Check Failure Handling Logic to Frontend * Improve Comment Wording * Add Missing Space Before Access Email * Deepak/appeals 53851 (#22628) * Add Sensitivity Checks - Verify user/veteran sensitivity levels are compatible when calling ExternalApi::VBMSService.fetch_document_series_for and when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch. * Add Class Comment * Add Sensitivity Check Failure Handling Logic to Frontend * Improve Comment Wording * Add Missing Space Before Access Email * Add checks for Sensitivity level * small fix * update specs --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> * Kev ma/appeals 53862 (#22636) * Added method to fetch and verify access by vet file number * Added spec tests and guard clause for unassosciated documents * Updated ruby_claim_evidence_api gem with ref * Updated ruby_claim_evidence_api gem * Update feature toogle to send_current_user_cred * Update feature toogle to send_current_user_cred_to_ce_api * Update Feature Toggle Logic (#23001) * Update Feature Toggle Logic - Remove references to the send_current_user_cred_to_ce_api flag as it is not yet implemented. - Update sensitivity checks in vbms_service to be controlled by the use_ce_api feature toggle. - Remove sensitivity checks from VbmsRequestWithFileNumber and child classes. * Revert Unintended DB Schema Changes * Update VBMSService to Pass ClaimEvidenceRequest to CE API Gem - This change will allow the CE API gem to call the CE API using the css_id and station_id in the passed ClaimEvidenceRequest object. - The send_current_user_cred_to_ce_api in Caseflow will control whether user credentials or system credentials flow the CE API gem. * Update ruby_claim_evidence_api Gem - Update gem to use changes that allow for sending user creds to the CE API. * Fix Misc. Issues - Refactor some duplicate code. - Use branch for CE API gem in Gemfile. --------- Co-authored-by: SanthiParakal133 <132940479+SanthiParakal133@users.noreply.github.com> Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com> Co-authored-by: Deepak <santhi.parakal@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Update rspec failures * Update for lint errors --------- Co-authored-by: Alex Smith <alex.smith.99@thunderyard.com> Co-authored-by: SanthiParakal133 <132940479+SanthiParakal133@users.noreply.github.com> Co-authored-by: Deepak <santhi.parakal@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* Updated to error object * Fix rspec failures * Update VBMSService to Pass ClaimEvidenceRequest to CE API Gem (#23101) * Add New CE REST API REST Functionality for Vet Docs (#21812) * Add New CE REST API REST Functionality for Vet Docs - Add feature toggle to enable/disable new functionality. - Call REST endpoint for veteran docs when the use_ce_api feature toggle is enabled. - Add supporting services and specs. * Fix Misc. Issues - Update JsonApiResponseAdapter with latest changes to respnse parsing found in caseflow-efolder testing. - Update ruby_claim_evidence_api to bugfix version. * Update received_at Date Parsing Logic - Use slashes instead of hyphens to help JS correctly parse the date. * Fix Double Quote Issue * Improve JsonApiResponseAdapter Blank Response Handling * Pass Rails Logger to VeteranFileFetcher * Deepak/appeals 46955 (#21865) * Add New CE REST API REST Functionality for Vet Docs - Add feature toggle to enable/disable new functionality. - Call REST endpoint for veteran docs when the use_ce_api feature toggle is enabled. - Add supporting services and specs. * Fix Misc. Issues - Update JsonApiResponseAdapter with latest changes to respnse parsing found in caseflow-efolder testing. - Update ruby_claim_evidence_api to bugfix version. * Update received_at Date Parsing Logic - Use slashes instead of hyphens to help JS correctly parse the date. * Fix Double Quote Issue * add CE-API endpoint to fetch document * Improve JsonApiResponseAdapter Blank Response Handling * Pass Rails Logger to VeteranFileFetcher * small fix --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> * Kev ma/appeals 46956 v1 (#21920) * Add New CE REST API REST Functionality for Vet Docs - Add feature toggle to enable/disable new functionality. - Call REST endpoint for veteran docs when the use_ce_api feature toggle is enabled. - Add supporting services and specs. * Fix Misc. Issues - Update JsonApiResponseAdapter with latest changes to respnse parsing found in caseflow-efolder testing. - Update ruby_claim_evidence_api to bugfix version. * Update received_at Date Parsing Logic - Use slashes instead of hyphens to help JS correctly parse the date. * Fix Double Quote Issue * add CE-API endpoint to fetch document * Improve JsonApiResponseAdapter Blank Response Handling * Pass Rails Logger to VeteranFileFetcher * Updated Vbms Service for RestAPI --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: Deepak <santhi.parakal@va.gov> * Updated ruby_claim_evidence_api gem * Added ClaimEvidenceApiError to rescue block (#21987) * update result_hash (#22011) * Fix nil Series_id for GetDocumentContent (#22038) * Add series_id assignment to initial fetch from VBMS * Wrap attribute assignment in feature toggle and added test case * Allow Vet File Update via Claim Evidence API (#22194) * Allow Vet File Update via Claim Evidence API * Update Gem Version and Get Specs Passing * Update Caseflow to Use Updated CE API Gem (#22272) * Fix Misc. Issues with Caseflow Vet Doc Updates (#22301) - Remove curly brackets around file series IDs and update call to use series ID. - Correctly format date_va_received_document string. - Update specs. * Move update_document Feature Flag Logic (#22345) * Move update_document Feature Flag Logic Move to wrap call to the legacy SOAP request. Previously, the legacy request could still be used if users called update_document directly, but this PR closes that loophole. * Add Subject to Doc Update * Deepak/appeals 51312 (#22364) * Move update_document Feature Flag Logic Move to wrap call to the legacy SOAP request. Previously, the legacy request could still be used if users called update_document directly, but this PR closes that loophole. * Add Subject to Doc Update * allow VeteranFileUpload to connect with CEAPI * update response * update specs * fix * add json adapter * small fix * Fix lint issues * lint fix * rubocop fix * Updated ruby ce api gem --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Updated ruby_claim_evidence_ap gem * Update How Caseflow Adapts CE API Responses (#22395) * Update How Caseflow Adapts CE API Responses * Remove Unneeded Gemfile Changes * Reset Gemfile to Match Feature Branch --------- Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Reset Gem Versions (#22458) Address issues with AWS requests failing by falling back to older versions of some gems. * Updated ruby_claim_evidence_api gem * Create Example Sensitivity Banner (#22562) * Add Base Sensitivity Methods and Services (#22589) * Add Base Sensitivity Methods and Services - Add user/veteran sensitivity methods to BGSService, borrowed from work done for correspondence auto assignment. - Create new service for checking the compatibility of user/veteran sensitivity. * Add Sensitivity Method to VBMS Service * Add FindDocumentSeriesReference Sensitivity Checks (#22616) * Add Sensitivity Checks - Verify user/veteran sensitivity levels are compatible when calling ExternalApi::VBMSService.fetch_document_series_for and when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch. * Add Class Comment * Add Sensitivity Check Failure Handling Logic to Frontend * Improve Comment Wording * Add Missing Space Before Access Email * Deepak/appeals 53851 (#22628) * Add Sensitivity Checks - Verify user/veteran sensitivity levels are compatible when calling ExternalApi::VBMSService.fetch_document_series_for and when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch. * Add Class Comment * Add Sensitivity Check Failure Handling Logic to Frontend * Improve Comment Wording * Add Missing Space Before Access Email * Add checks for Sensitivity level * small fix * update specs --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> * Kev ma/appeals 53862 (#22636) * Added method to fetch and verify access by vet file number * Added spec tests and guard clause for unassosciated documents * Updated ruby_claim_evidence_api gem with ref * Updated ruby_claim_evidence_api gem * Update feature toogle to send_current_user_cred * Update feature toogle to send_current_user_cred_to_ce_api * Update Feature Toggle Logic (#23001) * Update Feature Toggle Logic - Remove references to the send_current_user_cred_to_ce_api flag as it is not yet implemented. - Update sensitivity checks in vbms_service to be controlled by the use_ce_api feature toggle. - Remove sensitivity checks from VbmsRequestWithFileNumber and child classes. * Revert Unintended DB Schema Changes * Update VBMSService to Pass ClaimEvidenceRequest to CE API Gem - This change will allow the CE API gem to call the CE API using the css_id and station_id in the passed ClaimEvidenceRequest object. - The send_current_user_cred_to_ce_api in Caseflow will control whether user credentials or system credentials flow the CE API gem. * Update ruby_claim_evidence_api Gem - Update gem to use changes that allow for sending user creds to the CE API. * Fix Misc. Issues - Refactor some duplicate code. - Use branch for CE API gem in Gemfile. --------- Co-authored-by: SanthiParakal133 <132940479+SanthiParakal133@users.noreply.github.com> Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com> Co-authored-by: Deepak <santhi.parakal@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> * Update rspec failures * Update for lint errors * Updated error handling --------- Co-authored-by: Alex Smith <alex.smith.99@thunderyard.com> Co-authored-by: SanthiParakal133 <132940479+SanthiParakal133@users.noreply.github.com> Co-authored-by: Deepak <santhi.parakal@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* Add CE API Error Handler Class * Add Error Handling Update the VBMSService and SensitivityChecker clases to use the new ClaimEvidenceApiErrorHandler service. * Add Specs * Fix Lint Errors and Spec Failures
youfoundmanesh
force-pushed
the
current-user-mgmt
branch
from
October 25, 2024 18:42
d3adb19
to
65ba2ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling