Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current user mgmt #23137

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Current user mgmt #23137

wants to merge 29 commits into from

Conversation

youfoundmanesh
Copy link
Contributor

Resolves Jira Issue Title

Description

Please explain the changes you made here.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to Jira Issue/Test Plan Link or list them below
  • For feature branches merging into main: Was this deployed to UAT?

Frontend

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
BEFORE AFTER

Storybook Story

For Frontend (Presentation) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

Backend

Database Changes

Only for Schema Changes

  • Add typical timestamps (created_at, updated_at) for new tables
  • Update column comments; include a "PII" prefix to indicate definite or potential PII data content
  • Have your migration classes inherit from Caseflow::Migration, especially when adding indexes (use add_safe_index) (see Writing DB migrations)
  • Verify that migrate:rollback works as desired (change supported functions)
  • Perform query profiling (eyeball Rails log, check bullet and fasterer output)
  • For queries using raw sql was an explain plan run by System Team
  • Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
  • Run make check-fks; add any missing foreign keys or add to config/initializers/immigrant.rb (see Record associations and Foreign Keys)
  • Add belongs_to for associations to enable the schema diagrams to be automatically updated
  • Document any non-obvious semantics or logic useful for interpreting database data at Caseflow Data Model and Dictionary

Integrations: Adding endpoints for external APIs

  • Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
    • Request: Service name, method name, input field names
    • Response: Check expected data structure
    • Check that calls are wrapped in MetricService record block
  • Check that all configuration is coming from ENV variables
    • Listed all new ENV variables in description
    • Worked with or notified System Team that new ENV variables need to be set
  • Update Fakes
  • For feature branches: Was this tested in Caseflow UAT

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

  • Are performance metrics (e.g., response time, throughput) being tracked?
  • Are key application components monitored (e.g., database, cache, queues)?
  • Is there a system in place for setting up alerts based on performance thresholds?

Logging

  • Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
  • Are logs structured (e.g., using log tags) for easier querying and analysis?
  • Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
  • Is log retention and rotation configured correctly?
  • Are logs being forwarded to a centralized logging system if needed?

Auditing

  • Are user actions being logged for audit purposes?
  • Are changes to critical data being tracked ?
  • Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

  • Are errors being caught and handled gracefully?
  • Are appropriate error messages being displayed to users?
  • Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
  • Are unhandled exceptions being caught at the application level ?

Exception Handling

  • Are custom exceptions defined and used where appropriate?
  • Is exception handling consistent throughout the codebase?
  • Are exceptions logged with relevant context and stack trace information?
  • Are exceptions being grouped and categorized for easier analysis and resolution?

Copy link

codeclimate bot commented Oct 8, 2024

Code Climate has analyzed commit 65ba2ae and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3

View more on Code Climate.

tradesmanhelix and others added 29 commits October 25, 2024 14:39
* Add New CE REST API REST Functionality for Vet Docs

- Add feature toggle to enable/disable new functionality.

- Call REST endpoint for veteran docs when the use_ce_api feature
toggle is enabled.

- Add supporting services and specs.

* Fix Misc. Issues

- Update JsonApiResponseAdapter with latest changes to respnse
parsing found in caseflow-efolder testing.

- Update ruby_claim_evidence_api to bugfix version.

* Update received_at Date Parsing Logic

- Use slashes instead of hyphens to help JS correctly parse the
date.

* Fix Double Quote Issue

* Improve JsonApiResponseAdapter Blank Response Handling

* Pass Rails Logger to VeteranFileFetcher
* Add New CE REST API REST Functionality for Vet Docs

- Add feature toggle to enable/disable new functionality.

- Call REST endpoint for veteran docs when the use_ce_api feature
toggle is enabled.

- Add supporting services and specs.

* Fix Misc. Issues

- Update JsonApiResponseAdapter with latest changes to respnse
parsing found in caseflow-efolder testing.

- Update ruby_claim_evidence_api to bugfix version.

* Update received_at Date Parsing Logic

- Use slashes instead of hyphens to help JS correctly parse the
date.

* Fix Double Quote Issue

* add CE-API endpoint to fetch document

* Improve JsonApiResponseAdapter Blank Response Handling

* Pass Rails Logger to VeteranFileFetcher

* small fix

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>
* Add New CE REST API REST Functionality for Vet Docs

- Add feature toggle to enable/disable new functionality.

- Call REST endpoint for veteran docs when the use_ce_api feature
toggle is enabled.

- Add supporting services and specs.

* Fix Misc. Issues

- Update JsonApiResponseAdapter with latest changes to respnse
parsing found in caseflow-efolder testing.

- Update ruby_claim_evidence_api to bugfix version.

* Update received_at Date Parsing Logic

- Use slashes instead of hyphens to help JS correctly parse the
date.

* Fix Double Quote Issue

* add CE-API endpoint to fetch document

* Improve JsonApiResponseAdapter Blank Response Handling

* Pass Rails Logger to VeteranFileFetcher

* Updated Vbms Service for RestAPI

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>
Co-authored-by: Deepak <santhi.parakal@va.gov>
* Add series_id assignment to initial fetch from VBMS

* Wrap attribute assignment in feature toggle and added test case
* Allow Vet File Update via Claim Evidence API

* Update Gem Version and Get Specs Passing
- Remove curly brackets around file series IDs and update call
  to use series ID.

- Correctly format date_va_received_document string.

- Update specs.
* Move update_document Feature Flag Logic

Move to wrap call to the legacy SOAP request. Previously, the
legacy request could still be used if users called update_document
directly, but this PR closes that loophole.

* Add Subject to Doc Update
* Move update_document Feature Flag Logic

Move to wrap call to the legacy SOAP request. Previously, the
legacy request could still be used if users called update_document
directly, but this PR closes that loophole.

* Add Subject to Doc Update

* allow VeteranFileUpload to connect with CEAPI

* update response

* update specs

* fix

* add json adapter

* small fix

* Fix lint issues

* lint fix

* rubocop fix

* Updated ruby ce api gem

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* Update How Caseflow Adapts CE API Responses

* Remove Unneeded Gemfile Changes

* Reset Gemfile to Match Feature Branch

---------

Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Address issues with AWS requests failing by falling back to older
versions of some gems.
* Add Base Sensitivity Methods and Services

- Add user/veteran sensitivity methods to BGSService, borrowed
from work done for correspondence auto assignment.

- Create new service for checking the compatibility of
user/veteran sensitivity.

* Add Sensitivity Method to VBMS Service
* Add Sensitivity Checks

- Verify user/veteran sensitivity levels are compatible when
calling ExternalApi::VBMSService.fetch_document_series_for and
when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch.

* Add Class Comment

* Add Sensitivity Check Failure Handling Logic to Frontend

* Improve Comment Wording

* Add Missing Space Before Access Email
* Add Sensitivity Checks

- Verify user/veteran sensitivity levels are compatible when
calling ExternalApi::VBMSService.fetch_document_series_for and
when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch.

* Add Class Comment

* Add Sensitivity Check Failure Handling Logic to Frontend

* Improve Comment Wording

* Add Missing Space Before Access Email

* Add checks for Sensitivity level

* small fix

* update specs

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>
* Added method to fetch and verify access by vet file number

* Added spec tests and guard clause for unassosciated documents
* Update Feature Toggle Logic

- Remove references to the send_current_user_cred_to_ce_api flag
  as it is not yet implemented.

- Update sensitivity checks in vbms_service to be controlled by
  the use_ce_api feature toggle.

- Remove sensitivity checks from VbmsRequestWithFileNumber and
  child classes.

* Revert Unintended DB Schema Changes
* Add New CE REST API REST Functionality for Vet Docs (#21812)

* Add New CE REST API REST Functionality for Vet Docs

- Add feature toggle to enable/disable new functionality.

- Call REST endpoint for veteran docs when the use_ce_api feature
toggle is enabled.

- Add supporting services and specs.

* Fix Misc. Issues

- Update JsonApiResponseAdapter with latest changes to respnse
parsing found in caseflow-efolder testing.

- Update ruby_claim_evidence_api to bugfix version.

* Update received_at Date Parsing Logic

- Use slashes instead of hyphens to help JS correctly parse the
date.

* Fix Double Quote Issue

* Improve JsonApiResponseAdapter Blank Response Handling

* Pass Rails Logger to VeteranFileFetcher

* Deepak/appeals 46955 (#21865)

* Add New CE REST API REST Functionality for Vet Docs

- Add feature toggle to enable/disable new functionality.

- Call REST endpoint for veteran docs when the use_ce_api feature
toggle is enabled.

- Add supporting services and specs.

* Fix Misc. Issues

- Update JsonApiResponseAdapter with latest changes to respnse
parsing found in caseflow-efolder testing.

- Update ruby_claim_evidence_api to bugfix version.

* Update received_at Date Parsing Logic

- Use slashes instead of hyphens to help JS correctly parse the
date.

* Fix Double Quote Issue

* add CE-API endpoint to fetch document

* Improve JsonApiResponseAdapter Blank Response Handling

* Pass Rails Logger to VeteranFileFetcher

* small fix

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>

* Kev ma/appeals 46956 v1 (#21920)

* Add New CE REST API REST Functionality for Vet Docs

- Add feature toggle to enable/disable new functionality.

- Call REST endpoint for veteran docs when the use_ce_api feature
toggle is enabled.

- Add supporting services and specs.

* Fix Misc. Issues

- Update JsonApiResponseAdapter with latest changes to respnse
parsing found in caseflow-efolder testing.

- Update ruby_claim_evidence_api to bugfix version.

* Update received_at Date Parsing Logic

- Use slashes instead of hyphens to help JS correctly parse the
date.

* Fix Double Quote Issue

* add CE-API endpoint to fetch document

* Improve JsonApiResponseAdapter Blank Response Handling

* Pass Rails Logger to VeteranFileFetcher

* Updated Vbms Service for RestAPI

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>
Co-authored-by: Deepak <santhi.parakal@va.gov>

* Updated ruby_claim_evidence_api gem

* Added ClaimEvidenceApiError to rescue block (#21987)

* update result_hash (#22011)

* Fix nil Series_id for GetDocumentContent (#22038)

* Add series_id assignment to initial fetch from VBMS

* Wrap attribute assignment in feature toggle and added test case

* Allow Vet File Update via Claim Evidence API (#22194)

* Allow Vet File Update via Claim Evidence API

* Update Gem Version and Get Specs Passing

* Update Caseflow to Use Updated CE API Gem (#22272)

* Fix Misc. Issues with Caseflow Vet Doc Updates (#22301)

- Remove curly brackets around file series IDs and update call
  to use series ID.

- Correctly format date_va_received_document string.

- Update specs.

* Move update_document Feature Flag Logic (#22345)

* Move update_document Feature Flag Logic

Move to wrap call to the legacy SOAP request. Previously, the
legacy request could still be used if users called update_document
directly, but this PR closes that loophole.

* Add Subject to Doc Update

* Deepak/appeals 51312 (#22364)

* Move update_document Feature Flag Logic

Move to wrap call to the legacy SOAP request. Previously, the
legacy request could still be used if users called update_document
directly, but this PR closes that loophole.

* Add Subject to Doc Update

* allow VeteranFileUpload to connect with CEAPI

* update response

* update specs

* fix

* add json adapter

* small fix

* Fix lint issues

* lint fix

* rubocop fix

* Updated ruby ce api gem

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Updated ruby_claim_evidence_ap gem

* Update How Caseflow Adapts CE API Responses (#22395)

* Update How Caseflow Adapts CE API Responses

* Remove Unneeded Gemfile Changes

* Reset Gemfile to Match Feature Branch

---------

Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Reset Gem Versions (#22458)

Address issues with AWS requests failing by falling back to older
versions of some gems.

* Updated ruby_claim_evidence_api gem

* Create Example Sensitivity Banner (#22562)

* Add Base Sensitivity Methods and Services (#22589)

* Add Base Sensitivity Methods and Services

- Add user/veteran sensitivity methods to BGSService, borrowed
from work done for correspondence auto assignment.

- Create new service for checking the compatibility of
user/veteran sensitivity.

* Add Sensitivity Method to VBMS Service

* Add FindDocumentSeriesReference Sensitivity Checks (#22616)

* Add Sensitivity Checks

- Verify user/veteran sensitivity levels are compatible when
calling ExternalApi::VBMSService.fetch_document_series_for and
when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch.

* Add Class Comment

* Add Sensitivity Check Failure Handling Logic to Frontend

* Improve Comment Wording

* Add Missing Space Before Access Email

* Deepak/appeals 53851 (#22628)

* Add Sensitivity Checks

- Verify user/veteran sensitivity levels are compatible when
calling ExternalApi::VBMSService.fetch_document_series_for and
when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch.

* Add Class Comment

* Add Sensitivity Check Failure Handling Logic to Frontend

* Improve Comment Wording

* Add Missing Space Before Access Email

* Add checks for Sensitivity level

* small fix

* update specs

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>

* Kev ma/appeals 53862 (#22636)

* Added method to fetch and verify access by vet file number

* Added spec tests and guard clause for unassosciated documents

* Updated ruby_claim_evidence_api gem with ref

* Updated ruby_claim_evidence_api gem

* Update feature toogle to send_current_user_cred

* Update feature toogle to send_current_user_cred_to_ce_api

* Update Feature Toggle Logic (#23001)

* Update Feature Toggle Logic

- Remove references to the send_current_user_cred_to_ce_api flag
  as it is not yet implemented.

- Update sensitivity checks in vbms_service to be controlled by
  the use_ce_api feature toggle.

- Remove sensitivity checks from VbmsRequestWithFileNumber and
  child classes.

* Revert Unintended DB Schema Changes

* Update VBMSService to Pass ClaimEvidenceRequest to CE API Gem

- This change will allow the CE API gem to call the CE API using
  the css_id and station_id in the passed ClaimEvidenceRequest
  object.

- The send_current_user_cred_to_ce_api in Caseflow will control
  whether user credentials or system credentials flow the CE API
  gem.

* Update ruby_claim_evidence_api Gem

- Update gem to use changes that allow for sending user creds
  to the CE API.

* Fix Misc. Issues

- Refactor some duplicate code.

- Use branch for CE API gem in Gemfile.

---------

Co-authored-by: SanthiParakal133 <132940479+SanthiParakal133@users.noreply.github.com>
Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
Co-authored-by: Deepak <santhi.parakal@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* update unused parameter

* rubocop fix
* Updated to error object

* Fix rspec failures

* Update VBMSService to Pass ClaimEvidenceRequest to CE API Gem (#23101)

* Add New CE REST API REST Functionality for Vet Docs (#21812)

* Add New CE REST API REST Functionality for Vet Docs

- Add feature toggle to enable/disable new functionality.

- Call REST endpoint for veteran docs when the use_ce_api feature
toggle is enabled.

- Add supporting services and specs.

* Fix Misc. Issues

- Update JsonApiResponseAdapter with latest changes to respnse
parsing found in caseflow-efolder testing.

- Update ruby_claim_evidence_api to bugfix version.

* Update received_at Date Parsing Logic

- Use slashes instead of hyphens to help JS correctly parse the
date.

* Fix Double Quote Issue

* Improve JsonApiResponseAdapter Blank Response Handling

* Pass Rails Logger to VeteranFileFetcher

* Deepak/appeals 46955 (#21865)

* Add New CE REST API REST Functionality for Vet Docs

- Add feature toggle to enable/disable new functionality.

- Call REST endpoint for veteran docs when the use_ce_api feature
toggle is enabled.

- Add supporting services and specs.

* Fix Misc. Issues

- Update JsonApiResponseAdapter with latest changes to respnse
parsing found in caseflow-efolder testing.

- Update ruby_claim_evidence_api to bugfix version.

* Update received_at Date Parsing Logic

- Use slashes instead of hyphens to help JS correctly parse the
date.

* Fix Double Quote Issue

* add CE-API endpoint to fetch document

* Improve JsonApiResponseAdapter Blank Response Handling

* Pass Rails Logger to VeteranFileFetcher

* small fix

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>

* Kev ma/appeals 46956 v1 (#21920)

* Add New CE REST API REST Functionality for Vet Docs

- Add feature toggle to enable/disable new functionality.

- Call REST endpoint for veteran docs when the use_ce_api feature
toggle is enabled.

- Add supporting services and specs.

* Fix Misc. Issues

- Update JsonApiResponseAdapter with latest changes to respnse
parsing found in caseflow-efolder testing.

- Update ruby_claim_evidence_api to bugfix version.

* Update received_at Date Parsing Logic

- Use slashes instead of hyphens to help JS correctly parse the
date.

* Fix Double Quote Issue

* add CE-API endpoint to fetch document

* Improve JsonApiResponseAdapter Blank Response Handling

* Pass Rails Logger to VeteranFileFetcher

* Updated Vbms Service for RestAPI

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>
Co-authored-by: Deepak <santhi.parakal@va.gov>

* Updated ruby_claim_evidence_api gem

* Added ClaimEvidenceApiError to rescue block (#21987)

* update result_hash (#22011)

* Fix nil Series_id for GetDocumentContent (#22038)

* Add series_id assignment to initial fetch from VBMS

* Wrap attribute assignment in feature toggle and added test case

* Allow Vet File Update via Claim Evidence API (#22194)

* Allow Vet File Update via Claim Evidence API

* Update Gem Version and Get Specs Passing

* Update Caseflow to Use Updated CE API Gem (#22272)

* Fix Misc. Issues with Caseflow Vet Doc Updates (#22301)

- Remove curly brackets around file series IDs and update call
  to use series ID.

- Correctly format date_va_received_document string.

- Update specs.

* Move update_document Feature Flag Logic (#22345)

* Move update_document Feature Flag Logic

Move to wrap call to the legacy SOAP request. Previously, the
legacy request could still be used if users called update_document
directly, but this PR closes that loophole.

* Add Subject to Doc Update

* Deepak/appeals 51312 (#22364)

* Move update_document Feature Flag Logic

Move to wrap call to the legacy SOAP request. Previously, the
legacy request could still be used if users called update_document
directly, but this PR closes that loophole.

* Add Subject to Doc Update

* allow VeteranFileUpload to connect with CEAPI

* update response

* update specs

* fix

* add json adapter

* small fix

* Fix lint issues

* lint fix

* rubocop fix

* Updated ruby ce api gem

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Updated ruby_claim_evidence_ap gem

* Update How Caseflow Adapts CE API Responses (#22395)

* Update How Caseflow Adapts CE API Responses

* Remove Unneeded Gemfile Changes

* Reset Gemfile to Match Feature Branch

---------

Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Reset Gem Versions (#22458)

Address issues with AWS requests failing by falling back to older
versions of some gems.

* Updated ruby_claim_evidence_api gem

* Create Example Sensitivity Banner (#22562)

* Add Base Sensitivity Methods and Services (#22589)

* Add Base Sensitivity Methods and Services

- Add user/veteran sensitivity methods to BGSService, borrowed
from work done for correspondence auto assignment.

- Create new service for checking the compatibility of
user/veteran sensitivity.

* Add Sensitivity Method to VBMS Service

* Add FindDocumentSeriesReference Sensitivity Checks (#22616)

* Add Sensitivity Checks

- Verify user/veteran sensitivity levels are compatible when
calling ExternalApi::VBMSService.fetch_document_series_for and
when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch.

* Add Class Comment

* Add Sensitivity Check Failure Handling Logic to Frontend

* Improve Comment Wording

* Add Missing Space Before Access Email

* Deepak/appeals 53851 (#22628)

* Add Sensitivity Checks

- Verify user/veteran sensitivity levels are compatible when
calling ExternalApi::VBMSService.fetch_document_series_for and
when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch.

* Add Class Comment

* Add Sensitivity Check Failure Handling Logic to Frontend

* Improve Comment Wording

* Add Missing Space Before Access Email

* Add checks for Sensitivity level

* small fix

* update specs

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>

* Kev ma/appeals 53862 (#22636)

* Added method to fetch and verify access by vet file number

* Added spec tests and guard clause for unassosciated documents

* Updated ruby_claim_evidence_api gem with ref

* Updated ruby_claim_evidence_api gem

* Update feature toogle to send_current_user_cred

* Update feature toogle to send_current_user_cred_to_ce_api

* Update Feature Toggle Logic (#23001)

* Update Feature Toggle Logic

- Remove references to the send_current_user_cred_to_ce_api flag
  as it is not yet implemented.

- Update sensitivity checks in vbms_service to be controlled by
  the use_ce_api feature toggle.

- Remove sensitivity checks from VbmsRequestWithFileNumber and
  child classes.

* Revert Unintended DB Schema Changes

* Update VBMSService to Pass ClaimEvidenceRequest to CE API Gem

- This change will allow the CE API gem to call the CE API using
  the css_id and station_id in the passed ClaimEvidenceRequest
  object.

- The send_current_user_cred_to_ce_api in Caseflow will control
  whether user credentials or system credentials flow the CE API
  gem.

* Update ruby_claim_evidence_api Gem

- Update gem to use changes that allow for sending user creds
  to the CE API.

* Fix Misc. Issues

- Refactor some duplicate code.

- Use branch for CE API gem in Gemfile.

---------

Co-authored-by: SanthiParakal133 <132940479+SanthiParakal133@users.noreply.github.com>
Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
Co-authored-by: Deepak <santhi.parakal@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Update rspec failures

* Update for lint errors

---------

Co-authored-by: Alex Smith <alex.smith.99@thunderyard.com>
Co-authored-by: SanthiParakal133 <132940479+SanthiParakal133@users.noreply.github.com>
Co-authored-by: Deepak <santhi.parakal@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* Updated to error object

* Fix rspec failures

* Update VBMSService to Pass ClaimEvidenceRequest to CE API Gem (#23101)

* Add New CE REST API REST Functionality for Vet Docs (#21812)

* Add New CE REST API REST Functionality for Vet Docs

- Add feature toggle to enable/disable new functionality.

- Call REST endpoint for veteran docs when the use_ce_api feature
toggle is enabled.

- Add supporting services and specs.

* Fix Misc. Issues

- Update JsonApiResponseAdapter with latest changes to respnse
parsing found in caseflow-efolder testing.

- Update ruby_claim_evidence_api to bugfix version.

* Update received_at Date Parsing Logic

- Use slashes instead of hyphens to help JS correctly parse the
date.

* Fix Double Quote Issue

* Improve JsonApiResponseAdapter Blank Response Handling

* Pass Rails Logger to VeteranFileFetcher

* Deepak/appeals 46955 (#21865)

* Add New CE REST API REST Functionality for Vet Docs

- Add feature toggle to enable/disable new functionality.

- Call REST endpoint for veteran docs when the use_ce_api feature
toggle is enabled.

- Add supporting services and specs.

* Fix Misc. Issues

- Update JsonApiResponseAdapter with latest changes to respnse
parsing found in caseflow-efolder testing.

- Update ruby_claim_evidence_api to bugfix version.

* Update received_at Date Parsing Logic

- Use slashes instead of hyphens to help JS correctly parse the
date.

* Fix Double Quote Issue

* add CE-API endpoint to fetch document

* Improve JsonApiResponseAdapter Blank Response Handling

* Pass Rails Logger to VeteranFileFetcher

* small fix

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>

* Kev ma/appeals 46956 v1 (#21920)

* Add New CE REST API REST Functionality for Vet Docs

- Add feature toggle to enable/disable new functionality.

- Call REST endpoint for veteran docs when the use_ce_api feature
toggle is enabled.

- Add supporting services and specs.

* Fix Misc. Issues

- Update JsonApiResponseAdapter with latest changes to respnse
parsing found in caseflow-efolder testing.

- Update ruby_claim_evidence_api to bugfix version.

* Update received_at Date Parsing Logic

- Use slashes instead of hyphens to help JS correctly parse the
date.

* Fix Double Quote Issue

* add CE-API endpoint to fetch document

* Improve JsonApiResponseAdapter Blank Response Handling

* Pass Rails Logger to VeteranFileFetcher

* Updated Vbms Service for RestAPI

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>
Co-authored-by: Deepak <santhi.parakal@va.gov>

* Updated ruby_claim_evidence_api gem

* Added ClaimEvidenceApiError to rescue block (#21987)

* update result_hash (#22011)

* Fix nil Series_id for GetDocumentContent (#22038)

* Add series_id assignment to initial fetch from VBMS

* Wrap attribute assignment in feature toggle and added test case

* Allow Vet File Update via Claim Evidence API (#22194)

* Allow Vet File Update via Claim Evidence API

* Update Gem Version and Get Specs Passing

* Update Caseflow to Use Updated CE API Gem (#22272)

* Fix Misc. Issues with Caseflow Vet Doc Updates (#22301)

- Remove curly brackets around file series IDs and update call
  to use series ID.

- Correctly format date_va_received_document string.

- Update specs.

* Move update_document Feature Flag Logic (#22345)

* Move update_document Feature Flag Logic

Move to wrap call to the legacy SOAP request. Previously, the
legacy request could still be used if users called update_document
directly, but this PR closes that loophole.

* Add Subject to Doc Update

* Deepak/appeals 51312 (#22364)

* Move update_document Feature Flag Logic

Move to wrap call to the legacy SOAP request. Previously, the
legacy request could still be used if users called update_document
directly, but this PR closes that loophole.

* Add Subject to Doc Update

* allow VeteranFileUpload to connect with CEAPI

* update response

* update specs

* fix

* add json adapter

* small fix

* Fix lint issues

* lint fix

* rubocop fix

* Updated ruby ce api gem

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Updated ruby_claim_evidence_ap gem

* Update How Caseflow Adapts CE API Responses (#22395)

* Update How Caseflow Adapts CE API Responses

* Remove Unneeded Gemfile Changes

* Reset Gemfile to Match Feature Branch

---------

Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Reset Gem Versions (#22458)

Address issues with AWS requests failing by falling back to older
versions of some gems.

* Updated ruby_claim_evidence_api gem

* Create Example Sensitivity Banner (#22562)

* Add Base Sensitivity Methods and Services (#22589)

* Add Base Sensitivity Methods and Services

- Add user/veteran sensitivity methods to BGSService, borrowed
from work done for correspondence auto assignment.

- Create new service for checking the compatibility of
user/veteran sensitivity.

* Add Sensitivity Method to VBMS Service

* Add FindDocumentSeriesReference Sensitivity Checks (#22616)

* Add Sensitivity Checks

- Verify user/veteran sensitivity levels are compatible when
calling ExternalApi::VBMSService.fetch_document_series_for and
when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch.

* Add Class Comment

* Add Sensitivity Check Failure Handling Logic to Frontend

* Improve Comment Wording

* Add Missing Space Before Access Email

* Deepak/appeals 53851 (#22628)

* Add Sensitivity Checks

- Verify user/veteran sensitivity levels are compatible when
calling ExternalApi::VBMSService.fetch_document_series_for and
when calling ExternalApi::VbmsDocumentSeriesForAppeal.fetch.

* Add Class Comment

* Add Sensitivity Check Failure Handling Logic to Frontend

* Improve Comment Wording

* Add Missing Space Before Access Email

* Add checks for Sensitivity level

* small fix

* update specs

---------

Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>

* Kev ma/appeals 53862 (#22636)

* Added method to fetch and verify access by vet file number

* Added spec tests and guard clause for unassosciated documents

* Updated ruby_claim_evidence_api gem with ref

* Updated ruby_claim_evidence_api gem

* Update feature toogle to send_current_user_cred

* Update feature toogle to send_current_user_cred_to_ce_api

* Update Feature Toggle Logic (#23001)

* Update Feature Toggle Logic

- Remove references to the send_current_user_cred_to_ce_api flag
  as it is not yet implemented.

- Update sensitivity checks in vbms_service to be controlled by
  the use_ce_api feature toggle.

- Remove sensitivity checks from VbmsRequestWithFileNumber and
  child classes.

* Revert Unintended DB Schema Changes

* Update VBMSService to Pass ClaimEvidenceRequest to CE API Gem

- This change will allow the CE API gem to call the CE API using
  the css_id and station_id in the passed ClaimEvidenceRequest
  object.

- The send_current_user_cred_to_ce_api in Caseflow will control
  whether user credentials or system credentials flow the CE API
  gem.

* Update ruby_claim_evidence_api Gem

- Update gem to use changes that allow for sending user creds
  to the CE API.

* Fix Misc. Issues

- Refactor some duplicate code.

- Use branch for CE API gem in Gemfile.

---------

Co-authored-by: SanthiParakal133 <132940479+SanthiParakal133@users.noreply.github.com>
Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
Co-authored-by: Deepak <santhi.parakal@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Update rspec failures

* Update for lint errors

* Updated error handling

---------

Co-authored-by: Alex Smith <alex.smith.99@thunderyard.com>
Co-authored-by: SanthiParakal133 <132940479+SanthiParakal133@users.noreply.github.com>
Co-authored-by: Deepak <santhi.parakal@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* Add CE API Error Handler Class

* Add Error Handling

Update the VBMSService and SensitivityChecker clases to use the
new ClaimEvidenceApiErrorHandler service.

* Add Specs

* Fix Lint Errors and Spec Failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants