-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect Request: Vet Center QR code URL - ASAP target timing #11662
Comments
Hi @jilladams @davidconlon - we don't usually get involved in legacy content to legacy content redirects, only those that involve our modernized pages. You can move forward on this as you see fit. |
Ah, didn't realize. Thanks Mikki! |
Oops, wrong ticket. Disregard. |
Learned stuff with Dave's help:
Thusly: have opened a ServiceNow ticket for WebOps help: https://yourit.va.gov/va?id=ticket&is_new_order=true&table=incident&sys_id=47f15a951bef555018da5316624bcbe1 (And: how to do that, if needed in future) |
Unassigning / removed from sprint, since this became a VA admin thing and not a PW code thing. |
We've opened a SNOW ticket with WebOps: https://yourit.va.gov/va?id=ticket&is_new_order=true&table=incident&sys_id=47f15a951bef555018da5316624bcbe1 |
Updates: 1, I apparently didn't understand how to send a SNOW ticket to WebOps and have been asked to reassign it to WebOps. Figuring that out. 2, Meanwhile: Ryan and I re-reviewed the info around client side redirects. Some takeaways: Client-side redirect is only possible if the proxy-rewrite JS is being executed on the relevant subdomain. In the case of This means:
@ryguyk could you update points here for your best guess, assuming we go the client-side redirect route? (Including testing, and debugging if it doesn't initially work, which seems possible.) |
Merged, leaving open to get verified in prod after deploy. |
Sad news, friends @jtmst @ryguyk : This redirect isn't working. Verified that code is live in prod: https://www.vetcenter.va.gov/Vet_Centers_are_Here_For_You_24_7.asp still lands / does not forward to the new URL. Moving ticket back to Stretch, and we'll need to work out new approach. I'm gonna start by trying to figure out how to properly request something from WebOps via ServiceNow. |
Found a portal to make requests direct to WebOps instead of through ServiceNow: https://vaww.webops.va.gov/info/?get=catalog Filed a redirect request there today. Will see what sort of response we get -- guessing prob not much in this holiday week, but tbd. Have also closed loop with stakeholder who made this request, and is 2ndary contact on the WebOps ticket. Not sure if it's worth doing much more on our side here until we hear from them. |
Note: I can't find any artifact of the WebOps ticket. 🤷♀️ Didn't receive an email, and the WebOps ticketing UI did confirm successful submission, but I'm not finding any way to see my open issues. So: unclear if/when we may get traction on that. |
No news from WebOps ticket. |
New attempt: Following steps from https://vaww.webops.va.gov/apps/kbx/kbarticle.cfm?get=2018-CST-0416041924, filed a new YourIT ticket to WebOps: |
The plot thickens: WebOps responded to our ticket:
The issue was reassigned to Sandeep, our TeamSite friend. Per discussion with Jenny:
|
After auditing existing docs, I don't find any indication that the PW team can directly implement a page-level redirect between 2 subdomain URLs. (In this case: both to/from are on the vetcenter.va.gov subdomain, powered by TeamSite, that does run our proxy-rewrite js but does not currently display the injected header.) These docs seem to indicate that:
I'd feel better about that assessment if someone with a better working knowledge of reverse proxies and TICs reviewed docs #1 and #2 here to see if they agree. And if so: my suggestion would be for me to email Sandeep Kotian, Brad Smelley, and Jenny H-L on the existing email thread with Tiffany Lever / Dave / @wesrowe to figure out how TeamSite folks can / can't help us. Existing redirect documentation1. Redirects
Describes 3 types of redirect:
2. Redirect Implementation Strategy
4 types of redirects:
3. Redirects Strategy Suggestion
Doc #2, Redirect Implementation Strategy, specifically notes that it replaces this doc. 4. Redirects
IA doc specific to requesting a redirect & vetting it. 5. Client-side and service-side redirect implementation process for Public Websites team
Mostly an outdated workflow doc for an old PW team, that is replaced by doc #4 above, and should be updated or removed. 6. Client-side-redirects
Stub doc with no details, should be deleted. Other relevant docsReverse Proxy documentation
Docs to dos
|
@apisandipas @ryguyk FYI: Latest change in PR #23065 is merged / deployed, and redirect is still not working. Not urgent, as Dave has asked us to timebox this since it has sprawled. Maybe next week at onsite we can briefly chat at some point about how redirects and regroup. |
S76 sprint planning: the work to date has not successfully implemented a subdomain > subdomain redirect.
Per conversation with DaveC: we aren't able to spend more time on this right now. Low priority for this path, so we will not continue work here. We'll discuss next steps at the higher level subdomain > subdomain redirect level with DaveC and I'll close loop with the original requester, Tiffany, after that talk. Closing ticket. |
BLOCKED on WebOps: for subdomain > subdomain redirect, our attempted code change did not work. We will need WebOps to perform this redirect. WebOps ticket opened, TBD response.
Type of request
Context
From Tiffany Lever via email to DaveC:
Implementation date
When does this request need to be live:
no hard timingASAP since fix for incorrect link in the wildRedirects
FE Implementation notes
This will need to be done via client side redirect.
Process, Roles and Responsibilities
The text was updated successfully, but these errors were encountered: