Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11662 - redirect to subdomain redirect match destination #23065

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

apisandipas
Copy link
Contributor

Summary

This PR makes adjustments to client-side redirect logic to ensure subdomain redirects go to their intended destination

Related issue(s)

Testing done

None, will need to be validated in production.

What areas of the site does it impact?

  • This will only effect redirects between two subdomains.

Acceptance criteria

  • [n/a] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • [n/a] Events are being sent to the appropriate logging solution
  • [n/a] Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • [n/a] Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • [n/a] If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • [n/a] I added a screenshot of the developed feature

Requested Feedback

Needs to be validated in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants