Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC prototype | Add MST info to intro #31416

Merged
merged 1 commit into from
Aug 15, 2024
Merged

SC prototype | Add MST info to intro #31416

merged 1 commit into from
Aug 15, 2024

Conversation

Mottie
Copy link
Contributor

@Mottie Mottie commented Aug 15, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to Summary and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • (Summarize the changes that have been made to the platform)

    Adding military sexual trauma (MST) information to the Supplemental Claim

  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution)
  • (Which team do you work for, does your team own the maintenance of this component?)
  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results

    No unit or e2e tests for this prototype

  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Intro Current content at bottom of SC intro page New SC intro page content with military sexual trauma information

What areas of the site does it impact?

Supplemental Claim prototype

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link

@shaunburdick shaunburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Mottie Mottie merged commit 2be061a into main Aug 15, 2024
78 of 79 checks passed
@Mottie Mottie deleted the 90568-sc-mst branch August 15, 2024 18:02
gabezurita added a commit that referenced this pull request Aug 15, 2024
* main:
  [SIMPLE-FORMS] feat: add accordion to new confirmation page (#31325)
  MHV-60214: Landing page typo (#31425)
  Remove pattern validation for service number (#31417)
  Update URL for 'Enrollment Manager FAQs' (#31371)
  Add MST info to SC intro (#31416)
  Add SC housing & living situation questions (#31391)
  SC prototype | Update beginning pages (#31354)
  Prevent multiple TOU requests (#31347)
  Add trace logging to unit test stability workflow (#31421)
  90728 Combine street text fields in submit transformer - forms 10-7959c, 10-7959a (#31404)
  updated confirmation page: (#31394)
  #89775: Update transformer to pull modality for appointment from the preferredModality field [VA Requests] (#31380)
  VAGOV-TEAM-89918: Create Form Config object from normalized input (#31296)
  Add features flags for upcoming HCA initiatives (#31420)
  Fixes flaky medications unit test (#31422)
  added address line 3 and address line 4 to UI (#31423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants