Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pattern validation for service number #31417

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Aug 15, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to Summary and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Summary

Removes the pattern validation for Pensions service number to allow both the old format for service number and SSN.

Related issue(s)

Testing done

  • Navigate to the service branches page in Pensions
  • Add any string in the service number field and confirm it's accepted

Screenshots

Screenshot 2024-08-14 at 4 59 05 PM Screenshot 2024-08-14 at 4 59 25 PM

What areas of the site does it impact?

Pensions

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@mjknight50 mjknight50 marked this pull request as ready for review August 15, 2024 18:21
@mjknight50 mjknight50 requested review from a team as code owners August 15, 2024 18:21
Copy link
Contributor

@mjknight50 mjknight50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@TaiWilkin TaiWilkin merged commit 015854e into main Aug 15, 2024
85 checks passed
@TaiWilkin TaiWilkin deleted the pensions-90673-service-number branch August 15, 2024 18:41
gabezurita added a commit that referenced this pull request Aug 15, 2024
* main:
  [SIMPLE-FORMS] feat: add accordion to new confirmation page (#31325)
  MHV-60214: Landing page typo (#31425)
  Remove pattern validation for service number (#31417)
  Update URL for 'Enrollment Manager FAQs' (#31371)
  Add MST info to SC intro (#31416)
  Add SC housing & living situation questions (#31391)
  SC prototype | Update beginning pages (#31354)
  Prevent multiple TOU requests (#31347)
  Add trace logging to unit test stability workflow (#31421)
  90728 Combine street text fields in submit transformer - forms 10-7959c, 10-7959a (#31404)
  updated confirmation page: (#31394)
  #89775: Update transformer to pull modality for appointment from the preferredModality field [VA Requests] (#31380)
  VAGOV-TEAM-89918: Create Form Config object from normalized input (#31296)
  Add features flags for upcoming HCA initiatives (#31420)
  Fixes flaky medications unit test (#31422)
  added address line 3 and address line 4 to UI (#31423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants