VAGOV-TEAM-90731: add ombinfo prop

[derekhouck]

Are you removing, renaming or moving a folder in this PR?

• No, I'm not changing any folders (skip to Summary and delete the rest of this section)
• Yes, I'm removing, renaming or moving a folder

Summary

• Extracts the normalized ombInfo section created by VATEAM-90733: Normalize OMB info fields content-build#2252 from fetched form data and inserts it into the IntroductionPage component.

Related issue(s)

• Add ombInfo prop to rendered Element in App.jsx va.gov-team#90731

Testing done

• New unit tests for the ombInfo action and reducer.
• New unit tests for the app's new root reducer.
• New unit tests for the IntroductionPage container.
• Updated tests for the form-load reducer and the App container.
• Local testing using mock data.

Screenshots

Local host rendering a mock form with dynamic OMB Info data:

What areas of the site does it impact?

This PR only touches the form-renderer application, which is not yet live.

Acceptance criteria

Quality Assurance & Testing

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Linting warnings have been addressed
• Documentation has been updated (link to documentation *if necessary)
• Screenshot of the developed feature is added
• Accessibility testing has been performed

Error Handling

• Browser console contains no warnings or errors.
• Events are being sent to the appropriate logging solution
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

• Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

Due to our use of createRoutesWithSaveInProgress to create our child routes, I could not easily pass along data outside of formConfig to the IntroductionPage component as props. Instead, I loaded it into our Redux store and pulled from that. This is relevant to future work, as we will eventually want to customize both IntroductionPage and ConfirmationPage more thoroughly on a per-form basis. Neither of these components required access to the Redux store before this PR, so continuing on in this direction will make both components more complex.

[ryguyk]

First off, beautiful code. This is really well written, organized, etc.

I wonder, though, if this code is implementing the cleanest approach. It feels a bit odd to me to treat the loading (and storage via Redux) of the OMB info in a manner that is isolated from the rest of the form data that is loaded and subsequently converted into a formConfig object.

This code snippet, specifically, feels like it should already be doing what we want to do:

// src/applications/form-renderer/utils/formConfig.js (before)

const formConfig = createFormConfig(form);

dispatch(formLoadingSucceeded(formConfig));

It feels odd to have to also call a dispatch for OMB-specific info:

// src/applications/form-renderer/utils/formConfig.js (proposed change)

const formConfig = createFormConfig(form);

dispatch(ombInfoLoaded(form.ombInfo));
dispatch(formLoadingSucceeded(formConfig));

It'd be great if the formConfig object would already encapsulate the needed OMB info so that we wouldn't need to introduce it separately on the Redux store. I think we can do that:

// src/applications/form-renderer/utils/formConfig.js (createFormConfig function)
return {
    ...
    introduction: props => (
      <IntroductionPage {...props} ombInfo={ombInfo} />
    ),
    ...
}

If we need to abstract this behavior for reuse, we could create a higher-order component:

const withProps = (WrappedComponent, additionalProps) => {
    return (props) => <WrappedComponent {...props} {...additionalProps} />;
};

I'm certainly open to other thoughts on this. Perhaps we can discuss.

[ryguyk]

This feels odd to me. See more general discussion.

TL;DR it seems like loading OMB info should be part of loading the other form data.

[ryguyk]

Again, see more general discussion. It feels a bit odd to have the OMB data treated separately from the rest of the form data.

[derekhouck]

// src/applications/form-renderer/utils/formConfig.js (createFormConfig function)
return {
    ...
    introduction: props => (
      <IntroductionPage {...props} ombInfo={ombInfo} />
    ),
    ...
}

• Yes, this would be a lot simpler and cleaner. Never even occurred to me. After I finish the revisions on VATEAM-90733: Normalize OMB info fields content-build#2252, I'll give this a stab and verify the props get successfully passed through using this method. I appreciate the insight.

[ryguyk]

Nice work!

[ryguyk]

I approved, but I did add two small comments after doing so. I don't consider them significant enough to block approval, but they are worth considering, perhaps.