Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#vebt-470 #comment Removed constants for 22-1990N #31843

Merged
merged 5 commits into from
Sep 16, 2024
Merged

#vebt-470 #comment Removed constants for 22-1990N #31843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f96480f
#vebt-470 #comment Removed constants for 22-1990N
Sep 9, 2024
e3ce515
#vebt-470 #comment Attempt to resolve merge conflicts
Sep 11, 2024
bf4a01e
Merge branch 'main' into vebt-470
govcioChad Sep 11, 2024
bed756f
Merge branch 'main' into vebt-470
govcioChad Sep 11, 2024
5ed9edd
Merge branch 'main' into vebt-470
govcioChad Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/applications/edu-benefits/1990n/config/form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,20 @@

import fullSchema1990n from 'vets-json-schema/dist/22-1990N-schema.json';

import schoolSelectionPage, {
schoolSelectionOptionsFor,
} from '../../pages/schoolSelection';
import applicantInformationPage from 'platform/forms/pages/applicantInformation';
import FormFooter from 'platform/forms/components/FormFooter';
import environment from 'platform/utilities/environment';
import preSubmitInfo from 'platform/forms/preSubmitInfo';
import schoolSelectionPage, {
schoolSelectionOptionsFor,
} from '../../pages/schoolSelection';
import GetFormHelp from '../../components/GetFormHelp';
import ErrorText from '../../components/ErrorText';
import additionalBenefitsPage from '../../pages/additionalBenefits';
import contactInformationPage from '../../pages/contactInformation';
import createDirectDepositPage from '../../pages/directDeposit';
import preSubmitInfo from 'platform/forms/preSubmitInfo';
import { VA_FORM_IDS } from 'platform/forms/constants';

import * as toursOfDuty from '../../definitions/toursOfDuty.jsx';

Check warning on line 18 in src/applications/edu-benefits/1990n/config/form.js

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/edu-benefits/1990n/config/form.js:18:30:Unexpected use of file extension "jsx" for "../../definitions/toursOfDuty.jsx"

import IntroductionPage from '../containers/IntroductionPage';
import ConfirmationPage from '../containers/ConfirmationPage';
Expand All @@ -36,7 +35,7 @@
urlPrefix: '/',
submitUrl: `${environment.API_URL}/v0/education_benefits_claims/1990n`,
trackingPrefix: 'edu-1990n-',
formId: VA_FORM_IDS.FORM_22_1990N,
formId: '22-1990N',
saveInProgress: {
messages: {
inProgress:
Expand Down
1 change: 0 additions & 1 deletion src/applications/edu-benefits/components/createEducationApplicationStatus.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ const eduForms = new Set([
VA_FORM_IDS.FORM_22_1995,
VA_FORM_IDS.FORM_22_5490,
VA_FORM_IDS.FORM_22_5495,
VA_FORM_IDS.FORM_22_1990N,
]);

export default function createEducationApplicationStatus(store, widgetType) {
Expand Down
9 changes: 0 additions & 9 deletions src/platform/forms/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ export const VA_FORM_IDS = Object.freeze({
FORM_22_1990: '22-1990',
FORM_22_1990EMEB: '22-1990EMEB',
FORM_22_1990EZ: '22-1990EZ',
FORM_22_1990N: '22-1990N',
FORM_22_1995: '22-1995',
FORM_22_1995S: '22-1995S',
FORM_22_5490: '22-5490',
Expand Down Expand Up @@ -141,7 +140,6 @@ export const getAllFormLinks = getAppUrlImpl => {
[VA_FORM_IDS.FORM_22_10203]: `${tryGetAppUrl('10203-edu-benefits')}/`,
[VA_FORM_IDS.FORM_22_1990]: `${tryGetAppUrl('1990-edu-benefits')}/`,
[VA_FORM_IDS.FORM_22_1990EZ]: `${tryGetAppUrl('1990ez-edu-benefits')}/`,
[VA_FORM_IDS.FORM_22_1990N]: `${tryGetAppUrl('1990n-edu-benefits')}/`,
[VA_FORM_IDS.FORM_22_1995]: `${tryGetAppUrl('1995-edu-benefits')}/`,
[VA_FORM_IDS.FORM_22_5490]: `${tryGetAppUrl('5490-edu-benefits')}/`,
[VA_FORM_IDS.FORM_22_5495]: `${tryGetAppUrl('5495-edu-benefits')}/`,
Expand Down Expand Up @@ -307,13 +305,6 @@ export const MY_VA_SIP_FORMS = [
description: 'education benefits application (22-1990EZ)',
trackingPrefix: 'edu-1990ez-',
},
{
id: VA_FORM_IDS.FORM_22_1990N,
benefit: 'education benefits',
title: 'education benefits (22-1990N)',
description: 'education benefits application (22-1990N)',
trackingPrefix: 'edu-1990n-',
},
{
id: VA_FORM_IDS.FORM_22_1995,
benefit: 'education benefits',
Expand Down
Loading