Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#vebt-470 #comment Removed constants for 22-1990N #31843

Merged
merged 5 commits into from
Sep 16, 2024
Merged

#vebt-470 #comment Removed constants for 22-1990N #31843

merged 5 commits into from
Sep 16, 2024

Conversation

govcioChad
Copy link
Contributor

@govcioChad govcioChad commented Sep 9, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to Summary and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).

If an entry for this folder exists in content-build and you are:

  1. Deleting a folder:

    1. First search vets-website for all instances of the entryName in your manifest.json and remove them in a separate PR. Look particularly for references in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js. If you do not do this, other applications will break!
      • Add the link to your merged vets-website PR here
    2. Then, Delete the application entry in registry.json and merge that PR before this one
  2. Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

- (Summarize the changes that have been made to the platform)

  • Removing all instances of entryName for 22-1990N form
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution)
  • (Which team do you work for, does your team own the maintenance of this component?)
  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

Jira -> https://jira.devops.va.gov/browse/VEBT-470

As a...

VEBT developer

I want...

all references to the GovCIO version of 22-1990n from the va.gov code base

So that...

we can get rid of some tech debt

Acceptance Criteria:

GovCIO EDU form 22-1990n no longer exists in the code base
Remove everywhere

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@govcioChad govcioChad marked this pull request as ready for review September 9, 2024 17:08
@govcioChad govcioChad requested review from a team as code owners September 9, 2024 17:08
@va-vfs-bot va-vfs-bot temporarily deployed to master/vebt-470/vebt-470 September 9, 2024 18:50 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/vebt-470/vebt-470 September 11, 2024 16:24 Inactive
@govcioChad govcioChad merged commit d88e013 into main Sep 16, 2024
84 checks passed
@govcioChad govcioChad deleted the vebt-470 branch September 16, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants