Skip to content

Commit

Permalink
Bundler native helpers should not run in a frozen context (#8419)
Browse files Browse the repository at this point in the history
  • Loading branch information
deivid-rodriguez committed Nov 20, 2023
1 parent 8283b0e commit aad7489
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions bundler/helpers/v1/lib/functions.rb
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,9 @@ def self.set_bundler_flags_and_credentials(dir:, credentials:)

# Use HTTPS for GitHub if lockfile
Bundler.settings.set_command_option("github.https", "true")

# Native helpers rely on dependency unlocking, so Bundler should never be frozen
Bundler.settings.set_command_option("frozen", "false")
end

def self.relevant_credentials(credentials)
Expand Down
3 changes: 3 additions & 0 deletions bundler/helpers/v2/lib/functions.rb
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,9 @@ def self.set_bundler_flags_and_credentials(dir:, credentials:)
Bundler.ui = Bundler::UI::Silent.new

Bundler.settings.set_command_option("forget_cli_options", "true")

# Native helpers rely on dependency unlocking, so Bundler should never be frozen
Bundler.settings.set_command_option("frozen", "false")
end

def self.relevant_credentials(credentials)
Expand Down

0 comments on commit aad7489

Please sign in to comment.