Bundler native helpers should not run in a frozen context #8419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulapopoola
approved these changes
Nov 16, 2023
deivid-rodriguez
force-pushed
the
bundler-native-helpers-not-frozen
branch
from
14368c1
to
5a97e92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #8138, I realized that our Bundler native helpers in production are running with the
frozensetting set totrue, because that's what it's set in the updater image as configuration:dependabot-core/Dockerfile.updater-core
Line 118 in 7e90f1c
Our native helper specs don't catch this, because they don't run in the context of the
updaterdirectory/Gemfile, so thefrozensetting is not visible, but they do fail when they start running in the context of theupdaterdirectory/Gemfile. That was surfaced by the changes in #8138.