Actions: skip unsupported uses strings #8026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulapopoola
approved these changes
Sep 13, 2023
landongrindheim
approved these changes
Sep 13, 2023
github_actions/spec/dependabot/github_actions/file_parser_spec.rb
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where if you name the local reusable workflow with an
@then the path is parsed wrong.For example with
./.github/workflows/test.yml@v2.1.0. The code expects either<owner>/<repo>@<version>or./.github/<path>, but this parsed as./.github/<path>@<version>which is wrong since the@v2.1.0is just a part of the path. Thus we ended up with a dependency ofowner: '.github'which broke the update when fetching the remote file.Since we currently don't support updating the dependencies of local paths in this way, and also we don't support updating
docker://workflows either, I'm explicitly skipping them for now to avoid any other latent issues.Conveniently there was a TODO that I could put this skip right after 😄.