Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: skip unsupported uses strings #8026

Merged
merged 4 commits into from
Sep 13, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ def workfile_file_dependencies(file)

uses_strings.each do |string|
# TODO: Support Docker references and path references
next if string.start_with?(".", "docker://")
next unless string.match?(GITHUB_REPO_REFERENCE)

dep = build_github_dependency(file, string)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,14 @@ def mock_service_pack_request(nwo)
end
end

describe "with a local reusable workflow that has an @ in the file name" do
let(:workflow_file_fixture_name) { "local_workflow_with_at.yml" }
jakecoffman marked this conversation as resolved.
Show resolved Hide resolved

it "does not treat the path like a dependency" do
expect(dependencies).to eq([])
end
end

describe "with composite actions" do
let(:workflow_file_fixture_name) { "composite_action.yml" }
let(:workflow_files) do
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
on:
pull_request:

jobs:
test:
uses: ./.github/workflows/test.yml@v2.1.0
Loading