Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundler native helpers should not run in a frozen context #8419

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Bundler native helpers should not run in a frozen context #8419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bundler/helpers/v1/lib/functions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,9 @@ def self.set_bundler_flags_and_credentials(dir:, credentials:)

# Use HTTPS for GitHub if lockfile
Bundler.settings.set_command_option("github.https", "true")

# Native helpers rely on dependency unlocking, so Bundler should never be frozen
Bundler.settings.set_command_option("frozen", "false")
end

def self.relevant_credentials(credentials)
Expand Down
3 changes: 3 additions & 0 deletions bundler/helpers/v2/lib/functions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,9 @@ def self.set_bundler_flags_and_credentials(dir:, credentials:)
Bundler.ui = Bundler::UI::Silent.new

Bundler.settings.set_command_option("forget_cli_options", "true")

# Native helpers rely on dependency unlocking, so Bundler should never be frozen
Bundler.settings.set_command_option("frozen", "false")
end

def self.relevant_credentials(credentials)
Expand Down