Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strictly type GitMetadataFetcher #8441

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Strictly type GitMetadataFetcher #8441

merged 5 commits into from
Nov 27, 2023

Conversation

JamieMagee
Copy link
Contributor

No description provided.

@JamieMagee JamieMagee requested a review from a team as a code owner November 20, 2023 06:02
@JamieMagee JamieMagee force-pushed the jamiemagee/strict-type-git-metadata-fetcher branch from af13c8b to ce5d36b Compare November 20, 2023 20:22
honeyankit
honeyankit approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@honeyankit honeyankit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the implementation of the GitRef class!

@jakecoffman jakecoffman merged commit 0191616 into main Nov 27, 2023
81 checks passed
@jakecoffman jakecoffman deleted the jamiemagee/strict-type-git-metadata-fetcher branch November 27, 2023 16:45
@deivid-rodriguez deivid-rodriguez mentioned this pull request Nov 27, 2023
Merged
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honeyankit honeyankit honeyankit approved these changes

@jakecoffman jakecoffman Awaiting requested review from jakecoffman

Assignees
No one assigned
Labels
sorbet 🍦 Relates to Sorbet types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamieMagee @honeyankit @jakecoffman