Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type issues detected in GitHub Actions ecosystem #8472

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

deivid-rodriguez
Copy link
Contributor

After deploying #8441, I saw this new error:

Parameter 'ref': Expected type String, got type NilClass
Caller: /home/dependabot/common/lib/dependabot/git_commit_checker.rb:98
Definition: /home/dependabot/common/lib/dependabot/git_metadata_fetcher.rb:71

I think this should fix the culprit.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner November 27, 2023 20:16
@github-actions github-actions bot added the L: github:actions GitHub Actions label Nov 27, 2023
This would be the case when user is pinning an action to an "orphaned"
commit. In this case, no update is possible, so just return nil as the
latest version.
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/find-container-branch-not-nil branch from 92200d7 to 84b2fcb Compare November 28, 2023 12:54
@deivid-rodriguez deivid-rodriguez merged commit 8ab9e8f into main Nov 28, 2023
81 checks passed
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/find-container-branch-not-nil branch November 28, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: github:actions GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants