Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add numAffectedRows @ PlanetScaleConnection.executeQuery. #8

Merged

Conversation

igalklebanov
Copy link
Contributor

@igalklebanov igalklebanov commented Dec 10, 2022

aligns with kysely-org/kysely#188 (not released yet)

QueryResult.numUpdatedOrDeletedRows is being deprecated in next kysely release, and will be removed in the future. It is being replaced with QueryResult.numAffectedRows for reasons discussed in linked pull request.

@igalklebanov igalklebanov marked this pull request as ready for review December 10, 2022 16:11
Copy link
Member

@jacobwgillespie jacobwgillespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much for this! 🎉

@jacobwgillespie jacobwgillespie merged commit 46e7589 into depot:main Dec 10, 2022
@igalklebanov igalklebanov deleted the support-future-query-result-changes branch December 10, 2022 16:19
@jacobwgillespie
Copy link
Member

This has been released as v1.2.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants