-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add numInsertedOrUpdatedRows
to InsertResult
.
#188
Merged
koskimas
merged 17 commits into
kysely-org:master
from
igalklebanov:add-affected-rows-to-insert-result
Dec 10, 2022
Merged
add numInsertedOrUpdatedRows
to InsertResult
.
#188
koskimas
merged 17 commits into
kysely-org:master
from
igalklebanov:add-affected-rows-to-insert-result
Dec 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalklebanov
added
enhancement
New feature or request
api
Related to library's API
labels
Oct 9, 2022
igalklebanov
changed the title
add affected rows to InsertResult.
add Oct 18, 2022
numUpdatedOrDeletedRows
to InsertResult
.
igalklebanov
changed the title
add
add Oct 19, 2022
numUpdatedOrDeletedRows
to InsertResult
.numInsertedOrUpdatedRows
to InsertResult
.
koskimas
reviewed
Nov 1, 2022
koskimas
reviewed
Nov 1, 2022
koskimas
reviewed
Nov 1, 2022
|
koskimas
reviewed
Nov 5, 2022
koskimas
force-pushed
the
add-affected-rows-to-insert-result
branch
from
December 10, 2022 09:34
c360c94
to
7935c7e
Compare
koskimas
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
Related to library's API
bug
Something isn't working
deprecation
Something is/should be deprecated
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
QueryResult.numUpdatedOrDeletedRows
and addQueryResult.numAffectedRows
.InsertResult
.- [ ] typings tests.tests forInsertResult
already in place.On MySQL, this field lets consumers know whether an
insert...on duplicate key update
query inserted OR updated some records. Real world scenario, publishing an event following the query, "entity {created | updated}".The field is also relevant to inserts in Postgres..
Things to consider:
Feels like
QueryResult
'snumUpdatedOrDeletedRows
should be renamed tonumAffectedRows
, which is more readable, neutral and aligned with MySQL terminology.Stopped myself from doing this change as it'll break 3rd party drivers.