Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Silence/Resolve Clippy lints + reformat + CI work #36

Closed
wants to merge 6 commits into from

Conversation

duesee
Copy link
Contributor

@duesee duesee commented Nov 28, 2023

This makes rustfmt and Clippy happy. I believe that the added allows are apppropriate. But better to be careful :-)

Also, I'm trying to resolve a few CI issues: Here, we need to agree how to resolve the dependency issues (explained below).

Further, cargo test (w/o) --workspace failed but CI was happy. This is, I believe, because --workspace pulls in additional dependencies. Thus, the examples in the doc failed because provider is not a default feature. And in CI, we always test with --workspace. cargo-hack is maybe worth a try.

@duesee
Copy link
Contributor Author

duesee commented Nov 28, 2023

  • Clippy
  • Rustfmt
  • Rust 1.61.0: package which v4.4.2 cannot be built because it requires rustc 1.63 or newer, while the currently active rustc version is 1.61.0
    • Not sure how to proceed here. Increase MSRV? Downgrade which?
  • minimal-versions: error: package regex-automata v0.4.3 cannot be built because it requires rustc 1.65 or newer, while the currently active rustc version is 1.61.0
    • Not sure how to proceed here. Increase MSRV? Downgrade regex-automata?
  • test/{beta,nightly]: unused import: MechanismErrorKind
    • Not sure what happens here... investigating.

@duesee
Copy link
Contributor Author

duesee commented Nov 28, 2023

I'll need your advice here, @dequbed. I'll try to figure out what's up with the unused imports. But I think you need to tell me how to proceed with MSRV.

$ cargo tree
rsasl v2.0.1
(...)
├── libgssapi v0.6.4
(...)
│       [build-dependencies]
│       └── bindgen v0.64.0
(...)
│           ├── regex v1.10.2
│           │   ├── regex-automata v0.4.3
│           │   │   └── regex-syntax v0.8.2
(...)
│           └── which v4.2.2
│               ├── either v1.6.0
│               └── libc v0.2.95
(...)

@duesee duesee changed the title chore: Silence/Resolve Clippy lints + reformat chore: Silence/Resolve Clippy lints + reformat + CI work Nov 28, 2023
@duesee duesee force-pushed the duesee_chore branch 2 times, most recently from 0ae994a to 1a17651 Compare December 4, 2023 21:39
dequbed added a commit that referenced this pull request Aug 10, 2024
Hello 👋 

[This advisory](GHSA-x4mq-m75f-mx8m) has
been bothering me since a while.
The origin of it is
[`acid_io`](https://github.com/dataphract/acid_io/blob/v0.1.0/Cargo.toml#L28),
where the [issue has been
fixed](dataphract/acid_io#21), but no release
has been publish 😞 (since 3 years!)

So, after reading this
[discussion/issue](rust-lang/rust#48331), I
decided to replace `acid_io` for
[`core2`](https://crates.io/crates/core2) (which seems quite used, even
if the last release was 2 years ago).

The changes was trivial as `acid_io` and `core2::io` have the same API
as `std::io`. But, while trying to test those changes, the CI failed
(which was also the case [`last
week`](https://github.com/dequbed/rsasl/actions/runs/8870496836)). So I
started to fix the CI, and made changes to make the CI pass.

I also added a `dependabot.yaml`, PR will be created monthly to update
the dependencies in the `Cargo.toml` and `ci.yml`.

I formatted the `README.md` and `Cargo.toml`.

I had to bump MSRV to 1.65.

I bumped the dependencies to their latest versions, and pushed the
`Cargo.lock`, see
[`why`](https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control).

And I ran `cargo clippy --fix` and `cargo fmt`, with not much
modification from myself.



I just finished to write the description of this PR and realize that
someone was working on #36, oops
@duesee duesee closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant