-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace acid_io
by core2
#40
Replace acid_io
by core2
#40
Conversation
Don't worry! As far as I remember, I wasn"t sure how to proceed with the PR. If you know how, please feel free to take anything you need from it (or not :-)). Can also be closed should it be/get outdated. Not much time to work on it currently :-( |
close #37 |
I managed to make all the CI job pass, i also added a Feel free to edit/push on this branch if you are not satisfied with some changes |
Thanks @Mathieu-Lala for this PR! |
Hello 👋
This advisory has been bothering me since a while.
The origin of it is
acid_io
, where the issue has been fixed, but no release has been publish 😞 (since 3 years!)So, after reading this discussion/issue, I decided to replace
acid_io
forcore2
(which seems quite used, even if the last release was 2 years ago).The changes was trivial as
acid_io
andcore2::io
have the same API asstd::io
. But, while trying to test those changes, the CI failed (which was also the caselast week
). So I started to fix the CI, and made changes to make the CI pass.I also added a
dependabot.yaml
, PR will be created monthly to update the dependencies in theCargo.toml
andci.yml
.I formatted the
README.md
andCargo.toml
.I had to bump MSRV to 1.65.
I bumped the dependencies to their latest versions, and pushed the
Cargo.lock
, seewhy
.And I ran
cargo clippy --fix
andcargo fmt
, with not much modification from myself.I just finished to write the description of this PR and realize that someone was working on #36, oops