Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace acid_io by core2 #40

Merged
merged 25 commits into from
Aug 10, 2024

Conversation

Mathieu-Lala
Copy link
Contributor

@Mathieu-Lala Mathieu-Lala commented May 6, 2024

Hello 👋

This advisory has been bothering me since a while.
The origin of it is acid_io, where the issue has been fixed, but no release has been publish 😞 (since 3 years!)

So, after reading this discussion/issue, I decided to replace acid_io for core2 (which seems quite used, even if the last release was 2 years ago).

The changes was trivial as acid_io and core2::io have the same API as std::io. But, while trying to test those changes, the CI failed (which was also the case last week). So I started to fix the CI, and made changes to make the CI pass.

I also added a dependabot.yaml, PR will be created monthly to update the dependencies in the Cargo.toml and ci.yml.

I formatted the README.md and Cargo.toml.

I had to bump MSRV to 1.65.

I bumped the dependencies to their latest versions, and pushed the Cargo.lock, see why.

And I ran cargo clippy --fix and cargo fmt, with not much modification from myself.

I just finished to write the description of this PR and realize that someone was working on #36, oops

@duesee
Copy link
Contributor

duesee commented May 19, 2024

I just finished to write the description of this PR and realize that someone was working on #36, oops

Don't worry! As far as I remember, I wasn"t sure how to proceed with the PR. If you know how, please feel free to take anything you need from it (or not :-)). Can also be closed should it be/get outdated. Not much time to work on it currently :-(

@Mathieu-Lala
Copy link
Contributor Author

close #37

@Mathieu-Lala
Copy link
Contributor Author

I managed to make all the CI job pass, i also added a docs and spellcheck jobs.

Feel free to edit/push on this branch if you are not satisfied with some changes

@Mathieu-Lala Mathieu-Lala marked this pull request as ready for review May 20, 2024 15:32
@dequbed
Copy link
Owner

dequbed commented Aug 10, 2024

Thanks @Mathieu-Lala for this PR!
I'm not perfectly clear if the lifetimes chances are correct (in the correctness despite unsafe meaning), but given they (seem to) fix #41 I'm going to merge this first and add some tests later making sure they also keep API for semver. :)

@dequbed dequbed merged commit 299114f into dequbed:development Aug 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants