Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update internal-link-present-evaluate to work with virtualNodes #2466

Closed
straker opened this issue Aug 20, 2020 · 5 comments
Closed

Update internal-link-present-evaluate to work with virtualNodes #2466

straker opened this issue Aug 20, 2020 · 5 comments
Labels
good first issue For first-time contributors pr A pr has been created for the issue
Milestone
Axe-core 4.5

Comments

@straker
Copy link
Contributor

straker commented Aug 20, 2020 •
edited
Loading

The internal-link-present-evaluate function should work with virtualNode rather than actualNode. Update the regexp test to use virtual-node methods to get the attribute.

You'll also need to update the tests to pass the virtual node rather than just the node.

See non-empty-if-presenet-evaluate and its test file as an example.
@straker straker added the good first issue For first-time contributors label Aug 20, 2020
@anuk79
Copy link
Contributor

anuk79 commented Sep 3, 2020

@straker May I pick this one if no one else is working on it?

@straker
Copy link
Contributor Author

straker commented Sep 3, 2020

Sure thing, all yours.

@straker straker added the hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/ label Oct 1, 2020
@straker
Copy link
Contributor Author

straker commented Dec 23, 2020

@anuk79 any update on working on this? If not I'll probably pick it up.

@anuk79
Copy link
Contributor

anuk79 commented Dec 24, 2020

Hi @straker sorry I couldn't pick it up. You can reassign

@dylanb dylanb removed the hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/ label Mar 12, 2021
dan-tripp added a commit to dan-tripp/axe-core that referenced this issue Aug 20, 2021
@dan-tripp
refactor(checks/navigation): improve internal-link-present-evaluate
2467b3a 
Make `internal-link-present-evaluate` work with virtualNode rather than actualNode.

Closes issue dequelabs#2466
@dan-tripp dan-tripp mentioned this issue Aug 20, 2021
Merged
@dan-tripp
Copy link
Contributor

Hello. I'm new here. Figured I'd try this 'good first issue'. I submitted a PR for it. Is it useful?

straker pushed a commit that referenced this issue Aug 31, 2021
@dan-tripp
refactor(checks/navigation): improve internal-link-present-evaluate (…
035c148 
…#3128)

Make `internal-link-present-evaluate` work with virtualNode rather than actualNode.

Closes issue #2466
straker added a commit that referenced this issue Nov 4, 2021
@dan-tripp @straker
fix(nested-interactive): add message for negative tabindex (#3194)
b445291 
* refactor(checks/navigation): improve `internal-link-present-evaluate`

Make `internal-link-present-evaluate` work with virtualNode rather than actualNode.

Closes issue #2466

* test commit 1

* test commit 2

* test commit 3

* Revert "Merge branch 'dan-test-branch-1' into develop"

This reverts commit 428e015, reversing
changes made to 9f996bc.

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue #2934

* Revert "fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive""

This reverts commit 30f0e01.

* refactor(check): split no-focusable-content rule into three.

That rule is now:
no-focusable-content-for-aria-text,
no-focusable-content-for-nested-interactive, and
no-focusable-content-for-frame

These three are all copy-and-pastes of each other, so far.

* fix(rule): add custom message for nested-interactive.

aria-hidden and negative tabindex will trigger messageKey.

* style(rule): fix lint errors

Errors were in parent commit.

* fix(no-focusable-content-for-frame): fix locale files

Was broken by recent rename of this check.

* refactor(check): undo recent check rename

Rename check "no-focusable-content-for-frame" back to "frame-focusable-content".

* refactor(check): undo recent split of checks

Recombine checks "no-focusable-content-for-aria-text" and "no-focusable-content-for-nested-interactive" back into "no-focusable-content".

* refactor(check): rename local variable

* fix(rule): make no-focusable-content not consult aria-hidden

no-focusable content now consults only tabindex (for the 'not a reliable way of hiding interactive elements' messageKey check)

* fix(checks/keyboard): make no-focusable-content use messageKey the right way

* refactor(check): misc. renaming and refactoring

* Updating description / messageKey text as per #3163 (comment)

* add unit test for frame-focusable-content check

* update the no-focusable-content unit tests to add a test to capture negative tabindex

* update the nested-interactive integration test to add a failure for elements with negative tabindex values

* fix(no-focusable-content-for-frame): fix locale files

Was broken by recent rename of this check.

* Update lib/rules/nested-interactive.json

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

* Update lib/checks/keyboard/no-focusable-content.json

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

* fixing botched merge

* update rule-descriptions.md

* fix locale files

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
dan-tripp added a commit to dan-tripp/axe-core that referenced this issue Nov 20, 2021
@dan-tripp @straker
fix(nested-interactive): add message for negative tabindex (dequelabs…
f8481db 
…#3194)

* refactor(checks/navigation): improve `internal-link-present-evaluate`

Make `internal-link-present-evaluate` work with virtualNode rather than actualNode.

Closes issue dequelabs#2466

* test commit 1

* test commit 2

* test commit 3

* Revert "Merge branch 'dan-test-branch-1' into develop"

This reverts commit 428e015, reversing
changes made to 9f996bc.

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue dequelabs#2934

* Revert "fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive""

This reverts commit 30f0e01.

* refactor(check): split no-focusable-content rule into three.

That rule is now:
no-focusable-content-for-aria-text,
no-focusable-content-for-nested-interactive, and
no-focusable-content-for-frame

These three are all copy-and-pastes of each other, so far.

* fix(rule): add custom message for nested-interactive.

aria-hidden and negative tabindex will trigger messageKey.

* style(rule): fix lint errors

Errors were in parent commit.

* fix(no-focusable-content-for-frame): fix locale files

Was broken by recent rename of this check.

* refactor(check): undo recent check rename

Rename check "no-focusable-content-for-frame" back to "frame-focusable-content".

* refactor(check): undo recent split of checks

Recombine checks "no-focusable-content-for-aria-text" and "no-focusable-content-for-nested-interactive" back into "no-focusable-content".

* refactor(check): rename local variable

* fix(rule): make no-focusable-content not consult aria-hidden

no-focusable content now consults only tabindex (for the 'not a reliable way of hiding interactive elements' messageKey check)

* fix(checks/keyboard): make no-focusable-content use messageKey the right way

* refactor(check): misc. renaming and refactoring

* Updating description / messageKey text as per dequelabs#3163 (comment)

* add unit test for frame-focusable-content check

* update the no-focusable-content unit tests to add a test to capture negative tabindex

* update the nested-interactive integration test to add a failure for elements with negative tabindex values

* fix(no-focusable-content-for-frame): fix locale files

Was broken by recent rename of this check.

* Update lib/rules/nested-interactive.json

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

* Update lib/checks/keyboard/no-focusable-content.json

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

* fixing botched merge

* update rule-descriptions.md

* fix locale files

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
WilcoFiers pushed a commit that referenced this issue Dec 6, 2021
@dan-tripp
fix(nested-interactive/aria-text): allow "tabindex=-1" on elements wi…
0ddc00b 
…th no role (#3165)

* refactor(checks/navigation): improve `internal-link-present-evaluate`

Make `internal-link-present-evaluate` work with virtualNode rather than actualNode.

Closes issue #2466

* test commit 1

* test commit 2

* test commit 3

* Revert "Merge branch 'dan-test-branch-1' into develop"

This reverts commit 428e015, reversing
changes made to 9f996bc.

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue #2934

* work in progress

* work in progress

* test commit 1

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue #2934

* work in progress

* work in progress

* fix whitespace

* add new case to test test/checks/keyboard/no-focusable-content.js

* change "disabled" test case in test/checks/keyboard/no-focusable-content.js

* fix merge problem
straker added a commit that referenced this issue Feb 22, 2022
@dan-tripp @straker
fix(checks/no-focusable-disable): don't count non-disableable element…
bb8b5ca 
…s as disabled (#3393)

* refactor(checks/navigation): improve `internal-link-present-evaluate`

Make `internal-link-present-evaluate` work with virtualNode rather than actualNode.

Closes issue #2466

* test commit 1

* test commit 2

* test commit 3

* Revert "Merge branch 'dan-test-branch-1' into develop"

This reverts commit 428e015, reversing
changes made to 9f996bc.

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue #2934

* work in progress

* work in progress

* test commit 1

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue #2934

* work in progress

* work in progress

* fix whitespace

* add new case to test test/checks/keyboard/no-focusable-content.js

* change "disabled" test case in test/checks/keyboard/no-focusable-content.js

* fix merge problem

* fix(commons/dom): focusDisabled() behavior

Now checks "disabled" attribute

Closes issue #3315

* Update lib/commons/dom/focus-disabled.js

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

* fix typo

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
straker pushed a commit that referenced this issue Feb 28, 2022
@dan-tripp
fix(checks/unsupportedrole): support unsupported dpub and fallback ro…
3c0f10f 
…les, add role to message (#3395)

* refactor(checks/navigation): improve `internal-link-present-evaluate`

Make `internal-link-present-evaluate` work with virtualNode rather than actualNode.

Closes issue #2466

* test commit 1

* test commit 2

* test commit 3

* Revert "Merge branch 'dan-test-branch-1' into develop"

This reverts commit 428e015, reversing
changes made to 9f996bc.

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue #2934

* work in progress

* work in progress

* test commit 1

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue #2934

* work in progress

* work in progress

* fix whitespace

* add new case to test test/checks/keyboard/no-focusable-content.js

* change "disabled" test case in test/checks/keyboard/no-focusable-content.js

* fix merge problem

* fix(rules): unsupportedrole check bugs

Closes issue #3282

* lint fix

* add assertion on checkContext._data to unit tests

* refactor(checks/unsupportedrole): change this.data from using array to single string

to match lib/checks/aria/deprecatedrole-evaluate.js

* Revert "refactor(checks/unsupportedrole): change this.data from using array to single string"

This reverts commit e7c757f9330b635b1ed16385b3526f2e71786488.

* refactor(checks/unsupportedrole): change this.data from using array to single string
@straker straker added the pr A pr has been created for the issue label Jul 26, 2022
@straker straker added this to the Axe-core 4.5 milestone Jul 26, 2022
@straker straker closed this as completed Jul 26, 2022
@Shubhabrata08 Shubhabrata08 mentioned this issue Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue For first-time contributors pr A pr has been created for the issue
Projects
None yet
Milestone
Axe-core 4.5
Development

No branches or pull requests
4 participants
@dylanb @straker @anuk79 @dan-tripp