Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(checks/no-focusable-disable): don't count non-disableable elements as disabled #3393

Merged
merged 49 commits into from
Feb 22, 2022
Merged

fix(checks/no-focusable-disable): don't count non-disableable elements as disabled #3393

merged 49 commits into from
Feb 22, 2022

Conversation

dan-tripp
Copy link
Contributor

focusDisabled() now checks the element name to see if "disabled" attribute is valid on that element.

Closes issue #3315

dan-tripp and others added 30 commits August 19, 2021 21:17
@dan-tripp
refactor(checks/navigation): improve internal-link-present-evaluate
2467b3a 
Make `internal-link-present-evaluate` work with virtualNode rather than actualNode.

Closes issue dequelabs#2466
@dan-tripp
Merge branch 'dequelabs:develop' into develop
bde2684
@dan-tripp
test commit 1
9f996bc
@dan-tripp
test commit 2
c011d2c
@dan-tripp
test commit 3
a386166
@dan-tripp
Merge branch 'dan-test-branch-1' into develop
428e015
@dan-tripp
Revert "Merge branch 'dan-test-branch-1' into develop"
31b19a3 
This reverts commit 428e015, reversing
changes made to 9f996bc.
@dan-tripp
Revert "test commit 1"
ac32146 
This reverts commit 9f996bc.
@dan-tripp
Merge branch 'dequelabs:develop' into develop
6e389a1
@dan-tripp
Merge branch 'dequelabs:develop' into develop
739f035
@dan-tripp
fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-inte…
30f0e01 
…ractive"

Closes issue dequelabs#2934
@dan-tripp
Merge branch 'dequelabs:develop' into develop
9caefd7
@dan-tripp
Merge branch 'dequelabs:develop' into develop
41fd8e2
@dan-tripp
Merge branch 'dequelabs:develop' into develop
7aeac06
@dan-tripp
Merge branch 'dequelabs:develop' into develop
c37be71
@dan-tripp
Merge branch 'dequelabs:develop' into develop
2896478
@dan-tripp
Merge branch 'dequelabs:develop' into develop
02cfb18
@dan-tripp
Merge branch 'dequelabs:develop' into develop
f2ae004
@dan-tripp
Merge branch 'dequelabs:develop' into develop
b687d45
@dan-tripp
Merge branch 'dequelabs:develop' into develop
0729846
@dan-tripp
Merge branch 'dequelabs:develop' into develop
b257208
@dan-tripp
Merge branch 'develop' of https://github.com/dequelabs/axe-core into …
6c5a5ed 
…dequelabs-develop-2
@dan-tripp
Merge pull request #4 from dan-tripp/dequelabs-develop-2
0d92cf2 
Dequelabs develop 2
@dan-tripp
Merge branch 'dequelabs:develop' into develop
5baa656
@dan-tripp
work in progress
40025ad
@dan-tripp
Merge pull request #5 from dan-tripp/dequelabs-develop-2
f12379e 
work in progress
@dan-tripp
work in progress
92dc637
@dan-tripp
Merge pull request #6 from dan-tripp/dequelabs-develop-2
2666eeb 
work in progress
@dan-tripp
Merge branch 'dequelabs:develop' into develop
7e692b4
@dan-tripp
test commit 1
6d8a0f6
dan-tripp and others added 15 commits November 29, 2021 20:59
@dan-tripp
Revert "test commit 1"
9373c58 
This reverts commit 9f996bc.
@dan-tripp
fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-inte…
0a4fd4f 
…ractive"

Closes issue dequelabs#2934
@dan-tripp
work in progress
d50b56a
@dan-tripp
work in progress
74d5656
@dan-tripp
fix whitespace
54329dd
@dan-tripp
add new case to test test/checks/keyboard/no-focusable-content.js
499768f
@dan-tripp
change "disabled" test case in test/checks/keyboard/no-focusable-cont…
8c32f03 
…ent.js
@dan-tripp
Merge branch 'develop' into dequelabs-develop-2
ed9da3e
@dan-tripp
Merge branch 'dequelabs-develop-2' into develop
99000d4
@dan-tripp
Merge branch 'develop' of https://github.com/dan-tripp/axe-core into …
7ad504f 
…develop
@dan-tripp
Merge branch 'dequelabs:develop' into develop
e69a0f5
@dan-tripp
fix merge problem
d6a5573
@dan-tripp
Merge remote-tracking branch 'remotes/origin/develop' into develop
9a61752
@dan-tripp
Merge branch 'dequelabs:develop' into develop
02c91ed
@dan-tripp
Merge branch 'dequelabs:develop' into develop
18a7ac6
@dan-tripp dan-tripp requested a review from a team as a code owner February 21, 2022 16:04
straker
straker previously requested changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking on the pr. Just have 1 suggestion, but otherwise it looks good.

lib/commons/dom/focus-disabled.js Outdated Show resolved Hide resolved
dan-tripp and others added 2 commits February 21, 2022 14:05
@dan-tripp @straker
Update lib/commons/dom/focus-disabled.js
903fbd5 
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
@dan-tripp
fix typo
404a092
@dan-tripp
Copy link
Contributor Author

Right on. Done.

@straker straker dismissed their stale review February 21, 2022 21:45

Resolved

@straker
Copy link
Contributor

straker commented Feb 22, 2022

reviewed for security

@straker straker changed the title fix(commons/dom): focusDisabled() behavior fix(checks/no-focusable-disable): don't count non-disableable elements as disabled Feb 22, 2022
@straker straker merged commit bb8b5ca into dequelabs:develop Feb 22, 2022
@dan-tripp
Copy link
Contributor Author

Thanks!

@Shubhabrata08 Shubhabrata08 mentioned this pull request Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-tripp @straker