chore(text): update text content #4499
Conversation
Fix minor issues like capitalization and spelling
There was a problem hiding this comment.
Thank you very much @marktnoonan. Would you mind making these changes in their source files instead of in the generated file though?
Sorry about that, we normally put a comment at the top of generated files. Can't put comments in JSON unfortunately.
locales/_template.json
Outdated
There was a problem hiding this comment.
@marktnoonan This is a generated file. You'll need to make these changes in in the different JSON files in lib/checks/*/{check-id}.json. This won't be used in axe-core, and it's going to get overwritten when this file is regenerated.
There was a problem hiding this comment.
Oh that makes so much sense, yes I'll move changes to the proper place, thanks!
| @@ -86,9 +86,9 @@ | |||
|
|
|||
There was a problem hiding this comment.
@WilcoFiers This file is also generated - should I remove these changes from the PR also?
There was a problem hiding this comment.
No, we try to keep this in sync with the .json files in the repo. We actually need the _template.json file updated too. Would you mind running npm run build to update that file as well?
There was a problem hiding this comment.
Ah understood - we want the generated files updated and committed, but they are not edited directly, and so they stay current with the values used elsewhere in code. Updated the PR with the generated _template file.
There was a problem hiding this comment.
@WilcoFiers I believe everything is committed and good to go at this point.
There was a problem hiding this comment.
LGTM. Thank you for the kind contribution @marktnoonan!
For the books; I reviewed this PR for security.
## [4.10.0](v4.9.1...v4.10.0) (2024-07-29) ### Features - **new-rule:** summary elements must have an accessible name ([#4511](#4511)) ([0d8a99e](0d8a99e)), closes [#4510](#4510) ### Bug Fixes - **all-rules:** fix flakey all-rules firefox test ([#4467](#4467)) ([3f13aa1](3f13aa1)) - **aria-allowed-attr:** allow aria-multiline=false for element with contenteditable ([#4537](#4537)) ([f019068](f019068)) - **aria-allowed-attr:** allow aria-required=false when normally not allowed ([#4532](#4532)) ([2e242e1](2e242e1)) - **aria-prohibited-attr:** allow aria-label/ledby on decendants of widget ([#4541](#4541)) ([07c5d91](07c5d91)) - **aria-roledescription:** keep disabled with { runOnly: 'wcag2a' } ([#4526](#4526)) ([5b4cb9d](5b4cb9d)), closes [#4523](#4523) - **autocomplete-valid:** incomplete for invalid but safe values ([#4500](#4500)) ([e31a974](e31a974)), closes [#4492](#4492) - **build:** limit locales to valid files when using the --all-lang option ([#4486](#4486)) ([d3db593](d3db593)), closes [#4485](#4485) - colorio.js patch mocking CSS ([#4456](#4456)) ([3ef9353](3ef9353)), closes [#4400](#4400) - correct typos in texts ([#4499](#4499)) ([11fad59](11fad59)) - **landmark-unique:** follow spec, aside -> landmark ([#4469](#4469)) ([e32f803](e32f803)), closes [#4460](#4460) - **required-attr:** allow aria-valuetext on slider instead of valuenow ([#4518](#4518)) ([135898b](135898b)), closes [#4515](#4515) This PR was opened by a robot 🤖 🎉
Hi! I noticed some minor typos and inconsistent text capitalization, as well as what looks like flipped
helpanddescriptiontext in one spot for thelandmark-uniquerule. This PR fixes the ones I was able to spot.I noticed some overlap with #4385, I'd be happy to grab the text changes mentioned there in this PR as well, ("Ensures" -> "Ensure" in rule descriptions), if that's not stepping on anybody's toes.