Ceramic publish history #245
Conversation
|
(this may not build until this is merged and final codex package versions get published: desci-labs/desci-codex#42) |
| "@opentelemetry/auto-instrumentations-node": "^0.37", | ||
| "@penseapp/discord-notification": "^2.0.9", | ||
| "@prisma/client": "4.2.1", |
There was a problem hiding this comment.
Why the downgrade here? though bullish on the other version bumps
There was a problem hiding this comment.
It's an upgrade to 4.10.1, see line below :)
| never, | ||
| PublishReqBody | ||
| > & { | ||
| user: User; // added by auth middleware |
There was a problem hiding this comment.
Cool we should do this more frequently in other areas and make a generic type for this as its common across many reqs
Generally 2 variants, req.user, and req.user + req.node
| @@ -5,7 +5,7 @@ import { base32 } from "multiformats/bases/base32"; | |||
| import { CID } from "multiformats/cid"; | |||
|
|
|||
| export const convertUUIDToHex = (uuid: string) => { | |||
| const decoded = decode(uuid + "."); | |||
| const decoded = decode(uuid); | |||
There was a problem hiding this comment.
Would this decode fine if the uuid does include a period at the end?
There was a problem hiding this comment.
Yes, it'll keep any ./= padding, but we slice the first 32 bytes on the next line regardless so they don't get put in the contracts
There was a problem hiding this comment.
The dots simply mean "data has ended but here are some more chars to make a full byte", so they'll decode to = which is base64 padding
There was a problem hiding this comment.
This reminded me to downgrade url-safe-base64 in nodes-lib btw, thanks
m0ar
force-pushed
the
m0ar/ceramic-publish-history
branch
2 times, most recently
from
587938e
to
cd1b89a
Compare
m0ar
force-pushed
the
m0ar/ceramic-publish-history
branch
from
51131f4
to
0e1a818
Compare
This PR mainly adds tracking of ceramic commitID's in
NodeVersion, but due to some recent changes in the backend also patches a bunch of regressions.Notable changes:
TOGGLE_CERAMICenv no longer necessary due to (hopefully) idempotent stream tracking