Remove rimraf dependency in favor of Node native rm #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niik
commented
Nov 24, 2024
| @@ -1,43 +1,23 @@ | |||
| import { spawn } from 'child_process' | |||
| import { glob } from 'glob' | |||
There was a problem hiding this comment.
So turns out I was depending on a sub-dependency of rimraf here so when I removed it glob disappeared as well but that lead to a nice cleanup in this script as well, utilizing the recursive option of readdir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#601 is open because of our use of rimraf which carries with it a ton of sub dependencies. I'm hoping to be able to get rid of it in favor of the recursive option for the native
rmfunction from thefsmodule.