Get rid of temp module which also depends on rimraf #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiou87
previously approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting #602 but extracting this to be reviewed separately to not muddy #602 any more than necessary.
So I thought we had gotten rid of rimraf in #602 but it turns out our dependency on
tempbrings it right back in. We use temp to create temporary test directories that get cleaned up after the test run. The temp module adds a hook when the process exits which cleans up all created temp directories. I took a different approach and decided to clean up after each test run instead. Felt cleaner to me to clean up resources as close to their creation as possible even though it does require passing the test context around.