Make useradd defaults in login.defs dependent on OS #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andre Lehmann <aisberg@posteo.de>
All tabs were converted into spaces and all values were properly aligned, making the file easier to read. Signed-off-by: Andre Lehmann <aisberg@posteo.de>
Signed-off-by: Andre Lehmann <aisberg@posteo.de>
Signed-off-by: Andre Lehmann <aisberg@posteo.de>
Signed-off-by: Andre Lehmann <aisberg@posteo.de>
|
Thanks for these numerous improvements! :) |
| @@ -27,5 +27,8 @@ os_auth_sys_uid_max: 499 | |||
| os_auth_sys_gid_min: 100 | |||
| os_auth_sys_gid_max: 499 | |||
|
|
|||
| # defaults for useradd | |||
| os_useradd_create_home: false | |||
There was a problem hiding this comment.
@aisbergg why Suse in particular has this disabled by default?
There was a problem hiding this comment.
@aisbergg why Suse in particular has this disabled by default?
That I can't say, all I can say is that those are the defaults found in the shadow package.
rndmh3ro
added a commit
that referenced
this pull request
Jul 24, 2020
Do not use bash to get ssh version
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
Do not use bash to get ssh version
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
* Add proper ansible_managed header in each template Signed-off-by: Andre Lehmann <aisberg@posteo.de> * Use consistent indentation All tabs were converted into spaces and all values were properly aligned, making the file easier to read. Signed-off-by: Andre Lehmann <aisberg@posteo.de> * Make useradd defaults inside login.defs dependent on OS family Signed-off-by: Andre Lehmann <aisberg@posteo.de> * Remove duplicate key Signed-off-by: Andre Lehmann <aisberg@posteo.de> * Replace tab with space Signed-off-by: Andre Lehmann <aisberg@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to make the useradd defaults
MAIL_DIRandCREATE_HOMEdependent on the OS (fixes: #265). Other minor changes included in this PR are:ansible_managedheader correctly in each of the templateskernel.kptr_restrictindefaults/main.ymlintroduced in Add kernel hardening parameters from Tails and CIS Benchmark #263