-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SECURITY-INSIGHTS.md #50
Conversation
Signed-off-by: thepetk <thepetk@gmail.com>
1b08b7e
to
a0b1d3f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 73.16% 73.16%
=======================================
Files 11 11
Lines 1565 1565
=======================================
Hits 1145 1145
Misses 351 351
Partials 69 69 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Will the threat model and vulnerability reporting be added after conclusion of the epic?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeap, in the devfile/api#1461 it is mentioned in the acceptance criteria that all |
@thepetk I was looking over the docs again and noticed there has to be a specific naming convention for the |
never mind. We did use a yaml file and the title of the PR threw me off. The issue is due to the extension being |
|
What does this PR do?
As part of the CNCF defender tasks we need to add a
security-insights.md
to reach the 100% on the monitor. More information for the security insights here: https://github.com/ossf/security-insights-spec/blob/main/specification.mdWhich issue(s) does this PR fix
Fixes devfile/api#1392
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer