Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security insights naming #52

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Mar 1, 2024

What does this PR do?

Simply renames the SECURITY-INISIGHTS.yaml to SECURITY-INSIGHTS.yml to be alinged with the CLO Monitoring guidelines

Which issue(s) does this PR fix

fixes devfile/api#1392

PR acceptance criteria

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Unit/Functional tests

  • Documentation

How to test changes / Special notes to the reviewer

Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
@openshift-ci openshift-ci bot requested review from elsony and Jdubrick March 1, 2024 19:44
@openshift-ci openshift-ci bot added the approved label Mar 1, 2024
@thepetk thepetk changed the title Bug/fix security insights naming Fix security insights naming Mar 1, 2024
@thepetk thepetk mentioned this pull request Mar 1, 2024
2 tasks
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.16%. Comparing base (b1b0c21) to head (01639e7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   73.16%   73.16%           
=======================================
  Files          11       11           
  Lines        1565     1565           
=======================================
  Hits         1145     1145           
  Misses        351      351           
  Partials       69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thanks Fanis

Copy link

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 631a34e into devfile:main Mar 1, 2024
8 checks passed
@Jdubrick
Copy link
Contributor

Jdubrick commented Mar 1, 2024

@thepetk after that name change merge went through I noticed there is a duplicate and we have both .yml and .yaml extensions in the root of the repo.

@thepetk
Copy link
Contributor Author

thepetk commented Mar 1, 2024

@thepetk after that name change merge went through I noticed there is a duplicate and we have both .yml and .yaml extensions in the root of the repo.

@Jdubrick Very strange, might be brought from a rebase. I've created a PR to fix the issue: https://github.com/devfile/alizer/pull/53/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CNCF Defender Tasks for devfile/alizer
2 participants