Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The devfile schema/samples should have version and name #10

Closed
l0rd opened this issue Feb 5, 2020 · 4 comments
Closed

The devfile schema/samples should have version and name #10

l0rd opened this issue Feb 5, 2020 · 4 comments
Assignees
@davidfestal
Milestone
2.0

Comments

@l0rd
Copy link
Contributor

l0rd commented Feb 5, 2020 •
edited
Loading

Adding optional metadata version and name:

schemaVersion: 2.0.0
metadata:
  name: petclinic-dev-environment                # optional
  version: x.y.z                                          # optional
projects:
   ...
components:
  ...
commands:
  ...

Since in the schema the metadata are optional they can even be extracted in a meta.yaml as it is today in the devfile-registry but that's not covered in the spec.

⚠️ That's about the version of the devfile and not to be confused with the schemaVersion. And the semantic is the semVer one.
@l0rd l0rd mentioned this issue Feb 5, 2020
Closed
28 tasks
@davidfestal
Copy link
Collaborator

See this comment is a distinct issue that seem to be a duplicate:
#7 (comment)

Do we really want to keep annotations here ? since we agreed that trying to make the Devfile itself a K8S object is a non-goal (having the devfile inner structure be K8S-compatible to be shared with the K8S-native DevworkspaceTemplate is a goal though)

@davidfestal
Copy link
Collaborator

duplicate of #7 ?

@davidfestal davidfestal mentioned this issue Feb 18, 2020
Closed
@l0rd l0rd changed the title The devfile schema/samples should have version and metadata attributes The devfile schema/samples should have version and generatedName Mar 10, 2020
@l0rd l0rd changed the title The devfile schema/samples should have version and generatedName The devfile schema/samples should have version and name Mar 10, 2020
@l0rd
Copy link
Contributor Author

l0rd commented Mar 10, 2020

Discussed and validated

davidfestal added a commit that referenced this issue Apr 7, 2020
@davidfestal
Implement agreement on issue #10
5b2ac1c 
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal added a commit that referenced this issue Apr 7, 2020
@davidfestal
Implement agreement on issue #10
c766457 
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal davidfestal mentioned this issue Apr 22, 2020
Merged
davidfestal added a commit that referenced this issue Apr 22, 2020
@davidfestal @sleshchenko
Implement agreed-on devfile 2.0 issues (#35)
f9e7352 
* Implement agreement on issue #18
* Implement agreement on issue #17
* Implement agreement on issue #21
* Implement agreement on issue #22
* Implement agreement on issue #27
* Implement agreement on issue #9
* Implement agreement on issue #10
* Fix PR comments about issue #9 PR comment #35 (comment)
* Fix PR comments about issue #17 PR comment #35 (comment)
* Implement agreement on issue #14 and  #19
* Add the spring boot example
* Implement agreement on issue #32
* Fix last PR comments

Signed-off-by: David Festal <dfestal@redhat.com>

Co-Authored-By: Sergii Leshchenko <sleshche@redhat.com>
@l0rd l0rd added this to the 2.0.0 milestone Jun 16, 2020
@l0rd
Copy link
Contributor Author

l0rd commented Jun 24, 2020 •
edited
Loading

Closing it as been included in the spec.

@l0rd l0rd closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidfestal davidfestal

Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@l0rd @davidfestal