Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement agreed-on devfile 2.0 issues #35

Merged
merged 16 commits into from
Apr 22, 2020
Merged

Implement agreed-on devfile 2.0 issues #35

merged 16 commits into from
Apr 22, 2020

Conversation

davidfestal
Copy link
Collaborator

What does this PR do?

This PR implements the changes agreed on in the devfile 2.0 epic

What issues does this PR fix or reference?

#15

@davidfestal
Implement agreement on issue #18
2a3a2c5 
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal
Implement agreement on issue #17
515a430 
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal
Implement agreement on issue #21
8bceda9 
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal
Implement agreement on issue #22
680c4cb 
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal
Implement agreement on issue #27
8145b87 
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal
Implement agreement on issue #9
6c99166 
Signed-off-by: David Festal <dfestal@redhat.com>
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

amisevsk
amisevsk reviewed Apr 3, 2020
View reviewed changes
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments/questions from a first pass over the changes.

deploy/crds/workspaces.ecd.eclipse.org_devworkspaces_crd.yaml Outdated Show resolved Hide resolved
deploy/crds/workspaces.ecd.eclipse.org_devworkspaces_crd.yaml Show resolved Hide resolved
pkg/apis/workspaces/v1alpha1/kubernetesLikeComponent.go Outdated Show resolved Hide resolved
pkg/apis/workspaces/v1alpha1/commands.go Show resolved Hide resolved
deploy/crds/workspaces.ecd.eclipse.org_devworkspaces_crd.yaml Outdated Show resolved Hide resolved
devfile-support/samples/nodejs-stack.devfile.yaml Show resolved Hide resolved
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

@davidfestal
Implement agreement on issue #10
c766457 
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal davidfestal force-pushed the Implement-agreed-on-devfile-2.0-issues branch from 5b2ac1c to c766457 Compare April 7, 2020 13:05
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

@davidfestal
Fix PR comments about issue #9
636fff6 
PR comment is here: #35 (comment)

Signed-off-by: David Festal <dfestal@redhat.com>
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

@davidfestal
Fix PR comments about issue #17
04e50e3 
PR comment is here: #35 (comment)

Signed-off-by: David Festal <dfestal@redhat.com>
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

@davidfestal
Implement agreement on issue #14 and #19
2b3097f 
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal
Add the spring boot example
2fa17a9 
Signed-off-by: David Festal <dfestal@redhat.com>
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

@davidfestal
Implement agreement on issue #32
bbb2bbf 
Signed-off-by: David Festal <dfestal@redhat.com>
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

amisevsk
amisevsk reviewed Apr 14, 2020
View reviewed changes
schemas/devfile.json Outdated Show resolved Hide resolved
devfile-support/samples/sample-devfile.yaml Show resolved Hide resolved
deploy/crds/workspaces.ecd.eclipse.org_devworkspaces_crd.yaml Show resolved Hide resolved
schemas/devfile.json Outdated Show resolved Hide resolved
@amisevsk
Copy link
Contributor

I've also left a comment in #32 here. The semantics of how preStart/postStop apply to whether a container is in the main deployment are unclear to me.

@davidfestal
Fix last PR comments
e0b9a38 
Signed-off-by: David Festal <dfestal@redhat.com>
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

@davidfestal @sleshchenko
Update devfile-support/samples/simple-devfile.yaml
5b45b98 
Co-Authored-By: Sergii Leshchenko <sleshche@redhat.com>
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

1 similar comment
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

@davidfestal davidfestal changed the title WIP: Implement agreed-on devfile 2.0 issues Implement agreed-on devfile 2.0 issues Apr 22, 2020
@davidfestal
Fix PR comments
4a7d642 
Signed-off-by: David Festal <dfestal@redhat.com>
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

@davidfestal davidfestal requested a review from l0rd April 22, 2020 11:48
@davidfestal
Fix an error in the Go source
6b5f1ff 
that doesn't impact the resulting schema

Signed-off-by: David Festal <dfestal@redhat.com>
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

@davidfestal davidfestal merged commit f9e7352 into master Apr 22, 2020
This was linked to issues Jun 22, 2020
Renaming workdir into workingDir #22
Closed
Environment variables for a specific command #21
Closed
Add lifecycle bindings to bind commands to specific events #32
Closed
Command group (application lifecycle) #27
Closed
Composite commands label and id #18
Closed
Specify the source mapping path for component containers #17
Closed
Allow volumes to be shared across components #19
Closed
Allow the size of a component's volume to be specified in a Devfile #14
Closed
Names field mandatory for k8s/openshift, optional for plugins #9
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisevsk amisevsk amisevsk left review comments

@sleshchenko sleshchenko sleshchenko left review comments

@l0rd l0rd l0rd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@davidfestal @amisevsk @l0rd @sleshchenko