Revert "Update SCC and RBAC handling for DevWorkspaces" #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AObuchow
approved these changes
Nov 7, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, AObuchow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Revert changes in 954 as they are breaking for container-build functionality in Eclipse Che. Revert "Fix RBAC tests to accomodate serviceaccount changes." This reverts commit 25d533b. Revert "Fix RBAC provisioning after rebase (changes to SA name package)" This reverts commit f825089. Revert "Add tests for role/rolebinding provisioning" This reverts commit ee81bb3. Revert "Update cache filter for roles and rolebindings, update migrate process" This reverts commit f66fd3f. Revert "Update DevWorkspace operator clusterrole" This reverts commit 3d9f908. Revert "Stop adding workspace SA to SCC and don't use SA finalizer" This reverts commit 2767a45. Revert "Switch to using updated RBAC syncing process" This reverts commit a4c0f94. Revert "Add function to clean up old roles and rolebindings" This reverts commit d21d696. Revert "Add new way of handling workspace RBAC that supports SCCs" This reverts commit 612baf3. Revert "Begin process of deprecating previous role and rolebinding functionality" This reverts commit 5610c8c. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
force-pushed
the
revert-954-update-scc-config
branch
from
ad201f5
to
5c1b54c
Compare
|
New changes are detected. LGTM label has been removed. |
Merged
10 tasks
amisevsk
added a commit
to amisevsk/devworkspace-operator
that referenced
this pull request
Nov 10, 2022
Reapply changes from PR devfile#954 (commits ac944d5..25d533b) that had been reverted (PR devfile#972) The original PR was reverted due to required changes in the Che Operator. As those are now applied, the original PR can be re-applied. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #954 as it requires an update in Che, which uses this functionality.