Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: scikitlearn (original, original-workmark, plain, plain-wordmark, line, line-wordmark) #1605

Closed
wants to merge 1 commit into from

Conversation

ConX
Copy link
Contributor

@ConX ConX commented Jan 3, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1032

Link to prove your SVG is correct and up-to-date.

https://scikit-learn.org/stable/about.html#artwork

@luizcarloscf
Copy link
Contributor

luizcarloscf commented Jan 5, 2023

Even if this pull request is allowed to run checks, I don't think it will pass. The commit was added directly to develop branch. I think you should create another branch based on develop, add your commits and then open a pull request. Finally, all commits in your branch will be squash into a single commit and merged to develop.

Just letting you know, I'm not a maintainer. Soon, one of them will clarify this doubt.

@ConX
Copy link
Contributor Author

ConX commented Jan 5, 2023

Hi @luizcarloscf, thanks for checking. If there is a need to re-submit with different branches, I will do so ;) Let's wait for a maintainer to take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants