new icon: scikitlearn (original, plain, line) #1616

ConX · 2023-01-06T21:49:29Z

Double check these details before you open a PR

PR does not match another non-stale PR currently opened
PR name matches the format new icon: Icon name (versions separated by comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here

This PR closes #1032
This was submitted a few days ago(#1605) but was closed to fix the branches.

Link to prove your SVG is correct and up-to-date.

https://scikit-learn.org/stable/about.html#artwork

lunatic-fox

Hello there!
I think we can also add tool to tags.
I've optimized your icons using SVGOMG. Hope that's ok! 😁

devicon.json

Snailedlt

Hmm, maybe the icons you added should be the "non-wordmark" versions?

In their repo they call the icon scikit-learn-logo-notext.png. If so, we can add this version as the wordmark version

Though the text might be too small, so I'm fine with not using that version at all.

devicon.json

Add "tool" in tags Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

…into new-icon-scikitlearn

Panquesito7

LGTM! Thanks. 🚀

github-actions · 2023-02-09T01:09:26Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

lunatic-fox

Great! ✔
Thank you for this contribution! 🚀

devicon.json

Snailedlt

See panquesito's comment

No aliases were provided for the icon.

github-actions · 2023-03-16T04:41:04Z

Hi!

I'm the check-bot and we have some issues with your PR:



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/scikitlearn/scikitlearn-original-wordmark.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

github-actions · 2023-03-16T04:42:45Z

Hi!

I'm the check-bot and we have some issues with your PR:



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/scikitlearn/scikitlearn-original-wordmark.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

github-actions · 2023-03-16T08:16:47Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt

LGTM! ✔️
Thanks for another great contibution! 🚀

lunatic-fox

Great work! ✔
Thank you for this contribution! 🚀

* Add icons for scikit-learn (python library) * Remove unofficial non-wordmark versions * Optmize icons * Update devicon.json Add "tool" in tags Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com> * Remove redundant whitespace Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> * Add "library" tag * Rename icons * Optimize icons * Update devicon.json to add aliases * Remove wordmark from regular versions * Add newline to optimized icons --------- Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

ConX added 2 commits January 6, 2023 15:46

Add icons for scikit-learn (python library)

fb41896

Remove unofficial non-wordmark versions

6449444

ConX changed the title ~~new icon: scikitlearn (original, original-workmark, plain, plain-wordmark, line, line-wordmark)~~ new icon: scikitlearn (original-workmark, plain-wordmark, line-wordmark) Jan 8, 2023

Optmize icons

1968a3d

lunatic-fox added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 8, 2023

This comment was marked as outdated.

Sign in to view

lunatic-fox requested a review from Snailedlt January 8, 2023 23:12

lunatic-fox reviewed Jan 8, 2023

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

Snailedlt requested a review from Panquesito7 January 9, 2023 20:48

Snailedlt requested changes Jan 9, 2023

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

devicon.json Outdated Show resolved Hide resolved

ConX and others added 4 commits January 9, 2023 15:21

Update devicon.json

ef3d6e1

Add "tool" in tags Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>

Remove redundant whitespace

98ffbfe

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Add "library" tag

e5c9768

Merge branch 'new-icon-scikitlearn' of https://github.com/ConX/devicon …

0b0b86c

…into new-icon-scikitlearn

Panquesito7 previously approved these changes Feb 9, 2023

View reviewed changes

Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Feb 9, 2023

Panquesito7 requested review from Snailedlt and lunatic-fox February 9, 2023 01:20

Snailedlt approved these changes Feb 9, 2023

View reviewed changes

Merge branch 'develop' into new-icon-scikitlearn

92eb5f6

lunatic-fox previously approved these changes Feb 9, 2023

View reviewed changes

Panquesito7 reviewed Feb 9, 2023

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

Snailedlt requested changes Feb 9, 2023

View reviewed changes

ConX and others added 3 commits March 15, 2023 23:33

Merge branch 'develop' into new-icon-scikitlearn

f66767a

Rename icons

47f6933

Optimize icons

b645a86

ConX dismissed lunatic-fox’s stale review via b645a86 March 16, 2023 04:40

Update devicon.json to add aliases

0b538ed

Remove wordmark from regular versions

9a1d894

Snailedlt changed the title ~~new icon: scikitlearn (original-workmark, plain-wordmark, line-wordmark)~~ new icon: scikitlearn (original, plain, line) Mar 16, 2023

Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 16, 2023

Snailedlt requested review from lunatic-fox and Panquesito7 March 16, 2023 08:18

Snailedlt previously approved these changes Mar 16, 2023

View reviewed changes

Add newline to optimized icons

1568724

lunatic-fox dismissed Snailedlt’s stale review via 1568724 March 17, 2023 01:58

Merge branch 'develop' into new-icon-scikitlearn

df70f30

lunatic-fox approved these changes Mar 17, 2023

View reviewed changes

lunatic-fox requested a review from Snailedlt March 17, 2023 02:05

Snailedlt approved these changes Mar 17, 2023

View reviewed changes

Merge branch 'develop' into new-icon-scikitlearn

1fde406

Snailedlt merged commit 8ce3911 into devicons:develop Mar 17, 2023

ConX deleted the new-icon-scikitlearn branch March 28, 2023 06:17

Snailedlt mentioned this pull request Feb 5, 2024

Release v2.16.0 #2131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new icon: scikitlearn (original, plain, line) #1616

new icon: scikitlearn (original, plain, line) #1616

ConX commented Jan 6, 2023

This comment was marked as outdated.

lunatic-fox left a comment

Snailedlt left a comment

Panquesito7 left a comment

github-actions bot commented Feb 9, 2023

lunatic-fox left a comment

Snailedlt left a comment

github-actions bot commented Mar 16, 2023

github-actions bot commented Mar 16, 2023

github-actions bot commented Mar 16, 2023

Snailedlt left a comment

lunatic-fox left a comment

new icon: scikitlearn (original, plain, line) #1616

new icon: scikitlearn (original, plain, line) #1616

Conversation

ConX commented Jan 6, 2023

Double check these details before you open a PR

Link to prove your SVG is correct and up-to-date.

This comment was marked as outdated.

lunatic-fox left a comment

Choose a reason for hiding this comment

Snailedlt left a comment

Choose a reason for hiding this comment

Panquesito7 left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 9, 2023

lunatic-fox left a comment

Choose a reason for hiding this comment

Snailedlt left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 16, 2023

github-actions bot commented Mar 16, 2023

github-actions bot commented Mar 16, 2023

Snailedlt left a comment

Choose a reason for hiding this comment

lunatic-fox left a comment

Choose a reason for hiding this comment